From patchwork Wed Jan 17 11:45:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13521651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49188C47258 for ; Wed, 17 Jan 2024 11:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B86456B00E2; Wed, 17 Jan 2024 06:46:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B35A26B00E4; Wed, 17 Jan 2024 06:46:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FF296B00E5; Wed, 17 Jan 2024 06:46:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8EA026B00E2 for ; Wed, 17 Jan 2024 06:46:39 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 607DD120A66 for ; Wed, 17 Jan 2024 11:46:39 +0000 (UTC) X-FDA: 81688625718.20.C117C14 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 5E8FE40019 for ; Wed, 17 Jan 2024 11:46:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705491997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4HDr49UmFwIRlrPlPmxLaKJQ6Bsv2Jm5RU4nZOF6dLw=; b=DCzJm8TfFphESKyIiPfcTx8H4l5iN+ijRWYuqX6iCBG7t8wUzfmnlT7aDS6TJ2SKBxFgbJ fL3l5qNVmSPFpMLHDB3Q5mWh5D5hkULLJrMnTIzQGLsotdASPCoX6LdcXFpM4hEJaD271U 4z/STo1+D7iK+s3OkkcgN+QG1OsRl0o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705491997; a=rsa-sha256; cv=none; b=6JOv7VS/JJM8lMZpqqM+ntDH2dCCipoX5xq5iMThw2sMK6GJHrmVFi+F5q5csYijvmUIRG gaQiP+I1CHBt8QnTrgI6yWjiWI0UgGWAMS6zhae4SE0V/GTVxXe6yYXHfQKhR03BcoRCsi D4jHqYSkPllkSrFORBUr90aDFm7eaPw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Wed, 17 Jan 2024 11:45:59 +0000 Subject: [PATCH 2/3] mm/slub: remove full list manipulation for non-debug slab MIME-Version: 1.0 Message-Id: <20240117-slab-misc-v1-2-fd1c49ccbe70@bytedance.com> References: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> In-Reply-To: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Vlastimil Babka , Christoph Lameter , Pekka Enberg , Andrew Morton , Roman Gushchin , David Rientjes Cc: linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1705491984; l=1053; i=zhouchengming@bytedance.com; s=20231204; h=from:subject:message-id; bh=dSgFg48t7LupTsKBO2gZsJttDy0+Yco9PB4eWVCuRJk=; b=5XIIuX0qwsSqEvymGfIXuXLWpVtl9zXEjYel4Re50np/cxam9armg3d5VQKRVueB0DNreHkfP hgVbFAM35ZaDZEywwRZZ52cNqr8+6l7gbh1JIGosavcoqYyq5KQue2/ X-Developer-Key: i=zhouchengming@bytedance.com; a=ed25519; pk=xFTmRtMG3vELGJBUiml7OYNdM393WOMv0iWWeQEVVdA= X-Migadu-Flow: FLOW_OUT X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam-User: X-Rspamd-Queue-Id: 5E8FE40019 X-Rspamd-Server: rspam11 X-Stat-Signature: rj434ndxg9dr4h6zyauk6yssh6ffxr5i X-Rspam: Yes X-HE-Tag: 1705491997-362633 X-HE-Meta: U2FsdGVkX1+ezP+M+GOpYwcFdCq7pX6mXoD7SF5w3qqbFTXN5kOPWXEf0Xj3WNn+D7bYSuKoKrD6MTP4TKGZPzBq2m/StwcDjpdNPBXjcVa7vvYUT7LMR15RUNcfyvT5/jmlf6ITPCh5GjgriTj56bLtBobzqXjwxeScSdq7ZxHD4Mj+dtQfFwf8aB1y5IBvZ7qLob/Nj41y8zHwmZmcyqiHqYpwQ6ijC0LED4YmJZ8KY21YsTMqFapgul6CK+PSA0rh5HJsvreK0X66wP0NEu7xEkrH3jmwhP2vwwDggnNV8ztUAPWTn5crkNhySlPNeg1qWgxNXdI+bvp/Boq+CoO+ducgb1D0muD5H7wNX3B/umXXLN5J7jmoxPGUr/p/S1lsPNUC5hFI6kIe1ZM9xPwcb9bzPpLBvw56GTcr6mdDHWm9kc9FKwfRI/ct5Ym4gJVygdphA+5rBo/2Nk1hmJdiiZYoHVIGDbfJZ/Ra2h+zijgluNFc3lVnhcKS4i2X74aMiJlWQGvRV/wRgGdWwwaY+FfQSjlTwFs4hRUUNQZNu4Af2E6IsHIZPH5W1kY2WV8EuFCPFwNaMBIm/wPn+yZbrIUl8DTUj6dOxhqeucNe4kFdKcoLiO0pZFgxHv3x0+aZBloMornOFz3QQoB9ZXJC0vM1Jnr2IqMK8KVMhICgEsUI3rDctQU3D3LGxjSb2sKIMaln35pD8Z6hwz6QQZ4cz6VQjlZnKzkiXujtvddhayGhWIbK1crFIP1rHEyUd6u2Xj5J/1hbAMgO4HtMxTfDQJKCJ0vgjKIIohsKmhsWf7tycPRV/fgdR9Y/gvVex841i+lYSX+Ehk5z6xZduHflov5mgMIRWDOfJZpmqedJeu5eteCoZc9BowTHlnLNb3oq2Vn0ej/rWirev7zBIGKV/JKGA5oDlSxcccY6k1Cr2p9Gox25qtPDg2/Ab3eroDa2UkiPVkJTy3iIIf8 TlDazqA0 Ti3i7DcQGAfua1n7GySdvx3O6L2UhJDtdg0wZ51M2HT6q6LPrk/r5PxiwHIFvT+Vjs84oPTXr20RmRPdMM/980PqYdmgB+QWuhdQ/vMQ9+zZKcxzefOgNeCssTum1ndvyBWc01xXDHonIh8hzaldnF77GIZeyZbky4AhVo5h6wWZG4QYPBOup12UTX5YUNAwJt7wDoc0WIfASzNoP5UFCs418mzlQ8vig9pE9TUTr37s05DcSVn74A5LBxLPUIkDy7D2FZAxX2Qn9ZGxqauJXA5u9m27rE/dBauCrRQKjlpHAqDqwUAK63KhhWI1OuCWEsszc+e1IWsqqtJKknkkGAI6aQkC9KgCfDpczQfdAHSHW/IOmz0FnJuMVbFPfAqBMHD5E54m7BzuTEnc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since debug slab is processed by free_to_partial_list(), and only debug slab which has SLAB_STORE_USER flag would care about the full list, we can remove these unrelated full list manipulations from __slab_free(). Signed-off-by: Chengming Zhou Acked-by: Christoph Lameter (Ampere) Reviewed-by: Vlastimil Babka --- mm/slub.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 20c03555c97b..f0307e8b4cd2 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4187,7 +4187,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, * then add it. */ if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) { - remove_full(s, n, slab); add_partial(n, slab, DEACTIVATE_TO_TAIL); stat(s, FREE_ADD_PARTIAL); } @@ -4201,9 +4200,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, */ remove_partial(n, slab); stat(s, FREE_REMOVE_PARTIAL); - } else { - /* Slab must be on the full list */ - remove_full(s, n, slab); } spin_unlock_irqrestore(&n->list_lock, flags);