From patchwork Wed Jan 17 11:46:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13521652 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5806EC47DA2 for ; Wed, 17 Jan 2024 11:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5A7D6B00E4; Wed, 17 Jan 2024 06:46:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3146B00E5; Wed, 17 Jan 2024 06:46:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8FF6B00E6; Wed, 17 Jan 2024 06:46:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B15B96B00E4 for ; Wed, 17 Jan 2024 06:46:44 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77098160B87 for ; Wed, 17 Jan 2024 11:46:42 +0000 (UTC) X-FDA: 81688625844.30.CA4E7A7 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by imf23.hostedemail.com (Postfix) with ESMTP id 96B2114000D for ; Wed, 17 Jan 2024 11:46:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf23.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705492000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yidEzXzJPgSqQaIUJwDUiw63hBbEIw1Zt18J4A65pq4=; b=0SeyxH8ShmcC6/gsDD36QRbFjrURGBAxidTDI7H66me4BSkBAzlsBO/b+0kGNHAOq4Jm7t 4aDy35IDnrIZYimcpafoT/KlWF9nUftJNk+Sx2sOq1EH+h6ci1mMwTRwLpFA1duVtx7LzA DOevalqfUGfLlefM8qr5tp9sjtnlg2w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf23.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705492000; a=rsa-sha256; cv=none; b=O/OMrwu+gY1gEPbTyL49i1HT7+OU5sjrPWrR2Bc0Gb6OXzQtOfOndg5rtp1odGfggDyDUT WMRT9KC2gxhgHXaM+NbFcLbcYY+eauyiRP7DSzkVAnsHxW16BHNLS2ruYPvWkgO/LP4zPA 3vj8dm14AZ/6OlJMdR9LsFJcu2nfh68= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Wed, 17 Jan 2024 11:46:00 +0000 Subject: [PATCH 3/3] mm/slub: remove unused parameter in next_freelist_entry() MIME-Version: 1.0 Message-Id: <20240117-slab-misc-v1-3-fd1c49ccbe70@bytedance.com> References: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> In-Reply-To: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Vlastimil Babka , Christoph Lameter , Pekka Enberg , Andrew Morton , Roman Gushchin , David Rientjes Cc: linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1705491984; l=1440; i=zhouchengming@bytedance.com; s=20231204; h=from:subject:message-id; bh=FCOnwYrhZkluxCwU1rI7qym40IkKZ74sKbmGZdbV/NU=; b=r60bI1xFOSY0XMd/T4Vsn0QUucBv9bV6X7Ko6gDXvzMuaW9qAxNwy6xtQTq9LHk4bfdsUq04n Izus8lbaiz1CHUbUv63tGpbiP1Tp3eAQ0hAti23U2ipWl75vInBFP5w X-Developer-Key: i=zhouchengming@bytedance.com; a=ed25519; pk=xFTmRtMG3vELGJBUiml7OYNdM393WOMv0iWWeQEVVdA= X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 96B2114000D X-Rspamd-Server: rspam12 X-Stat-Signature: yxubtazei4e89o6oikhk5fpoep69j3hd X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1705492000-776554 X-HE-Meta: U2FsdGVkX18IheeztIJKNxX2qkbxIszxl7QZpv9KQ3ri8E5WutnnvClhDlhPOJ855sNGSOxAKd6pYramqC/5DGg64neHk91k+MMuOWsW29V+ZWKBDgkMtkdiFTiDveWLuRht5LtGsOSh+szGIHkA4G2rfixbxSZ2LcpzCWNEqUOwmFFnJrSfZ5MM7wtG4Vih9bIMyXaSj9kRxxEAmmu1lqmNoxSFdcNptuPk5GGKuJkl013XoTE9Ia05JTo0pZYeycC+G4+uKu3DlFx/gCB1qLBpiJ6jHRJM5JY2/0XLzrfIHtllO7Gemcf09aFSU+68aBLA0EQBWgwrrNbxNqpDRnst43P8dGe3y0xaQNZjiaI9ouETQ+zX7IxEPI2YMCaWInNa8F8W9WKM7mT+9ZgHJYwoyeLJxkNcT4PRxCy9R3Yva8nydi/Qgafn4sftY9vjHU8JhcabX5kpRexZMttaOlzknYO7jRfGXlNmS/8v298VlaafNvqBcj8Uro4/zPVx2CG7YzFjav7/Q+uE3osdLrqCfwubm2tRBAdTHZ9os5FXYKd3tLId2RCNPwXfHHeYxXEqf/qIYTvZMtUR0HuopSO4fcjeskAZPOJFrg90O1DigMFEQJsvtYFJA67iU8HDDACW80IEX/xhoR2KBzs5en8ZbgpE5M6Z9GP0DzkWqFrcJ+7FCTY3n1VPfLb0Tr9RkJlhx46J6y/r+KGs/QSwd+qQq9C45cXa0E9MHjRIm1IWig6F8U0l75ugHtTxCizktitRawnDlZAINQJN5j5pSL/dn4pprfOPc+/ZkVF5vBx3hman2HrU0Jr4X8z+J/SPeesj8ubifvgknp5KA+UuXgHEU4gWjZAlMcf0DY4ISMJsmYt5lRM2Jjcl8F1GR4eWm9j1D3YjSPI+pENvgIL96u/xvQoUFpBo1oJ76gVPTkjZGCAQ2Ywjw2C9S7u06CWARFDKao1u+n0pkZc44HU blx2IuYA 4WXuEYIvQyiaV9s3jJLlbIEYHu9K9dx3/cPR4NnF3h1MlKe0IQsHBNPP7Ezwap2c3n+S4n32cILnomSXskNsUu7OAh2PiYE9ZTELfjbdRolqCgIvfxJpiHd55kGfJpYjw/SdH5x5SA+BsFvbTpDehFI1hxp014uTwSlDslvysyYWk3MiMLEemihv1MgNEqUpz3h4FMXOVUMF5HJGbzp3jgjGw5OJid57eP2R1QbYPKxIpmHxq5rIUzIgCJg5jEk1ItLVFgmFGSwjqRGetikQI0Zq7EEnkacXUE1cP2UjPdrwzsYlmcvnmXP7pxVOlwv6brpx7QMS1ugME77QkH6yyDajXyoH2PdpZrUh+/UzT2q19w3bjXIU6XyDxld3ZbDH3DDJ4WUM1AXqcMLu/YKsQcIAGuopg8hWOxZflMlwTNwbs4WnLIAzFXKk+gip6lK85NEJi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The parameter "struct slab *slab" is unused in next_freelist_entry(), so just remove it. Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka --- mm/slub.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index f0307e8b4cd2..3a4e2f8d341c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2243,7 +2243,7 @@ static void __init init_freelist_randomization(void) } /* Get the next entry on the pre-computed freelist randomized */ -static void *next_freelist_entry(struct kmem_cache *s, struct slab *slab, +static void *next_freelist_entry(struct kmem_cache *s, unsigned long *pos, void *start, unsigned long page_limit, unsigned long freelist_count) @@ -2282,13 +2282,12 @@ static bool shuffle_freelist(struct kmem_cache *s, struct slab *slab) start = fixup_red_left(s, slab_address(slab)); /* First entry is used as the base of the freelist */ - cur = next_freelist_entry(s, slab, &pos, start, page_limit, - freelist_count); + cur = next_freelist_entry(s, &pos, start, page_limit, freelist_count); cur = setup_object(s, cur); slab->freelist = cur; for (idx = 1; idx < slab->objects; idx++) { - next = next_freelist_entry(s, slab, &pos, start, page_limit, + next = next_freelist_entry(s, &pos, start, page_limit, freelist_count); next = setup_object(s, next); set_freepointer(s, cur, next);