From patchwork Thu Jan 18 12:39:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang Li X-Patchwork-Id: 13522807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72191C4707B for ; Thu, 18 Jan 2024 12:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 016BB6B0089; Thu, 18 Jan 2024 07:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F08AD6B008A; Thu, 18 Jan 2024 07:39:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF50B6B008C; Thu, 18 Jan 2024 07:39:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF0576B0089 for ; Thu, 18 Jan 2024 07:39:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A8283160C9D for ; Thu, 18 Jan 2024 12:39:31 +0000 (UTC) X-FDA: 81692387742.23.408235F Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf04.hostedemail.com (Postfix) with ESMTP id E7F3A4001E for ; Thu, 18 Jan 2024 12:39:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="CBfV/dbd"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705581570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TzFCclyqcCZ/DPTkdiqBlpFX5oAyD0zr6O7wxsAo568=; b=luxl0yXURvAEFTbamo3GbWzkYemaG1prmhz2qAyE9bJokzEWhfpphvo4q0tWLgHr1Ainje BgS+G5hPaQh2K8q0+oKdYIzXWOngpxZJWXfT0I/fnVvSWnN/gso8W7Bz5Ps13qijcS4/nA MtOtOljh3tvCZa0RxnNIqh1p2NU5c9g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="CBfV/dbd"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705581570; a=rsa-sha256; cv=none; b=sKkH5e3KPD455TwZOl/zxrDfLUz7VqOdFObIOvMPYAZK9HCnXlyGz7ZhAXOHiK8qaK8XTK Ye7qQjz6Ly28YAQpS/1XqsbMcjOrlzp8GGN4Akp7/M0UlnnufE+XazQgM6f+aJiIvFwVos RE0oehn7af1If4DXnAovcfpgZ5XfqKI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705581568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TzFCclyqcCZ/DPTkdiqBlpFX5oAyD0zr6O7wxsAo568=; b=CBfV/dbd2xHdE+F7YOmZ8GE2oRxwpthKTYpZaNj00rjrNcG/Z6lT98VVTzGw5xvY9Iwof6 dbCeWyIuDNqzO2dQE9ps3z2Qxk/A0VvAR8HDZp233bxQeP3YxsFW41WeXH4eB6WEwKUxc2 jA2LqaFNCxUtLsV24/vypYmZim4cKdU= From: Gang Li To: David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, Gang Li Subject: [PATCH v4 3/7] padata: dispatch works on different nodes Date: Thu, 18 Jan 2024 20:39:07 +0800 Message-Id: <20240118123911.88833-4-gang.li@linux.dev> In-Reply-To: <20240118123911.88833-1-gang.li@linux.dev> References: <20240118123911.88833-1-gang.li@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E7F3A4001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8ya9oezaw5ptnw3q6t5zza611o48juyk X-HE-Tag: 1705581569-830587 X-HE-Meta: U2FsdGVkX1+pL7I3YUkuoy++hTL3qDuU23ub8gPx8932M7qPfHs5qbxrWGRL+p3baGfzR913920pwrgyOVV3HWZHMXX1DWswMTnfHz4NsenM6ab/4kYLypTdtywweTqG1v4pqyTRDmurENMQZ2mvF7br2j1kTwMlVxB/l0BdwTpbV+aZevVZj3rSHEZmtne0cTpqqvtqnWbR5IwpjQ2ig6MsWg9ATTIYPbefZZ8fEtYuS8LbdVdUyMpxj3yaVw+J7m310uy4lDFM/ul4FDuqfzRVSvz8Wnu6iyBgMOJnYrmCkVAZlwkW/yZ5X1Jl1jaBM7nHppIhvH4khQawiHpZRIeivV8j+83H/+avqBBeP/lpSRanqBQ6Z1AO0gcULOOX4g+YtBH5WFLpndYUY8s0x6gmSKLymz9HRJU6Y59mV3BuMHmRK7a3L4wzyBBf19YxkjOSP2Zeh/a/tCEsjKMAKAumk6HOSjufo7pOQ5S/T+Hvu8N0spLqIQ9we6AVrF6VbHyoXq1c9xDrPM/kJGzJo/IdAYZzBIuRQojm8bRvFQxQ+5t4fFWCK6fa6LqpNKOn51PEX1fkMWwanS2VpFph+ipjFYLMxvbQbRwGrARpsL6XJTMpPO4/5r0uWKYeeWzJS3LHUZmP0FfYcxRqMX8+AV1kNqND0s9kWqPWKSEcTgK4Pfy6EDF7gS7M9LQuvsGdcmTFjpe7s5UFnE4dvd0Qou4tDJUmuuE4N1le/dyGfUnvbwh2Wb/zc/qupPncCWcreRYYqTG+NUq9ft4AWqvePgaVKwsuKKdSNRhyCkK2jpINayMfie+MK3BdH5JDZocreWcv4lk+lolmeamlBCproZ907JAF3UEZ2niOEosotBZNaMptTe8tMHmQYHFOY8pDGN5ecNo5k8I0vpLUk6YzFEKnET7mmZKco4r378QWWzDTZTPh0dfKwdzsS+eQEXCelKyl7iRosX6jhCTIEJd t2E1v88k 69IhSnxRVqt2+7MM97aul3prAGCwA4CWuUfOGZXAEYB5xTB42JJvrn80MvLPRb0mFpFahgFuk3obBoF6SQ23GlCKfhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a group of tasks that access different nodes are scheduled on the same node, they may encounter bandwidth bottlenecks and access latency. Thus, numa_aware flag is introduced here, allowing tasks to be distributed across different nodes to fully utilize the advantage of multi-node systems. Signed-off-by: Gang Li Tested-by: David Rientjes Reviewed-by: Muchun Song --- include/linux/padata.h | 3 +++ kernel/padata.c | 14 ++++++++++++-- mm/mm_init.c | 1 + 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 495b16b6b4d7..f79ccd50e7f4 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -137,6 +137,8 @@ struct padata_shell { * appropriate for one worker thread to do at once. * @max_threads: Max threads to use for the job, actual number may be less * depending on task size and minimum chunk size. + * @numa_aware: Dispatch jobs to different nodes. If a node only has memory but + * no CPU, dispatch its jobs to a random CPU. */ struct padata_mt_job { void (*thread_fn)(unsigned long start, unsigned long end, void *arg); @@ -146,6 +148,7 @@ struct padata_mt_job { unsigned long align; unsigned long min_chunk; int max_threads; + bool numa_aware; }; /** diff --git a/kernel/padata.c b/kernel/padata.c index 179fb1518070..10eae3f59203 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) struct padata_work my_work, *pw; struct padata_mt_job_state ps; LIST_HEAD(works); - int nworks; + int nworks, nid; + static atomic_t last_used_nid = ATOMIC_INIT(0); if (job->size == 0) return; @@ -517,7 +518,16 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) ps.chunk_size = roundup(ps.chunk_size, job->align); list_for_each_entry(pw, &works, pw_list) - queue_work(system_unbound_wq, &pw->pw_work); + if (job->numa_aware) { + int old_node = atomic_read(&last_used_nid); + + do { + nid = next_node_in(old_node, node_states[N_CPU]); + } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); + queue_work_node(nid, system_unbound_wq, &pw->pw_work); + } else { + queue_work(system_unbound_wq, &pw->pw_work); + } /* Use the current thread, which saves starting a workqueue worker. */ padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK); diff --git a/mm/mm_init.c b/mm/mm_init.c index 2c19f5515e36..549e76af8f82 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2231,6 +2231,7 @@ static int __init deferred_init_memmap(void *data) .align = PAGES_PER_SECTION, .min_chunk = PAGES_PER_SECTION, .max_threads = max_threads, + .numa_aware = false, }; padata_do_multithreaded(&job);