From patchwork Mon Jan 22 01:00:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13524733 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399A1C47422 for ; Mon, 22 Jan 2024 02:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8F786B0072; Sun, 21 Jan 2024 21:48:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF1356B0074; Sun, 21 Jan 2024 21:48:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943F66B0078; Sun, 21 Jan 2024 21:48:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 867FA6B0072 for ; Sun, 21 Jan 2024 21:48:13 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 482311206FD for ; Mon, 22 Jan 2024 02:48:13 +0000 (UTC) X-FDA: 81705412866.05.15C2E1B Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf08.hostedemail.com (Postfix) with ESMTP id 4D2C816000D for ; Mon, 22 Jan 2024 02:48:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705891691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JD5mtfEWkRjuaUV9XVtob8Xf345yQ1B8wbzU19SAuqU=; b=2dDc1iYgklGOiDw6+5kTDGY93/RHbk5iW4oagm7FuzEqP1Gky5OJCzj5Pt7Mrnwlg+nzxb U0jufltk4Cl1vVLsyuva6OnT3VkoZzpC3EVXN1IyKRQBoQpipm1sRqIEOHpjJ/ctn6apLP /3EoBHRHukaCkLdXH+dN7oEGJstmMGU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705891691; a=rsa-sha256; cv=none; b=N9weTeFbCnQhPRrQN8jOA5Su29cmvglt56lhVQLdM43hkkPybcejs1vL+bSB/a7mcR36r6 iP5YjItqDxU+DzYuUppdBTUFjk9Ghk4eqQRS9OzkjAqZPu+lmdSpUAbWpjRGlbpD+K5qGK vj28zrzg9I1psJ3Z08Bg+bPc8EJYOWo= X-AuditID: a67dfc5b-d85ff70000001748-7f-65adbe43fac1 From: Byungchul Park To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com Subject: [PATCH v7 4/8] x86/tlb, mm/rmap: Separate arch_tlbbatch_clear() out of arch_tlbbatch_flush() Date: Mon, 22 Jan 2024 10:00:36 +0900 Message-Id: <20240122010040.74346-5-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240122010040.74346-1-byungchul@sk.com> References: <20240122010040.74346-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsXC9ZZnka7zvrWpBtsnaljMWb+GzeLzhn9s Fi82tDNafF3/i9ni6ac+FovLu+awWdxb85/V4vyutawWO5buY7K4dGABk8X1XQ8ZLY73HmCy mH/vM5vF5k1TmS2OT5nKaPH7B1DHyVmTWRwEPb639rF47Jx1l91jwaZSj80rtDwW73nJ5LFp VSebx6ZPk9g93p07x+5xYsZvFo95JwM93u+7yuax9ZedR+PUa2wenzfJebyb/5YtgD+KyyYl NSezLLVI3y6BK+PonXtsBXM4K87/msrUwHiJvYuRg0NCwERiws+yLkZOMPPa0+WMIDabgLrE jRs/mUFsEQEziYOtf4DKuTiYBT4ySaz+3sECkhAWSJU49eo7WAOLgKrE1nMPwBp4BUwlli1+ yggxVF5i9YYDYHFOoEFTfnUxgdhCQDVzP+xkBBkqIdDMLvHz7lJWiAZJiYMrbrBMYORdwMiw ilEoM68sNzEzx0QvozIvs0IvOT93EyMwHpbV/onewfjpQvAhRgEORiUeXgf2talCrIllxZW5 hxglOJiVRHj5VVelCvGmJFZWpRblxxeV5qQWH2KU5mBREuc1+laeIiSQnliSmp2aWpBaBJNl 4uCUamDsXX6r+OLRd4dfr/vpuvrC4/vaq8wdzyqrcN7883LRhBntXtPMMtsbtsjd2vb2qYBQ BOuh3yZcD5z6blQF3XNKlRA65Sp2OOPWwe+GV/1z/R65/yysrbw0gaV57XrGxlTfZ+rz86S/ Khur/TEIqL1bMTHm2IZz7Mdts+LY595N197J+T30hMdfJZbijERDLeai4kQAW6vnxIMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsXC5WfdrOu8b22qwaaJshZz1q9hs/i84R+b xYsN7YwWX9f/YrZ4+qmPxeLw3JOsFpd3zWGzuLfmP6vF+V1rWS12LN3HZHHpwAImi+u7HjJa HO89wGQx/95nNovNm6YyWxyfMpXR4vcPoI6TsyazOAh5fG/tY/HYOesuu8eCTaUem1doeSze 85LJY9OqTjaPTZ8msXu8O3eO3ePEjN8sHvNOBnq833eVzWPxiw9MHlt/2Xk0Tr3G5vF5k5zH u/lv2QIEorhsUlJzMstSi/TtErgyjt65x1Ywh7Pi/K+pTA2Ml9i7GDk5JARMJK49Xc4IYrMJ qEvcuPGTGcQWETCTONj6B6iGi4NZ4COTxOrvHSwgCWGBVIlTr76DNbAIqEpsPfcArIFXwFRi 2eKnjBBD5SVWbzgAFucEGjTlVxcTiC0EVDP3w07GCYxcCxgZVjGKZOaV5SZm5pjqFWdnVOZl Vugl5+duYgSG97LaPxN3MH657H6IUYCDUYmH14F9baoQa2JZcWXuIUYJDmYlEV5+1VWpQrwp iZVVqUX58UWlOanFhxilOViUxHm9wlMThATSE0tSs1NTC1KLYLJMHJxSDYwlu0V7RCOeRefs dO2/Kfs9avae3+sdFe8I7H7rq3adq4XhBoO2X8KkCa5mT+eEHr19tSLW8eyJNRn9d+UnsWh5 /fE16lfYLNfHI/ZHi/+30CqhO1c3crmc3FS6PsSS32y6+7UFl7jTX7hvvjNP5Vq8WdGl0pWS oq4PAu3VGs2m/DBev+ggV5USS3FGoqEWc1FxIgBG/k1hawIAAA== X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 4D2C816000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8cnh39u9mnktsi58f37xr5ahhjjqcdrw X-HE-Tag: 1705891691-379921 X-HE-Meta: U2FsdGVkX18uXBE9yWVwBH2E42UgefsshhRq9WgogiJCgwlm6jZS5d5REhFBimUWckXDqDROkI3/BagwISlclHzCfe6g0hiILqGC0a7LK5ixmW0SrZ58WC8MEfyYifTbyWXEzTU1uggS0R0enUHW95B7HO/Zl9J+LaunYCa6eGbiPnl5a3jN/leebhgLjtVJ2ZjpBnjSiM/PDXhPFW6nUT5C2Yt/+Ut+gTQVeQtcqBrGHrdN2z4gKeNPrzCYfmgS6tZ0zT+cKtAZ1uCfIYTtWiq19VxSy6opHvaxgdh8TXCJDCZgfGbXaMOubebmz+OUGWTElRlQT+JttM5Wg3YC2j1i47OJgNg21/5+Z5/Kertaqfz/OHGwstEyUmi+aNFsmqfk0NMfrRX3gPRn/QKjwtvdsfZ1yxqVtUpAGxKViNbNpcRTtsmh0/qQ9jNjOch/Q1TbKAXyuh1U+rUac6OgGe6t1LpPZEhg3thL39ygsod2B87lW+0TKE/o8h4gRDLGFmbgT6g8i9Q6WW+4y+2y6CPlPc+skggxiY7dKOdLA9gnjOWx+3Nm7IGnUEqBq3zkZe9DX83Wzo1PhusLtxrnkLuYnoZGYgYwo1WHxiU0URhbmg8CK1x4LEtgapfuoz28n/GY+Eh6A//eDCKvtuXFmVX+x4WcL98OZ4CfR7Vx42yE3msgaJpw0Uqut2cQZux8AbEbfWgDh9h+6zEHn8IGcwT1/tZS+q04DnLH1eNFhgp0dH/rW47jX4RPildzwdvheuieVUs3/4ms2MGzHcBWLeiHBZQyM4ie4Tokm0pfLPR4x/OXlxwJXSPC+0poMtDlqZiLlKdFK6hj0OEi5QRLXHnNzsoq/wJGODpb0OU5DNqKYg9y4+U8FPfg5HJsA3X8Nef2DUJIVfLZoKq6vwpYNO5jIv4Ydp4io5ftxcxTzxvtidOQIf84gUYuT9b3566RdZjbzRHM99yyvfzn3OJ yps8uzuy 7vcqUPexzoh4U14N6NbIrorUsUalggFZ3/Fw2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a preparation for migrc mechanism that requires to avoid redundant TLB flushes by manipulating tlb batch's arch data after arch_tlbbatch_flush(). However, we cannot because the data is getting cleared inside arch_tlbbatch_flush(). So separated the part clearing the tlb batch's arch data out of arch_tlbbatch_flush(). Signed-off-by: Byungchul Park --- arch/x86/mm/tlb.c | 2 -- mm/rmap.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 453ea95b667d..941f41df02f3 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1268,8 +1268,6 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) local_irq_enable(); } - cpumask_clear(&batch->cpumask); - put_flush_tlb_info(); put_cpu(); } diff --git a/mm/rmap.c b/mm/rmap.c index da36f23ff7b0..b484d659d0c1 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -643,6 +643,7 @@ void try_to_unmap_flush(void) return; arch_tlbbatch_flush(&tlb_ubc->arch); + arch_tlbbatch_clear(&tlb_ubc->arch); tlb_ubc->flush_required = false; tlb_ubc->writable = false; }