From patchwork Mon Jan 22 01:00:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13524735 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2902C47422 for ; Mon, 22 Jan 2024 02:48:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 610F86B0078; Sun, 21 Jan 2024 21:48:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59A116B007B; Sun, 21 Jan 2024 21:48:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 413BA8D0001; Sun, 21 Jan 2024 21:48:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C8B66B0078 for ; Sun, 21 Jan 2024 21:48:26 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BD8F31208C3 for ; Mon, 22 Jan 2024 02:48:25 +0000 (UTC) X-FDA: 81705413370.04.A26D788 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf29.hostedemail.com (Postfix) with ESMTP id D9DA7120025 for ; Mon, 22 Jan 2024 02:48:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705891704; a=rsa-sha256; cv=none; b=P6anPqN4KI1y2xul1oZXurkkl9c7h7+LGTRtFVbegH7klIA4nhNjUL746Ff3O6H3pAL9/9 cnjahnqvD0FhkFLY4BSLKuuc3YLD2tBLFxsD46sw3xaQrZhlFBKYHNAdmAa/5tHY0KM22h SrJ3TjTJI6KFU9Jl7CQEy05BOtRor+8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705891704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=xyww7pMUuLyPBfG9ZuK6U6g9ZtqJWjn+tCNK2s25zA8=; b=5CTGxUahgES6A/e8JvcMnC5J94yFIrxMbb+f1T0MvlSS4nEey8jdWnrncDR9y25IeIUlCf OHMmsI9gL6dVEdI3DMjv1Susbhufc9Dod+EbO+3onLAwXZ4O+ELBiF8ilLpip9ji5hUoah 3nMKhBlGNEeA6lxI1eLkTaXcxJ8VIpc= X-AuditID: a67dfc5b-d85ff70000001748-8a-65adbe437328 From: Byungchul Park To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com Subject: [PATCH v7 6/8] mm: Add APIs to free a folio directly to the buddy bypassing pcp Date: Mon, 22 Jan 2024 10:00:38 +0900 Message-Id: <20240122010040.74346-7-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240122010040.74346-1-byungchul@sk.com> References: <20240122010040.74346-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsXC9ZZnka7zvrWpBtc2G1rMWb+GzeLzhn9s Fi82tDNafF3/i9ni6ac+FovLu+awWdxb85/V4vyutawWO5buY7K4dGABk8X1XQ8ZLY73HmCy mH/vM5vF5k1TmS2OT5nKaPH7B1DHyVmTWRwEPb639rF47Jx1l91jwaZSj80rtDwW73nJ5LFp VSebx6ZPk9g93p07x+5xYsZvFo95JwM93u+7yuax9ZedR+PUa2wenzfJebyb/5YtgD+KyyYl NSezLLVI3y6BK6PjOlvBH6mKw8d3Mzcw/hDtYuTgkBAwkdhxjAPG3N4s2MXIycEmoC5x48ZP ZhBbRMBM4mDrH/YuRi4OZoGPTBKrv3ewgCSEBSIkpmxfxA5iswioSjRMfAkW5xUwlTi//QUj iC0hIC+xesMBsEGcQIOm/OpiArGFgGrmftgJVdPOLvFmvz+ELSlxcMUNlgmMvAsYGVYxCmXm leUmZuaY6GVU5mVW6CXn525iBEbCsto/0TsYP10IPsQowMGoxMPrwL42VYg1say4MvcQowQH s5IIL7/qqlQh3pTEyqrUovz4otKc1OJDjNIcLErivEbfylOEBNITS1KzU1MLUotgskwcnFIN jFPjFoYkO/Srujx9E/MstvSd0JHVn5Yxz61ROWWgqS9hsud8W57y6arTa96rLrC/+m37qjid 5NYEs7I9DSeKudKLs3cfd9V7wiH55kvB4s0Mx66JLL0iGGZpWRRra61/8cAdNakXp2/f9vCO ym3bIhqsc9HpwW251btaprjeO3/w4i+N8y/TFyuxFGckGmoxFxUnAgBo49/vgAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsXC5WfdrOu8b22qwd+FahZz1q9hs/i84R+b xYsN7YwWX9f/YrZ4+qmPxeLw3JOsFpd3zWGzuLfmP6vF+V1rWS12LN3HZHHpwAImi+u7HjJa HO89wGQx/95nNovNm6YyWxyfMpXR4vcPoI6TsyazOAh5fG/tY/HYOesuu8eCTaUem1doeSze 85LJY9OqTjaPTZ8msXu8O3eO3ePEjN8sHvNOBnq833eVzWPxiw9MHlt/2Xk0Tr3G5vF5k5zH u/lv2QIEorhsUlJzMstSi/TtErgyOq6zFfyRqjh8fDdzA+MP0S5GDg4JAROJ7c2CXYycHGwC 6hI3bvxkBrFFBMwkDrb+Ye9i5OJgFvjIJLH6ewcLSEJYIEJiyvZF7CA2i4CqRMPEl2BxXgFT ifPbXzCC2BIC8hKrNxwAG8QJNGjKry4mEFsIqGbuh52MExi5FjAyrGIUycwry03MzDHVK87O qMzLrNBLzs/dxAgM7WW1fybuYPxy2f0QowAHoxIPrwP72lQh1sSy4srcQ4wSHMxKIrz8qqtS hXhTEiurUovy44tKc1KLDzFKc7AoifN6hacmCAmkJ5akZqemFqQWwWSZODilGhjDKx6vLkh3 Mvtea9p77d7RzOPWKxN4W3a4T6++ddqBbWbq3J+TtSaXTH7AaCzym1le+vjqQvfUxcflTvyI fl6VsP3tvEnl089+/LIpjVvXSUo8616gj+cV5VszBHuZKh6JVD5bXW3Isb9ggnP7l9PuRfF7 dKdeNrhel3VsVtIy0awtlZ9maq5VYinOSDTUYi4qTgQAE1Vq9mkCAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D9DA7120025 X-Stat-Signature: xg1qu9k8ip86dkrwwc35hta6x7iyw53k X-Rspam-User: X-HE-Tag: 1705891703-4570 X-HE-Meta: U2FsdGVkX1/cI/Z+TywbsFnSFeU9G1akC9MvvCrOJqxGipnZPgMhjgHyE5DJZrlc1ZITYheuiKWHw0T8LqDNekjgQvjY6c/hAh5YhjSSV8Kpgsl7MHRBfZtDOLBzrOH04KlguMuYEdbKd7wGAubfglRDcNoK6IoS5S1+hEfH8cF7VyNP18qodpYcZ1sKbevSCjeykajcYESxsqiCa2M2mRKISDB2cJ/mK0TFmII4g2yZXjcukE7tnkczoRba6UinkjKTzPCIL5YQt0Tyq6xx27fkRAM70jEzgR5jokoSTwsgcWHMfO1ekj5h2DCbSlF9cYjF5InK4hITekUzELY+RpJ8rdmYfORqgUDY8zw9DgOtFik4h/e0aQSCf4fvj8dRAXCxPpiLnpVcxxGl/ZY334fBgmphK9khNPr/Wr0duhpO5f7+kkMhxCzfa7qVD2PqvvDdNB9dWism4EUAcEkdYPOzCdIpUxWT3wev92qAxsr1B42+RNA/DisgZVavvaycfpjR/u9ZT8Ldd4bcf1GX6oprIsbog3QXIdXTStkKVB5oz3srovIxsRXuqmqiCI5NlPtbTm78ABhlqFV68IEVRIACJea1nD2xz8wLodrsCzIhEEf43zW6C+jMgreUW5PN+LSCkS1Pqf7Ns4WLsHPkR4vKFntV7Td2dXATYDzbC2nLs1Y1kLMwHdhtmUg56zXITpdDLGJzaQw25AvaX8sZMsYEYlblS9BxZMQhOXcPMGcQo+m4lv5h4wyEha2PsxQEyGn3fAQ7fmBAROSust8Zj1TVmMOPDQ7I4YsZ5f4CdNzCSWTYL3eS2hfi3FRK91oFkiv0y1yeWPEIUOaFfBYbl7aEjVUN4/DeE46c+j3S30b18+MN1lt1Uve7mXR9IblGHbEoogH2HI3yNvMUU/mArOFQ/9WwC0ilDbfUVaE/rq6ZjAXZxS4VCAp+//M+33wXFNg91rzymq8Wl4rt4ss XOTIG2Cv ShT0XNEx0urOBBk8IuetPd4nqLOiRyLrYnynLhHxDh4wgIwaqRIm0ioqL3k8xUFxrWv0HqbsHRJcswq691fWQBUQ97VeZHLU7YDsfz6cLSouZhb98lrBoKl7isbP3Qul0xOQU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a preparation for migrc mechanism that frees folios at a better time later, rather than the moment migrating folios. The folios freed by migrc are too old to keep in pcp. Signed-off-by: Byungchul Park --- include/linux/mm.h | 23 +++++++++++++++++++++++ mm/internal.h | 1 + mm/page_alloc.c | 10 ++++++++++ mm/swap.c | 7 +++++++ 4 files changed, 41 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index da5219b48d52..fc0581cce3a7 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1284,6 +1284,7 @@ static inline struct folio *virt_to_folio(const void *x) } void __folio_put(struct folio *folio); +void __folio_put_small_nopcp(struct folio *folio); void put_pages_list(struct list_head *pages); @@ -1483,6 +1484,28 @@ static inline void folio_put(struct folio *folio) __folio_put(folio); } +/** + * folio_put_small_nopcp - Decrement the reference count on a folio. + * @folio: The folio. + * + * This is only for a single page folio to release directly to the buddy + * allocator bypassing pcp. + * + * If the folio's reference count reaches zero, the memory will be + * released back to the page allocator and may be used by another + * allocation immediately. Do not access the memory or the struct folio + * after calling folio_put_small_nopcp() unless you can be sure that it + * wasn't the last reference. + * + * Context: May be called in process or interrupt context, but not in NMI + * context. May be called while holding a spinlock. + */ +static inline void folio_put_small_nopcp(struct folio *folio) +{ + if (folio_put_testzero(folio)) + __folio_put_small_nopcp(folio); +} + /** * folio_put_refs - Reduce the reference count on a folio. * @folio: The folio. diff --git a/mm/internal.h b/mm/internal.h index b880f1e78700..3be8fd5604e8 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -451,6 +451,7 @@ extern int user_min_free_kbytes; extern void free_unref_page(struct page *page, unsigned int order); extern void free_unref_page_list(struct list_head *list); +extern void free_pages_nopcp(struct page *page, unsigned int order); extern void zone_pcp_reset(struct zone *zone); extern void zone_pcp_disable(struct zone *zone); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 733732e7e0ba..21b8c8cd1673 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -565,6 +565,16 @@ static inline void free_the_page(struct page *page, unsigned int order) __free_pages_ok(page, order, FPI_NONE); } +void free_pages_nopcp(struct page *page, unsigned int order) +{ + /* + * This function will be used in case that the pages are too + * cold to keep in pcp e.g. migrc mechanism. So it'd better + * release the pages to the tail. + */ + __free_pages_ok(page, order, FPI_TO_TAIL); +} + /* * Higher-order pages are called "compound pages". They are structured thusly: * diff --git a/mm/swap.c b/mm/swap.c index cd8f0150ba3a..3f37496a1184 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -106,6 +106,13 @@ static void __folio_put_small(struct folio *folio) free_unref_page(&folio->page, 0); } +void __folio_put_small_nopcp(struct folio *folio) +{ + __page_cache_release(folio); + mem_cgroup_uncharge(folio); + free_pages_nopcp(&folio->page, 0); +} + static void __folio_put_large(struct folio *folio) { /*