From patchwork Mon Jan 22 22:32:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13526332 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A5FC46CD2 for ; Mon, 22 Jan 2024 22:33:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1912D8D000A; Mon, 22 Jan 2024 17:33:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1407A8D0003; Mon, 22 Jan 2024 17:33:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFC1C8D000A; Mon, 22 Jan 2024 17:33:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D741E8D0003 for ; Mon, 22 Jan 2024 17:33:06 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B7CEB120659 for ; Mon, 22 Jan 2024 22:33:06 +0000 (UTC) X-FDA: 81708398772.30.99AE4D4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id F054F100006 for ; Mon, 22 Jan 2024 22:33:04 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a7jsWXxM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705962785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; b=8IPtIYsUTUhLfGUw/CJRn9HQgXcXXqBu/m69ayTtOfZqn/SC3gDZYNCKOVpX6ZuzP4Ipls jDS5qG/Xb8cSkNyAeKBSH18JiEiRrtjtswzVSOfonFogsjDRLuUegUyqcrD7X+svrlT7q0 Ij8fWcvbVSIgj7t9o0Jc1XuMYCrnZ4I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a7jsWXxM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705962785; a=rsa-sha256; cv=none; b=hG9o1+/zcZFnkXMKKivb31vY8qGvc+rNC/UvAsyvsXJ5t1WUG2f1YKL9DJEF55KC09/ieH 90dgctH6VVBzhpUsOvNqt49XzQlXHXxUyxNleADL19l9PgIKrMYTLdlnXiK7ZFQ2hWpU4E 0uhU3Z70hWdmsSEsdiPUtfyBpk3K2aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705962784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; b=a7jsWXxMF9S6/wVlvkgRhnbZZf4Tepll56ndYZZA2jOUio9APcErXR9gX86GIVrIqtg2rA aff+a7Hw1szC6RDEKEkHL2Grm9/l9A+iDp8g0IGkhEsRcOmyJIJphw/qtnk/MLePLiYGnt DiV9QtewnDW6ojeVPSyXO2hTspnUELc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473--HGPYFG7OMq08y4wHZqsJA-1; Mon, 22 Jan 2024 17:33:01 -0500 X-MC-Unique: -HGPYFG7OMq08y4wHZqsJA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F87A185A780; Mon, 22 Jan 2024 22:33:00 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FAB4C0FDCA; Mon, 22 Jan 2024 22:32:57 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Viro , Marc Dionne Subject: [PATCH v2 09/10] afs: Remove afs_dynroot_d_revalidate() as it is redundant Date: Mon, 22 Jan 2024 22:32:22 +0000 Message-ID: <20240122223230.4000595-10-dhowells@redhat.com> In-Reply-To: <20240122223230.4000595-1-dhowells@redhat.com> References: <20240122223230.4000595-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F054F100006 X-Stat-Signature: t4emezqjxcg7z1sbpusi5f8ty4yrso41 X-HE-Tag: 1705962784-111906 X-HE-Meta: U2FsdGVkX18G0QcrbkSXu9MA+yp0AVz0Zxm2dRgyBs0JypBke2NidZlxRI5/hYnfL8jaqDCzWekBdh9H06P6Hi/HuQpAokTW/njf/VdstvnRYErWMa+twiwrNg7PaHZleKWC0friK7uaMGzPmWP4102ugGEj1UVJtqaqjfWpsTtLAK5MtKjmkKjeC4AX18vPBRhBJWT34RWsXJv2wZqzzTnflh+VNkonReRDmxR3xtqMObTwHF1j+H7lwiv7Tswc0l7Lzibnh7Q8xh+qRZ6cQatXu/YkA99IkpkjVuPiHrsU0GOT31WoXRPE1zdwTcc3jGgnPEhwSjo+ej8arlnE/WoV5Du++nOmfn0Kb1Gs6iAQa+MNb7N8JGUwBIfZovbL80r7HTWkItBX2wL7BD/iS1tfziSa5ZQFBJ3uZGVFDG2RA3cD1i5k4Ayrlvl2IqYQOFKLr7MUw0R7Aiy+9tjJHuTeT7dC2UAmTaVchtFfyJf90Nt0oeFjzQfteja948xZ8azUIH7zgW0pNJSOjeflpT6H6kRDjH8+6OnEa0jKfo99NAf/f5BhVcuj8M7jkzzIj2cDKIB5ExRMdBTvjEiJyD59O1HaPUNK6Wf/YmYmt0mFxDB86aUuAybFpUTTkzLutHBJQycr8cg3OilcLmmaYBEdz97hP9g4D0TTo/ndMj3WhsrI3LeJ1fHKxEM3ZQljx+XlkwR9lu1Sg4fVYWDvXDMNglSooYV4CDbgWQxhRS/auiymUEvYTqUwvxLER6wHXDziP/xxfIad3RM/7NBzavYcqyQl+94htP478xgRMYKTMhHNlnwsB05F8XuqbBew/Yq8c9+IqcEhfe1palewmeLf48mbrNWABWYBHfgS2E3KMXWSUpqaISF2tD8o6pX3mYLyysMHH9kxbjAJaIrxRxUj9sbDkneO9cRZHIZLwpV745ojO9Vc1C0aM47YdkUKXsA5VEuXyy0k127hYx9 Uzojd0du IGYheQUE3YQ7p2jS5HlmI+AWvi1sSLgV579QvL75VJzkiGpT1EMhB1sDgO+JZYtwSOQeTaavWUuPfRd0ZlRTRTeK/4Tst4HitSu5y1tisfvvZfqmo3iBHlgZgRxdTftCva8y60HrlBPKNJYbHufBWpFaY5q+TQxzTfygEo2l7Jl6jqLQYlGLGmWrKK1zSr7x3FNdXOyo5MIk38ru4P+lVAwGNSXDkz6FYDAY6GWyTj3DIxITBlGZc5xZg1XyYDqTkZ3TSJJCrzMeNu0FRsBAFO20dXMalKCNXvsKOxp9UEMYzjxm0qDY3+ASJQi6HIqdCmhjfSmSd8UpQDTGSyuQLmLLO2VgaqliKZgnS8EeFjqx9OVcY0JiR291TzoaEk55TXrfhO4XrNmZjiLhjtJzgoKfo7PGE9K9lZ9y0kyKXKLiLtgM+t/07UTTwu/DG7OCOKfV6nDUivdiYar4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove afs_dynroot_d_revalidate() as it is redundant as all it does is return 1 and the caller assumes that if the op is not given. Suggested-by: Alexander Viro Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org cc: linux-fsdevel@vger.kernel.org --- fs/afs/dynroot.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index d3bc4a2d7085..c4d2711e20ad 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -258,16 +258,7 @@ const struct inode_operations afs_dynroot_inode_operations = { .lookup = afs_dynroot_lookup, }; -/* - * Dirs in the dynamic root don't need revalidation. - */ -static int afs_dynroot_d_revalidate(struct dentry *dentry, unsigned int flags) -{ - return 1; -} - const struct dentry_operations afs_dynroot_dentry_operations = { - .d_revalidate = afs_dynroot_d_revalidate, .d_delete = always_delete_dentry, .d_release = afs_d_release, .d_automount = afs_d_automount,