From patchwork Tue Jan 23 00:27:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 13526629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D742C47DDB for ; Tue, 23 Jan 2024 00:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF8126B0081; Mon, 22 Jan 2024 19:29:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7EF66B0082; Mon, 22 Jan 2024 19:29:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81E1B6B0083; Mon, 22 Jan 2024 19:29:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6F79E6B0081 for ; Mon, 22 Jan 2024 19:29:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1056C1A03A7 for ; Tue, 23 Jan 2024 00:29:19 +0000 (UTC) X-FDA: 81708691638.17.76AF4D4 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf11.hostedemail.com (Postfix) with ESMTP id 23AF340017 for ; Tue, 23 Jan 2024 00:29:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=m5E80MaW; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705969757; a=rsa-sha256; cv=none; b=0h3B9KiSHNWscrRtM5gpWAYg26yRNtnpdOChLyj8en6MZ342x9hecfnWyhiFPn1QBLK+Ab 1L8+gg3jarCJN+oPXPsTQdhaVlf/p4vxwP2+BVqgBIgeiM8WHu1K6wx9bMRRNPzBXBi4v4 KHFP4AQIrMkCr5aN4F8CpeWekRRsH+M= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=m5E80MaW; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705969757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4R+UH41sqIFBEg2yHgSz9fASiwRmxO8UrEbFS39w0BY=; b=GtwutbY3VKUn0huTz6APFeXi2aESShSwsESU0buo8QqpknM7dIXLCGsPbZYEB4wF8kB+s/ 8K/MaSxe3C564oWugpyuVUq2HDzDQYGUim8VWY5eKcs0gbWQFITd+ZcieOGgdCHQaRQUqZ UeXbf6GRbPnRfD6XjOR96UqyokGlIC8= Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so2643a12.3 for ; Mon, 22 Jan 2024 16:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705969756; x=1706574556; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4R+UH41sqIFBEg2yHgSz9fASiwRmxO8UrEbFS39w0BY=; b=m5E80MaW+W6GOtp/ivZuB9cZX0BRjYE1WtT8Z6bqD0P+AdvlDpEwZqfWuELCRrEaQ6 6bad4zDUaWO5ydJZoJNjryHT1I02BZdx5cGobSI04mbsVDT3bS/+UGazCIzRDYWMdfE6 /BbNrYlTI4vy9ylIhD5tfUjwJ/1bJk0FCzdoo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705969756; x=1706574556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4R+UH41sqIFBEg2yHgSz9fASiwRmxO8UrEbFS39w0BY=; b=KNiQWPMw5JkqHOq5ZuszbjXeWc0KpFvqPYbqqbeK2WYFIaRVNHD3IF+JlQsELMuAhh NRLNjrBs5Pszznc0MfGuDpJ4mA5V9k5omDcojN5TAs217eePGBLnK82nkE+ayLJ18IhH 6FyBviS7fb0Afp3APQhE8O/3Oe76ZXP01jCujt6PNZC/3eulje91XXFLpQJZxjyLqWF7 QNwAxeeQ+wwLAa8zw2ZOa/DaUUGQnWPlAs3He+HUqj30iuWk7AuB333fbOBhsk4lPATp qHMiqXzqOBuDV727q2XRxK/thBYTxoMBaTIU2lBbhbzGDfRfEcDYs0Tba+nwX8H9KhYp 8MhA== X-Gm-Message-State: AOJu0Yy+iufmB1OPAnjBnRtk0/TGWFxyCscntjfM4dlqsJ3GXNNLQxtb giMPR1lppvvHQ5kslhh1agJVnPECAhBv/Hn2PDdVGPeAG2OZW9Ku+5jPmcmLGw== X-Google-Smtp-Source: AGHT+IEOQPxBrxeTVknuQ85iWItECd3oDMC0wKeLvQMG9XfT1svGRvJdDWYE3hUC2zG+qCIX3weiSw== X-Received: by 2002:a05:6a20:1446:b0:19c:5821:1d6b with SMTP id a6-20020a056a20144600b0019c58211d6bmr373911pzi.71.1705969756091; Mon, 22 Jan 2024 16:29:16 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id s2-20020a17090302c200b001d707987ce3sm7513949plk.194.2024.01.22.16.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 16:29:08 -0800 (PST) From: Kees Cook To: linux-hardening@vger.kernel.org Cc: Kees Cook , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "Gustavo A. R. Silva" , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org Subject: [PATCH 63/82] mm: Refactor intentional wrap-around test Date: Mon, 22 Jan 2024 16:27:38 -0800 Message-Id: <20240123002814.1396804-63-keescook@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240122235208.work.748-kees@kernel.org> References: <20240122235208.work.748-kees@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4403; i=keescook@chromium.org; h=from:subject; bh=IXC9gHJS+Pnry0+OD6RifuKC5iruziQtcHdroYUu0NY=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlrwgKGl7sIklkp9DpywnYDLBMy17rUJMlBDpuZ IF1ZnQBhjmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZa8ICgAKCRCJcvTf3G3A JiG2D/9PRn4Y/k1W4IyELDW0vMaP8RPiiJfMCcL4ThXwWsfGmaqGLqfV1zQEvJXDHSGEjV3qA6f 1QWoI9IwuKjfA6OfO0JlksQZDvV/d4C1mTWzdQrRY2/LthSJBzsCK5VbReL0TpTAcFMajuY0JUk y79Nm7lQVGIPVT5kz9GE4HegEGGPsCk202fOQjGOid1P2FXfyctaxE7AC8A1oTmzBr7B6go6pES ZTzR/Z2fyNRTV4EbHBr9C3U447jLgO+uGVXj5FYunn/XaHZoFkbicu5CWTluotmM8My6vrUQc+R OVe3VQn2KHnuQsPPgENWLrMitHmaACD3nc3KGOQ5Nq6c9iVKKDGGSDopVfAm0cnC4JZNZssedWq QpeBszRZxgPbM6k0GMuCe73qgQg1GJuz4XqNNsDbrPNFJfH5ZXInUZt7+xx3wQ05371PA60Z8t0 tmCrWOgNSP9F1389si16h87Pzo/PvgvSF70Hbml6OUR4kU8xvA5OMHvggCQlwJG4zIykjLq9Ggu inHAl1IReCphEG4kev2pugmVlUlmGGkFAeg2uA4m/PbIKGl61suJep0mr5S3biRpHUZh/FVpWS0 dBLSKvx/lkw1jpHcmaLhj8srWr/oF+71hPZ7pLlb7R43ZReS0qw78SWDbOAttKIb6nPhBw9l//1 jTPSgii2rrZymlQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 23AF340017 X-Stat-Signature: tm9xgti59k18st5jfp6tnx13sejrjzgn X-HE-Tag: 1705969756-337718 X-HE-Meta: U2FsdGVkX1/KBzu5cq9saBE3WmTUFpeB6zkAbaz53ob9hAcmHvxVtylF+Etfp1UAyL3fTxDNUPWdpUEqc8ZzKiriv7TPd7AHTa04oGEHrxPk7kfMQamJjlKPKzURAD/4ibw5rtvG2Sr+lWgCugcLM0ijlbYExTw4/tHpaqhPxkTMJeqV4bytgxjSlGm/g+1+cqhYrujmrJKEwB8aBKOi3XfdgEmTaLHfGAdvIO0NbyBaVM8LPtFPgBZODqH7yKDZqeFT+01VS/P7XB+CzVVaOPXxG5nyvLiTUMKRlNfU1IunwaG5p+Wp/Mhi4E6sPthCt2/jetGl8koW4QpGLroodeyEJlIXg531SAi8VLWctWs74ZMLF00fX2O6w74x5ex0+eqJw/xuKEypbCaJzzPVEFmG5LOVPLRxDdyvlp+TRNwigZkahBB+WCPJ0iwdE/ema+Iq1rYBBB9t6LnIAfMVGa1HnziEK7DlKz2ycDDYIjpjwuNb2LYd+FtW3JBCrE139jixDbILcCQeynruij2nHFUViw2bSNN5lHyrmJMNdq0rmIsQRY0u+ItNrEdhRvZ/pbQqx1FQCG8EJ/bXBV9JXeQvO4lc0PGokSPx808pOWujCwwug+/IPy6+Vgc3wV1j88DNXk9AXP7FCJrb+rdVpdxzSX66EQhtzybnhGYwCUusj0ONRRgwnfGM2vrvqMeOFedv/zwDCzmtTuto2QGXuyWQ8xIWOH9oSCMmDk3ADWm1dAYJvFI9DK5Tvntz69cqSaJX+7xSU7VN19UoDuiFI0k8bYoFzg4uCK4okFy/7axxQ9lKBu2oczOhZj6F8lpeqWOIt93fCfQaUk9Aslye5SJW46qJokTHR4jLzxKJthh2SW9DcJT9G1Opls1o8ajmrWSEF+PpRKz7cO3dGO4gVbfoKUAQnKk0g8H7xWsg/75WZd1ZeptpzFeLHQ8iD1f1heoqHD8vKoqr+Fem9FF kinG4Q/d sjU0R0hmEJMbBaXhjYybrjNnObkgTmfR34MilxlEK4EmMqE+PAUCQEFDfvutznDPNJArirmCXA39u7XmdLw5/bS19EDRVU/xi8x2qp5A5WVZdcxOHUMIqIW3vaJttfe80eXApbJ6ISknlJvdOKCGU0otGI4q5hBI2cPw4RbbREnXVX4frJ8g2HN0pIxidzcaclc1rNAOV/4N5R/wI6wzZYl+ToXELf8UBMD/OqaCgDL4Nv3NRwLDEdapNNt3OnYcUBu4r3xwslE8CHXAfrfP8onnKg1JIIw0Ral/KHrhL2PeXmlEhI2YGKlIb1btIXZuJjd2br2jAhJlpEExS6jBomuLrQpAYR8q0J3z7my+ByXYlivVOTkuFemnh0f9iFDXJcSa9rGmVF9ClDrjyEvCFwx6ZvOyxudELezpRIxtV7qQ0oJALCCGAeBEgQhtx+kh39rOKaFKZ/z5Y7EMtGHZTAp4ZhcWck4QHk5JTFsfXlO7t52+vyeW3OuZIlIcfPMUXWfxsyk+YbuXfawjQrDzQ3QhPgxyxyXdHBoRT6Jcs6vWw1YbH193gk4B/SIiJekWlTX5H16QIDJpQTvIUU+3OS2wZDP9eivSKlIHY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer types, which the kernel works around by using the -fno-strict-overflow option in the build[1] (which used to just be -fwrapv). Regardless, we want to get the kernel source to the position where we can meaningfully instrument arithmetic wrap-around conditions and catch them when they are unexpected, regardless of whether they are signed[2], unsigned[3], or pointer[4] types. Refactor open-coded wrap-around addition test to use add_would_overflow(). This paves the way to enabling the wrap-around sanitizers in the future. Link: https://git.kernel.org/linus/68df3755e383e6fecf2354a67b08f92f18536594 [1] Link: https://github.com/KSPP/linux/issues/26 [2] Link: https://github.com/KSPP/linux/issues/27 [3] Link: https://github.com/KSPP/linux/issues/344 [4] Cc: Andrew Morton Cc: Shuah Khan Cc: linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org Signed-off-by: Kees Cook --- mm/memory.c | 4 ++-- mm/mmap.c | 2 +- mm/mremap.c | 2 +- mm/nommu.c | 4 ++-- mm/util.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 7e1f4849463a..d47acdff7af3 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2559,7 +2559,7 @@ int vm_iomap_memory(struct vm_area_struct *vma, phys_addr_t start, unsigned long unsigned long vm_len, pfn, pages; /* Check that the physical memory area passed in looks valid */ - if (start + len < start) + if (add_would_overflow(start, len)) return -EINVAL; /* * You *really* shouldn't map things that aren't page-aligned, @@ -2569,7 +2569,7 @@ int vm_iomap_memory(struct vm_area_struct *vma, phys_addr_t start, unsigned long len += start & ~PAGE_MASK; pfn = start >> PAGE_SHIFT; pages = (len + ~PAGE_MASK) >> PAGE_SHIFT; - if (pfn + pages < pfn) + if (add_would_overflow(pfn, pages)) return -EINVAL; /* We start the mapping 'vm_pgoff' pages into the area */ diff --git a/mm/mmap.c b/mm/mmap.c index b78e83d351d2..16501fcaf511 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -3023,7 +3023,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, return ret; /* Does pgoff wrap? */ - if (pgoff + (size >> PAGE_SHIFT) < pgoff) + if (add_would_overflow(pgoff, (size >> PAGE_SHIFT))) return ret; if (mmap_write_lock_killable(mm)) diff --git a/mm/mremap.c b/mm/mremap.c index 38d98465f3d8..efa27019a05d 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -848,7 +848,7 @@ static struct vm_area_struct *vma_to_resize(unsigned long addr, /* Need to be careful about a growing mapping */ pgoff = (addr - vma->vm_start) >> PAGE_SHIFT; pgoff += vma->vm_pgoff; - if (pgoff + (new_len >> PAGE_SHIFT) < pgoff) + if (add_would_overflow(pgoff, (new_len >> PAGE_SHIFT))) return ERR_PTR(-EINVAL); if (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP)) diff --git a/mm/nommu.c b/mm/nommu.c index b6dc558d3144..299bcfe19eed 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -202,7 +202,7 @@ EXPORT_SYMBOL(vmalloc_to_pfn); long vread_iter(struct iov_iter *iter, const char *addr, size_t count) { /* Don't allow overflow */ - if ((unsigned long) addr + count < count) + if (add_would_overflow(count, (unsigned long)addr)) count = -(unsigned long) addr; return copy_to_iter(addr, count, iter); @@ -1705,7 +1705,7 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, void *buf, in { struct mm_struct *mm; - if (addr + len < addr) + if (add_would_overflow(addr, len)) return 0; mm = get_task_mm(tsk); diff --git a/mm/util.c b/mm/util.c index 5a6a9802583b..e6beeb23b48b 100644 --- a/mm/util.c +++ b/mm/util.c @@ -567,7 +567,7 @@ unsigned long vm_mmap(struct file *file, unsigned long addr, unsigned long len, unsigned long prot, unsigned long flag, unsigned long offset) { - if (unlikely(offset + PAGE_ALIGN(len) < offset)) + if (unlikely(add_would_overflow(offset, PAGE_ALIGN(len)))) return -EINVAL; if (unlikely(offset_in_page(offset))) return -EINVAL;