Message ID | 20240125164256.4147-17-alexandru.elisei@arm.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55F8C47258 for <linux-mm@archiver.kernel.org>; Thu, 25 Jan 2024 16:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 564F76B007B; Thu, 25 Jan 2024 11:44:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EDAB6B0098; Thu, 25 Jan 2024 11:44:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38E7B6B009B; Thu, 25 Jan 2024 11:44:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2385A6B007B for <linux-mm@kvack.org>; Thu, 25 Jan 2024 11:44:22 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5A72A1B4D for <linux-mm@kvack.org>; Thu, 25 Jan 2024 16:44:21 +0000 (UTC) X-FDA: 81718406322.12.44DEAC0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 4676920009 for <linux-mm@kvack.org>; Thu, 25 Jan 2024 16:44:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706201060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kMWL/IvSQJqDXce5c4oy93Fth3a3FVCxaa93iLMEuZQ=; b=ewMvR7JAugqFEz0RjQZDG6Zg/53K14MdEzGi5+8w/aq0grxRja8J4wI+CZmHpD9tVQSSoN 0tbyUU9rKTPNDDKxmSFQmmAdl0YQGnolGFppVoZ5vZWEap+Sc5mkq3ro5nNU4hyDpN0Wde 35dDQtxNgc+5blJQsmgujficMA9jQkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706201060; a=rsa-sha256; cv=none; b=4JtiIp2HZOZSj9Re91conNSyI4tDTggkNDhvYznkQ07iBa0enJEjoOLnk5PSrYeVqiUut0 dtXGotqxyIv3D0Iq2NjynuW5ypEfPTkUEFt1Cs1qUmXzk6vQu3xLhldbc3iGbIakug4BUT V1EoJEOTneDW1HfwJ8SroY0xNC85ZEA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1168115DB; Thu, 25 Jan 2024 08:45:04 -0800 (PST) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 211FF3F5A1; Thu, 25 Jan 2024 08:44:13 -0800 (PST) From: Alexandru Elisei <alexandru.elisei@arm.com> To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC v3 16/35] KVM: arm64: Don't deny VM_PFNMAP VMAs when kvm_has_mte() Date: Thu, 25 Jan 2024 16:42:37 +0000 Message-Id: <20240125164256.4147-17-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240125164256.4147-1-alexandru.elisei@arm.com> References: <20240125164256.4147-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ue1qd4xeesxj58uhrzngmn6paydfki8s X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4676920009 X-Rspam-User: X-HE-Tag: 1706201060-661469 X-HE-Meta: U2FsdGVkX19p0xeSRzNTMI/4cA3WmHeN9oRp7h5965cpi7mOXtkDON3jtFHRDZ8zpATayLPN7nu79F1sOszatKvL39CcdLxyNtlkItCKEARFJprdkcxQPhsfFRG7uhE0mLfwDlJl8F1WbVSFQT8etmjOixznxpnMkLOwn6ummoJvPKEV3M6iK7EgLsDa3HfwTLnSvoDpD8H9f4mVSaxpOav4ZQ2ye9SQFW2CrTKufIJkAK/paghmO/knV6E6iXioT0EOrnzkShCrj740siG4B8HjUkSSY1Xuqpt1fit+4YHYvcCyhPuEO6pIfKi4hht714DkV/f8BDKHS52+cAqQFpkgrSToQZpdXpOB9y7z7b/1s7Y0LiMthCo9H1Oin7MM1jVgWalhMKNVTc3LLq6jAhsqpwlHlu2W2xrwlCHaryWqfGAbLAhY/pvvIK8uzKOtfbrj1vfOc3DFkeuvCz33HTa2ff3QUvVtUM5nnWpqLQ/08mvRw3vl1CpOREVrUIgsoPHICwkOAKX/gz6iMbh+cUx9ZlzDo/U01pVreT8Obh3GkSlSo4jyEfZaH9ZmLPOkmS5sVMUhfWeREN41AagtI/ZK2D/yjaQogcEfz7j64lTbC2DrNfzv9YAjmCQWFq/M8ptnFhRxPcztl2G5YGQC9tkZKIKQMZp2w/JPc6r5aD3V/6Z26QVG4uvdCbYOcSVlSitxuC29ZbtdJax8F25TVn84Qe2ezAg0BXrrVHvdZp+QvdE6O674MlOWShbuubDMf1MEjewBss48zcKuNuTsOgHsVA+6Q59lv42jjiMkSOZRqZHJRyzT4O1rFzjfxhqcxeMTh/glE0jsEtcnG0DAM0P5wH43v0cK21Cv4enAonV4L4fma+X+HsH6wxdj38ktRRbsDkQQW7awUhd3SiaREq9g5FHrL3kUM6n9f1NAX2hrOVKnDcVJzOfrdSWU5pDa3cV6q/LmPlOGQotjqZz YnBmPDfC 0uEmSqjUGRXQ0jt2GLnIYadHA1whWS2jd+9v2U9uqRkpD5tZu3fXffNVZKb3MWEdILg3pEInOna81Y8lbOp2Ti3vDWTv4RNcpCZZqTSnrt/agusGCDXO+3ylaApSPwnsWkZNPbjU/d8s/IMo8SL0LmMiV5kvXj3O1moaH8AIaTl9PCfhbvguoD2E6myF0XqW7K990GWWnZfruwuk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Add support for arm64 MTE dynamic tag storage reuse
|
expand
|
diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index d14504821b79..b7517c4a19c4 100644 --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -2028,17 +2028,15 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm, if (!vma) break; - if (kvm_has_mte(kvm) && !kvm_vma_mte_allowed(vma)) { - ret = -EINVAL; - break; - } - if (vma->vm_flags & VM_PFNMAP) { /* IO region dirty page logging not allowed */ if (new->flags & KVM_MEM_LOG_DIRTY_PAGES) { ret = -EINVAL; break; } + } else if (kvm_has_mte(kvm) && !kvm_vma_mte_allowed(vma)) { + ret = -EINVAL; + break; } hva = min(reg_end, vma->vm_end); } while (hva < reg_end);
According to ARM DDI 0487J.a, page D10-5976, a memory location which doesn't have the Normal memory attribute is considered Untagged, and accesses are Tag Unchecked. Tag reads from an Untagged address return 0b0000, and writes are ignored. Linux uses VM_PFNMAP VMAs represent device memory, and Linux doesn't set the VM_MTE_ALLOWED flag for these VMAs. In user_mem_abort(), KVM requires that all VMAs that back guest memory must allow tagging (VM_MTE_ALLOWED flag set), except for VMAs that represent device memory. When a memslot is created or changed, KVM enforces a different behaviour: **all** VMAs that intersect the memslot must allow tagging, even those that represent device memory. This is too restrictive, and can lead to inconsistent behaviour: a VM_PFNMAP VMA that is present when a memslot is created causes KVM_SET_USER_MEMORY_REGION to fail, but if such a VMA is created after the memslot has been created, the virtual machine will run without errors. Change kvm_arch_prepare_memory_region() to allow VM_PFNMAP VMAs when the VM has the MTE capability enabled. Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> --- Changes from rfc v2: * New patch. It's a fix, and can be taken independently of the series. arch/arm64/kvm/mmu.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)