From patchwork Fri Feb 2 17:02:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Gregory Price X-Patchwork-Id: 13543169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2228BC4828F for ; Fri, 2 Feb 2024 17:02:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD94E6B0078; Fri, 2 Feb 2024 12:02:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A87896B0075; Fri, 2 Feb 2024 12:02:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DB406B0078; Fri, 2 Feb 2024 12:02:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 79AFA6B0074 for ; Fri, 2 Feb 2024 12:02:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3A5068057D for ; Fri, 2 Feb 2024 17:02:54 +0000 (UTC) X-FDA: 81747483468.14.450C9FC Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf27.hostedemail.com (Postfix) with ESMTP id AF5524002F for ; Fri, 2 Feb 2024 17:02:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ExqMEzcs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.210.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706893370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1pDRIrlrQ4UtMpe5hzZtBydhtO2WkdGXjanRY84YnLE=; b=EGZT/dZSfe+sJCRMJpUkF0LYJbdp83lMNnphyFqvxi2y46wdAj0dz5BhsOz6BgJebA0cGP VOMptFvf6NzMKPBFZh3Ly+6hVIPsDzRyUVPdfLCw4LVenTEiy+bvxcxb9y/kyHDZHMFiPP bhKIreiJfyR3fOefF4J/qUy5g+cw7sM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ExqMEzcs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.210.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706893370; a=rsa-sha256; cv=none; b=Da0QMtlDGfLRMKFEwrjOC/8/M0N+fviy7G1tYca9ume7KSuSjMLrRmlJ8vq699KpHkYLxT XAKZ5zxjfLCMGYBLelgjFPUnLi5zJ8nhZgci3x2Ih/QHtYjgn+1PBgbJzq4UQwJTEGDRUl 7gPkdG+knJ1XxIleKdRIxPthz2gbOzI= Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-6de0ba30994so799164b3a.1 for ; Fri, 02 Feb 2024 09:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706893369; x=1707498169; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1pDRIrlrQ4UtMpe5hzZtBydhtO2WkdGXjanRY84YnLE=; b=ExqMEzcsZIZhwGZAk63NtYsw7TEsXZzecoIvxyZKc+q9gG3rbKVGMii9m4f9t0FW6E 7YJgQpzjcZufOvRunJoDnhtwZnEhCsQLcaAthcsa2Qbu8AUZFqZQccowdKTK0nR3J9EW pmD2tMA1+eLC20cRUS5SDRcuiliK++scNB2gckpQ5az5bGsVbvoXNaMSVf83jC7Zv1Vw D0gXGzRCSFBcbViyt7rooePtSqrGnDbZ1Do2J3tp4eAFf1wQ6LCHQrTaj3ejFT03QKJT djdvs3JCHpTQKQvqADykZB3utZV52KszZepTz99M82GsbMCvhnvYd15m+lxa3tNwzKEl wGAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706893369; x=1707498169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pDRIrlrQ4UtMpe5hzZtBydhtO2WkdGXjanRY84YnLE=; b=ovAJXyTpAglr3RIV5mcH/hsVJIJErVBO8G/Zicbxpu1bbdp5vlelrjood2Bq1Y+ZvL 5lMtNNgxCFpohYbvikXyaWd2qmxQMeefZ0/yyam+EeA/XgFpnJrL9xPuD4mkhKiG+vWl nWjwhVU9F7RAzdcNdjFe8q0ChWP1qJqeVYhu+/J26CBXQUCO2U2ioewiz+Ea1z5xizjR 54LGsVP5MAOsRcf2GLIsPvQVAnmKFYYlik8igRE+pPGe7rHoN0NrE5URKSqJjgMRsQHE dbOLqFMFf/aIEWvd0DwQjRcYVc6cacosS05ieYnKjTePhPVcykTlEumJnG/1e8u5QwuY HDhA== X-Gm-Message-State: AOJu0Yyw8368GZmNpHWEuCF1b0urpu4A4JF2giYaET9HpRsI0EOHsBq4 IBwc5ArOEGC0dA2sqBP60zGxxImbJ0sujcU51nL/OdK5ilEQPwEjhJRxnpOpSg== X-Google-Smtp-Source: AGHT+IEi0ywj/8sRmBXyXsM66L0qrQazVSY5CleNRDvWOz/EKdM4P7MBc4iBts3CCmK1F90toljgRA== X-Received: by 2002:a05:6a00:2d09:b0:6da:bcea:4cd4 with SMTP id fa9-20020a056a002d0900b006dabcea4cd4mr4198277pfb.16.1706893369247; Fri, 02 Feb 2024 09:02:49 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU1kz89Qv1XP+xUI9TWw/AYEC2UL/HgNVc490rP5Y7IX6xAlFUjUHtRkGqH2hXHAfI0JV4CBjP7TrlF32KaLHI5Ea83xq2PdC+AoncPzs58T5FZf1EEaB6ZhMlMPm6zyY/TU/TnDViEF8wYBL3mgo7R/S8j8WP6WNlUKA0HvEv+O0VUu6bNW2RtCd7/Ty0kTgojnF+NbaFxa0SR9LYAqSCkDT04Q7fWyxBt0ojzFTUsiu70LjRCBLlPq0eC7Mo/ya/NmZclCts6pp0LQMgg+dCpUQa469YLWK2hkrykaQiq8D9TSdBG9O2Jw4juCj65H75PesrMPF2wwTOb5GFGCOISNQ6HYgTDX/gZQnQlU1vSKDMRISQ4I2w/tHPjTDKnBHZfLUgKTTjymq3PAguvlj84h/xPIOKcNzYjopMtkmDJY1aiUISZWFxgHfxP77mJwoX9KOWj0BSgTDCcIqjlgpumbE7N68jQVrh7xzuHITqf8dSLZsVAMdUuELkr9rkUBVcKLnbDcVdQiksRUeEFP3ooRO8Nc2hUCMZVX6OFtzifmki5kwegyM6JFQ5S4sp/E2CkgDQg0LxI1bPR68uPJQ3Gqhxf68QuRx67ARBnEkWxXrtimbmYQFdcFLl2LwXttsgEBIjp8PM/yB5vhFHQ6mQmWYvhkQe+heSoBvSa/kU= Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id z22-20020aa785d6000000b006ddddc7701fsm1866578pfn.4.2024.02.02.09.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 09:02:48 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, corbet@lwn.net, akpm@linux-foundation.org, gregory.price@memverge.com, honggyu.kim@sk.com, rakie.kim@sk.com, hyeongtak.ji@sk.com, mhocko@kernel.org, ying.huang@intel.com, vtavarespetr@micron.com, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com, hannes@cmpxchg.org, dan.j.williams@intel.com Subject: [PATCH v5 1/4] mm/mempolicy: implement the sysfs-based weighted_interleave interface Date: Fri, 2 Feb 2024 12:02:35 -0500 Message-Id: <20240202170238.90004-2-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240202170238.90004-1-gregory.price@memverge.com> References: <20240202170238.90004-1-gregory.price@memverge.com> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: iaws31mr843m5cwg3gh9qbn1io636kbq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AF5524002F X-HE-Tag: 1706893370-310142 X-HE-Meta: U2FsdGVkX19rnphOAZDFs0uw3aeTO5Ot+7/iPmbnAwHBskPsSnUSIOdGjx4yoaV07Ohbl7qc8vEhUw8yHUeYxrdwRnEalM6ykcRO0MvbwkdhcnPJly8fUXmgS73+6Hjx+XKkn/6UgVzG7btQ9WSYaT8HNwGOq7G0TYVK89tHa17bB3dEcg5ZBz0u95SmZnC4gP2hdFUXysD6PXLMH2wuBaZQAPPpIywEHbMz71GoYN0VL1cbIjkU7pCbJSIkKNGRxUU9QLdh/eBCtMFoQyee9bsjz33nVds5nKw1UjDdH+IzlsrqaGRWV7LIHnIfJM74yIzSQV8DgyAIxf6yjeSgzZXCdwareoK0YBVEKfiBuzefRA3BiTJFti2JVdwFjKdduWPgOybHd9VJ/DAWNjiHnu0VRRXNyZL+ZsztNyOCj3BZHzgKLmtpO5B+ILKTHNAK+L0/tQjtWWb6weApO0wdZyP35WZ7/OUU13Tj7X5rOvpm9zqYZDWrTAT7YDMPg3PKOCBlNSivKvaSCyFyu+SnrG5t7xbWB8s9G8B6LlC8h7VIYajB56pul3o2DSBecaR75rR2BQKVuwPVaAyls0y/IuASCkMvBLcbwclxmUjNBaTJnhVLc0u9x0DOpYL/xHjDB9As/jfKEcf8PnCDXBzwe4mhv4IwF1jZofki9QarGYOquWVm3ayJ9UsWe5dlX+pBiJSuYU0KvKsazzlgaSE78TnzmMNyZLHt/Wik6v6D4xS4NeWRITaxTAnrpQFrzJ5TAPuNplgiaDnmuh2K241x4HbhipDcfjvoQhcBnT0puWSsSO9cOzzMdb7Id0liQP/Osw7DGigv/0W+aXJLIimKIGO6FnCidIGuX/KagNXOKNwd/c43QQZURH4hZabddThj01mT1J9Oz2OEQdJcCRQZQKu5OvfajP5UkCq1EPTkWW3SIXAdHJkAOU86u76FmNQ+9/bveyCEbZHZ0z2MTWR wVMGFgD9 id4LnafbwXjAVhIRlQ3K+NeT0ILRcHrekhWpryZt6U3oe6O4gaO1lIkAflCWcxK6/+QCxDY9pXkol30n4QgxB+XnX6pWuwQR3Opae1G+oL5wKbAQfCC2c1WgZHyVS4Sr/94P2mhu0LjhotWMvBUU4Pwj3uWquhVAshnGkWE/jh2AKCDSV16CZ4ffvI6EM3V85rsWQ+VsRPxkwIZFwgYfmwVIzmuwsfj6PKmVCHI8ewphGh3+7DjTR/DMymwSHR/oGQFfN8wasvpnY/rkqIpzJLu1fWrrWKDJ0ZPeZBn5UyZ29++KGo6I/nXAQjpiucQN/1pDIOrMm2p/Bly3aNvwvlSULjsxRPPSHXEM01td74aIe0rzVMbN/I//PgoGQUVa43nmKdz+L+WkjCdQd9PLM7KeEsgOvJXqMwnQuLbTlAmFPjRowtQn51XEwj9sddlWLWXULixTLgQu/x5LYG8wg2EoutPf7wY55UE5hrE1sgVkJ1bw/SxRUkOzTBc+ATdaL8+nvwtjU2ZHq0Uy1B7YCpNpj8QMRebEaYitPZ0/bx6adlymTvTIPL4s63seNEuidlzhDRYvANvpmLreO64k2Lr2JwpSHx5W3zBBWgVLQM7G+7ChYbkAKEmgcWep5cdDD9I89XbwuCBk755vfn+ZJRsmwxXapkNPAPKvVJ+pd6+TaZAySM4RYkwCjOOPrAf6E8an1hPp5MBD+efDY+5CiRwXKAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rakie Kim This patch provides a way to set interleave weight information under sysfs at /sys/kernel/mm/mempolicy/weighted_interleave/nodeN The sysfs structure is designed as follows. $ tree /sys/kernel/mm/mempolicy/ /sys/kernel/mm/mempolicy/ [1] └── weighted_interleave [2] ├── node0 [3] └── node1 Each file above can be explained as follows. [1] mm/mempolicy: configuration interface for mempolicy subsystem [2] weighted_interleave/: config interface for weighted interleave policy [3] weighted_interleave/nodeN: weight for nodeN If a node value is set to `0`, the system-default value will be used. As of this patch, the system-default for all nodes is always 1. Suggested-by: "Huang, Ying" Signed-off-by: Rakie Kim Signed-off-by: Honggyu Kim Co-developed-by: Gregory Price Signed-off-by: Gregory Price Co-developed-by: Hyeongtak Ji Signed-off-by: Hyeongtak Ji Reviewed-by: "Huang, Ying" --- .../ABI/testing/sysfs-kernel-mm-mempolicy | 4 + ...fs-kernel-mm-mempolicy-weighted-interleave | 25 ++ mm/mempolicy.c | 223 ++++++++++++++++++ 3 files changed, 252 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-mempolicy create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy new file mode 100644 index 000000000000..8ac327fd7fb6 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy @@ -0,0 +1,4 @@ +What: /sys/kernel/mm/mempolicy/ +Date: January 2024 +Contact: Linux memory management mailing list +Description: Interface for Mempolicy diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave new file mode 100644 index 000000000000..0b7972de04e9 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave @@ -0,0 +1,25 @@ +What: /sys/kernel/mm/mempolicy/weighted_interleave/ +Date: January 2024 +Contact: Linux memory management mailing list +Description: Configuration Interface for the Weighted Interleave policy + +What: /sys/kernel/mm/mempolicy/weighted_interleave/nodeN +Date: January 2024 +Contact: Linux memory management mailing list +Description: Weight configuration interface for nodeN + + The interleave weight for a memory node (N). These weights are + utilized by tasks which have set their mempolicy to + MPOL_WEIGHTED_INTERLEAVE. + + These weights only affect new allocations, and changes at runtime + will not cause migrations on already allocated pages. + + The minimum weight for a node is always 1. + + Minimum weight: 1 + Maximum weight: 255 + + Writing an empty string or `0` will reset the weight to the + system default. The system default may be set by the kernel + or drivers at boot or during hotplug events. diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 10a590ee1c89..41e58c4c0d01 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -131,6 +131,32 @@ static struct mempolicy default_policy = { static struct mempolicy preferred_node_policy[MAX_NUMNODES]; +/* + * iw_table is the sysfs-set interleave weight table, a value of 0 denotes + * system-default value should be used. A NULL iw_table also denotes that + * system-default values should be used. Until the system-default table + * is implemented, the system-default is always 1. + * + * iw_table is RCU protected + */ +static u8 __rcu *iw_table; +static DEFINE_MUTEX(iw_table_lock); + +static u8 get_il_weight(int node) +{ + u8 *table; + u8 weight; + + rcu_read_lock(); + table = rcu_dereference(iw_table); + /* if no iw_table, use system default */ + weight = table ? table[node] : 1; + /* if value in iw_table is 0, use system default */ + weight = weight ? weight : 1; + rcu_read_unlock(); + return weight; +} + /** * numa_nearest_node - Find nearest node by state * @node: Node id to start the search @@ -3067,3 +3093,200 @@ void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) p += scnprintf(p, buffer + maxlen - p, ":%*pbl", nodemask_pr_args(&nodes)); } + +#ifdef CONFIG_SYSFS +struct iw_node_attr { + struct kobj_attribute kobj_attr; + int nid; +}; + +static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) +{ + struct iw_node_attr *node_attr; + u8 weight; + + node_attr = container_of(attr, struct iw_node_attr, kobj_attr); + weight = get_il_weight(node_attr->nid); + return sysfs_emit(buf, "%d\n", weight); +} + +static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr, + const char *buf, size_t count) +{ + struct iw_node_attr *node_attr; + u8 *new; + u8 *old; + u8 weight = 0; + + node_attr = container_of(attr, struct iw_node_attr, kobj_attr); + if (count == 0 || sysfs_streq(buf, "")) + weight = 0; + else if (kstrtou8(buf, 0, &weight)) + return -EINVAL; + + new = kzalloc(nr_node_ids, GFP_KERNEL); + if (!new) + return -ENOMEM; + + mutex_lock(&iw_table_lock); + old = rcu_dereference_protected(iw_table, + lockdep_is_held(&iw_table_lock)); + if (old) + memcpy(new, old, nr_node_ids); + new[node_attr->nid] = weight; + rcu_assign_pointer(iw_table, new); + mutex_unlock(&iw_table_lock); + synchronize_rcu(); + kfree(old); + return count; +} + +static struct iw_node_attr **node_attrs; + +static void sysfs_wi_node_release(struct iw_node_attr *node_attr, + struct kobject *parent) +{ + if (!node_attr) + return; + sysfs_remove_file(parent, &node_attr->kobj_attr.attr); + kfree(node_attr->kobj_attr.attr.name); + kfree(node_attr); +} + +static void sysfs_wi_release(struct kobject *wi_kobj) +{ + int i; + + for (i = 0; i < nr_node_ids; i++) + sysfs_wi_node_release(node_attrs[i], wi_kobj); + kobject_put(wi_kobj); +} + +static const struct kobj_type wi_ktype = { + .sysfs_ops = &kobj_sysfs_ops, + .release = sysfs_wi_release, +}; + +static int add_weight_node(int nid, struct kobject *wi_kobj) +{ + struct iw_node_attr *node_attr; + char *name; + + node_attr = kzalloc(sizeof(*node_attr), GFP_KERNEL); + if (!node_attr) + return -ENOMEM; + + name = kasprintf(GFP_KERNEL, "node%d", nid); + if (!name) { + kfree(node_attr); + return -ENOMEM; + } + + sysfs_attr_init(&node_attr->kobj_attr.attr); + node_attr->kobj_attr.attr.name = name; + node_attr->kobj_attr.attr.mode = 0644; + node_attr->kobj_attr.show = node_show; + node_attr->kobj_attr.store = node_store; + node_attr->nid = nid; + + if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) { + kfree(node_attr->kobj_attr.attr.name); + kfree(node_attr); + pr_err("failed to add attribute to weighted_interleave\n"); + return -ENOMEM; + } + + node_attrs[nid] = node_attr; + return 0; +} + +static int add_weighted_interleave_group(struct kobject *root_kobj) +{ + struct kobject *wi_kobj; + int nid, err; + + wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); + if (!wi_kobj) + return -ENOMEM; + + err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj, + "weighted_interleave"); + if (err) { + kfree(wi_kobj); + return err; + } + + for_each_node_state(nid, N_POSSIBLE) { + err = add_weight_node(nid, wi_kobj); + if (err) { + pr_err("failed to add sysfs [node%d]\n", nid); + break; + } + } + if (err) + kobject_put(wi_kobj); + return 0; +} + +static void mempolicy_kobj_release(struct kobject *kobj) +{ + u8 *old; + + mutex_lock(&iw_table_lock); + old = rcu_dereference_protected(iw_table, + lockdep_is_held(&iw_table_lock)); + rcu_assign_pointer(iw_table, NULL); + mutex_unlock(&iw_table_lock); + synchronize_rcu(); + kfree(old); + kfree(node_attrs); + kfree(kobj); +} + +static const struct kobj_type mempolicy_ktype = { + .release = mempolicy_kobj_release +}; + +static int __init mempolicy_sysfs_init(void) +{ + int err; + static struct kobject *mempolicy_kobj; + + mempolicy_kobj = kzalloc(sizeof(*mempolicy_kobj), GFP_KERNEL); + if (!mempolicy_kobj) { + err = -ENOMEM; + goto err_out; + } + + node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), + GFP_KERNEL); + if (!node_attrs) { + err = -ENOMEM; + goto mempol_out; + } + + err = kobject_init_and_add(mempolicy_kobj, &mempolicy_ktype, mm_kobj, + "mempolicy"); + if (err) + goto node_out; + + err = add_weighted_interleave_group(mempolicy_kobj); + if (err) { + pr_err("mempolicy sysfs structure failed to initialize\n"); + kobject_put(mempolicy_kobj); + return err; + } + + return err; +node_out: + kfree(node_attrs); +mempol_out: + kfree(mempolicy_kobj); +err_out: + pr_err("failed to add mempolicy kobject to the system\n"); + return err; +} + +late_initcall(mempolicy_sysfs_init); +#endif /* CONFIG_SYSFS */