[09/22] xfs: shmem_file_setup can't return NULL

Message ID	20240219062730.3031391-10-hch@lst.de (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: Christoph Hellwig <hch@lst.de> To: Chandan Babu R <chandan.babu@oracle.com>, "Darrick J. Wong" <djwong@kernel.org>, Hugh Dickins <hughd@google.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Hui Su <sh_def@163.com>, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 09/22] xfs: shmem_file_setup can't return NULL Date: Mon, 19 Feb 2024 07:27:17 +0100 Message-Id: <20240219062730.3031391-10-hch@lst.de> In-Reply-To: <20240219062730.3031391-1-hch@lst.de> References: <20240219062730.3031391-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	[01/22] mm: move mapping_set_update out of <linux/swap.h> \| expand [01/22] mm: move mapping_set_update out of <linux/swap.h> [02/22] shmem: move shmem_mapping out of line [03/22] shmem: set a_ops earlier in shmem_symlink [04/22] shmem: move the shmem_mapping assert into shmem_get_folio_gfp [05/22] shmem: export shmem_get_folio [06/22] shmem: export shmem_kernel_file_setup [07/22] shmem: document how to "persist" data when using shmem_*file_setup [08/22] xfs: use VM_NORESERVE in xfile_create [09/22] xfs: shmem_file_setup can't return NULL [10/22] xfs: use shmem_kernel_file_setup in xfile_create [11/22] xfs: don't modify file and inode flags for shmem files [12/22] xfs: remove xfile_stat [13/22] xfs: remove the xfile_pread/pwrite APIs [14/22] xfs: don't try to handle non-update pages in xfile_obj_load [15/22] xfs: don't allow highmem pages in xfile mappings [16/22] xfs: use shmem_get_folio in xfile_obj_store [17/22] xfs: use shmem_get_folio in in xfile_load [18/22] xfs: add file_{get,put}_folio [19/22] xfs: remove xfarray_sortinfo.page_kaddr [20/22] xfs: fix a comment in xfarray.c [21/22] xfs: convert xfarray_pagesort to deal with large folios [22/22] xfs: remove xfile_{get,put}_page

Message ID

20240219062730.3031391-10-hch@lst.de (mailing list archive)

State

New

Headers

From: Christoph Hellwig <hch@lst.de>
To: Chandan Babu R <chandan.babu@oracle.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Hui Su <sh_def@163.com>,
	linux-xfs@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH 09/22] xfs: shmem_file_setup can't return NULL
Date: Mon, 19 Feb 2024 07:27:17 +0100
Message-Id: <20240219062730.3031391-10-hch@lst.de>
In-Reply-To: <20240219062730.3031391-1-hch@lst.de>
References: <20240219062730.3031391-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

[01/22] mm: move mapping_set_update out of <linux/swap.h> | expand

Commit Message

Christoph Hellwig Feb. 19, 2024, 6:27 a.m. UTC

shmem_file_setup always returns a struct file pointer or an ERR_PTR,
so remove the code to check for a NULL return.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/scrub/xfile.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c
index 1cf4b239bdbbd7..e649558351bc5a 100644
--- a/fs/xfs/scrub/xfile.c
+++ b/fs/xfs/scrub/xfile.c
@@ -62,15 +62,13 @@  xfile_create(
 {
 	struct inode		*inode;
 	struct xfile		*xf;
-	int			error = -ENOMEM;
+	int			error;
 
 	xf = kmalloc(sizeof(struct xfile), XCHK_GFP_FLAGS);
 	if (!xf)
 		return -ENOMEM;
 
 	xf->file = shmem_file_setup(description, isize, VM_NORESERVE);
-	if (!xf->file)
-		goto out_xfile;
 	if (IS_ERR(xf->file)) {
 		error = PTR_ERR(xf->file);
 		goto out_xfile;

[09/22] xfs: shmem_file_setup can't return NULL

Commit Message

Patch