From patchwork Tue Feb 20 16:58:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13564279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDF1C48BC3 for ; Tue, 20 Feb 2024 16:58:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6C5F6B0081; Tue, 20 Feb 2024 11:58:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF37F6B0082; Tue, 20 Feb 2024 11:58:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD1C26B0083; Tue, 20 Feb 2024 11:58:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9CCFB6B0081 for ; Tue, 20 Feb 2024 11:58:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DDBFA09FF for ; Tue, 20 Feb 2024 16:58:50 +0000 (UTC) X-FDA: 81812791620.27.C7A7717 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id EE79D14000E for ; Tue, 20 Feb 2024 16:58:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RjcBobBc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JwFYRXTq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RjcBobBc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JwFYRXTq; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708448327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c4OC2yNSKLqgnXzwwPex64d+kZgeSX8gpLykWcl/SKw=; b=5FFOSNKE/J9ZnW0/aPvYwW8VqmoW7S6USYVBH32eA2NRHxyImREuHKDYQ2GO5UTvHG58Ip sJck5P/YH8sG1XT29CC0U9L16m7M+eFTr+DPF67mjYXttchQIgpDr8R9OHgyA1VLScbprh 61kCqGVANo9PzK53+Jps3aY+i3mTg2Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708448327; a=rsa-sha256; cv=none; b=pKT3Wmt/aLixR1NaIlR6VsrxWEoXwwIUpgbzA5R3QJti9TRoNk7OB2wXkdJ7uFgdOsiIP4 s0/j7QLB2Oo0zNinGbshUnEUOrSbEuEV6EmU30jn6vPjqKeRLvwZcKFrB1e0kFbGn/TU2Q m3LNYk1gwYc5tF/DJjYM1R0DUlbqFro= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RjcBobBc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JwFYRXTq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RjcBobBc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JwFYRXTq; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 411FC21FBD; Tue, 20 Feb 2024 16:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708448325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4OC2yNSKLqgnXzwwPex64d+kZgeSX8gpLykWcl/SKw=; b=RjcBobBcQec/R6BNYj9LVtWzct1RqrXs1Hh50ZzAqswNqAlsoooklOUijnTxlI1nWX3Dco vuH3FfKT6Qa+8jU56MYk0OjiBEuJ4EPlTADsYBwQBRR3tlkxiEuAvZVOq++BoGa7z3lyWR aoDDvqQfuzptU51eGvOW8ET9m4xcNHo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708448325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4OC2yNSKLqgnXzwwPex64d+kZgeSX8gpLykWcl/SKw=; b=JwFYRXTqoVvqzk23AIOLXuMzXVHV47mrjeIz+Xwiw3CpIAK0JVphGsnYKwgXL6bz1pSKYM u8JpMqFaG3AeHuDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708448325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4OC2yNSKLqgnXzwwPex64d+kZgeSX8gpLykWcl/SKw=; b=RjcBobBcQec/R6BNYj9LVtWzct1RqrXs1Hh50ZzAqswNqAlsoooklOUijnTxlI1nWX3Dco vuH3FfKT6Qa+8jU56MYk0OjiBEuJ4EPlTADsYBwQBRR3tlkxiEuAvZVOq++BoGa7z3lyWR aoDDvqQfuzptU51eGvOW8ET9m4xcNHo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708448325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4OC2yNSKLqgnXzwwPex64d+kZgeSX8gpLykWcl/SKw=; b=JwFYRXTqoVvqzk23AIOLXuMzXVHV47mrjeIz+Xwiw3CpIAK0JVphGsnYKwgXL6bz1pSKYM u8JpMqFaG3AeHuDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1915E13A93; Tue, 20 Feb 2024 16:58:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GJHYBUXa1GVKXQAAD6G6ig (envelope-from ); Tue, 20 Feb 2024 16:58:45 +0000 From: Vlastimil Babka Date: Tue, 20 Feb 2024 17:58:25 +0100 Subject: [PATCH 1/3] mm, slab: deprecate SLAB_MEM_SPREAD flag MIME-Version: 1.0 Message-Id: <20240220-slab-cleanup-flags-v1-1-e657e373944a@suse.cz> References: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> In-Reply-To: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Cc: Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Vlastimil Babka , Steven Rostedt X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1731; i=vbabka@suse.cz; h=from:subject:message-id; bh=OddJ5DHeDgks/i1mqhLaA/c2lRjGQhZqtVTweHMQxDw=; b=owEBbQGS/pANAwAIAbvgsHXSRYiaAcsmYgBl1No9wmY1D3tW/Cy64eGuViYQaGuyi/p0I9ZML 1aOynVc32uJATMEAAEIAB0WIQR7u8hBFZkjSJZITfG74LB10kWImgUCZdTaPQAKCRC74LB10kWI mgcCB/9ah3oEc1eVnw/8rJfS4V2CrkLLtkwjbxIk0QO1Y0hJK6fdAYScMioTiqBbFz2fYneiEib unIEdHVvpl+axQ6ErHTm8ti5I3TyU4MWWs83wr4c2KDwr6M1dl/PvpBvMynOrlEipojbhKdzBUG M7r0KCDPswYFY/bWZNDMSglmuV4rdwkzWpAlBnmUSK1ARpf/CL/dLuc8EoPraztYVvBTuVl7/sS yeaXUhG1SHr+j+ewEl+8Ng27ejIu7HOiappS80WyxN0awRxddapuB+uGZB7Oe88F1qMmz88+5/T Zwh17MejM5IUm/PPb+QCsLgpmJBon11M/C4qFpCzuDCoY2ct X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 X-Rspamd-Queue-Id: EE79D14000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wm558jt7yabzpjy7ja9dcbct6546j8ty X-HE-Tag: 1708448326-511967 X-HE-Meta: U2FsdGVkX184hgnVv9KIeOIzBr1bk2dUSGpwhVGjyj3/YeA1Gg/dJNqp/2LheJ231c51Csc2JrEGvR46i8vzBjMMNzgzaY4fOMPOvkrbPZCX/1bzTWSujZsdTOwcVo+LYbPksX8bsryBohMt4PTmje0RuN5XtKSlyrYTJ1SYjl3L//mmeGlvxnV5AUWZ8qdZFtoHRVbmaBWUMbfl+QltRY34W4NqZQVfgkCGLHiig0+LrYO6JFRqek+oFeHFAX4bbqrzGA5jIv7dmwR+y5ZUxlDdwYgK+tdPM39MXj3rGS9jNkZIDIYYdpTlmwz+OjHiCpBeTDNQTlxt93RxATMACXdu1+BhCYv65uqAo6BXVAHI+5R/jNyVkKcU7FgJPqI/LoFCtGCFR7JErdcQhRaanv/HeqLlcrzJzuwIlJFyGthUKzL9LUGcvGiqBgfAhhfSJ+9m4+6ZOAx65tolX4JEYDiS1tJH0d9WHoy+uzyZj3N0znS58a+Fi/NkNJunOC6aVPRt02PF/rCiWabry0IecwE+WRLQm4Ag0HVCRj+W4Q1orZdW8GJimDDAVQ0Mek9b7L3F/FdGRDoC4oZtXn0MZQyCsJs7WzP6ZPsU7/M9LBivVPRdL1kORbWXGtd1zsmNVwRBAknyg1eh7doKPp8t3jJ+kvEBl7wZhOZ62YzqB4pOYiDhrSbF+iDywrXB6doZsQdEuBo+EnnKw19jYcJtQ74zpBoFhrSYJje/H2MOtOpOb9pztVFHhKhr/eBA9nm0D0q1FCTftG8QiUaEk2m+62Kgw+Xr+APWwtvT4wrIFWw079YygE8REXAVFv9TfRglEHs8oS16Sk8DsMpOutYqgrkMcPEupmNgkfyE6SzkVRTQAvJkftRMPDzprOuUX2t/rxQ1sjwrksNz3re/kL1cYvGPz0wAVmR5P2r5coogSu/mupE2jDXoztiOvIEl5JF5P4UmIfHH17zecwH4yHT jUWQ+j7J a7Momk1svvkzgaeMQsKw5kk02xVEU4yWe+zGsb7qJhHl7VOoa0tNOIRkJFRv20NW/g07qBiEpa5VO5sAdp9UOXPA9+iE0+NrxDU5GbthXWuA5iaDoqA8Ixns+e4PWjroddM8PBdQGlVIzs1Y+uU+53zOWk9PDNwMsjJ2KiqCOhSnYVSH34CJ8gIELqGVzpgYDWKLyLq12ahPFs6wi6bVPDb7ddB2povPMU29EwwQkqeYxvJX2dHopT7YwbEy7JjsoVe593b0kmDiSPNQiW3mt8G36lsKMTaNzUfvwototq2grqa5yXBk9z95ubhByjN1ubL9sokYYX8hQlfEewyDyja5tfW/+/3mwZvew0Cqc59Ql1waRg/b51Fp2ydysac3UIsUFMFcL8XmZ26buLhbbKL8A91x8Seuzn+MqHW5zfOT3dd0qnH3k+hE444trYXvn/SruQIukxjycuMsTcc3cfjS0UA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed. SLUB instead relies on the page allocator's NUMA policies. Change the flag's value to 0 to free up the value it had, and mark it for full removal once all users are gone. Reported-by: Steven Rostedt Closes: https://lore.kernel.org/all/20240131172027.10f64405@gandalf.local.home/ Signed-off-by: Vlastimil Babka Tested-by: Xiongwei Song Reviewed-by: Xiongwei Song Reviewed-by: Chengming Zhou Reviewed-by: Roman Gushchin --- include/linux/slab.h | 5 +++-- mm/slab.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index b5f5ee8308d0..6252f44115c2 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -96,8 +96,6 @@ */ /* Defer freeing slabs to RCU */ #define SLAB_TYPESAFE_BY_RCU ((slab_flags_t __force)0x00080000U) -/* Spread some memory over cpuset */ -#define SLAB_MEM_SPREAD ((slab_flags_t __force)0x00100000U) /* Trace allocations and frees */ #define SLAB_TRACE ((slab_flags_t __force)0x00200000U) @@ -164,6 +162,9 @@ #endif #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ +/* Obsolete unused flag, to be removed */ +#define SLAB_MEM_SPREAD 0 + /* * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests. * diff --git a/mm/slab.h b/mm/slab.h index 54deeb0428c6..f4534eefb35d 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -469,7 +469,6 @@ static inline bool is_kmalloc_cache(struct kmem_cache *s) SLAB_STORE_USER | \ SLAB_TRACE | \ SLAB_CONSISTENCY_CHECKS | \ - SLAB_MEM_SPREAD | \ SLAB_NOLEAKTRACE | \ SLAB_RECLAIM_ACCOUNT | \ SLAB_TEMPORARY | \