From patchwork Fri Feb 23 14:37:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13569149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62711C5478C for ; Fri, 23 Feb 2024 14:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 464596B007B; Fri, 23 Feb 2024 09:37:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED4C6B007D; Fri, 23 Feb 2024 09:37:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28DAC6B007E; Fri, 23 Feb 2024 09:37:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 17FE56B007B for ; Fri, 23 Feb 2024 09:37:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7A40A40F25 for ; Fri, 23 Feb 2024 14:37:42 +0000 (UTC) X-FDA: 81823322364.21.51B5E1F Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf27.hostedemail.com (Postfix) with ESMTP id 9B0A240026 for ; Fri, 23 Feb 2024 14:37:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708699060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=955eO+Q/g6pl32XJ2cybDlr/zrSZEzRuSbd5YXn12rQ=; b=HRO5kqk8p/lXvz1ZJU8NcQ2W6VmchEjyOg2GiaxPBZMiWfh3uJKuHqoUhQ5r/zS5W4C2Sf tSl6UGesPGyjSSJHC4OFu7QmB0vJUyfeK/Bxi++jiYiQN3rUgdhK91OgkdiWEQ9APzJbKo 5s3d0moP84+lfR2vLVNQwooc3HYnXdA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708699060; a=rsa-sha256; cv=none; b=Uh41LmBOz7HFfDbeUAj5G2W+C32GQUzjF0PEwBA4VOz6KV/JX4tONDqugXamxHXHdtyxn0 N3FNasMT/OpaJi0hcgIR1ErPoHaxAQX2EbgFL3XJO7c1w9hRl8Z5o85dFsB+mz5px16CZH r2y0cQSvOwxzmFhydaZaimHtTK/AZDc= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ThCF34jntz6K8yQ; Fri, 23 Feb 2024 22:33:59 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id B9533140DE3; Fri, 23 Feb 2024 22:37:38 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 23 Feb 2024 14:37:37 +0000 From: To: , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [RFC PATCH v7 01/12] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Date: Fri, 23 Feb 2024 22:37:12 +0800 Message-ID: <20240223143723.1574-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20240223143723.1574-1-shiju.jose@huawei.com> References: <20240223143723.1574-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Queue-Id: 9B0A240026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oe1gaxh5itxu1r9ki95sizbw3cuaqhuy X-HE-Tag: 1708699060-581968 X-HE-Meta: U2FsdGVkX18p0u9cTVn2lAW/wBHv19mnS6SC7zgrumuWjCz4ks9U+1JGtNVcqfz2CUV7IoYUkOKLehU4hLUQO/rBbkMVCR7JanqAUHpSbSPtvF5nOSkD71E3EuJCGPb1tG0mE9mlTr5icmBLwxG8uYfgjKesjhYLq0d1tzCkR30ipxAxp92d59Gaw4GVbH2gBhcQKWo+kzzf6aJMKddz5oOxzRabhjFXhsZFQ4AW+z813SKnv+gVpNVmpuy5cmr5tlzaAdscTBYChj+B1YoJXgiYVg02JPJTb9Q+7XCMmr06OlLu26HQtZSVVzYHXTlLTX7G6mlTRqLcdNKGLNn+aY/6a7cxUo6rQ6G4E3SQOKzfB9P1mSOEl8pGsLTEdDopMw/M69u9EC9nGW61xeyXRtsAzvxuQjSACJ5xtWGC2YsMs9bNe+ZtbpUHpYwtITay9HmPiA57Wz+dGp9yHrpKzOVeq0Bv/WB96tu/1+W843HJc4a0+aeXOa4sZHxdYBjC0ibbfYMi+8xGfbJvGzmC2cXQTDVzaxlkEyIRuRFPbdQZc957RWzGXsul6v3X7IcxUGUXX1FwMzdmbtePJF3brnyaxcI/ZyCHwUCgeRYBXPuixybXdZkcUie0lDdPwFRxV2XUeC4Ipq/KtSTWUhWsSERXdXRi/crAVZkzGWaS3Bb2ex6FBBW91tg+WiPfkTmE2ApJjqY5t5xrvaG2J2Jv8oEb0o4SwUE2g/tZg4rDHvuslKcImgqh2esSDs71Y+BxdAyQyycmqnBycvIsoD6K9gx/DXOediOXpO4P5kNhCXzC9snx23jw4japzUB/NEwPu9RwVlSBWB24VYmYHnjNGlfYttX12ExZv8/8DaGrxfg887Ia8zAZYyqHb3nZrlQZhpaJ2z5CkQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for GET_SUPPORTED_FEATURES mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. CXL devices supports features with changeable attributes. Get Supported Features retrieves the list of supported device specific features. The settings of a feature can be retrieved using Get Feature and optionally modified using Set Feature. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 27 +++++++++++++++++++ drivers/cxl/cxlmem.h | 58 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 27166a411705..79cc7fd433aa 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1290,6 +1290,33 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds) } EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + u32 count, u16 start_index, + struct cxl_mbox_get_supp_feats_out *feats_out) +{ + struct cxl_mbox_get_supp_feats_in pi; + struct cxl_mbox_cmd mbox_cmd; + int rc; + + pi.count = cpu_to_le32(count); + pi.start_index = cpu_to_le16(start_index); + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_SUPPORTED_FEATURES, + .size_in = sizeof(pi), + .payload_in = &pi, + .size_out = count, + .payload_out = feats_out, + .min_out = sizeof(*feats_out), + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + return 0; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index 5303d6942b88..dd66523cd96a 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -529,6 +529,7 @@ enum cxl_opcode { CXL_MBOX_OP_SET_TIMESTAMP = 0x0301, CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, CXL_MBOX_OP_GET_LOG = 0x0401, + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -698,6 +699,60 @@ struct cxl_mbox_set_timestamp_in { } __packed; +/* Get Supported Features CXL 3.1 Spec 8.2.9.6.1 */ +/* + * Get Supported Features input payload + * CXL rev 3.1 section 8.2.9.6.1 Table 8-95 + */ +struct cxl_mbox_get_supp_feats_in { + __le32 count; + __le16 start_index; + u8 rsvd[2]; +} __packed; + +/* + * Get Supported Features Supported Feature Entry + * CXL rev 3.1 section 8.2.9.6.1 Table 8-97 + */ +/* Supported Feature Entry : Payload out attribute flags */ +#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) +#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK GENMASK(3, 1) +#define CXL_FEAT_ENTRY_FLAG_PERSIST_ACROSS_FIRMWARE_UPDATE BIT(4) +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_DEFAULT_SELECTION BIT(5) +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_SAVED_SELECTION BIT(6) + +enum cxl_feat_attr_value_persistence { + CXL_FEAT_ATTR_VALUE_PERSISTENCE_NONE, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_CXL_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_HOT_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_WARM_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_COLD_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_MAX +}; + +struct cxl_mbox_supp_feat_entry { + uuid_t uuid; + __le16 index; + __le16 get_size; + __le16 set_size; + __le32 attr_flags; + u8 get_version; + u8 set_version; + __le16 set_effects; + u8 rsvd[18]; +} __packed; + +/* + * Get Supported Features output payload + * CXL rev 3.1 section 8.2.9.6.1 Table 8-96 + */ +struct cxl_mbox_get_supp_feats_out { + __le16 nr_entries; + __le16 nr_supported; + u8 rsvd[4]; + struct cxl_mbox_supp_feat_entry feat_entries[]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -829,6 +884,9 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_type event_type, const uuid_t *uuid, union cxl_event *evt); int cxl_set_timestamp(struct cxl_memdev_state *mds); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + u32 count, u16 start_index, + struct cxl_mbox_get_supp_feats_out *feats_out); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);