From patchwork Fri Feb 23 14:37:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13569148 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26393C54798 for ; Fri, 23 Feb 2024 14:37:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E77446B0078; Fri, 23 Feb 2024 09:37:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E254D6B007B; Fri, 23 Feb 2024 09:37:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6106B007D; Fri, 23 Feb 2024 09:37:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE34F6B0078 for ; Fri, 23 Feb 2024 09:37:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76E8E160C1B for ; Fri, 23 Feb 2024 14:37:44 +0000 (UTC) X-FDA: 81823322448.01.63EBB84 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf30.hostedemail.com (Postfix) with ESMTP id 925BC8001D for ; Fri, 23 Feb 2024 14:37:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708699062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0SFmr4UIoOGpWrIhelCVMqKDnU2V3fE7hjFxymHs78=; b=THBZ37QSL3xos6tB1CHUK7RYEGUwpG1RrR11a1hYn6jGJ0pAvDlBXTvnKytIFg8Z5erCHS ieEHCRXUNkCH8mJVOe+ZJ5uu1dFdcpSH4gWjHkFYcTXSJyzk6cJpvBqGKgYhgUWL0Q1ULS 6DTaeIpep5jOjaBWI1zO6yzP9BbUYn0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708699062; a=rsa-sha256; cv=none; b=DV3qlOw4yMnjtFpDN2PpByYcmp0bCtcom9vBUKXashkOY4Hpj4tSI5ygBeRswkZFsK4bEh JsaZuFUroPP0oFbf9tiVPfkvErwI2HkzwGrOWL/8Pnjkkno5cpu6GX2PUeUkBt5Z7dY7xq zCNTikk/cXGULvm8yoeqYEbNUqWqfOQ= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ThCF54nwwz6K6hC; Fri, 23 Feb 2024 22:34:01 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id BE6E1140119; Fri, 23 Feb 2024 22:37:40 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 23 Feb 2024 14:37:39 +0000 From: To: , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [RFC PATCH v7 03/12] cxl/mbox: Add SET_FEATURE mailbox command Date: Fri, 23 Feb 2024 22:37:14 +0800 Message-ID: <20240223143723.1574-4-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20240223143723.1574-1-shiju.jose@huawei.com> References: <20240223143723.1574-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Queue-Id: 925BC8001D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rgxej5po9ag78z5ed4nnct5t577xyi88 X-HE-Tag: 1708699062-717267 X-HE-Meta: U2FsdGVkX19MeF1kdSHNM57Isq7gxn0J5kqFGGZZUHs4qOXxx2NgAXoarW1nMHQ0iOHIY3VusvWn8D1Ohh13443E2mS5K/gswXTRT0Lj53OoRG17/5eY046W6aFbsZ7p05ItBRA66t5xQgNIsIRVG7JIt3Xa9vEn3v74y1j2VxPoP2PB6MOqPKpEXdDDwfV9LN1rb8asyTejXUPlukp/0idJw1jFnZ/JILqgzal2DPVAiETGvTgq4Cuk0OXqM4+BfV/o5pBTQ4LO765Pg3Z+J+QTxhfXv8bup0iDNldX8ietQacx/rWOom+Q9kvfecOhthNL1X4WhhtkMJe31tzRbPvzVd2VlFn5JWNHaRCaSRcPyZ29mnBbYD9D10BZsO7VRardrkkqt9araN1IoDiPZ7iPVQmunQS/KzfV9MrkceJ6WPgGmGDKk9++27LiJJsSQdBdUXsTrCKBF0j0BkaDe5s5I6qfupYSGsiBKDWywn5LV75/gsQ4HMTS4cbkuMsMb74WQGPMbGS8b8EjZpBjoepWufd7Vw7uMVJXGJdeu4Jdfry6J58lHbPeWzoQiqlz2BVFN31IvNKOQQbGzDEnS+DFZC9SLbCHWOSvjml1RpaXejq4A0PwKupChWz2JYVe+FeT4K4R9rIsQnWiFZZgwwv+2rbrACbHdNESZ1ccjEWz9HzFxU7kwdAHMdP7b0z02IXwwg2pPlFfNRckd7mYsCzMlek9z90Iz2qJMTSRK2RutsaGx3JROCcQvpPzQh9pXckareR3EDPQhiAPYPGSxRxR47xRDp/0nE6EONnK9djC5x/oTB/81zbi4Z2EwLLiABH1RXhePquodrDy+c1tzVHXZDNBNrBZS0ttKNPcoSoOj8ObQuC1imdGEW8w6DwXWiV9xJ6YBgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for SET_FEATURE mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. CXL devices supports features with changeable attributes. The settings of a feature can be optionally modified using Set Feature command. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 67 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 30 ++++++++++++++++++ 2 files changed, 97 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index c078e62ea194..d1660bd20bdb 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1366,6 +1366,73 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); +int cxl_set_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag) +{ + struct cxl_memdev_set_feat_pi { + struct cxl_mbox_set_feat_hdr hdr; + u8 feat_data[]; + } __packed; + size_t data_in_size, data_sent_size = 0; + struct cxl_mbox_cmd mbox_cmd; + size_t hdr_size; + int rc = 0; + + struct cxl_memdev_set_feat_pi *pi __free(kfree) = + kmalloc(mds->payload_size, GFP_KERNEL); + pi->hdr.uuid = feat_uuid; + pi->hdr.version = feat_version; + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; + hdr_size = sizeof(pi->hdr); + /* + * Check minimum mbox payload size is available for + * the feature data transfer. + */ + if (hdr_size + 10 > mds->payload_size) + return -ENOMEM; + + if ((hdr_size + feat_data_size) <= mds->payload_size) { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); + data_in_size = feat_data_size; + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); + data_in_size = mds->payload_size - hdr_size; + } + + do { + pi->hdr.offset = cpu_to_le16(data_sent_size); + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_SET_FEATURE, + .size_in = hdr_size + data_in_size, + .payload_in = pi, + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + data_sent_size += data_in_size; + if (data_sent_size >= feat_data_size) + return 0; + + if ((feat_data_size - data_sent_size) <= (mds->payload_size - hdr_size)) { + data_in_size = feat_data_size - data_sent_size; + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); + } + } while (true); + + return rc; +} +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index bcfefff062a6..a8d4104afa53 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -531,6 +531,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_LOG = 0x0401, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_GET_FEATURE = 0x0501, + CXL_MBOX_OP_SET_FEATURE = 0x0502, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -773,6 +774,31 @@ struct cxl_mbox_get_feat_in { u8 selection; } __packed; +/* Set Feature CXL 3.1 Spec 8.2.9.6.3 */ +/* + * Set Feature input payload + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 + */ +/* Set Feature : Payload in flags */ +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) +enum cxl_set_feat_flag_data_transfer { + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX +}; +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) + +struct cxl_mbox_set_feat_hdr { + uuid_t uuid; + __le32 flags; + __le16 offset; + u8 version; + u8 rsvd[9]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -912,6 +938,10 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, size_t feat_out_size, size_t feat_out_min_size, enum cxl_get_feat_selection selection); +int cxl_set_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);