From patchwork Sun Feb 25 07:56:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kasireddy, Vivek" X-Patchwork-Id: 13570757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A537C47DD9 for ; Sun, 25 Feb 2024 08:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FEF36B00FB; Sun, 25 Feb 2024 03:24:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D936B00FD; Sun, 25 Feb 2024 03:24:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DA806B00FE; Sun, 25 Feb 2024 03:24:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F01606B00FB for ; Sun, 25 Feb 2024 03:24:18 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C907C1202F6 for ; Sun, 25 Feb 2024 08:24:18 +0000 (UTC) X-FDA: 81829638996.22.54AEF59 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf14.hostedemail.com (Postfix) with ESMTP id CF2EC100005 for ; Sun, 25 Feb 2024 08:24:15 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FXfy7o2p; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708849456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A9kdWYJrq8df96o0nhlHNPK1LEB8BHvEeLApCKEij8Q=; b=YU/WvNpDh2Ypx2U+m2di472oShsm6vSZz5KUJurr1D/Iq9dGm34GFJYAgN9ogUD+cSd2DS 0eIwpe0b7K1C4aTGpmUNk9nSCq80cHaL25zGJvkjj7/3KSlOZskfOuFuSAOPzhl5zPpKvO VUhye7I+Jc7sHVpXLpSl8TuJXF2uC+Q= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FXfy7o2p; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708849456; a=rsa-sha256; cv=none; b=PHDULJzTIZi93aADPXlfLwTmkyIjIyO4ANSqsx52lj4KqAT58bNkKCwdyUCKemFBWtljZ8 XHnVOm4qWkuDuSpuBQvvEv1atL0x643xsNynMd4mKr7NaDGADVwOd4uBnNO88MSKJWF+Z9 G036smq1HBN5pP23IyIkhrgRIbvkOVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708849456; x=1740385456; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Mdt4r6h8BCL+kqp7gjKBQvdvVXgEI5bmUqCpjmEFAmQ=; b=FXfy7o2pcuFYLSp60fAIQEwg/gP11kDCoW1ppmdf9gzkhCGAM3tQIDAj 6bBe7TYLIwHyt96wjH9P6SS/SVIzuKhXjF8x3gSAZL21AIHOKFFFVvqUb 42QUUIZeTYdltEUL7J3ONttsH/S1GF1+EKqzLg8dAFuHSf4lUIBC5fbTl n01EnU6wQ2zJfS84qPcbVMZfkWypksYtOulGylovYKFCEqiWs7PZZWgbC GAxMizuUt8vAyr1YeGrdgJwTceTpvAN0I6j5mLBNBAzyXxLN1+fjZF6H+ m2JwqO6SBRFKvSuwMiY+Eh7Zdn5ETyb0E8EHf/WzK99ilhHcp9CKxyt+p A==; X-IronPort-AV: E=McAfee;i="6600,9927,10994"; a="2988355" X-IronPort-AV: E=Sophos;i="6.06,183,1705392000"; d="scan'208";a="2988355" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2024 00:24:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,183,1705392000"; d="scan'208";a="6783251" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2024 00:24:11 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , Dongwon Kim , Junxiao Chang , Jason Gunthorpe , Christoph Hellwig Subject: [PATCH v12 3/8] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios Date: Sat, 24 Feb 2024 23:56:59 -0800 Message-ID: <20240225080008.1019653-4-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240225080008.1019653-1-vivek.kasireddy@intel.com> References: <20240225080008.1019653-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CF2EC100005 X-Stat-Signature: u4nq1gkrr8sdf13a6fr9in5debgks5dy X-Rspam-User: X-HE-Tag: 1708849455-519791 X-HE-Meta: U2FsdGVkX19PhA8BY8IOiblyh0bdhNGjMQm5wu6vR79fuIQQshG5JfRu23+qovGHLXBVFkLSn/s4iM3aa3m7A6QB4GePfd78LqhpBryFOoR/T3kWyWrwF4N8fRuh917GHVdRUFTcdHvWYJ+09bICE1G48w9fQJFkqSG9LXznZLRnmwi5zq0zpphesmyYjXKiRndepAl/AuVtwUr4ai6zKBxCA7g1zV0WLwSZ5eJGQIXWqRLsAsqdlEMySgt6hLOWSZ214E7EqDtH2SrpM1ZYjSvDcyZnf/uAYaPI1yY9PlZpxaLHAgfsefBIzmWoVqGSbpi+Bp96nSyzYgKzXQfjmTNzmqzceuOuYp3o7x75ZB0cV7Owx77al0xNp5u+P36I2rfOf1hX+1jj0s8wF9warb2osDtN4/pgzjsfKTMOBtqXZbhyyWR37O6KgvEPqxhDymQwGvPwZtwOKUMaL+fw4Vda50eQ4WYNVWY8v3hCeWs/Q29B3YXVtrccEvSudu4Z0NjxQCKiz7X1Id9MLH0Iofob+JEhzDUug67rVqSHiSi5Rtuah3qr4KxI57+k41DqUG6AOtnSqwHvibclT3sPr6rkA3jQepLHEi4L4gL/+BqcGxRZMZikRow/VybrMlXcdXMrejSsxC5/bOUCoLfF4Eh8Fl9artgp3uHlmKCSoDMiWSIjGE9o9q73DGEvhBYSI/fsD6NSAOLPktXe3kO8QxGDCeSlS2UP7hAhuo4rchW2CxhlY8wYjpDQ4h8WNrTdMskGsUuzPLFkUQH2fzSdRUzMVLvOgrEWfbLcBJP/acJr2z43KLp9ynfC/xi/dzG2aPHynYyxiTEuQ8qUtHFU5mAJ/m5oQu8Ol+jJI5dRMo/72oIfykmJfMPqV1Vr/72V0xHHQq5PiwNTic4LzwePZvIhLoajNiuEcLJHUG+nVIVjYcC3EKos9O8Tu6B0UTpjlVi7oPLXGhsC26UAk5u dEpdrdOv Q2dsy+C1Ta01rQmTp1uQbLOx1S8OfliERwcMfP5F0MSG7JZbgCwxa0WAYtzkGgtjMqihRvCCIXfCdGt4+UnWyZo0YU1g9vu64Tm1zFJG09/kp3yTtMB5n8jYa6+NacIFHeueRZQcIKPyep56qpsFKAwEobhSz5Uu5kIotpRpOUoAYFZS1354ilANqH3lbqssTsNdRy5cICQBmD0OZyQcj9ftAPTQUnEvYr+RHRF8IKs4YgF0Ymp9pP6EZZksnkdOMyXHk1ssxT64ToNvdGFrDHHZ67kVVkfmT2Mv9+YcKdIzZhzeliZpvqGQUSvkwBd4K5JCUlkohPoepShONH0Yi8KdJ0NUjZgCumnjLKzkmoKCr1Lg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should work with any files that belong to either shmemfs or hugetlbfs. Files belonging to other filesystems are rejected for now. The folios need to be located first before pinning them via FOLL_PIN. If they are found in the page cache, they can be immediately pinned. Otherwise, they need to be allocated using the filesystem specific APIs and then pinned. Cc: David Hildenbrand Cc: Matthew Wilcox (Oracle) Cc: Christoph Hellwig Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: Jason Gunthorpe Reviewed-by: Jason Gunthorpe (v2) Reviewed-by: David Hildenbrand (v3) Reviewed-by: Christoph Hellwig (v6) Signed-off-by: Vivek Kasireddy --- include/linux/memfd.h | 5 ++ include/linux/mm.h | 3 + mm/gup.c | 136 ++++++++++++++++++++++++++++++++++++++++++ mm/memfd.c | 34 +++++++++++ 4 files changed, 178 insertions(+) diff --git a/include/linux/memfd.h b/include/linux/memfd.h index e7abf6fa4c52..3f2cf339ceaf 100644 --- a/include/linux/memfd.h +++ b/include/linux/memfd.h @@ -6,11 +6,16 @@ #ifdef CONFIG_MEMFD_CREATE extern long memfd_fcntl(struct file *file, unsigned int cmd, unsigned int arg); +struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx); #else static inline long memfd_fcntl(struct file *f, unsigned int c, unsigned int a) { return -EINVAL; } +static inline struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) +{ + return ERR_PTR(-EINVAL); +} #endif #endif /* __LINUX_MEMFD_H */ diff --git a/include/linux/mm.h b/include/linux/mm.h index 36e4c2b22600..54e2775f89be 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2491,6 +2491,9 @@ long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages, struct page **pages, unsigned int gup_flags); long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, struct page **pages, unsigned int gup_flags); +long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, + struct folio **folios, unsigned int max_folios, + pgoff_t *offset); int get_user_pages_fast(unsigned long start, int nr_pages, unsigned int gup_flags, struct page **pages); diff --git a/mm/gup.c b/mm/gup.c index 1410af954a4e..a72bff363d0c 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include @@ -17,6 +18,7 @@ #include #include #include +#include #include #include @@ -3530,3 +3532,137 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, &locked, gup_flags); } EXPORT_SYMBOL(pin_user_pages_unlocked); + +/** + * memfd_pin_folios() - pin folios associated with a memfd + * @memfd: the memfd whose folios are to be pinned + * @start: the first memfd offset + * @end: the last memfd offset (inclusive) + * @folios: array that receives pointers to the folios pinned + * @max_folios: maximum number of entries in @folios + * @offset: the offset into the first folio + * + * Attempt to pin folios associated with a memfd in the contiguous range + * [start, end]. Given that a memfd is either backed by shmem or hugetlb, + * the folios can either be found in the page cache or need to be allocated + * if necessary. Once the folios are located, they are all pinned via + * FOLL_PIN and @offset is populatedwith the offset into the first folio. + * And, eventually, these pinned folios must be released either using + * unpin_folios() or unpin_folio(). + * + * It must be noted that the folios may be pinned for an indefinite amount + * of time. And, in most cases, the duration of time they may stay pinned + * would be controlled by the userspace. This behavior is effectively the + * same as using FOLL_LONGTERM with other GUP APIs. + * + * Returns number of folios pinned, which could be less than @max_folios + * as it depends on the folio sizes that cover the range [start, end]. + * If no folios were pinned, it returns -errno. + */ +long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, + struct folio **folios, unsigned int max_folios, + pgoff_t *offset) +{ + unsigned int flags, nr_folios, nr_found; + unsigned int i, pgshift = PAGE_SHIFT; + pgoff_t start_idx, end_idx, next_idx; + struct folio *folio = NULL; + struct folio_batch fbatch; + struct hstate *h; + long ret; + + if (start > end || !max_folios) + return -EINVAL; + + if (!memfd) + return -EINVAL; + + if (!shmem_file(memfd) && !is_file_hugepages(memfd)) + return -EINVAL; + + if (is_file_hugepages(memfd)) { + h = hstate_file(memfd); + pgshift = huge_page_shift(h); + } + + flags = memalloc_pin_save(); + do { + nr_folios = 0; + start_idx = start >> pgshift; + end_idx = end >> pgshift; + if (is_file_hugepages(memfd)) { + start_idx <<= huge_page_order(h); + end_idx <<= huge_page_order(h); + } + + folio_batch_init(&fbatch); + while (start_idx <= end_idx && nr_folios < max_folios) { + /* + * In most cases, we should be able to find the folios + * in the page cache. If we cannot find them for some + * reason, we try to allocate them and add them to the + * page cache. + */ + nr_found = filemap_get_folios_contig(memfd->f_mapping, + &start_idx, + end_idx, + &fbatch); + if (folio) { + folio_put(folio); + folio = NULL; + } + + next_idx = 0; + for (i = 0; i < nr_found; i++) { + /* + * As there can be multiple entries for a + * given folio in the batch returned by + * filemap_get_folios_contig(), the below + * check is to ensure that we pin and return a + * unique set of folios between start and end. + */ + if (next_idx && + next_idx != folio_index(fbatch.folios[i])) + continue; + + folio = try_grab_folio(&fbatch.folios[i]->page, + 1, FOLL_PIN); + if (!folio) { + folio_batch_release(&fbatch); + goto err; + } + + if (nr_folios == 0) + *offset = offset_in_folio(folio, start); + + folios[nr_folios] = folio; + next_idx = folio_next_index(folio); + if (++nr_folios == max_folios) + break; + } + + folio = NULL; + folio_batch_release(&fbatch); + if (!nr_found) { + folio = memfd_alloc_folio(memfd, start_idx); + if (IS_ERR(folio)) { + ret = PTR_ERR(folio); + if (ret != -EEXIST) + goto err; + } + } + } + + ret = check_and_migrate_movable_folios(nr_folios, folios); + } while (ret == -EAGAIN); + + memalloc_pin_restore(flags); + return ret ? ret : nr_folios; +err: + memalloc_pin_restore(flags); + unpin_folios(folios, nr_folios); + + return ret; +} +EXPORT_SYMBOL_GPL(memfd_pin_folios); + diff --git a/mm/memfd.c b/mm/memfd.c index d3a1ba4208c9..36a75e8249f8 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -63,6 +63,40 @@ static void memfd_tag_pins(struct xa_state *xas) xas_unlock_irq(xas); } +/* + * This is a helper function used by memfd_pin_user_pages() in GUP (gup.c). + * It is mainly called to allocate a page in a memfd when the caller + * (memfd_pin_user_pages()) cannot find a page in the page cache at a given + * index in the mapping. + */ +struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) +{ +#ifdef CONFIG_HUGETLB_PAGE + struct folio *folio; + int err; + + if (is_file_hugepages(memfd)) { + folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), + NUMA_NO_NODE, + NULL, + GFP_USER); + if (folio && folio_try_get(folio)) { + err = hugetlb_add_to_page_cache(folio, + memfd->f_mapping, + idx); + if (err) { + folio_put(folio); + free_huge_folio(folio); + return ERR_PTR(err); + } + return folio; + } + return ERR_PTR(-ENOMEM); + } +#endif + return shmem_read_folio(memfd->f_mapping, idx); +} + /* * Setting SEAL_WRITE requires us to verify there's no pending writer. However, * via get_user_pages(), drivers might have some pending I/O without any active