| Message ID | 20240301160808.10623-2-vbabka@suse.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm, slab: remove memcg_from_slab_obj() | expand |
On 2024/3/2 00:08, Vlastimil Babka wrote: > This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was > never used. Probably a leftover from development of a series. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> LGTM, thanks! Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev> > --- > mm/slub.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 12066e69688d..186a8ec28228 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects, > obj_cgroup_uncharge(objcg, objects * obj_full_size(s)); > } > #else /* CONFIG_MEMCG_KMEM */ > -static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr) > -{ > - return NULL; > -} > - > static inline void memcg_free_slab_cgroups(struct slab *slab) > { > }
On Fri, Mar 01, 2024 at 05:08:09PM +0100, Vlastimil Babka wrote: > This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was > never used. Probably a leftover from development of a series. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev> Thanks!
On Fri, 1 Mar 2024, Vlastimil Babka wrote: > This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was > never used. Probably a leftover from development of a series. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: David Rientjes <rientjes@google.com>
diff --git a/mm/slub.c b/mm/slub.c index 12066e69688d..186a8ec28228 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects, obj_cgroup_uncharge(objcg, objects * obj_full_size(s)); } #else /* CONFIG_MEMCG_KMEM */ -static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr) -{ - return NULL; -} - static inline void memcg_free_slab_cgroups(struct slab *slab) { }
This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was never used. Probably a leftover from development of a series. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/slub.c | 5 ----- 1 file changed, 5 deletions(-)