From patchwork Tue Mar 5 08:59:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Max Kellermann X-Patchwork-Id: 13581855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0787C54E41 for ; Tue, 5 Mar 2024 08:59:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E32D6B0089; Tue, 5 Mar 2024 03:59:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 393856B008A; Tue, 5 Mar 2024 03:59:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2354F6B008C; Tue, 5 Mar 2024 03:59:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0D5F36B0089 for ; Tue, 5 Mar 2024 03:59:40 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CDCD9C0C5F for ; Tue, 5 Mar 2024 08:59:39 +0000 (UTC) X-FDA: 81862387278.01.C74815F Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf24.hostedemail.com (Postfix) with ESMTP id E0F3E180012 for ; Tue, 5 Mar 2024 08:59:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=BNp51xEd; dmarc=pass (policy=quarantine) header.from=ionos.com; spf=pass (imf24.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709629178; a=rsa-sha256; cv=none; b=VdG1sSLWdkfiGed+543a8NUkb1YxTDo2LD/V3BodOF59SGB61BlxpB4/KLlWxQXzdgXyj2 AA3sh4Rxz2nnYC+vR4FyASvOw8gvRc09dSIoVck44MM7tJBkUQMvsVm+qEKcw6n6A40/3E XmH/61zOviGCWpeHAkCmA/yimhMAW18= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=BNp51xEd; dmarc=pass (policy=quarantine) header.from=ionos.com; spf=pass (imf24.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709629178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BL1pmIo7s1MX4N9LU8kIbt0i/wU5mZK2rTJkOzRk4Zc=; b=TTiX1Q7VCgK5UaGaYDOF/cVTpy5C4wDpe/+P1eOyoN7/FeYMX2jpKqAG+MnsoTm5jZxDGG Tl1Ney3nvpzYhmcq3ATrfN64fS3583Egg7pkE285RMrprWfBglxQsvaiyf9iDkxT9LHuaG XKdE/Qv/zGWmUsieUuN+LCfnRqOHu9U= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a4467d570cdso544984766b.3 for ; Tue, 05 Mar 2024 00:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1709629176; x=1710233976; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BL1pmIo7s1MX4N9LU8kIbt0i/wU5mZK2rTJkOzRk4Zc=; b=BNp51xEdK/nrXCOhe3ibfKHk7RQJU/75TEtnVgf+aZz8NsetInEm1vkjB3nFE8QiuA dQ2E/Q0jthVllrHlwhgRotMBp5dKM16LM9j/AgOtrd6C9DSihkMw/oFuGSczP+blSE0u XIi2VdzJe5JtA4nWYL+gZEBedKOJ4EvJZc+2xGRFCT3uK1+b9cg8U6lwz4cdVl3IEOtz DGK+8ADJJ8XgZf14HRHr0L959bu4SyeOHljiU/K+KEq1sEHPw/XSdbwYAimRxb71jz2b a0yWu/nlhxIArQJH384gIoPs4MpEml2UWsyq2IqKlTU9IHa5LGVo879pSt1GN/W367Tg OcgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709629176; x=1710233976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BL1pmIo7s1MX4N9LU8kIbt0i/wU5mZK2rTJkOzRk4Zc=; b=bhhFO9LvTaUwAzT8xAVXa63mGZxGSc9dq4IA/a+3jRvEkWnO8l3IjE12hCTMIT0E2q tBMhclcP1xla5TeEJTmrjbw15M0qUg3ZIjaPz3ONhH49uqUbH5MaLVEN+Iz7784H3iFi zeriejqY8BWDoa+bQ/acebquPSlM6fw6Ck/ERoOzUrqJ6NP5YaJpSAh6DOmnFBYcDYIc 6z6287uocvcHaokfMM8P8wX7WK1hM4+ljIf+4c+i6DSxl4OoeMfnr5+McNR0cxPfRLZa 7fUACAhKzUptaHI2jfLwhYl6Jvyc/R9Q1gbEXbCPcd+O80UmcKgRMo338U+XnVoxkMjc kFbw== X-Forwarded-Encrypted: i=1; AJvYcCU8QD0f7XBD0WaTc4VJrEBpSJg4LftPPClUagUgL+aSz+4FMKXXZn1aawYN31UO6kilEADEzmZUdKITv18fWRuYOag= X-Gm-Message-State: AOJu0Yxc1mwgLvFzImscaIcZg9ZD2pQSB8ytNp7Lk4ST//8g6JmMIkh3 +ufR7xkgjkZRkw6vtSm0RhjAlJu2oV4XaOU/NyApVaGKHOVnUkfdIWLBV8ORYN0= X-Google-Smtp-Source: AGHT+IFECPH+najh1MX5zMcxH632u551jNgiqYN/FKRfvXxmD0N9/VMCEcGbJDINMY/jajNmROur7w== X-Received: by 2002:a17:906:7809:b0:a3f:29c:c8fa with SMTP id u9-20020a170906780900b00a3f029cc8famr7642550ejm.66.1709629176544; Tue, 05 Mar 2024 00:59:36 -0800 (PST) Received: from raven.blarg.de (p200300dc6f010900023064fffe740809.dip0.t-ipconnect.de. [2003:dc:6f01:900:230:64ff:fe74:809]) by smtp.gmail.com with ESMTPSA id gs4-20020a170906f18400b00a449d12cdc5sm4453005ejb.119.2024.03.05.00.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:59:35 -0800 (PST) From: Max Kellermann To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: willy@infradead.org, sfr@canb.auug.org.au, Max Kellermann Subject: [PATCH v3 02/14] include/drm/drm_gem.h: add poll_table_struct forward declaration Date: Tue, 5 Mar 2024 09:59:07 +0100 Message-Id: <20240305085919.1601395-3-max.kellermann@ionos.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240305085919.1601395-1-max.kellermann@ionos.com> References: <20240305085919.1601395-1-max.kellermann@ionos.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E0F3E180012 X-Stat-Signature: 8wcx5pyczje8zii9skoonjsb8qzhfdhq X-HE-Tag: 1709629177-641758 X-HE-Meta: U2FsdGVkX18VXqJIGDqe/y1jPd5TmsHhWt59mBciWSnT7dH+4nBxltjDpqWCxMHA6LuBxOykgQK0FKq6S5tSYdODAF8Dn435PulqNSnceAfwifPB20t1+GVJtILhsc4zSqeR2rgZ9Lxh2t3FYI/ucpWzrhNoqfeeFF2ZJDT8RxuktC4Qtwe6KAMtB7ydNG/GGCVVlzx5++8ZMNlnubzFRQAMD6LGs8phEVz1bkQcgNipAT4wEGjh6fg3l70KrWx8ai3eZrIV7mB8WMdsry5i2P6q08wnl3gmUAzR2WEM+UDv/xBQOsH6g99IS+uNwJ/TFgF34YNegF4K5HY52g5b2l5HdPW58fLOAn7381ewWz2e/Y8l8EJghmRdi3jtH9L4/eUxgSMe3XtX8GMc1OiZ7a42AMBpDYky+UTFPLxtwUQnLTBb4KQvsU1RwD2T/26EhB3OrFNFHDJ0CLceDXyZcswFYg/DIsrF3B1Lk+zEYF5FLh6tBc42/YE8pC8EmGRonKJndPAnd+1PIf6LPFwfEQD5KkEpv/sZBs1lUO96s1kzV0WBJB4kKOQ6TnUpDsnANzGw5NDrxSuUJaI/uHsGI/CwONBg8ShU/ugvOUIgGFd5VIuR6DGrcTGZlMOUtJPFYQaq2e8GwY98JZguK4wXhPxBiX41hAba/OcvvUaYIGCCi66G62zwDB9TFacQlupxje7za3mU+LRy0pdoG9djkurrF72qQDofsCudTkFjF4Tc9YTWGoLAnApTInd4ms+dEXyU2BLRu5uOtKAV8K5m3UXQh+0wuZ3usURR4Hzzyc0VWXnLmSqLwm76WMrSKi35rh31QRzgorPA4xVAv40zphniN25wpupCYRpd1OGhPum6Zm3FCfqsEO7XpTw1/fiEYaKpuPkBrvshNWvtCvaTPOh1P/0gaiY7oCXZr1OWyjZAjhBltNXm1lAahplGKuhC5CpqxQugEjMpIJo+crY cOw0eXVc Mxt9Sbp4OlAYkHlL3aWAObqthlkDEl7xbqeFdVnQN+a7xlPWBSSQwwljoMyrhOiny1+mEDriGvdzkx2stRDQsjwpSBFGtkNvX/HtowLqkopo/pN5XeNwyl3+hTq1IYukF1Lcr13gwlsA5LoQ4T0vnTGex2o6GJ+1xUrtkh4VY+f7Hh0M6cxCsO+yOlgm4QQIZBGC3IYYHuxJVeZc6GoNG5VmFhBCzSoH+m7NGiI785zctNbcrXIQqZK3xiPacvjw90nnOENsUKIH+MqauL/czEJF3ffgHGRRy99oUddJEN0flxlqgztj5J5eAdVey7owXtDM3ETrByS/mDSvvntOx6bE+U0+6S2ZzZzb5AYIl74qvfSoAjDRtXDOdxvwzi8esgd+wZq2e/muRpPZkQ5SW2VSzpO9CgOz/nWmWW8iPCPejbqJrqmz/c9A2tYZnB/Ha3zxWP/U6I9Rh2JA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After eliminating includes of linux/mm.h, the following build failure occurred: ./include/drm/drm_file.h:443:45: warning: ‘struct poll_table_struct’ declared inside parameter list will not be visible outside of this definition or declaration 443 | __poll_t drm_poll(struct file *filp, struct poll_table_struct *wait); | ^~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/imagination/pvr_gem.h:12, from drivers/gpu/drm/imagination/pvr_fw.h:9: ./include/drm/drm_gem.h:447:27: error: initialization of ‘__poll_t (*)(struct file *, struct poll_table_struct *)’ {aka ‘unsigned int (*)(struct file *, struct poll_table_struct *)’} from incompatible pointer type ‘__poll_t (*)(struct file *, struct poll_table_struct *)’ {aka ‘unsigned int (*)(struct file *, struct poll_table_struct *)’} [-Werror=incompatible-pointer-types] 447 | .poll = drm_poll,\ | ^~~~~~~~ The compiler is confused, and that can be fixed easily by forward-declaring the struct expicitly. Signed-off-by: Max Kellermann --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index ab230d3af138..f24ade9f766f 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -44,6 +44,7 @@ struct drm_device; struct drm_printer; struct device; struct file; +struct poll_table_struct; /* * FIXME: Not sure we want to have drm_minor here in the end, but to avoid