diff mbox series

[2/2] mm/kmemleak: Disable KASAN instrumentation in kmemleak

Message ID 20240307190548.963626-3-longman@redhat.com (mailing list archive)
State New
Headers show
Series mm/kmemleak: Minor cleanup & performance tuning | expand

Commit Message

Waiman Long March 7, 2024, 7:05 p.m. UTC
Kmemleak ia a memory leak checker. KASAN is also a memory checker but
it focuses more on finding out-of-bounds and use-after-free bugs. Since
kmemleak is inherently slow especially on systems with large number of
CPUs, adding KASAN instrumentation will make it slower even more. As
kmemleak is not for production use, the utility of enabling KASAN there
is questionable.

This patch disables KASAN instrumentation for configurations that
enable both of them to slightly reduce performance overhead.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 mm/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Catalin Marinas March 26, 2024, 5:34 p.m. UTC | #1
On Thu, Mar 07, 2024 at 02:05:48PM -0500, Waiman Long wrote:
> Kmemleak ia a memory leak checker. KASAN is also a memory checker but
> it focuses more on finding out-of-bounds and use-after-free bugs. Since
> kmemleak is inherently slow especially on systems with large number of
> CPUs, adding KASAN instrumentation will make it slower even more. As
> kmemleak is not for production use, the utility of enabling KASAN there
> is questionable.
> 
> This patch disables KASAN instrumentation for configurations that
> enable both of them to slightly reduce performance overhead.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
diff mbox series

Patch

diff --git a/mm/Makefile b/mm/Makefile
index e4b5b75aaec9..fc0f9a63a61e 100644
--- a/mm/Makefile
+++ b/mm/Makefile
@@ -5,6 +5,7 @@ 
 
 KASAN_SANITIZE_slab_common.o := n
 KASAN_SANITIZE_slub.o := n
+KASAN_SANITIZE_kmemleak.o := n
 KCSAN_SANITIZE_kmemleak.o := n
 
 # These produce frequent data race reports: most of them are due to races on