From patchwork Fri Mar 15 18:08:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christian_G=C3=B6ttsche?= X-Patchwork-Id: 13593825 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1502BC54E58 for ; Fri, 15 Mar 2024 18:10:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DC238013B; Fri, 15 Mar 2024 14:10:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 517B6800B4; Fri, 15 Mar 2024 14:10:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B80E8013B; Fri, 15 Mar 2024 14:10:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29D33800B4 for ; Fri, 15 Mar 2024 14:10:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F21CE1402FD for ; Fri, 15 Mar 2024 18:10:45 +0000 (UTC) X-FDA: 81900064050.15.487247C Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A530C0002 for ; Fri, 15 Mar 2024 18:10:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20230601 header.b=GZX1GCRt; dmarc=pass (policy=quarantine) header.from=googlemail.com; spf=pass (imf22.hostedemail.com: domain of cgzones@googlemail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=cgzones@googlemail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710526244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5vvztQ9R6kS3LLaEzPtb4PkQkdZH06n2URzp7Npwuwk=; b=zlpPqNQpxJp0RXwOY5jgsdeWB2pZo3D0XquGSg5HOHQ/nibetWTN28lMo7COgemSNDDFBz 6NP35IoXkSQWINXTfIV7S8V1ZGqGEq1mWdiUBfYIFs+qD5o5L+/nDys02cJdPHTtf+nc9M cpt0HbHRwu0JQdkhozAap+xSi9CQXfI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20230601 header.b=GZX1GCRt; dmarc=pass (policy=quarantine) header.from=googlemail.com; spf=pass (imf22.hostedemail.com: domain of cgzones@googlemail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=cgzones@googlemail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710526244; a=rsa-sha256; cv=none; b=ifWPaGnxQVINPpo73SycPKZwL2ZQ7vL0mzrj0D3fGw+p4v2iO1Ncan1E1+E1qVjHNcKv0H p6hCYnED7Mrb/tqIdzg6SIasI3UoAUKL2LyfVPeJvJIZaUP+gBC/EJPxui1QSON+zJO6os W5kilbYvRbvHE3udJQhKTpO0yi8ZaGA= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a466f796fc1so287583466b.3 for ; Fri, 15 Mar 2024 11:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1710526242; x=1711131042; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5vvztQ9R6kS3LLaEzPtb4PkQkdZH06n2URzp7Npwuwk=; b=GZX1GCRtrlrFKgmwhyV5GHgHflNIy43qo3v2Oezk1wFDOonsaJaKKMG9UDXwPHl70m kqeSd3Yren7udPqfmP2Xlqg6/wutiCsJkcU9b6NE3EbhoULcZr1wVNCK6OB9+vnky7NF Mu14Llbx+KswhPS+U5JN6tfknayxuOQV+L/Hv4VheYRuhu370Ac5O0Gs6hGS9/IasRjr hk+n7PkXVsrOYeuNdeMNicVjv4qUjA/o12QMdx3nbBQayv8B2PArUs39uIyr/P0bi5p9 UW+NzkKPUG+0gqkcAsInvABv+39IYx2gRy9y1JkMPdiI863awl01BaDyTP9nKSe0aF0k 0CLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710526242; x=1711131042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5vvztQ9R6kS3LLaEzPtb4PkQkdZH06n2URzp7Npwuwk=; b=awh1StTo5eRw8s5a6j2PrWDTvpv1L3eWo9qezDVDSXwpqmyI5ganFMK4le3ug//4MP PmW50fb+PzAcQLUsDzWrT/NG3E5s6He6kGFnIpNT34HXjGMEMfjuiW18ItM+krr1546G 1N1F+txPE13KkxNWWG3Bu5clgBGwObF7VCPZKxrquXiv5ck6g6X2B4RNQI+E/HEYfFvj WPKq8mlKbbHj7s5hf0AljgFcbK75qHMKGY+t2sT+FnmNEswUECW9JcrqZl56m9utsuUf lGWdoJZyDo0IWLv1YnB3RhXZNFpS+oMgI+4Ta3gkaJ3y88iJZyA0eTretTpIiHl5TVlM cAng== X-Forwarded-Encrypted: i=1; AJvYcCU+26jnibHcUmQZD6hozUpEuV79n6jl6qIIxWT5mbjdRy0s9Rq33TZVyagYMak7TjOaXmL+MPoiANihRsEwGF+01nk= X-Gm-Message-State: AOJu0YyZDZ8hV5dwUfgrmX+qDNBMWTf/fLrmSyjWKOQnNaFSLUdjz34U ei6WQ69WO5CNoqO6ppSLktSTIAEqehViOm83f6fRbDVdUEJGXJIP X-Google-Smtp-Source: AGHT+IGmE1hE7r5LCz1k5oYh5+BcCGT9TTZYLN0ExtvMuVZ15iQOYj4bzU0GgE1LYLz2d9qOed8Jmg== X-Received: by 2002:a17:906:7fc8:b0:a46:2760:3c9b with SMTP id r8-20020a1709067fc800b00a4627603c9bmr3360991ejs.34.1710526242402; Fri, 15 Mar 2024 11:10:42 -0700 (PDT) Received: from ddev.DebianHome (dynamic-095-119-217-226.95.119.pool.telefonica.de. [95.119.217.226]) by smtp.gmail.com with ESMTPSA id jx11-20020a170906ca4b00b00a46937bc44esm510480ejb.135.2024.03.15.11.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 11:10:41 -0700 (PDT) From: =?utf-8?q?Christian_G=C3=B6ttsche?= To: linux-security-module@vger.kernel.org Cc: Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Paul Moore , James Morris , "Serge E. Hallyn" , Khadija Kamran , Andrii Nakryiko , Casey Schaufler , Alexei Starovoitov , Ondrej Mosnacek , Roberto Sassu , Alfred Piccioni , John Johansen , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 1/2] lsm: introduce new hook security_vm_execstack Date: Fri, 15 Mar 2024 19:08:48 +0100 Message-ID: <20240315181032.645161-2-cgzones@googlemail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240315181032.645161-1-cgzones@googlemail.com> References: <20240315181032.645161-1-cgzones@googlemail.com> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: amgo9hxqa4rd3rsqerjfe53srcrirb95 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0A530C0002 X-HE-Tag: 1710526243-979330 X-HE-Meta: U2FsdGVkX18fysRcIuMOMp0s7/7JMs3M/hTLtO2cDW40tClka9vveYeiLKyk0AZd3J5t9N/sISy+/aHFWVHwKLRlk0ckKnUDJ8bExIEQ57E/yJitvUlgX8maTBnO6jLrBqefeV7dpZt+FAaXyGS8t0Ljn5XM8PLcubqqqD3xNfgvjOs/tAw9xyUejR39gi+8RHxK7Bh5qXNOOoY+MqUkr5gkTBQkItOeGFfXPuOb/G4TCXJB5S4z4CugokZ5CQhvG9U0kA4oYW/WPqbcGFkiRfyQ2Y74m0Mddzym8PltRzwwYCoIVWzJAra7AX2gZKs0tB/bJcPDTwp9cG73+CcRKsaoMuJNANXQOHkg0tbtUQlwpS5jCSmL4gYsk+Iz8ijIb8fyNgHWnqmITs7c2ZvwWlwSW5BnZUzYeozGvrlPpEqwh6tGmMD5CrmAcGINrfosjncQnM9ZWlMC0GhUDmgqlzBVY8TaeMqbZg/NUljp3ICSclLEhNJak6wr9b/H7na/9xm7nzd4eZcU7WmvKzyu9ijlQcV0/sx4rx3nSWo7Nb5Qx/ATDAalGXGnwkTa4QCSNyHA1PnlOWzHlF+m7UALFxnvYUca99sPLf/CvSJz4xii6M3ALyN10Ih3b18wRQRR1WVWVMdTOFvQPvB0sXW+pgpnHNV/Q5wWgkv5Rdz2KNtQW92iX7DBoZI7DOXfSTCo18zA7Yv3ziItTVsHI1I0YhCBeP8XEJeWfuPFCfZslkbzTTfqC6Et5HjHTCgAo1iSOWoTE9gadVv3uh+gXvq/J/u8bNkJ7XwtOtYIVRKUb44JtagpZ4NbG7Vs++QH0UPOpLEd4tapi897G9nhwjo/WR6iqOX8U2rQ+DjtZtYA9gIf5Lo++oe1Wwogg8x9Blws/Gwx0O4J90jt56u9qSnaTlyQo+5ZDIe2gRBB4QLLvk+RiZHhU8v7KH82ckTlmVvwIjF6MWwzeJOdBXorO41 /Ke3hjqT jIMFQevPGVlqi9PydBMYT8nzlUzB653MuF2effukGHXkiUeOjnbP3yhtFclr4lWnWXJGcwpJaNBhr2b56dn1SVeg3p6VQixsx6Vw/g3PEvqgmnV0ERn71/pAl8ZI0YgrdYlrmzA57cM7SfWox4xgK3hz1cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a new hook guarding instantiations of programs with executable stack. They are being warned about since commit 47a2ebb7f505 ("execve: warn if process starts with executable stack"). Lets give LSMs the ability to control their presence on a per application basis. Signed-off-by: Christian Göttsche --- fs/exec.c | 4 ++++ include/linux/lsm_hook_defs.h | 1 + include/linux/security.h | 6 ++++++ security/security.c | 13 +++++++++++++ 4 files changed, 24 insertions(+) diff --git a/fs/exec.c b/fs/exec.c index 8cdd5b2dd09c..e6f9e980c6b1 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -829,6 +829,10 @@ int setup_arg_pages(struct linux_binprm *bprm, BUG_ON(prev != vma); if (unlikely(vm_flags & VM_EXEC)) { + ret = security_vm_execstack(); + if (ret) + goto out_unlock; + pr_warn_once("process '%pD4' started with executable stack\n", bprm->file); } diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h index 185924c56378..b31d0744e7e7 100644 --- a/include/linux/lsm_hook_defs.h +++ b/include/linux/lsm_hook_defs.h @@ -49,6 +49,7 @@ LSM_HOOK(int, 0, syslog, int type) LSM_HOOK(int, 0, settime, const struct timespec64 *ts, const struct timezone *tz) LSM_HOOK(int, 1, vm_enough_memory, struct mm_struct *mm, long pages) +LSM_HOOK(int, 0, vm_execstack, void) LSM_HOOK(int, 0, bprm_creds_for_exec, struct linux_binprm *bprm) LSM_HOOK(int, 0, bprm_creds_from_file, struct linux_binprm *bprm, const struct file *file) LSM_HOOK(int, 0, bprm_check_security, struct linux_binprm *bprm) diff --git a/include/linux/security.h b/include/linux/security.h index d0eb20f90b26..084b96814970 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -294,6 +294,7 @@ int security_quota_on(struct dentry *dentry); int security_syslog(int type); int security_settime64(const struct timespec64 *ts, const struct timezone *tz); int security_vm_enough_memory_mm(struct mm_struct *mm, long pages); +int security_vm_execstack(void); int security_bprm_creds_for_exec(struct linux_binprm *bprm); int security_bprm_creds_from_file(struct linux_binprm *bprm, const struct file *file); int security_bprm_check(struct linux_binprm *bprm); @@ -624,6 +625,11 @@ static inline int security_vm_enough_memory_mm(struct mm_struct *mm, long pages) return __vm_enough_memory(mm, pages, cap_vm_enough_memory(mm, pages)); } +static inline int security_vm_execstack(void) +{ + return 0; +} + static inline int security_bprm_creds_for_exec(struct linux_binprm *bprm) { return 0; diff --git a/security/security.c b/security/security.c index 0144a98d3712..f75240d0d99d 100644 --- a/security/security.c +++ b/security/security.c @@ -1125,6 +1125,19 @@ int security_vm_enough_memory_mm(struct mm_struct *mm, long pages) return __vm_enough_memory(mm, pages, cap_sys_admin); } +/** + * security_vm_execstack() - Check if starting a program with executable stack + * is allowed + * + * Check whether starting a program with an executable stack is allowed. + * + * Return: Returns 0 if permission is granted. + */ +int security_vm_execstack(void) +{ + return call_int_hook(vm_execstack); +} + /** * security_bprm_creds_for_exec() - Prepare the credentials for exec() * @bprm: binary program information