From patchwork Fri Mar 29 05:33:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ho-Ren (Jack) Chuang" X-Patchwork-Id: 13610117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A789C6FD1F for ; Fri, 29 Mar 2024 05:34:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50DFD6B0095; Fri, 29 Mar 2024 01:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46EAD6B0096; Fri, 29 Mar 2024 01:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30EB86B0098; Fri, 29 Mar 2024 01:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 160BB6B0095 for ; Fri, 29 Mar 2024 01:34:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7A61B1211D7 for ; Fri, 29 Mar 2024 05:34:04 +0000 (UTC) X-FDA: 81948960408.21.61F65FE Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf05.hostedemail.com (Postfix) with ESMTP id A3C97100008 for ; Fri, 29 Mar 2024 05:34:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="W/DF+CKD"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711690442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=cwuJ7rBEdbjfdsj6X3oeVE6+xMZHpgnSgTY8Xgp8Vd2F/0IldDEaQOTcYr+qiiKwEzYDkL axtYJ/xzZM3drPUzz5b8sHI8MpXeukR7yqix8rU3XcNcNVUvz7ruolhRcjeQRtjKw2+ae5 W+Hk0jQdAmfikcklwAy3kzqYPs8lJkA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="W/DF+CKD"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711690442; a=rsa-sha256; cv=none; b=Xmgic3eCEawPaUEcTt7vLUtOoTPJ6A/MI3BMQ8yaVyj/4rgnSYA4b5jU+1W+iI/OR6jj9+ qCksPSQNOu5IRe7yusdIn0iPra2EpOHlMr1VIrfeCpcypcUtGcWvjJ0J0f1bVIkLQsRlme SolP9VgE5pzBy8dkbpWUexI+JORxMnM= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-430c45ab240so10249011cf.0 for ; Thu, 28 Mar 2024 22:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711690442; x=1712295242; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=W/DF+CKDrc/fcl8s4R4OZq9U1A1bHmjrA5s6TiG6mF/qvI9NZXb+etzwXaz0M3NKAT 8KYtkWZaUH7wpC5ZLJfNocntCnq6FY8MgE5qJt+w9aHeT+DXwwKObFtOyogqkjf8srOf J1Y5yv598YiQ1f2DmDP2ZfdpcTAqML4ZOr6t4bSXEApJeyG4+renYYAXUr6mCxz7EzQX MQn8+RrotANW8EpK05TSe5ya9M7vMNgPtE6z64iC+gj2jbKRug6MOjUZbNVIl/CzNtky LuPCFtg/ngQuIIWcIK8Olj9rEs5A3C7ArR9Tk10Y8asFLCJI+ZqUOJUmeY+cEKBhIHG/ 2TwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711690442; x=1712295242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=hTr6fcWwvdrQ89yCN4NYFnpph2Rb7zLCbxjup7gR7sY6MSntntu6kfoJQyLgwiPOt0 Q3YvBxpSRpj4cUvd26q9X2d2VrdV1Su33ruEmb3Eq46xzQSUgx5nGRQAJ7pUzpwIXeZC xfWuqFNPDdRrZZ809tjo0wF8Uj9EQzVBiVwTSyOSeH1Hh2B1gDr0XY6hFoBijWvxPXXa g8Kzwb9S5FLlUJRvSxcATEMENHie/EEYyDbxyIYPrZKGjJ5y0a7s5cKtxJWokuyYboJz 5N6+gRdE9Y+oVVnNBQvIeuYQWczpjj1Tsj3gcu3a5noN6siN6AY6KYKUYMkVFXfhAfEi RuZw== X-Forwarded-Encrypted: i=1; AJvYcCWM1Bj6sY49ljIMY68y9qSBce4slGAPoNvPlLp5U5ZMs+Qe5eFPfnRPnaRPOqzPVhiue64doJQGZ84RIkz8QNLRik8= X-Gm-Message-State: AOJu0YxPYigi3xUWz7etWx1z+jut02ElEGKTyGh+qLYY80YHlZjZR41Z cROnBr5DWya0hYhSy2WeOS9EkNGaqp5SRFYUW0WEsxCi6dRpE5/QZ3nhJAcHr1g= X-Google-Smtp-Source: AGHT+IFNoqNydjaxWSpQbLOw9NSrhWxbMGVfkX5oUHJM8lI3o7LuokzE9FNy1hUFSqYBfeSHSyDMdw== X-Received: by 2002:a05:622a:10:b0:431:756b:c48f with SMTP id x16-20020a05622a001000b00431756bc48fmr1092286qtw.27.1711690441708; Thu, 28 Mar 2024 22:34:01 -0700 (PDT) Received: from n231-228-171.byted.org ([147.160.184.85]) by smtp.gmail.com with ESMTPSA id jd25-20020a05622a719900b00430bf59ebccsm1293700qtb.11.2024.03.28.22.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 22:34:01 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v9 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Fri, 29 Mar 2024 05:33:52 +0000 Message-Id: <20240329053353.309557-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240329053353.309557-1-horenchuang@bytedance.com> References: <20240329053353.309557-1-horenchuang@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: A3C97100008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d4ngqsy3epyf6k8d5a8a88z4osta5jfc X-HE-Tag: 1711690442-230935 X-HE-Meta: U2FsdGVkX19uYmriLFR/BlEFpaaXp61CO+3uxbJM1QE1A80gFU5twtmTb2fa0A28f2x4IAAcWnzOqTijpBQtUZgQzmlS22mW72Svjq5kFUTnnXSZ2tEvTMfNTrpng6R6C6Ttd8V9nbBEzNSu3KAF/m8A+qZ9Uz5Rj/fQRTr46fWGYsY+UOgRSA5t10BJzxRBRLhp4TnePi4mBhVG0o8rYLCUJfQL7vswFLXOjVu4xfgc5w7aogkzbGtrBCl7klrpTVe0xARWW/+F0lxDxJzszo94LZtiP13aMBipwbxXEDH7/73Br8Pp7nzUCSYDEIk+3v9abtro5oC2QbEIiYVlvttd77cRlLziKblXLe1yH4F7G+m+beZXyeqqy7lZKRNQ8mUuD7Hm+E7bBquI8dKCYRZDEHyXeHLFZqugWE+2w+0NUMXDqSYoMzUVp1VEO3EaybakM9FZ9NRqtrUewv2CCof1DfeELAWeRR0eMGrArm0IYKVz3QN1DxAnguKDz3OjvvDxPXeLijwWF9G9gFa9VBidysgsfuLF56U8uXp+aBsto1fzwCTInOYhNi33PUFoSjAIPEcGZyOtQ0STJe+WM263kxk0S9V5f1an+0Sh5i2VOvY//ViRe0Re8bpypd2jeiL5vRhPWWSF9kAT/KiR1YuGSqj3qc06C9DcCMt28tK1osfl5+PAEpxxEcOtLjcU0FlAf2Oe9j7DA8BPDx8IItqEiqu3WfZfeCR/05qzqyDutUKi2/wMowZ+U+FMH5J1yaIbWzWRCP3TrhNbGd0z9Uo0G/SysLZAuog+GGBAMQxn+2aD2lVxKifnE3EqJB9KScMd+aAPNVmE9mOXLQAPg6avNHCxXDuULXf+BPdQkni0TP1U7mwg3Es2ARJeG527OqaxftMlSKafOuDuMaTSQlxank7St8QAOgYLs59ZGnzBfHGiifsPuz9Cr53lpkNB7CyMBaaIA/JYaOQ9Fmk hFfqjc3n VzXqJfa2vNrHR6S7CorM17g3RGWt5jnFPDmXcmefh6wF/ZoN/FY4XXZlc8ALHAO0VzVfq3MAVKzf857kn2uI6NSrdSKCo8Xy3RRI4HqK9AMCHt2U9Wu6UG3sN/Rn4sTiwVg0EdSVU7zF4/uO7WTxy9BhKALcS9tJ25oW1qS9kfCfCIzhNCHIywcm1DlSca0dmCQfnVXkLlQk4k3Y6vxINNlfwh7G0h00qmFpynBLyFNK4MRW4CLKRpitgEuzEhh0X/rS+idwjIzEHsnvO/NVaOGfhjy8C4/8vaMpsB7plBDxrm/sMQ/QcmDVZF7C90Y3oLoZwPxAjcaKsOFLsqQVyyVsY3nkUCvfdcjrRJorX/hbwAupzCVCvRUnNGPKzy3WaEyA6IQQrW+aseNFp6dsa/+G3cKmv0tfkIqIn2Tmy3A/jrsu62O4wBrdTiJXH1kEsjtyCbF3+Lf9mtsDOzgsYCgBcDYZEyeT3wmIHe87FtvOMl0c+EtaczTK44dPf48PBPfGd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang Reviewed-by: "Huang, Ying" --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; struct memory_dev_type *mtype; mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype = mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + bool found = false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance == adist) { + found = true; + break; + } + } + if (!found) { + mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info(