From patchwork Sun Mar 31 02:19:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Song, Xiongwei" X-Patchwork-Id: 13611789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CDDCD1288 for ; Sun, 31 Mar 2024 02:20:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D16816B0089; Sat, 30 Mar 2024 22:20:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9ED06B008C; Sat, 30 Mar 2024 22:20:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19D76B0092; Sat, 30 Mar 2024 22:20:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 888E56B0089 for ; Sat, 30 Mar 2024 22:20:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 55877160696 for ; Sun, 31 Mar 2024 02:20:04 +0000 (UTC) X-FDA: 81955729128.21.7664C91 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by imf15.hostedemail.com (Postfix) with ESMTP id 44C60A0003 for ; Sun, 31 Mar 2024 02:20:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=windriver.com header.s=PPS06212021 header.b="sSAxXW/v"; dmarc=pass (policy=reject) header.from=windriver.com; spf=pass (imf15.hostedemail.com: domain of "prvs=48209d7d2a=xiongwei.song@windriver.com" designates 205.220.166.238 as permitted sender) smtp.mailfrom="prvs=48209d7d2a=xiongwei.song@windriver.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711851602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2+C0G4UMINVUvGYbirPlCl5FdouMdwjB+cfew6a5HSU=; b=tRGz0q123i530HyuHKZQjlB+cutlkX7h0sCNSDl+wZaE3U5OHUbLwCCHwbbg2ZuHg+1/gC wHwA4oAWRqHf7IZeTr/NIXLSbKi2GLlPVVEOxGGTJRYyMjuMAfOneu2RHKhKGPc/M5RnRB p7bMDHdUpkzhXPLy3HcEY3p9DaFgxMk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=windriver.com header.s=PPS06212021 header.b="sSAxXW/v"; dmarc=pass (policy=reject) header.from=windriver.com; spf=pass (imf15.hostedemail.com: domain of "prvs=48209d7d2a=xiongwei.song@windriver.com" designates 205.220.166.238 as permitted sender) smtp.mailfrom="prvs=48209d7d2a=xiongwei.song@windriver.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711851602; a=rsa-sha256; cv=none; b=ZXjCzJtOOeEow07S2aQFJR4Pe16YcO6evnhcb15dvq1IqnpfCXmlIeahIYFrIW1fuhnohK 0cL/uXbWsqISMEA1nfnUdsD1NUGfh0H1jE5/wACHZPOoHJVMcafPGQxHqIvdqoIzOlbxDR c+sEI6vmyVKT9HZcnsF7eMBVlAXw6mk= Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 42V2ErUB022442; Sat, 30 Mar 2024 19:19:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=2+C0G4UMINVUvGYbirPlCl5FdouMdwjB+cfew6a5HSU=; b= sSAxXW/vj4FqFQfKPs3OceQDoGWqXNT7bQyhdW4uLTQlGimBtrWTjytPKSxvHgGh xniDw9B7CwYkFhvofNo8KXUT17xWwCREDsr+K4OaRV9e/JhncU1YUU4K2JrRdlGK 8NigrGt9fmFh6oNH5yVjftVou64QX6jAiIrKOzjB2ZXb2laK0qlcVxSNVnPfDOWM n69Xf4M+A3HZDaTEsd7gGPTiFae9vKY32tkBjQEhL+wmlfSPq2uISk4k6V1xN9rW NYkfKgwnSKh+EJ/rdCgTR4wxJYVQ0PCSm24Y3kscBEdrXFXVduwlPLGzd8+gq6gR jj6YdQzqbQbnlrSuS9roxw== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3x6e10gm3s-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Mar 2024 19:19:49 -0700 (PDT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Sat, 30 Mar 2024 19:19:44 -0700 Received: from pek-lpd-ccm5.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37 via Frontend Transport; Sat, 30 Mar 2024 19:19:42 -0700 From: To: , , , , , , , <42.hyeyoo@gmail.com> CC: , , Subject: [PATCH 3/4] mm/slub: simplify get_partial_node() Date: Sun, 31 Mar 2024 10:19:25 +0800 Message-ID: <20240331021926.2732572-4-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240331021926.2732572-1-xiongwei.song@windriver.com> References: <20240331021926.2732572-1-xiongwei.song@windriver.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: axzpVre-xU6I8oY8XQ3o9V6gU5HlFFCK X-Proofpoint-GUID: axzpVre-xU6I8oY8XQ3o9V6gU5HlFFCK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-31_01,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403310017 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 44C60A0003 X-Stat-Signature: 3pa46wmfq3awet9ts4yycznxayzo94ik X-HE-Tag: 1711851602-791968 X-HE-Meta: U2FsdGVkX1+lVrJRjKTKDdXS8IrU3LhZQaFxmGucGFx6sWyiMTwCuX8hqWpge+m7Vbx5rq97PABVh27EioKWYGqz2/xrhC0tNuuvSiekADiRUv8DJ5e9LQRUH4KoQfgd2LD3xL/cUxdPJfFfeOjY5wYcI7nHSZ0NRescNFCVqQYlQnY/OyQXILMDELomdI1EKFkx7xwPKcLZVegivF18OLf1JIcvAmisaidtr2PukMSVJa3UnznkFU5YpkJDgl18KrJZEPFDPT87vYdkuSyiF0e35qFf3Mpf5ByuZh1VL+MLQLcm6LoG0fQzM3dUIG2FXmEj+hn5A5Wd2z04KO11LKW7OsQTECoNMJ6FKLTg+Q7rfhfGzJdkW7vFxgpGgHlwuputBO6qUbbGbMrpFA14ljqaY9LLcOX2slmCM3a/CCdEVv4Ax5Lfd66gdR4WN1VmefBF2iIhcBCraS/7JieT4FHuBsQpXamVAW5SoiRxPCA/YpO8ERTBGEPgnzdOezv3VWEhOe+829e5ev4sDCYbSilkiPh5oCdbn3wWAR6cTKVE5fYY74469DRGZOXlrNhOV0OOoavFoCJVmD3Txprwlz9H3TC6YZe2w38F+fxrv5NcwQO+XcTyFx+VaCK2ytkJdksk142AroGzausQ7cRJtwSut40jD/5I6le+1/jEKBW+H41PIIjgOpBxuTtypR4nUPhPsSgbDZTogsMFxABYNZbSmrzjD4itgfGhToQbO9RPh9mg+gZNmdKEgb5NgTrSTVlLRjRzexJCbYUjqmElwQTaNcXnC1sQg8SRAEzeGNdtDgX7DwsaG0Jiwm2alprcgetvZyJiDXtrG87mgn2M1Wnd4QQkDBF6RD18QHdx3Te7c3oY5VoweyPHZ0dR0vjiMIzUyL725ST2xzjoN2kGS1kz0yk9sR89FQxuAKRuYew6ahNQEdv0equO4UdGE1f7yuFcyC2SQKYeEpFM7lq zb4BueJj 8QCMmQJyre1oPhcEG3Rixtb3hnIN+aJABZ04otYIRZD10NEKAthAuzHfti89DvqaNte/z2kNNcaKH0N5S6d3Y9ArwaytPkA8B5Yg71Rn74quJ+/IHF48j5BC/MSfrLABAMmBAMTOaSKRZXPsCnq8MxhieEMZ8bV+dpLe63Iobp5PoAXuqg3ayoAKy36iOaMHUlI5dkltcGfUoa8xqPBC0G4cGvkFWbV3Vlmj2IHgmb5eFkRReRR5ByMUvyLCgwcUd5ClYsHwri1OlCmkaDIA996naLNMNJq77c/6trPEhCdkvhUpC6tah7jhwrDAOSN/2/9ll1hMkbT4If5gSZDS6NMD1YaGAj4cKAV6JLPf7UnFLCOJoxurOzaggQSbdxRFFVqeOyNiwqsHE11VkCgfuGew4BCcOOS76LaDthKuNe2gXtROApVM7IHH68SLayFgec0ODDJ56uSm8cGj+fkGJ73tQeylF8vMbb1JijZhJWz1WTyJBEHkO/JMemXz37JfUBLml X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Xiongwei Song The break conditions can be more readable and simple. We can check if we need to fill cpu partial after getting the first partial slab. If kmem_cache_has_cpu_partial() returns true, we fill cpu partial from next iteration, or break up the loop. Then we can remove the preprocessor condition of CONFIG_SLUB_CPU_PARTIAL. Use dummy slub_get_cpu_partial() to make compiler silent. Signed-off-by: Xiongwei Song --- mm/slub.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 590cc953895d..ec91c7435d4e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2614,18 +2614,20 @@ static struct slab *get_partial_node(struct kmem_cache *s, if (!partial) { partial = slab; stat(s, ALLOC_FROM_PARTIAL); - } else { - put_cpu_partial(s, slab, 0); - stat(s, CPU_PARTIAL_NODE); - partial_slabs++; + + /* Fill cpu partial if needed from next iteration, or break */ + if (kmem_cache_has_cpu_partial(s)) + continue; + else + break; } -#ifdef CONFIG_SLUB_CPU_PARTIAL - if (partial_slabs > s->cpu_partial_slabs / 2) - break; -#else - break; -#endif + put_cpu_partial(s, slab, 0); + stat(s, CPU_PARTIAL_NODE); + partial_slabs++; + + if (partial_slabs > slub_get_cpu_partial(s) / 2) + break; } spin_unlock_irqrestore(&n->list_lock, flags); return partial;