From patchwork Tue Apr 2 00:17:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ho-Ren (Jack) Chuang" X-Patchwork-Id: 13613186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA8FCD1288 for ; Tue, 2 Apr 2024 00:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D6E16B009F; Mon, 1 Apr 2024 20:17:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 938266B00A0; Mon, 1 Apr 2024 20:17:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0EE6B00A1; Mon, 1 Apr 2024 20:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D3B66B009F for ; Mon, 1 Apr 2024 20:17:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 185B716085C for ; Tue, 2 Apr 2024 00:17:46 +0000 (UTC) X-FDA: 81962678532.14.DF76F12 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 77B361C0012 for ; Tue, 2 Apr 2024 00:17:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jIcTvCpJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712017064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=0iOcA8DNHtU9K6a5Z64KnDcRKEbKGHiewMFWzS/EYlH4kITew50XBbx9PKucJsrvysAHVq HMropAJ7uFrNCM0HmQAcrVz6GYpdKNtDCE1CLhfhr0diHkQ5eQ2dvEjqDzSmx1m821TEnP 5T1tIT2L9Qa/K7my1FgEDafcQLwPIsw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jIcTvCpJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712017064; a=rsa-sha256; cv=none; b=cLSYaDgLX+kI0ZCbue5NeBb9MZYt2TRpaLPC7mrxb8IeJmH4aSSR1sj/IjhR34hCoutdQK Rm+iWq+Go3EoxlmYtdWP/mytasI1aJ7bzof1AFzwnbpggoc5JvC5N3X1DKMZ+piMxxXYgk hObeMdcM1HkyBAvJ0z4iTVz+QhkxtZ0= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7e0ae718e36so1376097241.2 for ; Mon, 01 Apr 2024 17:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712017063; x=1712621863; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=jIcTvCpJ3LsDOJIga3tG196VHu4gsVzeqQ5kQkw2KllrJf3jefSCdRSKJGNkCnUSH3 CEM2Z5EkaXjEWZSOPd7YG99f+NgCkeVYJ9uHHwj/aTOqTfLnchDLFPucYkt6Tp0by33B WQcy530rvHS2KIVFDuxjXJgDXcsEGrIULw89D1WXnlHLkiFdBgH3XjwoUw4OK/rGifRl 3YfNe9caoyFqHWFNaT8X4/38ftferhwNWfNydRjxC+7+KCVVxp+2LMTelkRqeRrIM93+ LvC7ZHin7dLBxiRM9kiF7VQY5R1SBkcFJlwG9DFDMWE2FMPbRLAme+rMvVYTQAt4hoNS zAmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712017063; x=1712621863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=PXB9rlnZlsmJTOOeymMxydDU5vdJpPH/QjiPClH899i6o4dXKVqYHk1M63yDQXLscE te/1C4L/mP0EfOeLBCzph8yP+2zlueSXcJoBqKABcI9FF2RmXLx8gnel2+9DNnpCCITa YBuWGiXsFNvnFK6QSJUmdJafKAnhnyegPL+89vOPmkTC9HMITHxfWC7rl+PVErJUD0u5 h1J5rx7M9UXHhCgAFLx3RZksW5TWEKDZeoWf4l44qrUnkmC2jg3DxPehhBVwWap3JhVl S7kFpeOP9I4ywnGSX0ChgMO7UWoJZxke82a4C9L6FTPxpGV+ssDtO+SmmaCvPWa5d70v eC/A== X-Forwarded-Encrypted: i=1; AJvYcCXQFx3M93gsTvTN9VEuGsWLTbesP+NuK8KKbEbrIbK9qSarsuNjHXVV7+LsSNStg2Cod9aISiGjmZZRRA3h7KyOK/8= X-Gm-Message-State: AOJu0Yymyj60mZkqsLy4V4onPUNHnYzZmTTrUYeq/SumVfu4vM2GdLOM ACHi165+9m0IEXZWcTe8T8+g8SHlxC05SfSuU+Kptw0OWobF2Wx+lQDfnDZAwx8= X-Google-Smtp-Source: AGHT+IFKAc3hYgC4iDc8epxfwQKN8USKmAQhU8ZxSXJUvVeCt1lZzEZqTAGJQdv/3QSxwj+j4d4QMw== X-Received: by 2002:a05:6102:4a11:b0:478:52cc:fc42 with SMTP id jw17-20020a0561024a1100b0047852ccfc42mr8638750vsb.10.1712017063419; Mon, 01 Apr 2024 17:17:43 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.125]) by smtp.gmail.com with ESMTPSA id e10-20020a0562141d0a00b00698f9771822sm3013112qvd.83.2024.04.01.17.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 17:17:43 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , "SeongJae Park" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v10 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Tue, 2 Apr 2024 00:17:37 +0000 Message-Id: <20240402001739.2521623-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240402001739.2521623-1-horenchuang@bytedance.com> References: <20240402001739.2521623-1-horenchuang@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 77B361C0012 X-Stat-Signature: 9khctg4pdwb6oonw5k9epiozdwcoanas X-Rspam-User: X-HE-Tag: 1712017064-525649 X-HE-Meta: U2FsdGVkX1+AQlp97zCfYwe7byqYTMYtFVazfqWidwozlIg8+eE3dR359yLOMeG00FxuAuEeqTIKhCGku3kXrBBeuJa/+EwR1PyMudBXqBj/1EFSkqbYLONuJB1ewIMZUCPBvwTgAN1nWuQEwQ1i73UWvGhgJk8ykm8ApMS/oTNglnuKQ1nleTieBfce3f0rrCXW1eg8wlu6qPcPyPqnOYr4xazkITSbY/Gb3xNeIc2uIzxnF/wqLbUEH6dYw2nwm9TkewbtfXT14NwV8BPlmruk0antwU6gy6Da20tebeuzXjwUyoL3BKAmJB0l6cLkZyN15LbuA1oS1pQ19DYzMbaPGO2AvHyvZfC7hAJ/gE3z9aVNghi9TS58K2sE2KeElL6jtdPjFGZqwrJCP/GsEaoMtcBSJp7NEwIkhAGZKRznw7wY5t9LFzVfgT1uGZuVGWVzfqZg/IL7Hki3NHPd8MwUFuGBiYsRrUctDVfc3IRejJrdXNR5UozMZ3+ZutgvqKVPdNmmZgn4Ojcidmna1kWoQaacVS5IqGyzz+ZIXfXXXQuKJDpBkWNXeyX/+ghFZqik7AkApMbwirK+pTtSm+yQJHjGfqljApxlupVWdFu2h+fw+Wll99ClZGZwl9Mkun0zmmmpSfskQ7viVVZhC0I0T3X6BIw3t5cvRZT4FTTjliGmMiZF66yMPa3zAGUpVSF6sV5FCU/r9TOomLiprPNYC4attD4Ag1q4nyYweuLthPsDfVHWTX9jGVtRrhfE3OxR+uneUp/TnM4NZlzTve8TzagW3IgqqPPqEOXLdCQ432RxlF9OonBhhduGLA+JVWzuMlDUv3Ndd6YNKfYcpDta4qv3LWw9/O3f0DOAqc/fNusPWjTFwW+lToWb5lbhWskYxou71hhdy6m0GaDioduRIP7si8LBkzxHRvRAT/djIR9ExPthylQzkhXdo9X9RE73CMnoHtQQtlQ4NQk wiYU+PMN UkiZulUTCzA4vEk+IVeXP7DxohCFKOc8YTK95F+t3OjRwIcIjq2HriyCEQAA36OI0Zo8etjDvctdJNF5jT6ubT0rcsSeFvFi4U+CFhfDXa/uQc3ms/hTDeRa4pnKqF4YxCBKUPX1cDeAmN+PJEasW1Nw2nypryvjUOEj9Nf9J3h+tC0/k+zNK+8VS5HCZYbfgZPmdZRwtP+qBtzllUwGd4T6Nh2E99jl41gV363iToo/vKXtuNa7lkqRmApaumQtAzbdLImu3K5Ikqhi4Nuos9/kvXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang Reviewed-by: "Huang, Ying" --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; struct memory_dev_type *mtype; mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype = mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + bool found = false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance == adist) { + found = true; + break; + } + } + if (!found) { + mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info(