From patchwork Thu Apr 4 07:26:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kasireddy, Vivek" X-Patchwork-Id: 13617391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2C8CD129A for ; Thu, 4 Apr 2024 07:54:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265EB6B0088; Thu, 4 Apr 2024 03:54:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23C956B0089; Thu, 4 Apr 2024 03:54:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD206B008A; Thu, 4 Apr 2024 03:54:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E4A356B0088 for ; Thu, 4 Apr 2024 03:54:34 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9C0971C1207 for ; Thu, 4 Apr 2024 07:54:34 +0000 (UTC) X-FDA: 81971087268.09.C875433 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf25.hostedemail.com (Postfix) with ESMTP id 7CF79A0003 for ; Thu, 4 Apr 2024 07:54:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V7W8pv+i; spf=pass (imf25.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712217271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=spsxjLz9xHahODsx9a+NCs7hmIV3g28U1Tck8A2bWsg=; b=WYqNuXGJr2FGw+v6bjKEo5oNI9MbnZmSYweH/Vsw1wY50XSKWkt+Jw8vIrqFzINgXWtzXf /vtbsQT7AqR4sAJ4NYjUoJl2uNWB0Gm3DaVKdhOPOZp5aEwXi9Ib9mIerG8f1Tx5uAXSIU c/7fI+CS/sf9rrhyieXjepHWoMjWFq4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712217271; a=rsa-sha256; cv=none; b=JQsLeH/sygnuYj+6eheS84cqjPUz+G3C+bDMWWYA0JQjgOPOf6IwS6NjGjH167nb1UpKSt Lu3K1pI5Y4L2eLfjpAr8+SLkruq9w8R3izLz+8Ry9hq2R3X0DpBxHPVlQjhv8LRy2vZ8+j 5xmnm36lFLH1z17tZ4zOCNonKMpXQO0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V7W8pv+i; spf=pass (imf25.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712217270; x=1743753270; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PGtmtG3VhMVfYs+DXUcts3PKnWJf19JlGtMJ+EYjTaE=; b=V7W8pv+iLbopJkiC94kX1YoscQk2qGEmgJ1IU17+OzaYzT0Tad5UJGm+ b9tXKRDLtX2ha8SfzbPPvDwaPk63V2OCO6kSWhfcXeEnm9Fh6EG7OX961 N5EEc/uYoRWXQ9m2DWiq2DAYDjr43vqKotfgT3aauT+tqD83sYKQJCi1P bm7yejLMEAvu5LpSeqeMSjM68fVsTNdkv5FiL1vxiuzzTKGbYPyuY0Ugf Rm5yLoSvapHQbJSwL/J/ebV2jke9Xesi1PeDNQhg3uI3H7NzB94/FINTF n5UnNmTSghwFXHv55nQGj3yQpR5ZGjF261Jp8yMe/dGLbNpiwdvJEXDfu A==; X-CSE-ConnectionGUID: Saqp0m9iRm+scebZz9LZ9A== X-CSE-MsgGUID: uJW/GLvzToapkJR4+jTMSQ== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="10450776" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="10450776" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 00:54:26 -0700 X-CSE-ConnectionGUID: nPEUM93hQRKwVvp9iZMtuQ== X-CSE-MsgGUID: Y6t8X28USxKSDeB5/WokOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="19298756" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 00:54:27 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Peter Xu Subject: [PATCH v13 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers Date: Thu, 4 Apr 2024 00:26:08 -0700 Message-ID: <20240404073053.3073706-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240404073053.3073706-1-vivek.kasireddy@intel.com> References: <20240404073053.3073706-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Stat-Signature: 4spafndifmqwwaykfc8mhta1tbph8qjj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7CF79A0003 X-Rspam-User: X-HE-Tag: 1712217270-727647 X-HE-Meta: U2FsdGVkX19wDusa3JNq034x0X+vbkoL6uGEA5mWlLg6D/QEjynZtcRIrxb9xwvhoCfajKaFDtxaoprNtyOVZHmDL1pZ9vghrS3RO3a5KiAPPUkIoWhTlvRX2d7ujBZcP7CrNZEGPr+gP8eeStudEFGRGbJs/lk0GLXcqwSdFUi5DJ/ZUoXQ4njA7reRz7NYm9WQkSpSJRfR6wr0vSYoZFhu3apGoBLHNk+IkRmYV2e/EhXX7bvn62AfvTYsYnSZuDFOypNl6MxgHSA+A0pUuiMo6IJQYDm53EdjQkz7/jvbuBBhsdRVPAEpG+eQrncK35cl+Gb6Sy6RKnFSfdVqedlQZISq4H3C8e+3jtw+qaKa6diAdgIrwYytxNrM5XThVZaFPJbNxu+p4RhoCIND3+cDnGsrzpb/Uvbc0Zx8L5xReD6iTIqcgvyu4I0tmm5GmMNVmWHIvKRBToA7Nj5GvddOsZmoIzVMjU01KEwcfiBcqCqdX/FHbZfQfn8NEq4IHdezzfe4rE0A1GJgPUHKch8AtXZbcZ+ROMONukljCjNPB2TcqzRTGUE+e/NfSj7qTPJgtdhP6ml1eB4bWEI4vcu+Mz/rl2rFMWNHgg7MsgPQ+GQJ5biP6lqQwxILkds+G5MUAy1sN6OG2QjYRuV6WdwT1TTa4VRqzhIdj3Qjo8NstonSn06KwbKjQYfolGIpw2nss5FlnejgeDPUDMcKCP8jExh6TQDWcVG9bYiWhAPQB4Uj6YkZF4U1i7eaCFMfxY12+tK6RxtlTNJbHVOakFC4FN2vq7fpY8CEVDZr9gwxvw+6HncBLlcNaiiWdaV6jK5nO9wtAomZ3AJ1yetsobXhtGdDDcpbTSaOe4RzrsmMdX5ZgF/OS94VL/X9EoKl+Ldt70DykiQGUJe7r/mzW6qlUbiOZk66jmQNVkGKaiSUjQ938gWD44Q9ob4aGM3Ns+LYA2abteAsStzbVNc 8/v4J/oM k5F2OaealymRAqI+WPKdiuDY1D2/ZHcG+9dY7La58ueLwpqI7mr3t9JJbvBLz9j8uY8ZnbRJ9mFvi5cKjhp9wzJnjYqITHtoFWQO2duj8Sn7FUC6fOZIeVg3q775MaakQkGMrUX1cxoa0FXi5sZ+h5m3kb3SDskWwldOYGVpoZrXdsVMcbVlO/Yu0mxvYhGbXXihAppZN7DAEPpO4aTdqEY5YREdooac49kZI/3xov/hrOGDSmCiU2baHSg+bI0fwWW2hULU2rZLAYJy4B3pKLkHp/frPC7SG86RXGdb+8mCNYz9ZQ0MMoqxZ+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more folio-only helpers are added to GUP. We should probably sanity check the folio as part of unpin similar to how it is done in unpin_user_page/unpin_user_pages but we cannot cleanly do that at the moment without also checking the subpage. Therefore, sanity checking needs to be added to these routines once we have a way to determine if any given folio is anon-exclusive (via a per folio AnonExclusive flag). Cc: David Hildenbrand Cc: Matthew Wilcox Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Peter Xu Suggested-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- include/linux/mm.h | 2 ++ mm/gup.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index bc0cd34a8042..f2ffd54e1736 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1614,11 +1614,13 @@ static inline void put_page(struct page *page) #define GUP_PIN_COUNTING_BIAS (1U << 10) void unpin_user_page(struct page *page); +void unpin_folio(struct folio *folio); void unpin_user_pages_dirty_lock(struct page **pages, unsigned long npages, bool make_dirty); void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, bool make_dirty); void unpin_user_pages(struct page **pages, unsigned long npages); +void unpin_folios(struct folio **folios, unsigned long nfolios); static inline bool is_cow_mapping(vm_flags_t flags) { diff --git a/mm/gup.c b/mm/gup.c index 95bd9d4b7cfb..9cf2adfa4ce5 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -276,6 +276,19 @@ void unpin_user_page(struct page *page) } EXPORT_SYMBOL(unpin_user_page); +/** + * unpin_folio() - release a dma-pinned folio + * @folio: pointer to folio to be released + * + * Folios that were pinned via memfd_pin_folios() or other similar routines + * must be released either using unpin_folio() or unpin_folios(). + */ +void unpin_folio(struct folio *folio) +{ + gup_put_folio(folio, 1, FOLL_PIN); +} +EXPORT_SYMBOL_GPL(unpin_folio); + /** * folio_add_pin - Try to get an additional pin on a pinned folio * @folio: The folio to be pinned @@ -488,6 +501,40 @@ void unpin_user_pages(struct page **pages, unsigned long npages) } EXPORT_SYMBOL(unpin_user_pages); +/** + * unpin_folios() - release an array of gup-pinned folios. + * @folios: array of folios to be marked dirty and released. + * @nfolios: number of folios in the @folios array. + * + * For each folio in the @folios array, release the folio using gup_put_folio. + * + * Please see the unpin_folio() documentation for details. + */ +void unpin_folios(struct folio **folios, unsigned long nfolios) +{ + unsigned long i = 0, j; + + /* + * If this WARN_ON() fires, then the system *might* be leaking folios + * (by leaving them pinned), but probably not. More likely, gup/pup + * returned a hard -ERRNO error to the caller, who erroneously passed + * it here. + */ + if (WARN_ON(IS_ERR_VALUE(nfolios))) + return; + + while (i < nfolios) { + for (j = i + 1; j < nfolios; j++) + if (folios[i] != folios[j]) + break; + + if (folios[i]) + gup_put_folio(folios[i], j - i, FOLL_PIN); + i = j; + } +} +EXPORT_SYMBOL_GPL(unpin_folios); + /* * Set the MMF_HAS_PINNED if not set yet; after set it'll be there for the mm's * lifecycle. Avoid setting the bit unless necessary, or it might cause write