From patchwork Fri Apr 5 00:07:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ho-Ren (Jack) Chuang" X-Patchwork-Id: 13618314 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DD1CD1284 for ; Fri, 5 Apr 2024 00:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBB476B00A5; Thu, 4 Apr 2024 20:07:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C69B16B00A7; Thu, 4 Apr 2024 20:07:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31946B00A8; Thu, 4 Apr 2024 20:07:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 957C36B00A5 for ; Thu, 4 Apr 2024 20:07:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60D75A10C8 for ; Fri, 5 Apr 2024 00:07:14 +0000 (UTC) X-FDA: 81973538388.01.9FA42F1 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by imf18.hostedemail.com (Postfix) with ESMTP id 89B371C0012 for ; Fri, 5 Apr 2024 00:07:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QNBtuGjI; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712275632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q6McIYZbsLclE8SOPWcjX3CynsQ0RAlONuKXKFdsbWI=; b=D9AhfF3x8C6X66iK8+6SQqrAPytZ05m61mvlPzcKNhTd3piIb1C/cqjWVLbZ4E9zpqdVIi z4YyApAwNB4/uMbah53eIn0L1/2ZuVadL7qTjhhbScDJhBl9LCIk+K9XjDyCtl+WSmA0xl xRT91eLM3lZmn2msq1QDXFdj2x/YYuE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QNBtuGjI; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712275632; a=rsa-sha256; cv=none; b=cRN1D1J0neWqvNNiovAadnEQBH+izsHKGeqIjDBsuWwP8hElyXr2MWcZKVXR9EFGw469t6 1OxUWnpd+PMbOP2YIn7VV+ptx/IpLeYWvjtKtadlMHv81K9W0W2jTaPsBc0J4dqIns1t+A XuJttuajJ6hWu7/hvTgshNfvIBwcswE= Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-221e6bf537dso954128fac.1 for ; Thu, 04 Apr 2024 17:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712275631; x=1712880431; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q6McIYZbsLclE8SOPWcjX3CynsQ0RAlONuKXKFdsbWI=; b=QNBtuGjITWd/5BwRcGhBzXkSG29zQ7IOwOYP+cZoniyyCGe7g25QClWe1DVJ4hmOMA 6Jxpqqge47PVzY/UESnO7ItBK7CEVo+PSTmVwuJqEpLtX56dH5NW/T0Xmuq75FPg1dQj h6aVRu2B92+wfZNONN5DkaERWpy7lJBaLYYU/Lb6eTA2oDYWU5W1fbIkAOh5xdNb7sAm puA19Z8J9chSW9FpUOdMsaNQPMKFIBFs+yWB7TXDK6+2OSPOkq54WA+pJboGK5sdwtU4 DFnf98oS6I6Gl9r5gFX5OhAiJWsssiXy0pTy63DsSWOaxL+K+MNrIxK0ntGg+OeTfWYn IOzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712275631; x=1712880431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q6McIYZbsLclE8SOPWcjX3CynsQ0RAlONuKXKFdsbWI=; b=fc7wsPf43wPEw4IZ7xTfyTBucts4yr9VeVAg282Kp5IT/NP5OcWrLg5CGtpkE+AYJV raXsrXuMaNPXxHEzoZroYZCtQeqdpK3mJSDM4/d+P9aysVX8LExtw4k12nBQZNt8cbhT IENdze6rNYPGJb4tx8zScxMosQlXb2pWU/PABNW0VCiyspFq6Sn4SI59wF0w7JNnDkdS VxBaS4beVE3wnmrUxf4w30wkw3kXbLHJLmHiKapU3xIwsxdzGwpASSL0QRwK+oxVrsuM kLwdyIQWX57nWD/tHbkrowlFwEDw3XytAVrxrUt7avKOa7J+0s3PVdWdR4u1mo69EvzX e3bA== X-Forwarded-Encrypted: i=1; AJvYcCVbayFGHN/SIxxVNccaR/9wdYg0cUm/avjTvpi4S96/o1G4+0XLz8tbYUnoNzmiaJg/ampnsRCQh+EJBhcyLg2CTKQ= X-Gm-Message-State: AOJu0YzyIOgTO3pGPiCWMpfaU3QweVnFasOsvr8F0b/7Y2RhBmYOXDO1 6pZFIqASBfI4O0UnA5xX7oq9SgPlaBol3usv+Tpc0ZB3ZfzSr4Rhmkg4fcvaAlE= X-Google-Smtp-Source: AGHT+IETdG/JDjD1LulGxhxX7zA4HNJ1/USqVA9s7rf27ac8j8DzM+mrGRQqRxmrtXI7tO369pGm5Q== X-Received: by 2002:a05:6870:80cc:b0:22e:8fe3:a9f3 with SMTP id r12-20020a05687080cc00b0022e8fe3a9f3mr4500124oab.17.1712275631507; Thu, 04 Apr 2024 17:07:11 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.118]) by smtp.gmail.com with ESMTPSA id d4-20020a37c404000000b0078835bfddb8sm191433qki.84.2024.04.04.17.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 17:07:11 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Jonathan Cameron" , "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , "SeongJae Park" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v11 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Fri, 5 Apr 2024 00:07:05 +0000 Message-Id: <20240405000707.2670063-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240405000707.2670063-1-horenchuang@bytedance.com> References: <20240405000707.2670063-1-horenchuang@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 89B371C0012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 54wt8adksj56wykwa3ipb7ohdftq8m4h X-HE-Tag: 1712275632-215822 X-HE-Meta: U2FsdGVkX1/6zQLOmfjtEejG8AuwC4flnEUnMETwHoDLzpTUN8e5VW1HmO5DMDXoOi6Xb1RTQ1Cli0LKHzFCm4UGcXjRjExZoM93J3OYXqOsXdo0Ofxw24c/v4zhga0GhwoRuGICqSVgNUYmfPVQfjnKjTnch4RwHRbciPo2iTbfqnhuYzBHgm2KZmAxnKuLM4rL6VDsSUE+TgaMJSF1FPkAA6nZWv6B4EQonSJ0A6OXT0BmZ/qR5+F0SUOm/Ju/WlqBQtLltj+zGJ2Svn4ROusvUFKHphNCx1ebSEIQUO9gpEN4EUN6DnREQo1urmev59eMYm5VypHOJoL+QUwmFdJSQM8cdF/9fgvwJcZMuQUTEhXU1FCtUkJBIzTCY9yecb0bPl7ac7pE6cI1FMu3Vg0mDEVn4AXpEesxF3bUzn2RG+XGhHPPLbkAfz8U6vv4hZh8T1a/2sZ1lW7RHJxWrv0SxW+Xio7YZmNjKgSQJQYMCBv3Tpua0wlehWMRke+4j0Ii/4izng0FB4V9hoFDWvpFN2k1/5pQFIdyFgQUulpGv76UlMuIbXXOGkCgcwvl/jLNyHA/eKG32fjpIixqn500AEstIFlERD/K3hNJ3uD+neR1fX35kIkfkw2Bz3AbnQwpQypVFG4LWUG5OZUnXDTB5In4JKR9GR4nJAc3Y73j886cz2vzm58vcyRsFJXoARu2hW2XK0YG5knBT9pBBP6ZOPHWCVDiXQZN7wrlu2n9XhJ2LbMVBP8NTeedCLgjg18xPhqvUPSjv+lwZwUGtLhzQaqSHOBX3ODcn+nVXi9jRqW/oMztponKy/FDJm26rCOqG6RXwFyoadaDAv1DjH4K2azF3mja9jrCgz29sKItVzqdje27gvjunr29oJ4i0T4MI9cELrLoQmwnt6lv0GSxwC7tXO+IXcc22rdnyhPnDkZq1CZFDKukviwSEDIvvX1ch97j0lLw2w0hzvM YTs5In2I WrSQJvIrfDJ/pMGzQ69rYt+VLYck8UPW1bVBAUQa08ajZjh9M4NMLATF4MVWL8vR5HNpbPOyplec8xH6bL6gHIu4e+QljoDBDcWp52ji3o7uPq23cNsm0BZYptXuLWvNn/a/fsPywxOsm+9vbenLWGxNQwe2wMDFgSygHc9L8FEQ0uwZ6Hvm+1jiifDSWSswp32rtRU6gWKDiaDkmOYlJO4f5vaMoGyJEoeh4q/fOL1XB2LxiKTUMCE7pcje0Rfpjg8fNzByL+SzP2n5RHKLT5V1F7YTVF0SKDPQzBvhrR5GrIJ1wPbtmXV7XivdVHR2A9zoZXvqx6MIkHCMzaoo8o1EUbsFVy8w38U3osxokfcH5/9i/W0gysyhtJivYGsft2TBR/nIM68oouk7c4iUShRc9bwcayJGS1pmFK87CVrcqrTjkoWcL7bGpZrPtpqmer8Utn6UUbK/5akDnp/2S3AnMYL1F+TzldTORF3x00wponOiTHP+5mVHWxxNSO9Vm01zY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang Reviewed-by: "Huang, Ying" Reviewed-by: Jonathan Cameron --- drivers/dax/kmem.c | 30 ++++-------------------------- include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 29 +++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 26 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..4fe9d040e375 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,36 +55,14 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; - struct memory_dev_type *mtype; - - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } - mutex_unlock(&kmem_memory_type_lock); - - return mtype; + guard(mutex)(&kmem_memory_type_lock); + return mt_find_alloc_memory_type(adist, &kmem_memory_types); } static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } - mutex_unlock(&kmem_memory_type_lock); + guard(mutex)(&kmem_memory_type_lock); + mt_put_memory_types(&kmem_memory_types); } static int dev_dax_kmem_probe(struct dev_dax *dev_dax) diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..0d70788558f4 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +static inline struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types) +{ + return NULL; +} + +static inline void mt_put_memory_types(struct list_head *memory_types) +{ +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..516b144fd45a 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,35 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) + if (mtype->adistance == adist) + return mtype; + + mtype = alloc_memory_type(adist); + if (IS_ERR(mtype)) + return mtype; + + list_add(&mtype->list, memory_types); + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info(