mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc()

Commit Message

Sangyun Kim April 6, 2024, 7:44 a.m. UTC

The struct track for every object in a new slab is already set up by
new_slab(),
so remove the duplicate initialization in early_kmem_cache_node_alloc().

Signed-off-by: Sangyun Kim <[e-mail]>

Co-developed-by: Hyunmin Lee <[e-mail]>
Signed-off-by: Hyunmin Lee <[e-mail]>

Co-developed-by: Jeungwoo Yoo <[e-mail]>
Signed-off-by: Jeungwoo Yoo <[e-mail]>

Cc: Gwan-gyeong Mun <[e-mail]>
---
 mm/slub.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Vlastimil Babka April 9, 2024, 9:43 a.m. UTC | #1

On 4/8/24 7:14 PM, Christoph Lameter (Ampere) wrote:
> On Sun, 7 Apr 2024, David Rientjes wrote:
> 
>> What user observable effect does this have given it would only make a
>> difference when slab_state == DOWN?
> 
> It reduces the kernel text size and removes a line from source code.

Yeah it's not helpful to have redundant code, it may mislead people that
it's actually important.

Merged to slab/for-next, thanks

Patch

diff --git a/mm/slub.c b/mm/slub.c
index 0dfc0c18a78b..5ffe46843b36 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4938,7 +4938,6 @@  static void early_kmem_cache_node_alloc(int node)
 	BUG_ON(!n);
 #ifdef CONFIG_SLUB_DEBUG
 	init_object(kmem_cache_node, n, SLUB_RED_ACTIVE);
-	init_tracking(kmem_cache_node, n);
 #endif
 	n = kasan_slab_alloc(kmem_cache_node, n, GFP_KERNEL, false);
 	slab->freelist = get_freepointer(kmem_cache_node, n);