Message ID | 20240412095431.612839-1-haifeng.xu@shopee.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5FFC4345F for <linux-mm@archiver.kernel.org>; Fri, 12 Apr 2024 09:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18DD16B0083; Fri, 12 Apr 2024 05:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13EAB6B0087; Fri, 12 Apr 2024 05:54:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0057B6B0089; Fri, 12 Apr 2024 05:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D7B046B0083 for <linux-mm@kvack.org>; Fri, 12 Apr 2024 05:54:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9260E160E1C for <linux-mm@kvack.org>; Fri, 12 Apr 2024 09:54:52 +0000 (UTC) X-FDA: 82000420824.19.553A530 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf18.hostedemail.com (Postfix) with ESMTP id B28501C000D for <linux-mm@kvack.org>; Fri, 12 Apr 2024 09:54:50 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=HLUiS3O2; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf18.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712915690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=J2Shw6UlHeUYDPtpjOCh3gm8rSwGbYvX8gPhx5RCNzA=; b=6mo/jdTYhrFrBZCiwdE/QGRi8dDlcxBb8zc6NY50eBecS7mplxbTchBqP/6rkQ0thE9Ogc PKOLDGOpvmNa2+0VtzRIg77ET6mJL2uczH2iUIAjOEzJ/JT1g4h7AnmHmT9GX+E+f6zUO6 mTw+YrBiTRqmIdyp0mQRbQSUzEa1+D0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=HLUiS3O2; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf18.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712915690; a=rsa-sha256; cv=none; b=SEcJ6q02L25aml4VDAjbhjEOR1av2HJGBGI6VroEsbEvRxqPAuMiZTJ5coTf596owaT3pZ QMxm2Fu4RHnW8N4CPbON6WhEwUQFCpG1+viteaxVp/D7YDA21MRAz/k4wrC+fBCcxarnT9 tOIuZdUWojOsCAdsctiGhrfxP4RUi/0= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6ed627829e6so751920b3a.1 for <linux-mm@kvack.org>; Fri, 12 Apr 2024 02:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1712915689; x=1713520489; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J2Shw6UlHeUYDPtpjOCh3gm8rSwGbYvX8gPhx5RCNzA=; b=HLUiS3O21T4K3Qt5XVGEhIAJ3kSymtY1lWBynQ7Um1jY6UgmWETztQzIRddbIWi/q8 kOjbcpdXQ0zgEnqOppBA8ozQHux8rAd19G8+WFv3nv9wV0rphUM9jVnDOhwZ8Al1vtgx mlrZnCEGU6jRybTHHRVDbK00QHlolr3ZEMusbR8RPCDn95Qyc2qB2ifRm28VWLlagnbX lKnzgZRt/CwkMNvdMBNb6XMpgYN+XlhaX7aUVjo9479oLD5YtY4Qynr8JeCvW8doj/bZ aUH4IcvwUbbBwbUL0hFbSyD4BxeVuhDmoCRwFtmTUQYfFrjBCxyyhFSl1WeyiZ8bEjBG QRag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712915689; x=1713520489; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J2Shw6UlHeUYDPtpjOCh3gm8rSwGbYvX8gPhx5RCNzA=; b=YCBDD30bsfeaMcyPprx1SDEer13717oi7YuunfVWpspvunlRW8y7mYOOd01WN/af1+ Et6suIhQQt8DVg1PlZmShHkGeT6bCFOHlgLduy10h36UqJk9tjuLJN++XZqpYZq8R/rK OEFqwFh9X3Iet/J9E8mbxXbtwaakrJ0SAGu+i2N8q2BHG1cSxlYFoO6qDy15YxezDAoN 48BhIBlD+gDK03kpLbfpFYGa/C22rYZUKGKcvRNfYC/9tAW90lyLTvY4/lMi6aD8ODKt zNC6skvpzuwcu4HlYZCzbuyt5/3l8csgHPCaq5NbdW+wlbBa/BAjZovP+qRiGVsi5Sd2 ee4w== X-Forwarded-Encrypted: i=1; AJvYcCVmk5c/ryU35FVKf/wy17ljutb6YG9J6Bd/9u7x3VGV28Q/yvuDwIRh6JKV0MBnvLj5MIb0z8OJ6eCAAGTqN8AUXFI= X-Gm-Message-State: AOJu0Yy7uxHaNlImMCXYxxViejspYFoQvFprKgh+CCU12A+g1TNOn1VP HU2BAIdMcxtzk+nexW2ypAAJJ/Kd/H4UrjdzLgSTiIFR0eWYbKnqI5dVVC11YePmz5yAOOqMN3B Nk2DDvg== X-Google-Smtp-Source: AGHT+IFBsYlJEEwf43MspheO9XTlBmNW2+wfPHIkBMYYVF14myVo59eUvS/rsztZmRhPfWX6Wyvw0w== X-Received: by 2002:a05:6a20:c629:b0:1a9:5a2a:7e37 with SMTP id gp41-20020a056a20c62900b001a95a2a7e37mr1997680pzb.56.1712915689488; Fri, 12 Apr 2024 02:54:49 -0700 (PDT) Received: from localhost.localdomain ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id n5-20020a170903110500b001e478f359bdsm2590765plh.127.2024.04.12.02.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 02:54:49 -0700 (PDT) From: Haifeng Xu <haifeng.xu@shopee.com> To: cl@linux.com, vbabka@suse.cz Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu <haifeng.xu@shopee.com> Subject: [PATCH v2] slub: Clear __GFP_COMP flag when allocating 0 order page Date: Fri, 12 Apr 2024 09:54:31 +0000 Message-Id: <20240412095431.612839-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: bjtrr7t9bhgsy7wqhni9zy3u4mhy3nmz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B28501C000D X-HE-Tag: 1712915690-905223 X-HE-Meta: U2FsdGVkX18W8z7yXcEl82rutNH+DUyKwhCpQYGu+Jskjx4oxRbEpH7/Zo/kjOW0dUKdWR/gC4Ni3GqnmkJ/YhuaiRPzfSnX0EdWPca9Ni4hNvtVPcTVto49etDiiY83NnyUIXEUd5dwpDkBYGVafTrSXkuYT92qmwxZ4xtXk2Y8zH5aLroIMpjqnokdIcZH0dMhdCm5U6488qkdVKGcaLLWU3mpnYqCpGuezrhGtmRB/CveTmLzFFnOuI0LKkMAbpVinjTJm+A8uwUvuNYpE7mIB7kq50OblAu6FyNl/GxHzTkDjW5FZEDT1SVxkPYA9I3Zl4nyxDSz+2bc8HTjmTX6b8KX655Lr0CFZS1pw+0vQJ2sRb6Idq2a78JgBpGSwLo7atiDJScce3jwNnSimVd1lC/pHAs9sIxq0zSvK99+l9n4RK6Vm720ZQx0OTxoQDfCIxaYbyJO9/ucU7q9NTIObLfJwGouw1FEA1v9vysRpP10rP6e0fx5qzpoHA++SeKb+JE6lq4daxbqfYKFAqdD8Shv9LzBY2RTdA/UYMVMVqcm655HMnAQ+SiFMe0UBHzZVbZ3y1Jr81viZt13XJg2Q9TrR9BXCCamSjY/Js7ZvV1RO+ubl0CX0Z9dxVRz6Gd6Nwxx/s3cahp9qo5MV2hyRASZvwc5ZEpZl/fzcRwObywIVvLLOn86Hf4mjzMm3u6SX8OgOCafuaKdVHjFITF0kz5AGRRMafXML16PoQIHOjp13oj5UMEvIMX4Z+LZIx0ZADSAVQMswyGVVEu8K1xE3Yw8Qt2oUKFaWdhATlDI2fic0O6/5KRVTwQAgXLyJ7g5bnxs1Ag9hjEbhum00p/eMsmlQibwGg/zGneb2Lg+bK7rKk3GkTa0vqvDHTstA500uW7NXn/AzHqXXM3dLCkoSPkbpO833J/dOh+SSxZATOL2DxuiUuVpN2hZYO/P5hk7DFPd5zvZT0UYwQX 23HMl/rm eDR2aH3+18g4Hd/8EGI7Mv+z9Hmua39W7U1OWX4A2MO95RDKnxsz4M1/rOvkGhtEBdCO2KnHJg2GK0RE14fEUZ6TC0KnlN4eSq/PB5vLdCIaQNHl/C8TBy9b1zGSPy5WuUCVPeaQeuiznn/z74FQlCRwVwazd29KCpF3xgdE+GOinunLvHEO1FOEpR8Th3w5/D7+VOUb88axoNvf0uHmPtSvfTpI8vcMrLlMAZkV9I1mE7aFketClw+a2d2r2juNHKXn6uQ0Nyp/zXWMIUy6itM1PyuQRxo46KPrwgfph9MHEfOYBPKUhojuiAxaJlvBgSuMtenOlXc4WVXn2KczNpFCW2UHsX51YyaYpnKCKCvZXNYpLSGHjIrygObWRL2jMOWDe/CGf/648wNPUPrK3fW5DsTSphV+KGaq02bC+eOBJhCG1dHIOL2VPz/+jmMUpMXn3EnOPCf7eCOfhabeqRrYhY1js9qZhsH0uanG75Ao4QHr+i2EL+BvlyrDKpTB7OLxEA/KYWGG5zbIBRyc2OLqCrR/y6sTV0LsPncQuJ7q6VVjVHoT0xeOcrsSjmO68KYXJQOqQyQQwts4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
[v2] slub: Clear __GFP_COMP flag when allocating 0 order page
|
expand
|
diff --git a/mm/slub.c b/mm/slub.c index a307d319e82c..e7bf1a1a31a8 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2027,6 +2027,15 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) if (unlikely(!slab)) { oo = s->min; alloc_gfp = flags; + unsigned int order = oo_order(oo); + + /* + * If fallback to the minimum order allocation and + * the order is 0, clear the __GFP_COMP flag. + */ + if (order == 0) + alloc_gfp = alloc_gfp & ~__GFP_COMP; + /* * Allocation may have failed due to fragmentation. * Try a lower order alloc if possible
We encounter warning messages when failing to create a new slab like this: page allocation failure: order:0, mode:0x1004000(GFP_NOWAIT|__GFP_COMP), nodemask=(null) It's a bit confusing for users because __GFP_COMP flag is used to create compound page which implies the order should not be 0. This is because minimum order will be tried if higher-order allocation fails and the minimum order is 0. It's pointless to allocate 0 order page with __GFP_COMP flag. Therefore, clear the __GFP_COMP flag when falling back to 0 order allocation which makes the order and gfp flags matched. Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Suggested-by: Christoph Lameter (Ampere) <cl@linux.com> --- Changes since v1: - Place the check in allocate_slab() where the minimum order allocation is performed. --- mm/slub.c | 9 +++++++++ 1 file changed, 9 insertions(+)