From patchwork Thu Apr 18 02:19:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 13634076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E62BC001CC for ; Thu, 18 Apr 2024 02:22:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E75F6B009D; Wed, 17 Apr 2024 22:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 175216B009E; Wed, 17 Apr 2024 22:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2C276B009F; Wed, 17 Apr 2024 22:22:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D71276B009D for ; Wed, 17 Apr 2024 22:22:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 902421A091F for ; Thu, 18 Apr 2024 02:22:31 +0000 (UTC) X-FDA: 82021053702.11.B48EEC9 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf29.hostedemail.com (Postfix) with ESMTP id 2C32E120003 for ; Thu, 18 Apr 2024 02:22:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713406949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=voRblnmlOYBdc3jprzQ0QX2xV12p7y1xdT0AMN8QLus=; b=tcSZEp/5IGS7pCLHXnaA/CNvLEympwt0b1LwttCbUiyP8mgOZhSDXBn2kTfNfngCkLW89f xC/AMhBczQvO8bzqGrYbYvlQLALNEwEmcRIY5FChP6TYU6w/wLwryNwEEjE9iJipuJn9g6 w9W8YhbzE4tU+0my8+AnF+HQoB2lnEw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713406949; a=rsa-sha256; cv=none; b=H8S2qt8FdVXmFes9H00TkvUUistr5tn5LspBK5Y92Nu4kFi01Z6H0OvaafuHP+Ko5rLTU2 yuPAzMwR5kz+zRncion/ZWSllqMq4lPZjIbiFyDDVsicWc5BxzZ1Mhgdcb+S2ix4YMDjZc qhsIfGzpKMWHunpCF7biGqCgCWgN/9A= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4VKhLC1SFdz1R8Ww; Thu, 18 Apr 2024 10:19:31 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 704AF140120; Thu, 18 Apr 2024 10:22:24 +0800 (CST) Received: from huawei.com (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 10:22:23 +0800 From: Miaohe Lin To: , CC: , , , , , Subject: [PATCH 1/2] mm/hugetlb: fix DEBUG_LOCKS_WARN_ON(1) when dissolve_free_hugetlb_folio() Date: Thu, 18 Apr 2024 10:19:59 +0800 Message-ID: <20240418022000.3524229-2-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20240418022000.3524229-1-linmiaohe@huawei.com> References: <20240418022000.3524229-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: 9p53xtyza9ixqomfa88tm1563jcmbpid X-Rspamd-Queue-Id: 2C32E120003 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713406947-408234 X-HE-Meta: U2FsdGVkX19tQ9NF02XrRsa5i+Iizfs+qbcDEv1BHkx6Q9VJWAZPCFRT22xEURaGeQATkAIRDTmfC0b5/EqPHioHlK0KQ0V5hCGDwNSov8BFFx5nXxTo2T6x7cBpamjjkALhAEfajW92eu3Oe1Q7R2H7rqgmiw6sgQnPkw75RyRCChBhxM6mFBn9ZQKRech6YpsFFbUrJhp9MVlW+wciV3pvlMqAIaO1i8ySbjj6TqmpJ64RiI0pqosw68XOBNAc4f6Ui1PplHSPExViZJL68lBxzltUJ2+y9B6Tn8C7n3i5zeiMvMqExiHFN8Q9ESecS/jvTtZYAxVBaEKFvgX/hjrg9Q2QSnSlaCq1mLfvnmZvY8aFEId2kgUECm9LUzvPBZ1GeHvs8Os8QYp/N3Sz7w4UcC/AqVBW16Rwt28MWrb/gPCWESu/m9oKXM1O3cK6jptudbzg8coqbOxB8Rtd+M38IkFMfh6ohgUdVAtJcijauowirdV0aCuDi3CT4t96PnW1Eg+0e7HFhJb1FuYtvi7pJyyQCwM2OK1IKku+exHJ2JOj/+TZ34jA5kJ+nO6NWLB+KXjmkRLFrlJM+eqH9/QMrerTZ1kc3JA4nHOQO6G4xM/EVlUqAfh8at4Iu9HhhwuygyAaWkouwSIBYV8ONA4dDJs1Wb0+LFUZPPhtsOQtd6Hw7T0eg5itgi9fFSZrwmffPzSC5Eup+6rYJYqdbZFtV5uBKk2j1IiPSbReX3PclJ8ubihJS/U85M1F7owEjCvwBBEZc33QVYDzNzUEeq4XtOnmPbluKRhkYLVbB037EfA3I30MgUVFVfYrbZMcI5UVJPQOpSEIwxsu/VUCRejKYRe4VNvK7MEnYD3EsQBPXserI3anVrV6CDe0Qs6cJTQomP9I/3LBWDd6PTJcqwQ2ix6XbqrHZx84BEVQbK7WqkVpADdqTpK0cFsGW7sd72l4WhS6vO3vFeSwhr3 C/fiXuHT lR+j3v20KrSXOZQd24XChYJoxydMrNF4g7eq7u8r9HgZSf+sR6S6+PvI627XS8JU3PTO8yht5E/k+5dCyI2QZuV5iKLcM0bzGS/YBp6ZPv9Mz2mDYntm/UAZqzGL3FDW5JKVVWkMc338WtEcLWL8zrSGG/cY/oU08O7bcw6t6lSr0KSQ0QdKoDez1+InPKRYfn3iQ91CdQ6xVLsrWP3s8sXlNwHAOwORUqTAziPCdcZvsyPMlwkAURN89B+MyRpqBMBDBWRDknq7tWpObPqNLcX1b0ou8sWHO/W0D8k86ba9DMt8T/zs49DBKlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When I did memory failure tests recently, below warning occurs: DEBUG_LOCKS_WARN_ON(1) WARNING: CPU: 8 PID: 1011 at kernel/locking/lockdep.c:232 __lock_acquire+0xccb/0x1ca0 Modules linked in: mce_inject hwpoison_inject CPU: 8 PID: 1011 Comm: bash Kdump: loaded Not tainted 6.9.0-rc3-next-20240410-00012-gdb69f219f4be #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 RIP: 0010:__lock_acquire+0xccb/0x1ca0 RSP: 0018:ffffa7a1c7fe3bd0 EFLAGS: 00000082 RAX: 0000000000000000 RBX: eb851eb853975fcf RCX: ffffa1ce5fc1c9c8 RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffffa1ce5fc1c9c0 RBP: ffffa1c6865d3280 R08: ffffffffb0f570a8 R09: 0000000000009ffb R10: 0000000000000286 R11: ffffffffb0f2ad50 R12: ffffa1c6865d3d10 R13: ffffa1c6865d3c70 R14: 0000000000000000 R15: 0000000000000004 FS: 00007ff9f32aa740(0000) GS:ffffa1ce5fc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ff9f3134ba0 CR3: 00000008484e4000 CR4: 00000000000006f0 Call Trace: lock_acquire+0xbe/0x2d0 _raw_spin_lock_irqsave+0x3a/0x60 hugepage_subpool_put_pages.part.0+0xe/0xc0 free_huge_folio+0x253/0x3f0 dissolve_free_huge_page+0x147/0x210 __page_handle_poison+0x9/0x70 memory_failure+0x4e6/0x8c0 hard_offline_page_store+0x55/0xa0 kernfs_fop_write_iter+0x12c/0x1d0 vfs_write+0x380/0x540 ksys_write+0x64/0xe0 do_syscall_64+0xbc/0x1d0 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7ff9f3114887 RSP: 002b:00007ffecbacb458 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007ff9f3114887 RDX: 000000000000000c RSI: 0000564494164e10 RDI: 0000000000000001 RBP: 0000564494164e10 R08: 00007ff9f31d1460 R09: 000000007fffffff R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000c R13: 00007ff9f321b780 R14: 00007ff9f3217600 R15: 00007ff9f3216a00 Kernel panic - not syncing: kernel: panic_on_warn set ... CPU: 8 PID: 1011 Comm: bash Kdump: loaded Not tainted 6.9.0-rc3-next-20240410-00012-gdb69f219f4be #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: panic+0x326/0x350 check_panic_on_warn+0x4f/0x50 __warn+0x98/0x190 report_bug+0x18e/0x1a0 handle_bug+0x3d/0x70 exc_invalid_op+0x18/0x70 asm_exc_invalid_op+0x1a/0x20 RIP: 0010:__lock_acquire+0xccb/0x1ca0 RSP: 0018:ffffa7a1c7fe3bd0 EFLAGS: 00000082 RAX: 0000000000000000 RBX: eb851eb853975fcf RCX: ffffa1ce5fc1c9c8 RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffffa1ce5fc1c9c0 RBP: ffffa1c6865d3280 R08: ffffffffb0f570a8 R09: 0000000000009ffb R10: 0000000000000286 R11: ffffffffb0f2ad50 R12: ffffa1c6865d3d10 R13: ffffa1c6865d3c70 R14: 0000000000000000 R15: 0000000000000004 lock_acquire+0xbe/0x2d0 _raw_spin_lock_irqsave+0x3a/0x60 hugepage_subpool_put_pages.part.0+0xe/0xc0 free_huge_folio+0x253/0x3f0 dissolve_free_huge_page+0x147/0x210 __page_handle_poison+0x9/0x70 memory_failure+0x4e6/0x8c0 hard_offline_page_store+0x55/0xa0 kernfs_fop_write_iter+0x12c/0x1d0 vfs_write+0x380/0x540 ksys_write+0x64/0xe0 do_syscall_64+0xbc/0x1d0 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7ff9f3114887 RSP: 002b:00007ffecbacb458 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007ff9f3114887 RDX: 000000000000000c RSI: 0000564494164e10 RDI: 0000000000000001 RBP: 0000564494164e10 R08: 00007ff9f31d1460 R09: 000000007fffffff R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000c R13: 00007ff9f321b780 R14: 00007ff9f3217600 R15: 00007ff9f3216a00 After git bisecting and digging into the code, I believe the root cause is that _deferred_list field of folio is unioned with _hugetlb_subpool field. In __update_and_free_hugetlb_folio(), folio->_deferred_list is always initialized leading to corrupted folio->_hugetlb_subpool when folio is hugetlb. Later free_huge_folio() will use _hugetlb_subpool and above warning happens. Fix this by initialise folio->_deferred_list iff folio is not hugetlb. Fixes: b6952b6272dd ("mm: always initialise folio->_deferred_list") CC: stable@vger.kernel.org Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 26ab9dfc7d63..1da9a14a5513 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1788,7 +1788,8 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, destroy_compound_gigantic_folio(folio, huge_page_order(h)); free_gigantic_folio(folio, huge_page_order(h)); } else { - INIT_LIST_HEAD(&folio->_deferred_list); + if (!folio_test_hugetlb(folio)) + INIT_LIST_HEAD(&folio->_deferred_list); folio_put(folio); } }