From patchwork Mon Apr 22 08:47:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13637942 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4D0C07E8F for ; Mon, 22 Apr 2024 08:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF0C56B009C; Mon, 22 Apr 2024 04:47:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA0866B009D; Mon, 22 Apr 2024 04:47:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A67776B009E; Mon, 22 Apr 2024 04:47:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 894D56B009C for ; Mon, 22 Apr 2024 04:47:44 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 33C18A0B8D for ; Mon, 22 Apr 2024 08:47:44 +0000 (UTC) X-FDA: 82036539648.30.9925D10 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 4D123A0007 for ; Mon, 22 Apr 2024 08:47:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BhbYt1HW; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713775661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=xy/onuXdQ30KVEaYuNUZWEt3SxlLWflAgQY6tAjVj70=; b=HUt6ugVRckQ434D8LfiYbnXAid7hS/u6zkfSMeKTJRBkz/0ekmyylQTJ//v1p0bzg9YAZO h4nPxlLm7k2exJ8z8LhNcsNRv9CegrjUZ0ZzztnHQcf9MgiyuC5Ijdk59GSvBtuGyPGIuv p1Bq3TTB+secv4f684m5vLnsrkSO6zE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713775661; a=rsa-sha256; cv=none; b=HygqcNmuDCBTMVdNyDtR3fEO1HNoVQY4ciT7i63ouxjTMVkmqehSI6UA2SmRuIEbjH0JHG 7dI3vPo46Dh6EWcuWmB3KpoVlgS1x02GQMVywFDAgz8uLs82ArUJ2MA+gC3ZFioaanVZrQ wqalgQAstetQcf3e+HR7D7NRwODQO0E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BhbYt1HW; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6944CCE0987; Mon, 22 Apr 2024 08:47:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACF34C113CC; Mon, 22 Apr 2024 08:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713775657; bh=M6QQiy27Yx7cZTOC0617KB9Ln6pKKwikPWIcgenY/bM=; h=From:To:Cc:Subject:Date:From; b=BhbYt1HWBZxGe8p0rpcUIVFFy0qN3mUbgGQa+T/hdJ9oQJ5iN9QXtGO+1X2Qp+kcW q3FAb85uoScj1tMh7VK/q77eXzWKZQh5pt/OPtaDAEK6NzBtA4zbpekQbS/S73OKy+ S6K4J7+Gbcac0zubIdjxBgAfvUcmZPnk8iHEsua7yLLYoNI1nHquFFKokymhz1QsZ6 N2kiYbBilEozrmvprYGyC8M1TxF7Os+zPOSs7cNsuEML9MeP464uktwGfCcjzApu8s tW9zR6AyO4iX4WSS4f0h6ivopKwu9ye/MDbkwrxzhFXFzoptPuD2oe+4U9VpgigchB D5isfO4sruTJQ== From: Mike Rapoport To: linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Morton , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Mike Rapoport , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: [PATCH v5 01/15] arm64: module: remove unneeded call to kasan_alloc_module_shadow() Date: Mon, 22 Apr 2024 11:47:09 +0300 Message-ID: <20240422084717.3602332-1-rppt@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4D123A0007 X-Rspam-User: X-Stat-Signature: cuc8jti4mroehi3jm8swnqfu5uqbgwe1 X-HE-Tag: 1713775660-872974 X-HE-Meta: U2FsdGVkX18LFzghHVrpCVa8CsgzfWcQGEQX4rZ70WhhNCtgF/VA2HtQklf/jX48RwZMUAzMz8slNPyvYdpLdzxOuk4OoOP6wf/HwtDo+YIM5YhBzgg5xZTO8hJdgkoyZJ4lgepeJLHl0abuIZxJAop7mhZIwj+BMgxPyny4e7l+HdH/nofvDb3bwbyR5WeIaREY9aUnM5R0HNj2Y6FdxcqYTBTIR8PMnLcOsfuUxM43SdJ4ol+/9AkXdPJtat5ynMqfErhNj4ohHwrRMhoNdIwHK8145yzoAlNohFJcCftqCFl9w37wM0+hPhJ/W733bpCFLMZta0F+DZXm0RiEvudkHerFeKIWkuKyXodCOVd1AUFIZ/rM1lmykk2vg0A3E2MIaUfj11pxSGOWCYb0g7E1Nc6Pwsv0Oq3xNlkMWK+nugEJNMZeoR8fl10kRIvD3CeWHLgo9/S8mRhPn/njxeCvCzM/D3UGnYg1OelVV93vqLQ7J9gjEBAhgPFlFR6Fz2jn1abNZeNEE9NmsLdesQgifAwBQ9F05rY2v84kSQ7WnCyQxKqUMc04bpuT9r/9HBh3HiMrZXNb9tiCvNPH7j1te+rWsJviVAq4Y2myBLpQ777f95x6XBOpM5hXV2NmHiiU0lp90cDT6luie8xfqWX5BGSzrMRdFnCityoLH0+5Kbs+KE2AaE2If6+7nEn8947pO2texJwY/lc/VGWmAQ+TytF0phfHVY90kDMiPcEQshcRu3sgp+gyVTnnWqU37WxHlFT5E7XrQRWjfVCJ0EBbOXmnlLSoqhsnziWlrRcmuSfirL//JzODdrmhxnnS7o9auPcOCOWo6Isp4rEOOxQZZvkBFbClKyojLIMSYd6XwVsQ3agBBs5nD8dCW9Ch37KVkQWVsMdNhKqQvBZau3Izg4FXw7IP/AsYpCwsQeqbRYXlVu2szWf7RWb8bz1B+Twpb7+SoE0YaHjzlrb w6c30F4t 9hBArxCZdo5XkvQBo9NSPcE9gTDDnCmSn+kH7s5aFGiP3uueqUmyA+MQ4000cq+ttiQ2b4FhuPdpwQOXoAWttUI1fn/7SdhxHskjshd+kMEWewGL7GS9KFSlWKXWAP/rwAJ1ANTqsZDjPMAJh0pfr+LA84vHN+yhvN/VFXUTuaZGgLzF+7cp1xdTO21G3ynOYP2tPJ0LvmbJ24NxaIYVTkvRKWEpjwz9Y+722e0z6a/RQMZ1HjTicSAAqRRxx2wKO85Wskl03LOVg+JXZoZZ7jzVfWso+kdZqTgGGlhYD/ywKNKL1ZkvhH5WKx67QIbu9R2+Q+c4BLqpcXv0qpitpx7ZFs2jsaZN7Ya+2Sga1TTuR6Bw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Mike Rapoport (IBM)" Since commit f6f37d9320a1 ("arm64: select KASAN_VMALLOC for SW/HW_TAGS modes") KASAN_VMALLOC is always enabled when KASAN is on. This means that allocations in module_alloc() will be tracked by KASAN protection for vmalloc() and that kasan_alloc_module_shadow() will be always an empty inline and there is no point in calling it. Drop meaningless call to kasan_alloc_module_shadow() from module_alloc(). Signed-off-by: Mike Rapoport (IBM) --- arch/arm64/kernel/module.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index 47e0be610bb6..e92da4da1b2a 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -141,11 +141,6 @@ void *module_alloc(unsigned long size) __func__); } - if (p && (kasan_alloc_module_shadow(p, size, GFP_KERNEL) < 0)) { - vfree(p); - return NULL; - } - /* Memory is intended to be executable, reset the pointer tag. */ return kasan_reset_tag(p); }