From patchwork Wed Apr 24 10:53:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13641720 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF177C4345F for ; Wed, 24 Apr 2024 10:53:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A5866B026E; Wed, 24 Apr 2024 06:53:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 555106B026F; Wed, 24 Apr 2024 06:53:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444046B0270; Wed, 24 Apr 2024 06:53:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 265E76B026E for ; Wed, 24 Apr 2024 06:53:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9CB7580DF1 for ; Wed, 24 Apr 2024 10:53:12 +0000 (UTC) X-FDA: 82044113424.17.1E4A9AB Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 1CB5416000F for ; Wed, 24 Apr 2024 10:53:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713955991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=NThC23+STtu5jIlCkZZ55VUlsZKxUy/kB3g48hy+hDI=; b=7VLV08NzEoPSv6AO3l3I/yNnF1KGZj72Nf64GDtj5tDQk/FJ6C58s0DWhcvjH5OJpTvs1P hkzmxdTGw7iqszGYizR09BS+B5mtXVlQJrxsiffaxaRWKguCjp8gZnOYxJ2Fdsc4TeEcrU 64l7IO9/YzhhFJWmFjXFIzef5wFGT1c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713955991; a=rsa-sha256; cv=none; b=YATpNyaqsAc+c5weLDdBLYh/e740YMvkmvfbhlsGWGYMU3Ld7rPe1sztESn19IEAsQRgVb Wsxulr4DuCZv8hxEAxzRfP80TRAZMPgrxMm43M/n1oCEf7dSGjOPBitIehPMiiSAECp6hd ZfC7j0hFE9QXAl53WL8i8StWqFg5UPs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D58A0339; Wed, 24 Apr 2024 03:53:37 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23FCE3F73F; Wed, 24 Apr 2024 03:53:09 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Shuah Khan Cc: Ryan Roberts , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum , David Hildenbrand Subject: [PATCH v1] selftests/mm: soft-dirty should fail if a testcase fails Date: Wed, 24 Apr 2024 11:53:01 +0100 Message-Id: <20240424105301.3157695-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1CB5416000F X-Rspam-User: X-Stat-Signature: faobc8668ug97azkded6juxrmpksi9cc X-HE-Tag: 1713955990-99440 X-HE-Meta: U2FsdGVkX18+utXbnUUrqSmCr+tGS6VhxQN6xg/rTdaQPs5DT7XUPPL7Dpkh6VMs4+/cNBH74ltRUiUJbauPTYUtS4jAKXyILFnPrlsHejyiPwsFj5cq447RVNvkap2EgJTgWNR8C2wp793cZGPQDB1GSijq+S9T9t5cJhK5gDaeCZp9O9WG/i0P2RvftOvTC5Az3MJqwy8H3gNAQLwJEym7PW4MnpBy9v3hWPag6CqWsygjCSj2iPwVN4Ulaj01PMJAVyyHNJ4KJZTePcQHbrZCM0H2SkkXDNokdvB2Hg7B1RA+z6UYVh9RTSRef6w0e/CzMVAuXQnk7a7b53Y1XARyDbXXDcqJcUdDjyrSU6I2GBlHyn5eGn1oYzxt/eSpclSSqCuYEmQOVmDHzDqC2VduJKhG6/G6dMLnw7IyhFsH3O08M1b6R9vKveukUk8uRlrTQUuEp6Qgu/1fIYw7RyFgI8j5jCh/6NoNnRGs4Pi4HL7Srs73xecFsLLVyudbNsKWkTVwK481h8Jh0enb3Q7GwQeUk3cb2AyfXIQ2pMOweEmoEe/X06mr+tpgsCEp2w28CNsYV2obeCCkTyoH8Yv0ZFJpKJ7E/Pcor9OeVDxcj5QeKaPtoACdgb4uZyiOGDfatk9iO+TBC5Xs8BWl1hma/qIVGbGOY+7iOsrDrAch9DMDDW5RaMRvM0aL1W3mBoHB0e1DNMIWGpOoQwbwUCjpw91L9hEb0Is/m9V7L3otQZ6p6TUCHozw+vW8rhORaFP8uI0SI7PyvfrzIZeDzegs6J/He+jSpMrVLZ/4wSzT7M7mD7L5ZEYFyDzYcac8pcuGuGzzp6yP0Io/iYPl00gSmDws+m7zOgI3xIVrlNfj3LzSkoBd30GOTvXNIdm6bo6r8ewzW9m4runVdwTPCGfcLA5k4vyLaDSYNa5PUM+fbF8GXnRmrJV851xlVbCA03BjwAZWdg/jEj1HWr9 ECYcqQwt dUDa78XhfDq2CvB8xfOTqylIEkRhc92YH9qtb0pNOfb0yeIyGUyvJLIK+ZXIfX7TIK0teF99ZCpRXYGAba/av/M4b80rq4MpTrs1GJyajW/XsSJf4Aa7YTUCAC42E5+w8luhGfQ/ZUYNwrHLP0QCAVg5aQ4uocrqIQw1wStj36HjQhCOAVoML8+DUHiHgkGevczpd6BtuU0wRZrdSXLjKUxV5Em4H/Vj52X+h7ZHCmNNBSdmxjR8Y99EDx0oZQwt9j1AkIDHNzsOLPLAxXPb4Bb0YkcZo+g0Cxgtac1TwKk417/Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Previously soft-dirty was unconditionally exiting with success, even if one of it's testcases failed. Let's fix that so that failure can be reported to automated systems properly. Reviewed-by: Muhammad Usama Anjum Reviewed-by: David Hildenbrand Signed-off-by: Ryan Roberts --- Applies on top of v6.9-rc3. I previously sent this out as part of a larger series [1]. Feedback was to repost standalone. [1] https://lore.kernel.org/all/20240419074344.2643212-1-ryan.roberts@arm.com/ Thanks, Ryan tools/testing/selftests/mm/soft-dirty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c index 7dbfa53d93a0..bdfa5d085f00 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -209,5 +209,5 @@ int main(int argc, char **argv) close(pagemap_fd); - return ksft_exit_pass(); + ksft_finished(); }