diff mbox series

[v2,1/1] cgroup: Add documentation for missing zswap memory.stat

Message ID 20240502185307.3942173-2-usamaarif642@gmail.com (mailing list archive)
State New
Headers show
Series cgroup: Add documentation for missing zswap memory.stat | expand

Commit Message

Usama Arif May 2, 2024, 6:50 p.m. UTC
This includes zswpin, zswpout and zswpwb.

Signed-off-by: Usama Arif <usamaarif642@gmail.com>
---
 Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Nhat Pham May 2, 2024, 11:28 p.m. UTC | #1
On Thu, May 2, 2024 at 11:53 AM Usama Arif <usamaarif642@gmail.com> wrote:
>
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
>           pglazyfreed (npn)
>                 Amount of reclaimed lazyfree pages
>
> +         zswpin
> +               Number of pages moved in to memory from zswap.

nit: into?

> +
> +         zswpout
> +               Number of pages moved out of memory to zswap.
> +
> +         zswpwb
> +               Number of pages written from zswap to swap.
> +
>           thp_fault_alloc (npn)
>                 Number of transparent hugepages which were allocated to satisfy
>                 a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
> --
> 2.43.0
>

That very small nit aside, LGTM. Thanks for completing the documentation.
Acked-by: Nhat Pham <nphamcs@gmail.com>
Bagas Sanjaya May 3, 2024, 8:20 a.m. UTC | #2
On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
>  	  pglazyfreed (npn)
>  		Amount of reclaimed lazyfree pages
>  
> +	  zswpin
> +		Number of pages moved in to memory from zswap.
> +
> +	  zswpout
> +		Number of pages moved out of memory to zswap.
> +
> +	  zswpwb
> +		Number of pages written from zswap to swap.
> +
>  	  thp_fault_alloc (npn)
>  		Number of transparent hugepages which were allocated to satisfy
>  		a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
Johannes Weiner May 3, 2024, 2:54 p.m. UTC | #3
On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> This includes zswpin, zswpout and zswpwb.
> 
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Jonathan Corbet May 9, 2024, 4:53 p.m. UTC | #4
Usama Arif <usamaarif642@gmail.com> writes:

> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
>  Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
>  	  pglazyfreed (npn)
>  		Amount of reclaimed lazyfree pages
>  
> +	  zswpin
> +		Number of pages moved in to memory from zswap.
> +
> +	  zswpout
> +		Number of pages moved out of memory to zswap.
> +
> +	  zswpwb
> +		Number of pages written from zswap to swap.
> +

Applied, thanks.

jon
diff mbox series

Patch

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 17e6e9565156..eaf9e66e472a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1572,6 +1572,15 @@  PAGE_SIZE multiple when read back.
 	  pglazyfreed (npn)
 		Amount of reclaimed lazyfree pages
 
+	  zswpin
+		Number of pages moved in to memory from zswap.
+
+	  zswpout
+		Number of pages moved out of memory to zswap.
+
+	  zswpwb
+		Number of pages written from zswap to swap.
+
 	  thp_fault_alloc (npn)
 		Number of transparent hugepages which were allocated to satisfy
 		a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE