From patchwork Sun May 5 14:25:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13654312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72806C4345F for ; Sun, 5 May 2024 14:26:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3FD36B0088; Sun, 5 May 2024 10:26:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC93F6B0089; Sun, 5 May 2024 10:26:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41D06B008A; Sun, 5 May 2024 10:26:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3F3D6B0088 for ; Sun, 5 May 2024 10:26:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F998A0506 for ; Sun, 5 May 2024 14:26:37 +0000 (UTC) X-FDA: 82084568034.20.9D390D0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 8BCDA40011 for ; Sun, 5 May 2024 14:26:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NSPh68o6; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714919195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xy/onuXdQ30KVEaYuNUZWEt3SxlLWflAgQY6tAjVj70=; b=hcXw2u6CJSLuIrKtyozSc8vN8iScEkaHIqCNsDK9JBrgtzZ4LVhyGc9aBboNUt/dc+pNae A4Wio0v+vrhlDUl9ZpCcIpZ7HZtNugK0VEi1AhO/WAtv+02fTiqDa6y/H9m3gdCvJxra6n h+Yi/eBob39mthP9T3eB66xMuscFI0U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NSPh68o6; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714919195; a=rsa-sha256; cv=none; b=KvVnggK6XGslM37iu7NiVhV8Qfd35b13nSlZOwBZL+9thkGtKVa+//3+1n8UYwIRWVCO9u AQeoXQzGOVz7/H6bzs6Psm80QDBpQkEcOCPxtbpxiFdG9WY+Ys/XBUgDtPOBOSeyadIO5r 1n2CocTQgrsVUmSz2leBroMIHF6dKOM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4B70B60C88; Sun, 5 May 2024 14:26:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC393C4DDE5; Sun, 5 May 2024 14:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714919193; bh=M6QQiy27Yx7cZTOC0617KB9Ln6pKKwikPWIcgenY/bM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NSPh68o6mPYr5fxxFtC2V72LTOuvr3yq8hW9zx6j+MQT2QTIBh9u0UYi6U60wKMQ8 4pUcdPzWIOrk786o1LPMCd95D81lUAiJdKTVxj1ZpL+gyGi8qYDPggeL2hw/UDWEMu H8yR71nI/+PlLDzZBqTfTQ1Cie+RG4x5ncIdrHl8Seo9b772nXYthDV76uYlYsxO3e wQYg6gU14o2i3rAa5QG/0f77H7ZldG9qTZa21eZgJY4qTNmIeZTc79JOB4S8iYpY/l 0cYrL/tkLY7wSmRuDhM/ExnpEYA0X6qhsgfUjZwCYRm6wHSDtLs/Jy026Jn90UZc9J yhiYIU+MAPqGA== From: Mike Rapoport To: linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Morton , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Liviu Dudau , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Mike Rapoport , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: [PATCH v8 01/17] arm64: module: remove unneeded call to kasan_alloc_module_shadow() Date: Sun, 5 May 2024 17:25:44 +0300 Message-ID: <20240505142600.2322517-2-rppt@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240505142600.2322517-1-rppt@kernel.org> References: <20240505142600.2322517-1-rppt@kernel.org> MIME-Version: 1.0 X-Stat-Signature: jcy8dwofot8j9idgec8s4gysnjkgc3p6 X-Rspam-User: X-Rspamd-Queue-Id: 8BCDA40011 X-Rspamd-Server: rspam05 X-HE-Tag: 1714919195-539067 X-HE-Meta: U2FsdGVkX1+EbzH1vdCppdykCEcnru4lu5kPHGAG8FjPVONTainUtMWxX43dKy3csgo5CuNaJKpvUe32kIObwW/7UUXYN+mFloCvVlgpx8L+rp9P6k1zVaKmSG4bzGKN/9LXvllSmw9IADN29wWOj2vwv+/1opUJfCO8NPKnqqVobbS8pbrAc8SHHEV9iZ5RxY7kNVlv2VRfNlczgtwqfG4//MhQBtOolMJv5ZieCVxaCnTgoy0CQZ7LSX9PonhC1VY5qYrTnCNYOgx/AdDPfIZamLcFkJ2bpvJMSvbZYr1prhRsRzZZQ3mgatV0PO5P04we1UaW9IasKPAsfoCeRhHlaMvDIJMATTl+GL0ihxEzxXZlcloaWLkEPYJ0OddPoi7rkkYaOyiFYinKbineP5CANdcKJ/0bnYY44iAOpubOSTztFyewPUjgj5dF1AUjOa5nRKaQ3IdQqVOmhu8kgVUIkN+7je81oqMX947jGs2Hyp8VgE/ItoTbc0SNLhHlUD7Ziv119tb3Nb/K3L3J5hshN3HQiKm5bHRnUoCy+3zCJ7FWutkjxxrS9bbSpWRf2bScOBthA5cxgLeKBc7PqkmZc/MxslvFVgIH48txPJ45+xuiAxDH73YsCKY1l6EYNbEUgOskfzD6dRm1Pm2pCnHjMovXfEJeKzeA19OtKURJpPYeLWH7f1aDMjpyOxfMlD3YUpo6nLL+e3Xl4s1DCiyWc2T0pwGmHXUlP3WdWHIKozlO6vDNcODUfsGqeHo8UK0CR9fEM5m1rumgDDgRLwyCqa96AozqSppCZ2xrRW8Fh9ydkA5RT01k0o4fD4xmPhfJ1u6yeZ+VSLK3Ujz4WLa24e6j/BVY/oMWXpZl2O6A+nY54cruw0fG5IDoibfTCz5btveAUJWAMlSaxPHC/6R78KOYp2IQV1rJ6Sp81v6D17bBcvP77ELmT9PBfOfyZ3CJhcm3ChwJIilJhaQ fxCKfaAz CLjDj+6rDemnsT0AnmUTeI0r2QC+uJbK6jUv9pmWtXwHlgljgH5cqEtOU0Nu3Tz5VwzdVFRjs84bBe8dDV79nyTU7G6LZuukx85Aqrq1SqiqNQTfkgD4NMEYFNkFI7Jqvxy5U/r6TSJmw0aFPs/2BDfkXgqRJ7IwyqgwRAiNs26fuIGYvyRcl1DLQImv5QEg9sYWL5XK99z1w0WnIdaCFe1P5D9b7CoI8PMniVqwcEKgaPIX5E/R36hz2UuQaMlPfDWX+DSDcsxEcRTZ8mLP1Pq9LhoXdZgrTB+LxwJTE/pmhtfyfRxi6+HgqnGT/V6Wi6kymuj5yRYGUV6pvW8TWMKlaUFyS/+2TzMHWJdNSj5yqlw46o3NssQU/SRhcNItSFSyTiFSWjBrdy3rLHHdKugMTzwIHPaS6VCDcTbq8jtLAXHtl3Zs6GbFHkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Mike Rapoport (IBM)" Since commit f6f37d9320a1 ("arm64: select KASAN_VMALLOC for SW/HW_TAGS modes") KASAN_VMALLOC is always enabled when KASAN is on. This means that allocations in module_alloc() will be tracked by KASAN protection for vmalloc() and that kasan_alloc_module_shadow() will be always an empty inline and there is no point in calling it. Drop meaningless call to kasan_alloc_module_shadow() from module_alloc(). Signed-off-by: Mike Rapoport (IBM) --- arch/arm64/kernel/module.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index 47e0be610bb6..e92da4da1b2a 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -141,11 +141,6 @@ void *module_alloc(unsigned long size) __func__); } - if (p && (kasan_alloc_module_shadow(p, size, GFP_KERNEL) < 0)) { - vfree(p); - return NULL; - } - /* Memory is intended to be executable, reset the pointer tag. */ return kasan_reset_tag(p); }