From patchwork Sun May 5 16:06:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13654463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D58C4345F for ; Sun, 5 May 2024 16:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92B646B0083; Sun, 5 May 2024 12:07:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DA356B0085; Sun, 5 May 2024 12:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3006B0087; Sun, 5 May 2024 12:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B07E6B0083 for ; Sun, 5 May 2024 12:07:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0B7421C08D5 for ; Sun, 5 May 2024 16:07:03 +0000 (UTC) X-FDA: 82084821126.25.4F2EC72 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 69FE4C000C for ; Sun, 5 May 2024 16:07:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qq9xkaB6; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714925221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xy/onuXdQ30KVEaYuNUZWEt3SxlLWflAgQY6tAjVj70=; b=nDbkNzp3m0bYKqTtVELM6gvcsVQpO9QWjvUPsonlYcvnNsdOCEtxsObrEZnwY2tv37im5L nZEOUkvR9XbGIL0ALXdHp2hIgX5NgKyWNbBOP1+bMcz4Ph4AX8c/x9rWJ9i0+nyP4pv3yh q6R7Fv/YML4R/i1o8xG8u2m5QB4+Sk4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qq9xkaB6; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714925221; a=rsa-sha256; cv=none; b=7f/m8WKJEa/LZjydIsxiAj/KYQvNnNVrfjVo2ArJYiguTSRscIIlKJkFkwtBJ87M4+6+Kv eUlDD73CSWAMDvxwJ3ds6YoYp4u2U3JG/rWtekTQV99H54Df+s948IWaoAipL/zf2DRRGw yHfHphG3g81P5caX071Sn/ikYX2Cqr8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8666060C90; Sun, 5 May 2024 16:07:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F4F3C4DDE3; Sun, 5 May 2024 16:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714925220; bh=M6QQiy27Yx7cZTOC0617KB9Ln6pKKwikPWIcgenY/bM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qq9xkaB6DJwbvT6OTP2sGk7b6G6bmDN5GyK5sBXSm32BVbedH8jHvu58xQEar8ba4 uKzUigAgbBAtsz8r5l3mt2L2za5eSKU/+BjQNHwkb8bkk1dSzjGw0MuhLVplgL5ZP8 9+4Xjjkzq/fb5aRZ15hEIYgAO+SLQ3ZdibwPKIo+aOqxO1Wde5HY2qBWwQ/K0irIeT ivaaNIlis9trjR8Xspz86sAH3Biv9Y1hr0lxZc08RADzGXQ7JtgHd1tAb126rA5WHB b8dLhnVtioffkmnpyWBCyjSpVlTprGY0DDKi7/kPoX4BYqxHmygNlAT6hSyOu4Q7Tl 8KyBh8i4EO9TA== From: Mike Rapoport To: linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Morton , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Liviu Dudau , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Mike Rapoport , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: [PATCH RESEND v8 01/16] arm64: module: remove unneeded call to kasan_alloc_module_shadow() Date: Sun, 5 May 2024 19:06:13 +0300 Message-ID: <20240505160628.2323363-2-rppt@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240505160628.2323363-1-rppt@kernel.org> References: <20240505160628.2323363-1-rppt@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 69FE4C000C X-Rspamd-Server: rspam06 X-Stat-Signature: rrheiqkpgz11pqzji4z8y4sejookk1a7 X-HE-Tag: 1714925221-107503 X-HE-Meta: U2FsdGVkX19kRCF6UWe6emthMvk0woRbKwW4gRmeatkNF6D0ujPRYZmE6jMpjI1P/ebCzM3wx0MTs9Kb33U5A8503DJz+pNBUqOVRDG05Os92h9+RjjsTPgnl7yECpRpvsucnfMm7oC9vrsXEZV62YC+is8AoTJGRtv/WAnxzz7b0TbgE5YDugG3JBAROxQN9bD1olbJ+2JSIr/yRg0UqeKt+EGDcTeS939zVgxVMVLlbEV+dgN8IXguyXY0N8tcrGMuOKBIJaY2k4fK5LxQk+hs5dYO5boDdj7BAzJYoUnLG7Dpf0kTXl5GdmJ/2csSY36qpn26JTFv0k5z/G+9Zi1f7/pzyyWCd9t6wNkEKKYLgzIjRE0WohDdMCaOKd+FNTWU8yIe4BtAlA4Az+8Fgn4FTxkO2rrndSY14VguZ4D7Rxa0Io5Op0wN0lbjdTy+WSBCSdR0+KDJcBRX7maxqNkhzi5ChoBr/oE6VhxbYT5zg2Gwzl3Jfy2+0hYZfdMi66wON3sQ4uDFhm9kluKzzFeuit9xJdWhMPjqLxCo4/Mn8f28q3okSvWsigvoADUHlnP6agl7Xij0C8T9SGx1fymmAfYzyRxHV5M24CVcdFyMSvi4rIOYznbPgYc8LSMGWwFzBSTnuq3XWM2MBe/Ii2VHvcS4b7VLzTB8nxjPEXssosf8IQVjW/l00Ei0jrmw2gUzF5JBkOpKQYgj3Ar1s+5iwRPqEH17Y1AUUOKwpR5DWNZSZKJ13lk4TYymouKuOcGwUqwLi5FfXZC9EVQBQ6b3vqJ3/3WQkmHEPGXSaXAv/0L3s/sjHmeSe3llCOZYjaA9Z1MpuYImYDaGx3OT1114zPqLtBGePMiJ5uVLXYHUuOZ/ODNbjDWecQ2eqI4r7/FM/YtEr5B1w+hRKE/KH4d9LLqeTYvX6lrpT5DKWmXVHKwlbTRXQKa8TyWig3LAWhXZky8xhChNmtFYMCa maaYQTtQ WznB1vNxnMfu7pQiu7vAxQN+csHWpXzcKUPZo/HtPjDR5LatlvhVm89wjR2rrQyOt9M/VziXRTIfyNQcCmGIVZpbLdaYfnwZJ+TzHd46cMWFqj8znRx/JWYJcqWyKLwT+hxAsJ3vGPQMV8K/vwKvd9AW4lYAB89PKYelia2w4msNqYhrirxvY05sbMX1YKh3IniyxbtG4U4+hvKd3TTKC2gV8ZjKYVosQBWGVPmR0UaKXOb2KWUXzySO1l/p9qGaU6Lk+3dFkZ1U04x/r8g/cwBXf/LZezC2nD7o954+hJzg2pc4v16b+I+9poEASF5AD383j88NlzLq9yZ2eifQA1RZ3NPxUGIavBZ7Dlx81kAYA4RK7Yp3dxEQMQvIERwouq5LHw9uEcAFRZ6qYXPoYEmUpyFqhs9r+W7I7iWkFh9KzWAg2Nfl0Oiw3jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Mike Rapoport (IBM)" Since commit f6f37d9320a1 ("arm64: select KASAN_VMALLOC for SW/HW_TAGS modes") KASAN_VMALLOC is always enabled when KASAN is on. This means that allocations in module_alloc() will be tracked by KASAN protection for vmalloc() and that kasan_alloc_module_shadow() will be always an empty inline and there is no point in calling it. Drop meaningless call to kasan_alloc_module_shadow() from module_alloc(). Signed-off-by: Mike Rapoport (IBM) --- arch/arm64/kernel/module.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index 47e0be610bb6..e92da4da1b2a 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -141,11 +141,6 @@ void *module_alloc(unsigned long size) __func__); } - if (p && (kasan_alloc_module_shadow(p, size, GFP_KERNEL) < 0)) { - vfree(p); - return NULL; - } - /* Memory is intended to be executable, reset the pointer tag. */ return kasan_reset_tag(p); }