From patchwork Tue May 7 07:58:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13656393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC22C25B75 for ; Tue, 7 May 2024 07:59:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 843AB6B009B; Tue, 7 May 2024 03:59:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F21B6B009C; Tue, 7 May 2024 03:59:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695716B009D; Tue, 7 May 2024 03:59:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 49DED6B009B for ; Tue, 7 May 2024 03:59:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 08219161011 for ; Tue, 7 May 2024 07:59:31 +0000 (UTC) X-FDA: 82090850142.01.BE7775D Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 3FAEC180017 for ; Tue, 7 May 2024 07:59:28 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PcWxl/TE"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715068769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=y4x8iDNr1t1aZlUE79+8+zrL8CGa11yqdCcR54IvYps=; b=x2pvFrOPg69JGh2VM2qFHY52FvuM5dBNz0ApWd3QaQ8SZdNZyLwUfAqW2joT62jyCY0ZgS zyzNUempREuqxgKddp/ZTM9lr9F8qFGHdg/TDAdBQhHCUYJx3irGK/o8OZjP7p2DJeDODo /HtGkAcz4XLWRkHBIUZHyfGeORaKRKs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715068769; a=rsa-sha256; cv=none; b=dOrIvfDkULu9aIfHLZm58zUsNT0z17Awulgukv7VYxCzH0JbnGw+oJ8EAPv4gp3DOprlpl A81VMwrTjxFIuRhHpd2GqtlGCQCAMcDhQq77ihjwAEo3fzztv01b2FFL6Owe9MGRfVgemb +eIxEvUQHgciQHy/r9lKu0UwFeA0AoE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PcWxl/TE"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a59a934ad50so617278866b.1 for ; Tue, 07 May 2024 00:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715068768; x=1715673568; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=y4x8iDNr1t1aZlUE79+8+zrL8CGa11yqdCcR54IvYps=; b=PcWxl/TEetk7dQZ9FYwo2bZ8EzXbPBUSYzYgT1yFG+RLpzKDYiiQsJxyhpG8NA3AUl KoSEivJmAJh2wD7Vnn62Ak9AS82FcfYrWJZCo5+5edTkZwsRqHtNvgHy+Ygy+XY+/IWj yzK53dC4MCVzQUZ1VzRXd5DZ0C2ySsxSjaSx22koDL1jm0mJLZCPckkCCqiA68+p4DvF E8f+1xy3HOpaarfqYxfdat0eg+Fv8yaoupMkMQ6ddnR735ZRbosiVrX2TW6Udd3bzbYT nHYkOr3kSIsVAN4gwJaVVZB792hJBc6iIDflmwrX+qTfk8L2PmLnqI+lvaK7o7qN1ju+ IMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715068768; x=1715673568; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y4x8iDNr1t1aZlUE79+8+zrL8CGa11yqdCcR54IvYps=; b=RY8kU5VjuwRXObxmeKb59ZqIO2cSenoOSi1hjRLSaoKt/uxpvr5xzivOJJpPxv29EN mdERdsIJKYI0zLrhliwrcnbFOzNnwknV27mVT4qqou0+JDY+ArLxB1KWILaF20oaj1z+ Nk1/kzCqykRT/Tfkdc/lEY9jNEr4PkyzX63+3Z46dsaWVF1EeYFmp/eeT2WNuh5v7zec nnsKD6rXRcwmSfK+XZu3SmjXoBwt/lULNY5AhfVLZX686Sb1jam/R1qefk/eA1tbWXHq wegGMoaX4mhpWee1c/jr7ttveyUCTOMHasRuuc71cQxNUzG4ixJM+xGMcMyAPQ9aiK0/ bc+w== X-Gm-Message-State: AOJu0YwdLOpM6MbiayRgv0AYqNl6eY8Cb4wOFDmM7RAXVvO86IK/YSGp MJBs6/pmsNc55A1UG/5xxCHu2+YnXLnY6MhDRziiQ7iMEeomFmSc X-Google-Smtp-Source: AGHT+IEieQ2vBsgQuz3NRFuCTbBh9IvRqDg2LDSf6fOHJOHMcDxfPau4zdinDHZgFSuLeBUXtbQOyg== X-Received: by 2002:a17:906:f34e:b0:a59:a078:9e41 with SMTP id hg14-20020a170906f34e00b00a59a0789e41mr4963705ejb.45.1715068767601; Tue, 07 May 2024 00:59:27 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id y24-20020a170906071800b00a59cec38bf3sm2094505ejb.52.2024.05.07.00.59.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2024 00:59:27 -0700 (PDT) From: Wei Yang To: rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, Wei Yang Subject: [Patch v3 7/7] mm/memblock: default region's nid may be MAX_NUMNODES Date: Tue, 7 May 2024 07:58:33 +0000 Message-Id: <20240507075833.6346-8-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20240507075833.6346-1-richard.weiyang@gmail.com> References: <20240507075833.6346-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3FAEC180017 X-Stat-Signature: dmbpzyprsx8pjt767t1dhn9k8g8zyahq X-Rspam-User: X-HE-Tag: 1715068768-581396 X-HE-Meta: U2FsdGVkX18Rqd5vs6E5bO07zgMTjXb/ZM79R57l8XMbhQ3J3qh/+oucxV2NbCB11PEZNIdxSOFtE10vxfeN/ZjVzAzJ9QPc3+z9x2vr9EgAdoIe22oqg7V6ioxAsFYTZTYGsBYjVPJokmCxATt9s1/6wgMqjO2qcLZbjBjVpW/nclfgLEV3Kzq5RDaFvuPK50pTJ0oBlmHW549Xg/GUZ1Lf1UQDHHe1eiFsvh865wF6kuej3wKDrbeqjwQBIPm5UTQedlfoC9QbFZiTCnysm9x5UeGMmiuncpgP5aB5m0GAC/HZb4gN/DoZ0pc/R6UjzE3MatOIL76j+wEgYfgndKowppCqRQwGZOYRG9QKXVKQwr6ufSz6thlK811FS0sUTFKq3MCWfQFrcCHDc9XwqeRzfX+XsL0qFo4w3Cmirhb0bhuWeojpai/vkQPVxv1xxVL8ZCD2VOXInicCgSqSl4wGkH2o4G4SEBqIbti4aGUBh6zdaSOtCGXuX7JkCQ88OvZnh8OwKa0DD65fgp1SR2z8j2JOncXx80kwmEkWDkiVJrmr4iU4LdtVzEq+bc+ne3SN8yRLfNk/sLKGpMjpvqRIlliuH6RPw75+kALk3XHY6k9RzIvE5q2ZSwh+I7k9+t83cnXDjVoKbm6ljQONe7Ql+55QK5EiHrcCU7Tp//98LW91gCVB8B84OyfFAmM5QhQnln1/k023CdRjV0pnFmw+xl6I/sHAnU3T/Elr9JTr8NwVgC+kQJOFMPmnMvqQXYc2KQnh5seHVNiHUYIVke3PRWZXcs75QEzsdvaOGzu4FKnAlZg9OUp1i0o0MY0EZmb4BIxN+5Z86RQJTTRmDlwHQ32GsBvteiOCNfHt+0Iu/T9rh7E26eGbsFsSSHYprPXF/POYXxP6e3qRwlKbHY4cQnj4pptm+XYpdyMNuX35vNCmxjMUGwtbLJ3FI77uHQaIJXChPn/ax4YFBVI d8ycCqRG f+lFz4XxTzJP6j04BM4EbgoZghC5c3Kt6knJIizvcwoIkTn3J8OdwpXyJhXWaph8+Dsd6X4nyWhc2zXYB3CDJ6xaOiezZ+cjH9erLEdrYzLCF6gFWAF1Q1xq0dzrsLiQLmvYptgOqlJRC3UzadCgE6Oj69RffHI/aqlETEoJh96OQR9CLaGly6FxU81V7sNndWXp8Elww1HPeh6WrYtzq1u/4D/NjKyGFlnqTlXl6picXOkHhfQaqUMqmHCWb7t0Jdt7RElKJUmEPW8fxiyfc2viKU5kZmipxCxenq5FaVb9519ewHF+u0l4PKu+SwcId7mdcu08kwF/592MEisU8S1JcanTt/qi6WV3CYdhW8woc0oHKYovKo9UC5aVexHqKTwx9NU5bGrLoTTYCwI8voKc/rxXBEA00QeeeqK8ItSi/PRD0id4T4NhxUBZJQgujsS1aE4hJPoRpqd0OTN1p+cRpsmkXkxHLcJKJWeJrcqYUijAKc99XiH3C2nZf/5GnRXnyGXFcB0Yc/fd4E7ghoRbEFGd0WvPJHQ8BYVf8sPSGvEA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010283, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On x86, the call flow looks like this: numa_init() memblock_set_node(..., MAX_NUMNODES) numa_register_memblks() memblock_validate_numa_coverage() If there is a hole, the nid for this region would stay to be MAX_NUMNODES. Then memblock_validate_numa_coverage() will miss to report it. Signed-off-by: Wei Yang --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 33a8b6f7b626..e085de63688a 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -751,7 +751,7 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt /* calculate lose page */ for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, &nid) { - if (nid == NUMA_NO_NODE) + if (nid == MAX_NUMNODES || nid == NUMA_NO_NODE) nr_pages += end_pfn - start_pfn; }