From patchwork Wed May 8 11:18:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 13658579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA694C04FFE for ; Wed, 8 May 2024 11:22:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2DE6B013B; Wed, 8 May 2024 07:22:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67ACE6B013D; Wed, 8 May 2024 07:22:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CED16B013E; Wed, 8 May 2024 07:22:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 25F846B013B for ; Wed, 8 May 2024 07:22:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5FB3140E88 for ; Wed, 8 May 2024 11:22:44 +0000 (UTC) X-FDA: 82094991048.22.F4BAC15 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf23.hostedemail.com (Postfix) with ESMTP id CC25D14001B for ; Wed, 8 May 2024 11:22:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=TjwEqfEK; dmarc=none; spf=pass (imf23.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715167362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tID4t35K2Xq8XfdKgfehJoKp8xw/RZTmJgN0BGYZu8=; b=DH2GqN21tSNiOU/6MAZskiZKDDjS7VlYIoOaw9fg2oFeRutLv8vUmGbX90OG4MmJdouy88 oODCl7Yk0wp7t3qK1SQjbOHumisWZSuqohTvnYc+z+awnW/btgXstKSwpYnyrqZEnnlwVf kqRN5TzpVa6cqc4+vScakAI3EEeBydM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715167362; a=rsa-sha256; cv=none; b=zwxlzhXx2xE4eMNcaH8yQeNUZ7IRsuiQr/hbimN3wBQS4wiBc7R6FEkvwX8rI2zGN6xx/B BWsWtDvO4IaIjDBCKsRYUTRVppO+jYujweXQi/FhUxfNth7FMpCfyLDLxy3uB/oyUt03pl /TPSBEwb23KorjvyO+NTuViijoz+YOo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=TjwEqfEK; dmarc=none; spf=pass (imf23.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-34ddc9fe4a1so2946899f8f.0 for ; Wed, 08 May 2024 04:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715167361; x=1715772161; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9tID4t35K2Xq8XfdKgfehJoKp8xw/RZTmJgN0BGYZu8=; b=TjwEqfEK8/cL2wLB7PQErYSWb6Chb2+XfrUFqs+gyErRqmktXgPzp2tWy0tmlGvF+W opEAt0DC+uxqv5ygwSGUNfCMiDHdq/XujnKAivSwt+nqPJF7ajmDUonZ3qpFlaT8nuRp pTQqXMbD9oQ/vRBZGTI1ik+eC76K25plYOiezM47sHl6638ri5X+Y/4bP/bjCCdSkrqL /goCllKcUqJ/Pbd24zC79vUUwH961pfd3gSqUUaab41S8DyAmdiGzaOWa/htloU3xeut L1P979eSMEXEI5Jmo/QMYBW86PWKZAFg5i2cWuz/E2xK7U52btUkkTWzk5ZXAtNFbavs ct0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715167361; x=1715772161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9tID4t35K2Xq8XfdKgfehJoKp8xw/RZTmJgN0BGYZu8=; b=XkT3QYa7xtrYeuOatEa1fyG5PlgFzexybI88MFlbhTMkGGWCkqoDXSIbWI7dMXGMWE jeukFarjbr8Wf9KeQYDeSq0EPrzPo4pDKw31fdQLV0MHEQvsCI+RxyFL5F7lgN3c79tU CbbxC1IyEotZTMeEpjm5omqzF7jJILjCc4KVb/pTZq/XiTsPWFzZUCCcUZlZaO2bjq6p 7QEYwgNfzp1vTmqmXQTOtFP8JOeqGjIH7Jp9u6Gs99O5MudFSPUOOc8uaepzuLdybCXl NVXFklUX0y0o1745n7PixJ8Ud4ex5KJg0TMo/8D9/SpjrSxLCspDFo9zxKC0Z1sDyXvt lu8Q== X-Forwarded-Encrypted: i=1; AJvYcCVJf70EAefaZbh65YeUp8eOnExVQ382rLbj1XETyDkcZGVdH0yFADsPOxSLpRGu5EQX8WK2bXZmdkDQ8O+N45Hfl4M= X-Gm-Message-State: AOJu0Yy5JIDchP1GoRPgudT1kfVdf6TK/2cjbz1pzeUGHlSjESk7Mg3e ZtFjYU7QvJ1AB/BzLs59ox9FpVQ9S1KvoU0z3ShTRhX3Uk90oOBb3EkZJQ1TFWk= X-Google-Smtp-Source: AGHT+IEhj4x90HF7qk4DaGHuIQAJSSwdJ9BqGTmqhMoZKfcOAwPZQ6Sx+t8ghfaCru80kzJxCAbXqg== X-Received: by 2002:a05:6000:1b85:b0:349:7e8e:b29a with SMTP id ffacd0b85a97d-34fca80e9a8mr1884287f8f.62.1715167361084; Wed, 08 May 2024 04:22:41 -0700 (PDT) Received: from localhost.localdomain (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id p12-20020adfe60c000000b0034ccd06a6a3sm15154549wrm.18.2024.05.08.04.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 04:22:40 -0700 (PDT) From: Alexandre Ghiti To: Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org Cc: Alexandre Ghiti Subject: [PATCH v2 4/9] mm: Use common set_huge_pte_at() function for riscv/arm64 Date: Wed, 8 May 2024 13:18:24 +0200 Message-Id: <20240508111829.16891-5-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240508111829.16891-1-alexghiti@rivosinc.com> References: <20240508111829.16891-1-alexghiti@rivosinc.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: CC25D14001B X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: es5ung5kjw9xg8b8gag7c36gmofsf3nz X-HE-Tag: 1715167362-87333 X-HE-Meta: U2FsdGVkX19a+Xl5WHglQM6V/Ra51Eyhk529lPms6yKhM5TwOJ+9IiL2B91IKGmj5YtjJj9KXQCHbrGEVH2fP6eGRIc4zO/2uL12BBhqhC6EGjI3mv5KB+Bs0pStbrSfCM4ODkGaMOuPzeiUTeDG7r+NuhNjlQxryedbWnsUPPnM0yepwACxZdxdN6W8VOi9sN4Pdd2qPnK7UmAeviS568qZyiHOLHpfsFsWikjjeXkMY6taFBjSZkNjIzfPsrTi7TVwFMs1ub9s11o22a8ig3wDlYtxCQrNOfhO151iZJHAVM81X0/WKk1fR5FP9LgxAO92N4WINaouBAN4D+TAuHSwazEOtVCcwnJuymZ1ltNZu5apTFkw0zrduE0vy6aVaHjIt4Yh3pfkxthSUenZbG9QLyCox45U6GPXwbCcPxaACF/W+eVJSR9pcpUrsS/dhLDU2br6X0J8fi0S8+hZdu0aRTDuIjlsNfDkmNG3z+Nuv4yPAf57EHAPI/sZeLUbx3PUTJ2o8+MH0ZPcfBIc/CxpNN7evxXNtP0NOzVBWWGRJL9NLo6tvtgJmxHmwxFgPaZDCtxzuYJuQ1loLYfvIfqDJWnrnGBRbb5mjY5HYVkdrTjy6TrdfxgbKep7sTNEWdcDQXIDPeLz2KNTIAlHe1UN1vqDHVY0MjszfdA282sMOuYxTnE1jllOGT7BzBAUNvzZVR9p1orFQC+KH/RNtVNiSYQ+zok/EVEGLIQBr9S7X/p/ERVOl3q/O1iYPhz+hTC5+sYKPZzMxcpUsy++HMQR/HqNTrYAvHwEC8UJtF91nNw+MmqZzU8pEEG9CuBBg3ee59Xe4zYMEAoY539N+O0VfVskniKZ9D1N9L1By6k/xe8kyttDDfp/E5IqHe9pRzAlGOGrEDr8IA6bM6shtzkdKbLuuDwf2MMGZbaJvwUeTNpLUCrExVYTVRbAvIhkHJ8E6HuwkKow4DGARkp 4CR+FNuN OvkDvJnTe9U2oJfb2AvCrFfKr+msvtNFXQgfvboLtq/i+0bG+LwrhlyIpnOWWXE+kaKajWJkr4aGjToXMc3hFfr7xIVrMN1oj2/qpsMXiQVfT99ZLddr/bFpenY3I7bYCXBpeZVJpTI6iDyOEfPaqFMNtqlN4B59vjHfjhFlubnUNm2zJ1PL7GFUPuZFWCsXKiBUWxC35s/1/gJyLmuFk8UJalLg82iSTvB7Lw4s5XeJNZjfKLZR/3lmJYOn0OyBMnGG8YA7UIxO33OXDt0UVYvSQDf1uD5jzyuWyw+zLz0fUccXT5lRX36a/7317pG/5dN12JgeaCR0MqNYokuTZDptstgBnmwqGIhIlb8LpDW61wMPk83mK3+Pwn23RK8bmAYXggd/WMX/yzYPBxF0jRqGRHzOC4069CLRspur3y2y9+HFjvgJg66Mt8/Wmlm/BkcAzwBJTpg15YJLkvPRNg+5EPYNh9tGBlKy+LVZKfm2+EHiERHT2Psdbsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After some adjustments, both architectures have the same implementation so move it to generic code. Signed-off-by: Alexandre Ghiti --- arch/arm64/include/asm/pgtable.h | 14 +++++--- arch/arm64/mm/hugetlbpage.c | 56 ----------------------------- arch/riscv/include/asm/pgtable.h | 39 +++++++++++++------- arch/riscv/mm/hugetlbpage.c | 62 -------------------------------- mm/contpte.c | 59 ++++++++++++++++++++++++++++++ 5 files changed, 95 insertions(+), 135 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index e30149a128f2..2e0415fd5083 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -372,9 +372,10 @@ static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) return pfn_pte(pte_pfn(pte) + nr, pte_pgprot(pte)); } -static inline void __set_ptes(struct mm_struct *mm, - unsigned long __always_unused addr, - pte_t *ptep, pte_t pte, unsigned int nr) +static inline void ___set_ptes(struct mm_struct *mm, + unsigned long __always_unused addr, + pte_t *ptep, pte_t pte, unsigned int nr, + size_t pgsize) { page_table_check_ptes_set(mm, ptep, pte, nr); __sync_cache_and_tags(pte, nr); @@ -385,10 +386,15 @@ static inline void __set_ptes(struct mm_struct *mm, if (--nr == 0) break; ptep++; - pte = pte_advance_pfn(pte, 1); + pte = pte_advance_pfn(pte, pgsize >> PAGE_SHIFT); } } +#define __set_ptes(mm, addr, ptep, pte, nr) \ + ___set_ptes(mm, addr, ptep, pte, nr, PAGE_SIZE) + +#define set_contptes ___set_ptes + /* * Huge pte definitions. */ diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c index 9e9c80ec6e74..b8353b0a273c 100644 --- a/arch/arm64/mm/hugetlbpage.c +++ b/arch/arm64/mm/hugetlbpage.c @@ -159,62 +159,6 @@ static pte_t get_clear_contig_flush(struct mm_struct *mm, return orig_pte; } -/* - * Changing some bits of contiguous entries requires us to follow a - * Break-Before-Make approach, breaking the whole contiguous set - * before we can change any entries. See ARM DDI 0487A.k_iss10775, - * "Misprogramming of the Contiguous bit", page D4-1762. - * - * This helper performs the break step for use cases where the - * original pte is not needed. - */ -static void clear_flush(struct mm_struct *mm, - unsigned long addr, - pte_t *ptep, - unsigned long pgsize, - unsigned long ncontig) -{ - struct vm_area_struct vma = TLB_FLUSH_VMA(mm, 0); - unsigned long i, saddr = addr; - - for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) - __ptep_get_and_clear(mm, addr, ptep); - - flush_tlb_range(&vma, saddr, addr); -} - -void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned long sz) -{ - size_t pgsize; - int i; - int ncontig; - unsigned long pfn, dpfn; - pgprot_t hugeprot; - - ncontig = arch_contpte_get_num_contig(ptep, sz, &pgsize); - - if (!pte_present(pte)) { - for (i = 0; i < ncontig; i++, ptep++, addr += pgsize) - __set_ptes(mm, addr, ptep, pte, 1); - return; - } - - if (!pte_cont(pte)) { - __set_ptes(mm, addr, ptep, pte, 1); - return; - } - - pfn = pte_pfn(pte); - dpfn = pgsize >> PAGE_SHIFT; - hugeprot = pte_pgprot(pte); - - clear_flush(mm, addr, ptep, pgsize, ncontig); - - for (i = 0; i < ncontig; i++, ptep++, addr += pgsize, pfn += dpfn) - __set_ptes(mm, addr, ptep, pfn_pte(pfn, hugeprot), 1); -} - pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, unsigned long sz) { diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index 66061002ff36..5d1d3a6c7c44 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -535,29 +535,39 @@ static inline void __set_pte_at(struct mm_struct *mm, pte_t *ptep, pte_t pteval) static inline int arch_contpte_get_num_contig(pte_t *ptep, unsigned long size, size_t *pgsize) { + unsigned long hugepage_shift; pte_t __pte; /* We must read the raw value of the pte to get the size of the mapping */ __pte = READ_ONCE(*ptep); - if (pgsize) { - if (size >= PGDIR_SIZE) + if (size >= PGDIR_SIZE) { + if (pgsize) *pgsize = PGDIR_SIZE; - else if (size >= P4D_SIZE) + hugepage_shift = PGDIR_SHIFT; + } else if (size >= P4D_SIZE) { + if (pgsize) *pgsize = P4D_SIZE; - else if (size >= PUD_SIZE) + hugepage_shift = P4D_SHIFT; + } else if (size >= PUD_SIZE) { + if (pgsize) *pgsize = PUD_SIZE; - else if (size >= PMD_SIZE) + hugepage_shift = PUD_SHIFT; + } else if (size >= PMD_SIZE) { + if (pgsize) *pgsize = PMD_SIZE; - else + hugepage_shift = PMD_SHIFT; + } else { + if (pgsize) *pgsize = PAGE_SIZE; + hugepage_shift = PAGE_SHIFT; } /* Make sure __pte is not a swap entry */ if (pte_valid_napot(__pte)) return napot_pte_num(napot_cont_order(__pte)); - return 1; + return size >> hugepage_shift; } #endif @@ -586,8 +596,8 @@ static inline pte_t __ptep_get(pte_t *ptep) return pte; } -static inline void set_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pteval, unsigned int nr) +static inline void __set_ptes(struct mm_struct *mm, unsigned long addr, + pte_t *ptep, pte_t pteval, unsigned int nr) { #ifdef CONFIG_RISCV_ISA_SVNAPOT if (unlikely(pte_valid_napot(pteval))) { @@ -631,7 +641,8 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, pte_val(pteval) += 1 << _PAGE_PFN_SHIFT; } } -#define set_ptes set_ptes +#define set_contptes(mm, addr, ptep, pte, nr, pgsize) \ + __set_ptes(mm, addr, ptep, pte, nr) static inline void pte_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep) @@ -646,9 +657,8 @@ extern int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long addre extern int ptep_test_and_clear_young(struct vm_area_struct *vma, unsigned long address, pte_t *ptep); -#define __HAVE_ARCH_PTEP_GET_AND_CLEAR -static inline pte_t ptep_get_and_clear(struct mm_struct *mm, - unsigned long address, pte_t *ptep) +static inline pte_t __ptep_get_and_clear(struct mm_struct *mm, + unsigned long address, pte_t *ptep) { pte_t pte = __pte(atomic_long_xchg((atomic_long_t *)ptep, 0)); @@ -687,6 +697,9 @@ static inline int ptep_clear_flush_young(struct vm_area_struct *vma, } #define ptep_get __ptep_get +#define set_ptes __set_ptes +#define __HAVE_ARCH_PTEP_GET_AND_CLEAR +#define ptep_get_and_clear __ptep_get_and_clear #define pgprot_nx pgprot_nx static inline pgprot_t pgprot_nx(pgprot_t _prot) diff --git a/arch/riscv/mm/hugetlbpage.c b/arch/riscv/mm/hugetlbpage.c index be129f4f1503..d8f07aef758b 100644 --- a/arch/riscv/mm/hugetlbpage.c +++ b/arch/riscv/mm/hugetlbpage.c @@ -173,68 +173,6 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags) return entry; } -static void clear_flush(struct mm_struct *mm, - unsigned long addr, - pte_t *ptep, - unsigned long pgsize, - unsigned long ncontig) -{ - struct vm_area_struct vma = TLB_FLUSH_VMA(mm, 0); - unsigned long i, saddr = addr; - - for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) - ptep_get_and_clear(mm, addr, ptep); - - flush_tlb_range(&vma, saddr, addr); -} - -/* - * When dealing with NAPOT mappings, the privileged specification indicates that - * "if an update needs to be made, the OS generally should first mark all of the - * PTEs invalid, then issue SFENCE.VMA instruction(s) covering all 4 KiB regions - * within the range, [...] then update the PTE(s), as described in Section - * 4.2.1.". That's the equivalent of the Break-Before-Make approach used by - * arm64. - */ -void set_huge_pte_at(struct mm_struct *mm, - unsigned long addr, - pte_t *ptep, - pte_t pte, - unsigned long sz) -{ - unsigned long hugepage_shift, pgsize; - int i, pte_num; - - if (sz >= PGDIR_SIZE) - hugepage_shift = PGDIR_SHIFT; - else if (sz >= P4D_SIZE) - hugepage_shift = P4D_SHIFT; - else if (sz >= PUD_SIZE) - hugepage_shift = PUD_SHIFT; - else if (sz >= PMD_SIZE) - hugepage_shift = PMD_SHIFT; - else - hugepage_shift = PAGE_SHIFT; - - pte_num = sz >> hugepage_shift; - pgsize = 1 << hugepage_shift; - - if (!pte_present(pte)) { - for (i = 0; i < pte_num; i++, ptep++, addr += pgsize) - set_ptes(mm, addr, ptep, pte, 1); - return; - } - - if (!pte_napot(pte)) { - set_ptes(mm, addr, ptep, pte, 1); - return; - } - - clear_flush(mm, addr, ptep, pgsize, pte_num); - - set_ptes(mm, addr, ptep, pte, pte_num); -} - int huge_ptep_set_access_flags(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, diff --git a/mm/contpte.c b/mm/contpte.c index e8574051d0b9..2320ee23478a 100644 --- a/mm/contpte.c +++ b/mm/contpte.c @@ -10,6 +10,8 @@ /* * Any arch that wants to use that needs to define: * - __ptep_get() + * - __set_ptes() + * - __ptep_get_and_clear() * - pte_cont() * - arch_contpte_get_num_contig() */ @@ -17,6 +19,7 @@ /* * This file implements the following contpte aware API: * - huge_ptep_get() + * - set_huge_pte_at() */ pte_t huge_ptep_get(pte_t *ptep) @@ -43,3 +46,59 @@ pte_t huge_ptep_get(pte_t *ptep) } return orig_pte; } + +/* + * ARM64: Changing some bits of contiguous entries requires us to follow a + * Break-Before-Make approach, breaking the whole contiguous set + * before we can change any entries. See ARM DDI 0487A.k_iss10775, + * "Misprogramming of the Contiguous bit", page D4-1762. + * + * RISCV: When dealing with NAPOT mappings, the privileged specification + * indicates that "if an update needs to be made, the OS generally should first + * mark all of the PTEs invalid, then issue SFENCE.VMA instruction(s) covering + * all 4 KiB regions within the range, [...] then update the PTE(s), as + * described in Section 4.2.1.". That's the equivalent of the Break-Before-Make + * approach used by arm64. + * + * This helper performs the break step for use cases where the + * original pte is not needed. + */ +static void clear_flush(struct mm_struct *mm, + unsigned long addr, + pte_t *ptep, + unsigned long pgsize, + unsigned long ncontig) +{ + struct vm_area_struct vma = TLB_FLUSH_VMA(mm, 0); + unsigned long i, saddr = addr; + + for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) + __ptep_get_and_clear(mm, addr, ptep); + + flush_tlb_range(&vma, saddr, addr); +} + +void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, + pte_t *ptep, pte_t pte, unsigned long sz) +{ + size_t pgsize; + int i; + int ncontig; + + ncontig = arch_contpte_get_num_contig(ptep, sz, &pgsize); + + if (!pte_present(pte)) { + for (i = 0; i < ncontig; i++, ptep++, addr += pgsize) + __set_ptes(mm, addr, ptep, pte, 1); + return; + } + + if (!pte_cont(pte)) { + __set_ptes(mm, addr, ptep, pte, 1); + return; + } + + clear_flush(mm, addr, ptep, pgsize, ncontig); + + set_contptes(mm, addr, ptep, pte, ncontig, pgsize); +}