From patchwork Fri May 24 01:19:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13672596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13F0C25B7D for ; Fri, 24 May 2024 01:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53FDC6B0088; Thu, 23 May 2024 21:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EFEE6B0089; Thu, 23 May 2024 21:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 342CC6B008A; Thu, 23 May 2024 21:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1AA316B0088 for ; Thu, 23 May 2024 21:19:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A4A461A079C for ; Fri, 24 May 2024 01:19:58 +0000 (UTC) X-FDA: 82151532876.19.932DFDB Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf05.hostedemail.com (Postfix) with ESMTP id E1D40100004 for ; Fri, 24 May 2024 01:19:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JZledHIr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716513597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=FiBCELuE62C2faXPcJ+beB9jxHLe1JTI96VohTYJ0eA=; b=FNesrGATKjmPEqLF6zpWK3gQHuPBFi2NmwUNgqu1dosU8wKWogaYZeyqOQltLwyQH2L08U SOpsbq8rQ67KwR/Sjdqh//6x7OgFuc6H3LSWR/YEiX9CDLvYG1MNp4m6TU5b8J1gJfNQCT NBMw5F21nVkXyPPHr7N1cPW/DKs/Qgs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JZledHIr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716513597; a=rsa-sha256; cv=none; b=KhqvlAuDS+F22aA8vW6z1ozZfZ2sdluSgNOWXEp9/U7GOqu8Hnxk3GfTMsmpWlaHCSzh5Q rB2Xeeg3iBNuseek6QDIejb/gzGx0podMuQde5mJ3WvfJFwhnxw6ve8gohN27mGZKaCis8 WQy644UsqlTY40HdvmbmatjE1yF/XpM= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a6265d3c488so36828766b.0 for ; Thu, 23 May 2024 18:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716513595; x=1717118395; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=FiBCELuE62C2faXPcJ+beB9jxHLe1JTI96VohTYJ0eA=; b=JZledHIrPB4KEftU5eY2ze5PKdfsvBA2sp8fIFi1k4oGVea9LB6RyJ2bLQYkNFzvYK jlD8RLFSGR1dFiQOs5cSloN7Nd/8RiYRo1VBNulipUkQFdKR3bQ5EDjk1eg5uNPmHmC8 VIMFI/lUztFRY/d6wtcicseNMLmc3EaJKX7rM9XNAq32j+9GQlF8Dx1PgglBA0vNifW9 wIL3qXWZ4hCOZ7of/VctcNix0qWWaAF0MgTqSSK9moe7iYRyrzwo7LF+w2hjK98Kadxi AY2dAUuOcN/joe8UUvqBSTAppF3GIzi0cq6cCIChEt8MY7T2eGE8h6tK24GcS/jScEuG imPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716513595; x=1717118395; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FiBCELuE62C2faXPcJ+beB9jxHLe1JTI96VohTYJ0eA=; b=KSW0efwjDa4dajXwougLiC9Vfk6LuiwnBuef8LxW0Puoxu/sUaoTdszoTcWIDvicbV 9/6i179nQg0ze1Gwegl/GOEkfmzelbCCnbLv9/0FUQhbZcSJjKpLixo8q3pFxo+TYTdc GRTkzEE9GNyOg0LRYBBE+VIVYzZyRmCd/cLtSIuK5iFXb0h4hd0NVJilVi/NI0vVbQTl g9+JX25n9xeUzVxVnsHSwSPV7aXpm2LSrzbyrTKoQuQ8X6RTQQzWF+TPsOoiZvHRhLDv +bHMYaAeBSazM7PZWeDiv17X7dR5pm2Wc1vxDYqi7mDOozsFu7fHTY0s73O4H/XryGv6 K5mA== X-Gm-Message-State: AOJu0Yx2AcKSVBwj5XA5PaM7yQ2qh3j4EQloG37arxuUfj9GVgAK86mk JqUSeDV+ST5X8N4UtAPQ73Oc2v0CExwcJYFyNiTnnvvD8L5o2QWP X-Google-Smtp-Source: AGHT+IFKbueZjSjEkXgxFW7vMAJm3F9SqcaLOcM1LN4xUp3vUWaA5A3pAhNhyFm+hDYwCgtd61c5pA== X-Received: by 2002:a17:906:f18a:b0:a59:edbc:193d with SMTP id a640c23a62f3a-a6265119d6amr72613566b.55.1716513595350; Thu, 23 May 2024 18:19:55 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc519a2sm38338566b.126.2024.05.23.18.19.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2024 18:19:54 -0700 (PDT) From: Wei Yang To: rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, Wei Yang Subject: [Patch v2 2/2] mm/mm_init.c: move nr_initialised reset down a bit Date: Fri, 24 May 2024 01:19:14 +0000 Message-Id: <20240524011914.27854-2-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20240524011914.27854-1-richard.weiyang@gmail.com> References: <20240524011914.27854-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E1D40100004 X-Stat-Signature: 6nm8fgydpnhque9bn8paib7beuqznuxi X-HE-Tag: 1716513596-798276 X-HE-Meta: U2FsdGVkX1/mEIidS3ghsASOMdBZDc29k4N8t9CkGWZHY71U8SKUSxqtmA8iAwNDg40/PezU42JbqbWV3IOOz2M91LykbsO5wW5GPYZyhZjlIE3zgIAsZGnvPAv3lbcJygKyfZWsYX4Yxh7c3bKeajAJfT5VF4tX0yFc2y6Lu1RU/HkfDNPEaS5MGNO78/dWW0JGVq+dYILxPGr+0kYWGm/WAvc/mBhdox3iv/DFmAoTPIF1Wlk7IVvHiD34xzkUCan/wNAAobmKNKM8AkXlCrLm5403EiugLor0Bin0qoJ/kxzT0QeoseomI+NBN91v8a84kBSv4P4WtGwD+94xrqkyH9IiQ0H3FLMv/c8EOpPhCsz1wxskcM9Kku+ZOpW1gSTeMVJbX24Q5km4RaikTr+NXQRe4bqI95f+QZW7WY3SSKAloGWn5ZSjOJh+m7MUDH5lWBs+QNc8Uli8GE0LAVfrH6hhEKBpgd1uSxhTBlH2XJZwCEZPy2RPETJfeIJCMMUlqBBh0T2cFU1d6+IetaABvp9C+As9u/iENu1YkxNCQt5JsWq3fR89XxoNvcx4qFy2ybJKLxlPxSOqRHRIgq94NXuJfpYirAl7+utFdCDNw1wukaT8d1iiBo0KzMHXdU6ux5rdXnI1AfBKrjqSPDxMq228NwEwMRxoVGlJFkDVedQxvFg3za+t70ZFm/jUTXIEv93wwtI1Hq5KRkmGe8Po+Km4JkfVYztM8/lnXT5uPWomJUsTDMTS1AlpWHPlIVCf5Z9dwY37B4cUdmaecQ8+gPKQtLbdFAylj5cwbs6aX0QkZ35RMxcXDZw85OE1rFKbq6S2mBsAqzAtUJUKo2ENBvtAW22aVSJn0My35DbRMOB67gdD97tG02TmvHpvKH7voZ+I13uQzfTT+xG5HC+RShU3zGrZox8qChzO77fxg7I4w2VB5O74Rq4ok54tLfkNCYYfsVIguuonslp eSGOySXx yXhNrcRWNT1O0meRK2YmybBhGrtxypmlaNivT2pTRZMkhjbCnXvxsLkIsLJY1fmkfZ/Vl2qaTqR6c9Aq6XLXmQPxeCgzS6PnDZoMRoWDz7orhLrYL+XoQmtbYH5A/ZTZPWFZEQI1KKaQWwEbIikZPqywuOys3+doRouEEIJZpAZ4lnvGLYDB+pNBv9mrnFsO496xVILDouGPfGEUXHe7I8I1wb69F5GWtstYXDZEwDMoTKvGa8lsHVxTqPmhLkcBQfuDFWxWdAOG/tnEnd5RnmxJI/ZHLkaMeVwfYxk+Vk//QqSt2sUk0so7x75yB/CfG/uOB48O7fUqEwuzhx0WOT/ucdF44CpKQOhXhWkyeACUqJWoOwxY/fgPqG54+7deIAe8mQ1Z+hnly23CCXYbXbL+BwPyzzG0TKXx2fKv0gE35xfXn9aezyNZLnJ5PTtYvaRFi0DTHfCkXu+nYg2hTf64KwMl4Mh8/povEH1qgfnq6yD+v3JE0a9k7WHsHQQI0nrFo30W4QC4EJGCkkba0+qHvV/XvQ9Ap+cBDtnl8ScSyNrJlx+AlungM+Tn+Z+efCjVuppo4syp37R2D92B9I05NCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We don't need to count nr_initialised in two cases: * for low zones we always populate it * after first_deferred_pfn is detected Let's move the nr_initialised reset down a bit to reduce some comparison of prev_end_pfn and end_pfn. Signed-off-by: Wei Yang --- v2: move it after first_deferred_pfn is detected per rppt's comment --- mm/mm_init.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 2dfb87841fdb..bdbd800b0436 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -676,6 +676,14 @@ defer_init(int nid, unsigned long pfn, unsigned long end_pfn) if (early_page_ext_enabled()) return false; + + /* Always populate low zones for address-constrained allocations */ + if (end_pfn < pgdat_end_pfn(NODE_DATA(nid))) + return false; + + if (NODE_DATA(nid)->first_deferred_pfn != ULONG_MAX) + return true; + /* * prev_end_pfn static that contains the end of previous zone * No need to protect because called very early in boot before smp_init. @@ -685,12 +693,6 @@ defer_init(int nid, unsigned long pfn, unsigned long end_pfn) nr_initialised = 0; } - /* Always populate low zones for address-constrained allocations */ - if (end_pfn < pgdat_end_pfn(NODE_DATA(nid))) - return false; - - if (NODE_DATA(nid)->first_deferred_pfn != ULONG_MAX) - return true; /* * We start only with one section of pages, more pages are added as * needed until the rest of deferred pages are initialized.