From patchwork Tue Jun 4 06:29:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados via B4 Relay X-Patchwork-Id: 13684737 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307B4C25B7E for ; Tue, 4 Jun 2024 06:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9ED6B0098; Tue, 4 Jun 2024 02:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47A446B0099; Tue, 4 Jun 2024 02:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A786B009A; Tue, 4 Jun 2024 02:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A9AA6B0098 for ; Tue, 4 Jun 2024 02:30:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CBEDD1A0978 for ; Tue, 4 Jun 2024 06:30:07 +0000 (UTC) X-FDA: 82192231254.23.F54EBB1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 3ADA41C0016 for ; Tue, 4 Jun 2024 06:30:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="RkdsXLX/"; spf=pass (imf18.hostedemail.com: domain of devnull+j.granados.samsung.com@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=devnull+j.granados.samsung.com@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717482605; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lNwBqg1RlHfDvgRNDJRYuz7PqZC1ddC3YzSMApMVVGo=; b=Q7ijKjDr144j+C1uichrbcStk4VFP+OJ9A7MNQHhwp/iyKnFzv8a3C4QIb+saD2m11M2AN PliVHTJqcY6J3oLNKoT4bmVTo45qpplAeOlaywt2XvG5gamgLrinZYNtuTUhLa2vG6ZBut Q1DQD9fS7KEgN5od5NSADMUEMe9ft3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717482605; a=rsa-sha256; cv=none; b=BK6OpX/RElLH9JoiIdl2D5XeMPQyEsHUZSe3Qr+/7FkVtJ1FdsDrB62b42XiHb+OutZDwk 5AtYoGMVdsZFCkqbmpqrhmCrNH6UlHbQY0Is7yqWOKckIM+o5j+vWSGEEztNnDAeIE5xTp xOivfVQo/b3BmY9J5DzoswbguykmF+s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="RkdsXLX/"; spf=pass (imf18.hostedemail.com: domain of devnull+j.granados.samsung.com@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=devnull+j.granados.samsung.com@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 96446CE1021; Tue, 4 Jun 2024 06:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D51BCC4AF12; Tue, 4 Jun 2024 06:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717482599; bh=uQvKTedfeUJ5bmniBUr9CwYhnYEum8lzyXgoPJAiEIM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=RkdsXLX/rWNsSnP1w0vpeQO8ySbd33WZFy1o2u5e5N1MaiUcQP2TG2eJUTndxXt3q 6OxqXH4y8t+bk4SdJBB3SvyQOefglzILYK2uP527CPP9zD1yZnWraBkOBsm4sLCqvX /iqL5IFdy0HEEVY+3Hvot+cQfBKhwaGAZLW2Nbh42ex6j3bVFoM2Kgz7lYTG5Ge4cI NkKMcVXcV1cGMITbeti1Mx3rTuvfM1gBbZ8rdw4zC9O1kXyytocY5qr22xKPNCjSgi OLoI75IpKFkEerVQqpHzGSKIPc+6ljn5j5vYU/Lr5hciFXi8M3TBJ8M6gjr5QnTVYt UYTwzOiJ9VLAA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4ADC27C52; Tue, 4 Jun 2024 06:29:59 +0000 (UTC) From: Joel Granados via B4 Relay Date: Tue, 04 Jun 2024 08:29:24 +0200 Subject: [PATCH 6/8] sysctl: Remove "child" sysctl code comments MIME-Version: 1.0 Message-Id: <20240604-jag-sysctl_remset-v1-6-2df7ecdba0bd@samsung.com> References: <20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@samsung.com> In-Reply-To: <20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@samsung.com> To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Luis Chamberlain , Kees Cook , Joel Granados , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2907; i=j.granados@samsung.com; h=from:subject:message-id; bh=0XKCBtKXUsaQ3icltpQ/GcT4z/xTnWSxXkUvgvEAqjc=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGZetGSx+J2DsW2akHI1bXUBxwZLWJOp+r/vp Mjc/iI3BpjvEIkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJmXrRkAAoJELqXzVK3 lkFP5qIL/1mam3EXhTaxS41hy26Dmq0UjeoUbnRZYhSzHmbvW3UT9tGd0CEzkRmrmeO5pdUckpq /Xdt4dyVI2zsF1mpS0/senLUoeACPSh46rmxp5ymGQQZ999WnsOewsF44Mjh/agSxFKYLIMWhTu HP0QK15UKiFYjQVS/IcARz0Rq96i8bWVETbMGfCvTSh9swmqxWj7VqNDY1mXl1MIHr+Mzh6tdB1 AHaTV/HasD29w/8TIBI7J+II662XOod/LWhfuSYUKtkxKQgMCOw8wqIouOv1s9sdsnFR/6uaxEC GOHVm1t4sQ7GsSyaRwvEVP/aB5SnRGWn6408TrOz7E/Jn2sabbqUB9Ordb2H8FP0Ss88mW8kE2O GNFLoqO6pDYyWYSvXKLsugRX5f17Zhth9sYOdKExC+60DIQg2SFQoQRXHGGSVPBDFu/eLBCxlx9 jOHJAUn2H18r9Amtf/jCtQG51NN+gJH/ndYTe9NkwKnQpjhiITpmpMdb6QjPMrDMs8MnrpY0xV6 tI= X-Developer-Key: i=j.granados@samsung.com; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for j.granados@samsung.com/default with auth_id=70 X-Original-From: Joel Granados Reply-To: j.granados@samsung.com X-Rspam-User: X-Stat-Signature: q7fsjrmgor3myy7img37rgtpignh5rx4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3ADA41C0016 X-HE-Tag: 1717482604-365307 X-HE-Meta: U2FsdGVkX1/MclzkGWkLJtqsCG/idW1g8LyotoTM69dgMsvlwVQ/3Gf4Z/rLulisxT5FZ6XnzD73F4jIy1StEwZYtCXll5G75qMASooTFRp7toOLIZ+mp4QX3ghTe6PDmm7yH6JpznR0bvK6VVeYM3MvcsQIAGWVW+QTqR3g0yuApzJjF3djc8Fyi1TD/3TiYEGxjBN0Nln0xOwe4ny8Kj2OM/Hwq/xIKTrGyG82K6CLvKQkL/ndFD13TwVPpPc2l3BRK1D/jwRjDluJ7m2UWBugq6ZPL00S+BgJjWwsmciu3Zachw/m/UPfPgDReCntBinTmfblYRe0sYDehchLP1vINyoXCf673GP775A64QGw8odA+L6OF7e5cJV8U4nH6ewtnj3OU6MPEUD0ZpFKHzORIVMUMz2QyeDE+PpZaiGJ5wRJzXhl+pidj4FmeS5xT++39oBReAMigLb+rVs9r/3QZ3SyIqaW06tTWKzu2qsFwW496MrcXBqNC8dJnmMAxOncwRcoo7/BXWkIa4WFlvgENzR3O36IYry03HfYg2BgZKE4OZkGtthD6ee3gvWNyPlFR4jKBswhf0/e4/qveTPS2fME84si1Cx17LctEaenvYwi7wiKYc0tU8pUtZF+NmS/F4aMNCZMuUJ0M7h/u4gAl0X9yImmtb4jR+wO8avSYWqs4qqZjoblwF79E2CB5zvK7Vfb3jIX/GUJltITC9lAbfg3i7vJfRliROM6LbTKFKr4bGQ5iI2Ma6TALRxwB93kwtcd/bpayJ3Sz9pruO0dATu1NeqNaYZpJxwH06CbRfGi6dbClgSvhPEFhyo08XJgmVOmBy5Baf/vwMjJSzGBWKOV9H41lYAF3cyG0TX8eFLFU0ZkLlRij4qelELJdAccgNDU5lAWLW/mWfQZoL2fk+oYSzGWqptzcehVHiYygSvhIMm3WZNcIRfKzIB1AJXVjDPK4suraFrWJzq rBnAQMrH P+Y1cQheMAevHWsUJU5ChBG7rkNepvyYVpB/tZvc2lnm8GJOGXZeOZVMO/r6imXOMHf55VxMZspJVM+hPRsARMhKonfRlp2Su0w5j45/idYIi/EFMbCFSptkON8sG0mXda4+LccO0cqzBf8tT8jlc1kTp6rWtPK5aMM/BV0dSVihupbOCa2gPFRusE1UPUEDNU6TQGWhvQNfYau83XSGEGvciXmiW9e1stnOk/mdT2jzv8eNiG69SHRxfIA/zUt7tncYMB0k4QkwDkit+ejKe4k/PIbp3pNPEaXmu5CLPA1V002yDzgR/C4WISST8K8id8lQbVO1Wwj5rQcmCT4iU+2CEpX/qId2GEe1j/FSFatUzIefmkMOtHVWVvtCKv3Hlb0NhgqjpgzOIoPEWw0Z/8gDAoAQT1pIKFuNgPR2Qwq0kN5Wh264rM7uC/cY7p/27WKNDQaq4jAujr0zzd5eyDzi8eziToaNqYzQV2J+3mJzlfLM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Joel Granados Erase the code comments mentioning "child" that were forgotten when the child element was removed in commit 2f2665c13af48 ("sysctl: replace child with an enumeration"). Signed-off-by: Joel Granados --- fs/proc/proc_sysctl.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 29d40f0ff3ff..2ef23d2c3496 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -1298,28 +1298,23 @@ static struct ctl_dir *sysctl_mkdir_p(struct ctl_dir *dir, const char *path) * __register_sysctl_table - register a leaf sysctl table * @set: Sysctl tree to register on * @path: The path to the directory the sysctl table is in. - * @table: the top-level table structure without any child. This table - * should not be free'd after registration. So it should not be - * used on stack. It can either be a global or dynamically allocated - * by the caller and free'd later after sysctl unregistration. + * + * @table: the top-level table structure. This table should not be free'd + * after registration. So it should not be used on stack. It can either + * be a global or dynamically allocated by the caller and free'd later + * after sysctl unregistration. * @table_size : The number of elements in table * * Register a sysctl table hierarchy. @table should be a filled in ctl_table * array. A completely 0 filled entry terminates the table. * * The members of the &struct ctl_table structure are used as follows: - * * procname - the name of the sysctl file under /proc/sys. Set to %NULL to not * enter a sysctl file - * - * data - a pointer to data for use by proc_handler - * - * maxlen - the maximum size in bytes of the data - * - * mode - the file permissions for the /proc/sys file - * - * child - must be %NULL. - * + * data - a pointer to data for use by proc_handler + * maxlen - the maximum size in bytes of the data + * mode - the file permissions for the /proc/sys file + * type - Defines the target type (described in struct definition) * proc_handler - the text handler routine (described below) * * extra1, extra2 - extra pointers usable by the proc handler routines @@ -1327,8 +1322,7 @@ static struct ctl_dir *sysctl_mkdir_p(struct ctl_dir *dir, const char *path) * [0] https://lkml.kernel.org/87zgpte9o4.fsf@email.froward.int.ebiederm.org * * Leaf nodes in the sysctl tree will be represented by a single file - * under /proc; non-leaf nodes (where child is not NULL) are not allowed, - * sysctl_check_table() verifies this. + * under /proc; non-leaf nodes are not allowed. * * There must be a proc_handler routine for any terminal nodes. * Several default handlers are available to cover common cases -