From patchwork Thu Jun 13 15:34:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13697009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72ECAC27C4F for ; Thu, 13 Jun 2024 15:40:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3712D6B00B7; Thu, 13 Jun 2024 11:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 321EE6B00B9; Thu, 13 Jun 2024 11:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FF366B00BA; Thu, 13 Jun 2024 11:40:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E374F6B00B9 for ; Thu, 13 Jun 2024 11:40:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A99B41C03B3 for ; Thu, 13 Jun 2024 15:40:02 +0000 (UTC) X-FDA: 82226276244.03.D873052 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf13.hostedemail.com (Postfix) with ESMTP id 712DF2000E for ; Thu, 13 Jun 2024 15:40:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RNt9Kpbt; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718293199; a=rsa-sha256; cv=none; b=qYRFxs4oF3waCOdoRGzaVNkiHlOfTEIoc8lklofFNbxzL5/UagsLB1Xk9ZxY9KZ3UjWZU6 OSHRQGxUyA95smy/SQk0ZxTZo0DVXNoQgd8ESi96YPenLKJ7X5ZGY8s22jt9Hm71LNbRhF uXgYDtPyR94CwwOWtbppqhUJxknlrgU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RNt9Kpbt; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718293199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPY2/xfj0WoITwfgq4isE+nahUee+x7RgpdrRutXdLc=; b=lIYJ3lczVu7eLt6U0mM3/T/UOwDNImvubEVzQ/qIcJ0aXY3n+9pOy4Hk6Fh4hr6RFHvds6 7ZK9j1H11dnyckkWvzP1ZyTHh2med3BkEErDj6zgQN3B0Y7EAT2jGq0aCpq3jwvGNg6Fb9 AZjLZtnxaYVLu0m80uP6frZSVUBPWoQ= Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45DFQWrG031303; Thu, 13 Jun 2024 15:39:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=tPY2/xfj0WoIT wfgq4isE+nahUee+x7RgpdrRutXdLc=; b=RNt9KpbtT8zBkD+WuuQkoJfVFmKu+ RBc4v4DPmomg9KJxhTXgP8qrxggTUGaCDs47zrux0UusTn9FwnbEVBQX8oAbMHwE BM07tWNkcX1Vrvkei0vClxE5jmniD5YF7qz7dybD09S/HpUj9gXOhsRIcX+/55v3 GOWK8oXqqG6Pw1wulaZR4jrZwWT+nBA7V9yxg6xmnzafzIZgurR9rbj5pm7so0J/ 3603+UzkIGPonrxREn4ivyIpoTNoW7725FjQTp5ldA2fMjnCRylHQ8xghvUAuGgj q+Qn0GgicoRg5HbGCpqtQoR4U0Dr/VhLL4WuwjTz7MxsZTfI6lIZT9r7Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yqrw7hv3h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:54 +0000 (GMT) Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45DFdrZX022239; Thu, 13 Jun 2024 15:39:53 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yqrw7hv3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:53 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45DF9UK0004368; Thu, 13 Jun 2024 15:39:52 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yn2mq917v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:52 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45DFdkST44368360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jun 2024 15:39:48 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5DC12004D; Thu, 13 Jun 2024 15:39:46 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3367320043; Thu, 13 Jun 2024 15:39:46 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 13 Jun 2024 15:39:46 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v4 25/35] s390/cpumf: Unpoison STCCTM output buffer Date: Thu, 13 Jun 2024 17:34:27 +0200 Message-ID: <20240613153924.961511-26-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240613153924.961511-1-iii@linux.ibm.com> References: <20240613153924.961511-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hp04Eoi4U7PgytUYtQKm5O50m1EiIDWu X-Proofpoint-GUID: aOZfXgWJlu59bLyx5qDPGv483tF6W8_R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_09,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=957 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406130112 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 712DF2000E X-Stat-Signature: 1rpb73tncpjbuij8ft1g8c18o8cm169d X-Rspam-User: X-HE-Tag: 1718293200-661320 X-HE-Meta: U2FsdGVkX1+6knuTI4aAwSuk3FFsVYexd0r/zy78XG2Ea8T6DBvj7MoKa7X2lTXQKEUHxd7rvWrqHtumYpraBZG5BJ1VC3lEAhNmJM1kC/eGkNtKVVAK2vUXQsxlEeNRYG8IWyHSiOtSaMxQ0TrdWU0PCuam5z40EcUtz7uR8zVt58v7jZiXPyV8iPBnIebSdqIXE9lCrPhtys2bpmWBwVLmPnF23ho5rLZDU8sLuSS90Ytu/QH/v5fM5qr7qVBXhev5o+q4imdQOWMyaf78o3NECuAgq+1Gfmja3Hjy+B1jUHxmShxBaoij+tVF0wk8o6JlWwP9FBKuWfa9RPPcUATGjYfoTuGreBJMzMwmdZqEKajH+3EyXsn1fiJB2kuzFyw6HMezD59oiLTcCZ0l/gztENTpzRzWw8RiwghnlBBOOdho3H9DsSEEUMIfZ6CyXabZJrFP4OHCgF2Q7rBKG1EJq7hNRnEv/LeNDlVMP1IWiLT+wdq7El5OgKy6VgsdsopgJZ+8EOhfduxu7r3EeNskpKIB0vNc9F8ymAiu/xIfvx26AOP91TRwWSXYNVudTrYNTTZj45MrUUBVs7yNithN+ClksNGE2mU1ge9g9tECylVU7opZplkoBffaEMYve+cwvQvQPQ/CfYM/JJZIMNwarudIQl+huQD+cmxZUGrppclh5FSa9IWxqlcCylNjODJHeciraJrF+eMbWKGDWTOcWjr3VOcwqe9KlUX7nZZI09XowBviB31tAcNGjIQUOS+sSJqSrOpKut0R5585e/tmydgM8PG2BGXqCbY0B+smpPhewuFyikQIYx4L0f2mT30UV80taDKlxh7d32IYGtxHw77mmkBCbaGL0WwRKNmF78QPPelzamx7B0xbep/rLBCOp/wRpfXFf/GVzgzcKn5lgQ9PXz6cXCsiiaRXjhO4cmmPqEsl7MSuBP6HcLXefzhOL02sYnO5wNb5iGR z+lIz9eK gqvVTqP0rTXvDvPwYLCGde2AYXkSjJ0dzVdTFbVGhvvg7UrKj4lDJeodQGtHl9UfNvdxEkf4pmUgPDDr2mtZMxoDUbzJONV4bl7RyGUMWV52VURXEJ81L70+f2elc1k1mvxBCZKaLe5HC1pxfevl37f6plYu5mzlmg1MWOx5JVWSf73CDPYeRgb8jbkUlZiK65cIkB3wnwG9Hx7qkw3mMfNS38PiYLKDwm2o5cugxHI5BUOxYCFMBUpaE2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: stcctm() uses the "Q" constraint for dest, therefore KMSAN does not understand that it fills multiple doublewords pointed to by dest, not just one. This results in false positives. Unpoison the whole dest manually with kmsan_unpoison_memory(). Reported-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Acked-by: Heiko Carstens Signed-off-by: Ilya Leoshkevich --- arch/s390/include/asm/cpu_mf.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/s390/include/asm/cpu_mf.h b/arch/s390/include/asm/cpu_mf.h index a0de5b9b02ea..9e4bbc3e53f8 100644 --- a/arch/s390/include/asm/cpu_mf.h +++ b/arch/s390/include/asm/cpu_mf.h @@ -10,6 +10,7 @@ #define _ASM_S390_CPU_MF_H #include +#include #include #include @@ -239,6 +240,11 @@ static __always_inline int stcctm(enum stcctm_ctr_set set, u64 range, u64 *dest) : "=d" (cc) : "Q" (*dest), "d" (range), "i" (set) : "cc", "memory"); + /* + * If cc == 2, less than RANGE counters are stored, but it's not easy + * to tell how many. Always unpoison the whole range for simplicity. + */ + kmsan_unpoison_memory(dest, range * sizeof(u64)); return cc; }