From patchwork Thu Jun 13 15:34:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13697011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B25C27C6E for ; Thu, 13 Jun 2024 15:40:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B15966B00BA; Thu, 13 Jun 2024 11:40:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A73326B00BB; Thu, 13 Jun 2024 11:40:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89FBB6B00BC; Thu, 13 Jun 2024 11:40:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 671296B00BA for ; Thu, 13 Jun 2024 11:40:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 234371601B5 for ; Thu, 13 Jun 2024 15:40:05 +0000 (UTC) X-FDA: 82226276370.04.7942DFB Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id C1C054001A for ; Thu, 13 Jun 2024 15:40:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UNq2L3ci; spf=pass (imf07.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718293201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lwqEGphQg9/N4AE+qTFRbf/COwqV90p8RxwOJfRaDvM=; b=dkcfzLWEcZEB44QfXCz6M7cDL6p/hmAXpTGzFPHYuXDJMXDYRpKJGP+9PH9ynNOUoCtX5Y F8SQycMGRy/PFHacHRBqv8RS+TLwyHDbpgSXfxD3mcSm8MOMQFJseRB6jd9IuvMLuL7gbF enGs/Ig/W56++O8+x6iqCW4bHSw1RPY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718293201; a=rsa-sha256; cv=none; b=LkdwBsZ0yj6o+i/xtpl0vF+sAhaHdOsX5Kx5vSYtUIA7zc4+f/N4YuLbS/rUHxizNcDTLz lZKgEGwWUZS4Dg3hnoi9keJ7b3JZhLjzSolLG1YQGdo/Heo7IgYNUtMHosOMdDt+5Hrjun Ul93krGx2Y9mpKFexhcmk22LXtWhJCI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UNq2L3ci; spf=pass (imf07.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45DDPs1w029160; Thu, 13 Jun 2024 15:39:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=lwqEGphQg9/N4 AE+qTFRbf/COwqV90p8RxwOJfRaDvM=; b=UNq2L3ciAeXeg+Kl5XrEnosDMTAs8 Fo0GmDd0p2UK4sKNA+8i22Z8U/Dtg8kijuN9KTRbaw7Onv3/SzsxFjcX8m9szLB9 k2Djo/VBBYJIKWkLW8HNMFMz2b3mt/mhnRiTwtdqipTrQ+CjALv9hB9Da/8mVwSC ond/9p61WCawUt2YtMJPw3EW0SbA+5kxbGVdLvnSE3NyrNainusnb4tf5ycXcIWy 7qMIEUhdiGKj2xB5XJ+3lJgwZtP3+rKwTq2nT9lbIgkk4Z0uyDouP9RGbFq5zoNI apQbgPmsZ+J8hgHp+LPiNO59yOAMgMlkJ8Ouu7nMw/dY8imTQ5EE05BvA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yqq4rt37b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:56 +0000 (GMT) Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45DFdt6d026856; Thu, 13 Jun 2024 15:39:55 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yqq4rt377-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:55 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45DF54oG020086; Thu, 13 Jun 2024 15:39:54 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yn34nh0d0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 15:39:53 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45DFdl5E31982318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jun 2024 15:39:50 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC8BB20063; Thu, 13 Jun 2024 15:39:47 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49DC72005A; Thu, 13 Jun 2024 15:39:47 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 13 Jun 2024 15:39:47 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v4 27/35] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() Date: Thu, 13 Jun 2024 17:34:29 +0200 Message-ID: <20240613153924.961511-28-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240613153924.961511-1-iii@linux.ibm.com> References: <20240613153924.961511-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2CzzALgI92z2xp9DoNxArLwRD-45DbUj X-Proofpoint-GUID: vaNzi9dxYUytn-myd3xb7t8cTOvep84K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_08,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406130109 X-Stat-Signature: yp7bboiho4p5i378tco34mkdxdjinc3k X-Rspamd-Queue-Id: C1C054001A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718293202-873320 X-HE-Meta: U2FsdGVkX183iwY4KqJC8iFy1tqEhbbZpS4YFlQsJ7b8DpLUesCbOE2MoiUuMA9WyaXmz72m0xC1C6nUxFftkvlUewj6UZX1q3mOtHhUePaefsgJUKdQPmTA6FGQerV94tTgyKJ7b+mhpQlQCpNOt8MhIRyr6UM4yW4gMQWlPveE26JrAhotHS25wcqk65/w2XyKhTmCiFOOy0C3gUCgpvIH+o1cwsttBJsFPpFOKE2SHojUCVsKsim20PyFz8e2C6c1L4bwOMToglHXlwW3G03eCYTg66px49+t4jbA1eu3XVEi4Z3bfJvQZzZ307H72sAnSvtm3ErBr0+nhWcmKzcNMlR/3GqbSqyyfDTkolifuuOCqOr+7h3fsg21K0eHWiCEcyDgffKWAwN9he4KTv+zbQ3pQkVhwB1oawpu7wr7KABibbEGuBMvhLz9Iriw8perOriNNIjiShlGNVtVQhWOs8OOaNE8Se+ksc4g/z9fVerwb7dCNPhdeh653xRtzz0u+8RTPx7DpvmY1xObvcCE7i4P0VZ8naxhdwX5soKFvsqmgqc6M5v3bK3j06qruIRN/rPU5i1fOI1ayVcVvemrz9TvH/MVFMx6yVwzNVAQKt0THueZOUujSU6ERBxlM6KpaasEjgiatZaDDj1VPXOWYMcCKXA7bs+Xw9LCXttxVG7C/uAmil/W/+/WfwEVuROUNZlGlkcRVAZSx1Fxd8qPf7crq1kaEVejXFPPziObKGcinyPnnR900JzBioK5WWezQf2ieOqGbPnqFKjivhB2yiZDd53eLeYkgQV7CV+ZXrRmANGsUiPfzjdaMNhNNUvKOoAjkmKJ4Y/DdHIhzr/qNQnayA0I9QxIdsXmFBvPTcJENLg+wABcWjICjrVQ2vFO74AwVQX6L9S/Ph58bDupYXgxtFrwcy+0ZXZTkrxLE+d0UQ3I3ngXr3SA0IWlAiAPsmsFYLP96Bdb/ZO NJO/+/vE RdTOAhJ2ueoXTK786cEDjgtNx41NTwB3RWeXj54yzldjS0KXn7MTGKOK10ML123f7vyKciczGXRJjFiKsN++lk67gJfXAgEdFEo1KtbEUNUA1fln3x6yOjavFVDMHyE1xTXViDJi1alw/6OiPgBPvmmmR2LWUBBkLAzMSkLgKWgCfsngCGJ12zKtbqFCu4OIo89NflyR16ltAUJQmv81lgmJfQfvyWVGn9y5Y8SVqVRod1QF61RUclFMo+CDB5vVtfwNiE++rTFwqnBFC0smw5ev/4fGRcKZ04tQmXubJVdxJMd9KiUxgzNe1CPSIj8FG3ag0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: s390 uses assembly code to initialize ftrace_regs and call kprobe_ftrace_handler(). Therefore, from the KMSAN's point of view, ftrace_regs is poisoned on kprobe_ftrace_handler() entry. This causes KMSAN warnings when running the ftrace testsuite. Fix by trusting the assembly code and always unpoisoning ftrace_regs in kprobe_ftrace_handler(). Reviewed-by: Alexander Potapenko Acked-by: Heiko Carstens Signed-off-by: Ilya Leoshkevich --- arch/s390/kernel/ftrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/s390/kernel/ftrace.c b/arch/s390/kernel/ftrace.c index ddf2ee47cb87..0bd6adc40a34 100644 --- a/arch/s390/kernel/ftrace.c +++ b/arch/s390/kernel/ftrace.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -303,6 +304,7 @@ void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip, if (bit < 0) return; + kmsan_unpoison_memory(fregs, sizeof(*fregs)); regs = ftrace_get_regs(fregs); p = get_kprobe((kprobe_opcode_t *)ip); if (!regs || unlikely(!p) || kprobe_disabled(p))