From patchwork Mon Jun 17 05:29:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: aigourensheng X-Patchwork-Id: 13699943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7945FC27C77 for ; Mon, 17 Jun 2024 05:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81BA86B0135; Mon, 17 Jun 2024 01:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CB386B0136; Mon, 17 Jun 2024 01:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C236B0137; Mon, 17 Jun 2024 01:29:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 41F166B0135 for ; Mon, 17 Jun 2024 01:29:48 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5EE41C1CB8 for ; Mon, 17 Jun 2024 05:29:47 +0000 (UTC) X-FDA: 82239253614.10.0DF37E8 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf14.hostedemail.com (Postfix) with ESMTP id EAA3210000A for ; Mon, 17 Jun 2024 05:29:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QndNt9YQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of shechenglong001@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=shechenglong001@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718602180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=TUsI5R+Z0iy5fF8mDhU7qwVZOawS/mIqRte7Pe8J3zI=; b=Ac6Cjc0wyMHSO1TawpMBC+EdZPggoiCqSaZTCkJiuEykkHtsiRz1j4sjIeqLqXVaejjWIW g/CgfzTqcVjCp5v4R+Kv8vnVelFBbpcdkxBe4AuuNM/S83q91LYueHc4e/ZJjtjcnFMa1q yMnafVdKJ6HBPkSmoJDeAycAOUMPWOk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718602180; a=rsa-sha256; cv=none; b=FADBv/9FwFIT4cAH8QCvKbS8AgxVfCKgCRRijtLr4TMwumX0tLOXBtdVRHwkOit8C52YlB c/ham2UVxdCY5LJKuB+0e2A475+sZNKEx3wN0sI3amigD+eVIvq/p4CB+98mi1EAmLVgM8 n56Euh3ydtBBW8NYgP9uOrleeuTDJXQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QndNt9YQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of shechenglong001@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=shechenglong001@gmail.com Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-2c036a14583so763506a91.1 for ; Sun, 16 Jun 2024 22:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718602184; x=1719206984; darn=kvack.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TUsI5R+Z0iy5fF8mDhU7qwVZOawS/mIqRte7Pe8J3zI=; b=QndNt9YQYvVZJzzGKBGZZb+dgRRnkjpNC7Lfn+MkWzJVrJf6ibs0nju0N9vhdKMYx8 qFTOpod4d5jh994uBtiAP/YI+tohaGQIYDjm2f91pQgQhkCfz3WpS1HuiKU8p5/Irc6l X1Wjt0dWiA2ouPa2VV3LuJbabDp5nVBUZI4Fk+OPHA966CJsoWejGNZwS8S697KEcA14 kPy5bIkVXxrU4wOY3ErJnM83WB8mgSDq0FE6075olOy7ED5kYl9OOPNikWaUGDeniv8H MKDwJlYz/PM2KIWOw5moTEwLsad2Nk+9yi6+2ExFJJjXCqecF6B+89VSXx8rcrbPEz1g 3HJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718602184; x=1719206984; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TUsI5R+Z0iy5fF8mDhU7qwVZOawS/mIqRte7Pe8J3zI=; b=pvMBGzzEX+eYqHtQ5pJ2FHeVugAjm35XdQYZknbBZ5Zk+fI/jri1CeJH3bclxaHH77 NqRUMN2L4mJDZMc/OMZG0ULmT27iNb3GKiaAEU6+Sn8eRWERngfGcajCEyKDVIeiS9Xh ginpaf/tL/wFFOpOFbqy9qBtFc8+7dtTriQRUG4GlsupMngGddvHTzUwv3qhy5oiquf2 BfQbrEM2Niq5obgHQTXFCXuPXmJsJTH2nJJtn3C/1DA/I4aBBrgf1cwR1HlUYTgx2Z4t +BHgkS+OFrrZd9U+M4DK52VvarGJiPPvMJMTgJcPQZsSGBciDKY1tuMr0ASX9snf83wx OZFg== X-Forwarded-Encrypted: i=1; AJvYcCVMxHJsqYyooM98Xw5MjvY0pZUZm+5FFDB8mX9LY3CQJoWX9unJ9q8jEpNtgWXsbVXHtJsxuJsUdVFtLqoX9SgQmHg= X-Gm-Message-State: AOJu0YxSvZMRimb0YeoZQKBG+J8NQj8gX/HkcY+KuPU7lVdCAjkvb6Yh sffrgCAyCHA/uk5WhB69N5dp6XIUw8cvAYjQVeLKHHArj1rPfGMj X-Google-Smtp-Source: AGHT+IH3QQcBtYgpWXy8Eibq53Mk2mB6I+M4MbSta2aASqh/Q1m8xZoJHiVBxZsXJ0RpaXUKk29i0w== X-Received: by 2002:a17:902:d4c7:b0:1f2:f9b9:8796 with SMTP id d9443c01a7336-1f8627eb9fcmr102562255ad.2.1718602184316; Sun, 16 Jun 2024 22:29:44 -0700 (PDT) Received: from localhost.localdomain ([117.147.90.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f88daf2b8dsm11699355ad.193.2024.06.16.22.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 22:29:43 -0700 (PDT) From: aigourensheng To: akpm@linux-foundation.org Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, aigourensheng Subject: [PATCH] selftests/mm:fix test_prctl_fork_exec return failure Date: Mon, 17 Jun 2024 01:29:34 -0400 Message-Id: <20240617052934.5834-1-shechenglong001@gmail.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EAA3210000A X-Stat-Signature: 7hn85mhmk44so13t673d6dnk33ta97ny X-Rspam-User: X-HE-Tag: 1718602185-205609 X-HE-Meta: U2FsdGVkX18w1E3Ru5t/svXpBXCEzO1F+Nh68xm9w3OLRfJbGi3Hr4NshthqjgmGHflH/LIq6lEuVlxWUFcI8Z585ik/mLHS4/zCZHD+Lf70YYoxtclhJLyJIm0Vzv0lpolJnFCzl6XbuO9LoB5ELOB5ZWa69rOnYy++lq2xB5ixIZ8cCtB+grbHmZXrKmLQ5fqGVCmpnNxsVq5XIR6CEX3qveWOJVhZ08hLitxg2x8BzM1RbGlVMRoh+C8VkbFejfpY4CBdVsESjYc+Zg/D0iboyokXFoDKiv+NvIqvJOn6NxzKlnxN1k9VM+Q5G9kersl8eTqFOsVuMe20PeluFR4vSPTOZfdcuL8mZHryVMByn8iatb6QGWek39U1PIY7/ucR5hob/uzCxjwHA9QBBD4Rb8o3YZDpMqOe7klIwV07xwwAThL8Vt9S0Pgv4i89OCFzPWdHzdicZtAO4GRXXEWjBzjyJW6OnoTlSy+FlXYXDulVG2jvtcn7YkBFYrex03pbHEl149W7v+Wdeol4ZYc0ZWg76E4jTMHGb5haQOZfjOoufuAl1gZNI6iE3r6yAq2dSLVrp7DC973jW219yCwT5OIAIf//kv417KiWpZSgbvPCWUI8JQiw4glbVFH0jIMk4bGYeISDPi4CysEwqLVl9l7zQ8C2JBJEDRYrwQKfPOLkXg3OyT4TDAB+46qHSDgKmd50rTBK24AC+ytTLG2L0V/IQdN8EEmOdOt8uNk2fGGbmT7D5G4K5/wHjdM6lpO5yNlZVmxRACo29FRYWHvLG9zGOdwebK1PkZZm1CuYFI5ETGxbwjmr8Y7x1Y7RkQS5UJrPmY+okacHs0fMHpOFfkw+oEhEVyEr3kdMQgSnRlgofFO9bmvKyRcffnoG4sRW1N0skmvsK6YKV6GhHApFU8zJfjg53+iK4F9lvlKColeJIV1zLEXR4V72QAtskmCvwCh7tBUO6eG40ry 9hAR4rwf Xw5RZKsTaoTYVGS2wg23kCeDszlCLIVVDwJFXBjg0MRUMNK1hrHdI4Chabx83oOfkzCBx8pCQMFhndrwAJgzchVAAPomgPo0dsHH7UI1XBeKXpvYZw4CRWkRs8qmaF6qaXwXpOyHPGEe807r2dnFghmut7sjfcV+Ue5SR2+3VDEhlF/JS45ymV7IuGFMuvEsTLQmlD4CeeiowLsYZOux8gvAP/FsevUfPebcSNuOt4RdjvhC4QJKNOZjFtTFdn32BtBkNj63yCAKNxke89SlMkjcNKcM7HR/nUtS5F8Pc6PSkStVbCNH9Nv5kVkf8S1FjWODOEGIc6u4AIt4BjHk24LOiOt5Cg4/PdZMr7x90TlP8nHy97OHStpr1Vem2s1dHTP5O6CrgBvtZv5ya5A8kax8RLQbiCKTaXtJi3NTjIHoPdU2+x7arplSWHpkEQRfyP9MY/EElutUwCGl0S3f6792GWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: after calling fork() in the test_prctl_fork_exec() function, the global variable ksm_full_scans_fd is initialized to 0 in the child process upon entering the main function of ./ksm_functional_tests. In the function call chain test_child_ksm() -> __mmap_and_merge_range -> ksm_merge-> ksm_get_full_scans, start_scans = ksm_get_full_scans() will return an error. Therefore, the value of ksm_full_scans_fd needs to be initialized before calling test_child_ksm in the child process. Signed-off-by: aigourensheng Acked-by: David Hildenbrand --- .../selftests/mm/ksm_functional_tests.c | 38 +++++++++++-------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index 37de82da9be7..b61803e36d1c 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -656,12 +656,33 @@ static void test_prot_none(void) munmap(map, size); } +static void init_global_file_handles(void) +{ + mem_fd = open("/proc/self/mem", O_RDWR); + if (mem_fd < 0) + ksft_exit_fail_msg("opening /proc/self/mem failed\n"); + ksm_fd = open("/sys/kernel/mm/ksm/run", O_RDWR); + if (ksm_fd < 0) + ksft_exit_skip("open(\"/sys/kernel/mm/ksm/run\") failed\n"); + ksm_full_scans_fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); + if (ksm_full_scans_fd < 0) + ksft_exit_skip("open(\"/sys/kernel/mm/ksm/full_scans\") failed\n"); + pagemap_fd = open("/proc/self/pagemap", O_RDONLY); + if (pagemap_fd < 0) + ksft_exit_skip("open(\"/proc/self/pagemap\") failed\n"); + proc_self_ksm_stat_fd = open("/proc/self/ksm_stat", O_RDONLY); + proc_self_ksm_merging_pages_fd = open("/proc/self/ksm_merging_pages", + O_RDONLY); + ksm_use_zero_pages_fd = open("/sys/kernel/mm/ksm/use_zero_pages", O_RDWR); +} + int main(int argc, char **argv) { unsigned int tests = 8; int err; if (argc > 1 && !strcmp(argv[1], FORK_EXEC_CHILD_PRG_NAME)) { + init_global_file_handles(); exit(test_child_ksm()); } @@ -674,22 +695,7 @@ int main(int argc, char **argv) pagesize = getpagesize(); - mem_fd = open("/proc/self/mem", O_RDWR); - if (mem_fd < 0) - ksft_exit_fail_msg("opening /proc/self/mem failed\n"); - ksm_fd = open("/sys/kernel/mm/ksm/run", O_RDWR); - if (ksm_fd < 0) - ksft_exit_skip("open(\"/sys/kernel/mm/ksm/run\") failed\n"); - ksm_full_scans_fd = open("/sys/kernel/mm/ksm/full_scans", O_RDONLY); - if (ksm_full_scans_fd < 0) - ksft_exit_skip("open(\"/sys/kernel/mm/ksm/full_scans\") failed\n"); - pagemap_fd = open("/proc/self/pagemap", O_RDONLY); - if (pagemap_fd < 0) - ksft_exit_skip("open(\"/proc/self/pagemap\") failed\n"); - proc_self_ksm_stat_fd = open("/proc/self/ksm_stat", O_RDONLY); - proc_self_ksm_merging_pages_fd = open("/proc/self/ksm_merging_pages", - O_RDONLY); - ksm_use_zero_pages_fd = open("/sys/kernel/mm/ksm/use_zero_pages", O_RDWR); + init_global_file_handles(); test_unmerge(); test_unmerge_zero_pages();