From patchwork Mon Jun 17 13:14:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13700605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303F6C2BC81 for ; Mon, 17 Jun 2024 13:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D98986B019B; Mon, 17 Jun 2024 09:17:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D48C86B019D; Mon, 17 Jun 2024 09:17:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC4A86B019E; Mon, 17 Jun 2024 09:17:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 97EEC6B019B for ; Mon, 17 Jun 2024 09:17:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5D7DB1C15C6 for ; Mon, 17 Jun 2024 13:17:28 +0000 (UTC) X-FDA: 82240432176.11.711B47E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf13.hostedemail.com (Postfix) with ESMTP id EEC202000F for ; Mon, 17 Jun 2024 13:17:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718630242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BSQBVf6bemUV+5seaJ7jz+AIBGiFG280F3gCi38n6/U=; b=BYzlaGpydq7IBMhQ8Kr0awNqtY1bMtvrM6caUIMUI4Ltnp6mquUgdkyGI7dVLj3ZTR0m+t tkWVqRuDaIGCxihIinf5BRLFz2o92eUvrVSSB/HmNvbDr9c0Q7eLH9bb7D6atRkfh7Ojrv fs8Cs7bU+V0cj0D3Gl7jfotdeAlbTPs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718630242; a=rsa-sha256; cv=none; b=MXsLRXHnAVJRe0fMO+qpe4In6IyhvPwBJWfYy4VQ0KyrTZpuoF9DcVRQpDWD6Z+1ygKC0T jckHDtMlEgCukSd3Ye5+An/bKcYp+oqeZee9cS+Sw8sqDG2mburwqC6QR/Z5ONAuaDqvEm DZMy0sXeDs9C7LOszFsFZYI329OAie0= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W2r0k5Q6YzwSvs; Mon, 17 Jun 2024 21:13:10 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 5175114011B; Mon, 17 Jun 2024 21:17:23 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 17 Jun 2024 21:17:23 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Andrew Morton , Subject: [PATCH net-next v8 03/13] mm: page_frag: use initial zero offset for page_frag_alloc_align() Date: Mon, 17 Jun 2024 21:14:02 +0800 Message-ID: <20240617131413.25189-4-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20240617131413.25189-1-linyunsheng@huawei.com> References: <20240617131413.25189-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf200006.china.huawei.com (7.185.36.61) X-Stat-Signature: seuwm6e3x5ozq1ftisca4nr1r794qwn1 X-Rspam-User: X-Rspamd-Queue-Id: EEC202000F X-Rspamd-Server: rspam02 X-HE-Tag: 1718630245-661944 X-HE-Meta: U2FsdGVkX1/snESA7ctStsHUALnP/9tkIvQCdtOXyrW47uSN4thILKpSOpE5iwaa/f1eT3xjrv/7l/HXQmL4e5n8OOf6CYrj0eoZQqfHx9OocStf7cw2pSHNlA9OGOrPp6Y2SxONKhVlKuPkfIwxQ2CxIrXrjYLEdE+ozdvDJolKQ7XZNn819xnVyhaxJFv3MjqefKPr7yxGDptF6hqpQY4xwHjA5d6NGkJIA2lTlow4vE3QmekF1XetNUAzARVpCNlGR8CNxh0Lzgsh9cvyIMippkS3tlG7L60jnr4tr+EM8Lm0UyBGKlRVVQmLd5g8qkjMpN9Og3OyAFeat2/80xTFpfdan/GdodLzyCMTKCZqbM1x7ms/oUdLvjb+5B2m0tcbtrDulR+WA/ogkzP1v2FPTUiWRqe6eOn5BjlxSVDkaR5m5GZT5FSU/PMkHw7lEGepJ+okLfhBPjRgxX8UaFuRjoxQaEoW7cpzXju7RC2tFqTsVJ0+75/2MT0bBikcv2Xh7F+G3IvR97oSWZx+l0LqtLCDPua1DyoQ2njcv7uhQRSWIqnVkeSM1AWfpn8QSD9YMNkO8UadT7AsGVNB1QWRO8BFv9rqkCpLBShWPyRpT0bTT0iKjOtOia/l1C+hZa45vXBLfEssxijjWShkGtVbhZY1r+LroWizHKad9Zx6vaQNY/9t1Qiilts0iwlxVP/1zonNYLVNVkekvPZ+wgLymuZTcC74E0vYyl1dZhQTu+IM5tSDjN0Om7H0sT5aYWo5ZU4mp+cUAMkJ+EDHupT6/Tw8KxjLAP8UJS3DJT8SRRBKO80mO10nqQTHF/ZjCLSlRaq98Cj+aUpYrLe1NLwmnIplszL/OaDayAv8d3NN4/VGd9THairH2zF8nsXG++TMhGK6M/nmnyM8SE7LokfimtmT8A77rr+8e59Spe+F3InRvp0iPUk+MgPqgPr7eJkdIwjJogrPNaH8iWD YoubVB4v rpiYjF+rqZSNeEieOkzTWLC8jhig2XWet2BEu2Lm2FCpfVrI58kKGNjVcF9TQ+EdDDXNh3VRT7QTa3NU7WC/FBnvUe5ZE/KPAWtyUhR5HX8vYH91T1P65hyHImd862lTMN0Xf7/CeaK8XGRIUm+4Q1BAgZ9W2jhEJOglyPfQwdVae2jpyrq9skMhMPJ+2tt8F8GGENFq9SW4aZCaYxmE3iTt2O5gEKC/ShQZ1XVeTuEExuzcL+B4RKjD99pRKz8q6ZrwmZiFmjVI7iPsvMzuaLIsw4FqXJsb2WKfOsLyRBYlMmXN9bwSefeV5DkyizN8h4IULsGEh/KTeMu/4/ts9MDKDxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We are above to use page_frag_alloc_*() API to not just allocate memory for skb->data, but also use them to do the memory allocation for skb frag too. Currently the implementation of page_frag in mm subsystem is running the offset as a countdown rather than count-up value, there may have several advantages to that as mentioned in [1], but it may have some disadvantages, for example, it may disable skb frag coaleasing and more correct cache prefetching We have a trade-off to make in order to have a unified implementation and API for page_frag, so use a initial zero offset in this patch, and the following patch will try to make some optimization to aovid the disadvantages as much as possible. As offsets is added due to alignment requirement before actually checking if the cache is enough, which might make it exploitable if caller passes a align value bigger than 32K mistakenly. As we are allowing order 3 page allocation to fail easily under low memory condition, align value bigger than PAGE_SIZE is not really allowed, so add a 'align > PAGE_SIZE' checking in page_frag_alloc_va_align() to catch that. 1. https://lore.kernel.org/all/f4abe71b3439b39d17a6fb2d410180f367cadf5c.camel@gmail.com/ CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- include/linux/page_frag_cache.h | 2 +- include/linux/skbuff.h | 4 ++-- mm/page_frag_cache.c | 26 +++++++++++--------------- 3 files changed, 14 insertions(+), 18 deletions(-) diff --git a/include/linux/page_frag_cache.h b/include/linux/page_frag_cache.h index 3a44bfc99750..b9411f0db25a 100644 --- a/include/linux/page_frag_cache.h +++ b/include/linux/page_frag_cache.h @@ -32,7 +32,7 @@ static inline void *page_frag_alloc_align(struct page_frag_cache *nc, unsigned int fragsz, gfp_t gfp_mask, unsigned int align) { - WARN_ON_ONCE(!is_power_of_2(align)); + WARN_ON_ONCE(!is_power_of_2(align) || align > PAGE_SIZE); return __page_frag_alloc_align(nc, fragsz, gfp_mask, -align); } diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 28af9c728636..7387d3d3b5af 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3314,7 +3314,7 @@ static inline void *netdev_alloc_frag(unsigned int fragsz) static inline void *netdev_alloc_frag_align(unsigned int fragsz, unsigned int align) { - WARN_ON_ONCE(!is_power_of_2(align)); + WARN_ON_ONCE(!is_power_of_2(align) || align > PAGE_SIZE); return __netdev_alloc_frag_align(fragsz, -align); } @@ -3385,7 +3385,7 @@ static inline void *napi_alloc_frag(unsigned int fragsz) static inline void *napi_alloc_frag_align(unsigned int fragsz, unsigned int align) { - WARN_ON_ONCE(!is_power_of_2(align)); + WARN_ON_ONCE(!is_power_of_2(align) || align > PAGE_SIZE); return __napi_alloc_frag_align(fragsz, -align); } diff --git a/mm/page_frag_cache.c b/mm/page_frag_cache.c index 88f567ef0e29..da244851b8a4 100644 --- a/mm/page_frag_cache.c +++ b/mm/page_frag_cache.c @@ -72,10 +72,6 @@ void *__page_frag_alloc_align(struct page_frag_cache *nc, if (!page) return NULL; -#if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) - /* if size can vary use size else just use PAGE_SIZE */ - size = nc->size; -#endif /* Even if we own the page, we do not use atomic_set(). * This would break get_page_unless_zero() users. */ @@ -84,11 +80,16 @@ void *__page_frag_alloc_align(struct page_frag_cache *nc, /* reset page count bias and offset to start of new frag */ nc->pfmemalloc = page_is_pfmemalloc(page); nc->pagecnt_bias = PAGE_FRAG_CACHE_MAX_SIZE + 1; - nc->offset = size; + nc->offset = 0; } - offset = nc->offset - fragsz; - if (unlikely(offset < 0)) { +#if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) + /* if size can vary use size else just use PAGE_SIZE */ + size = nc->size; +#endif + + offset = __ALIGN_KERNEL_MASK(nc->offset, ~align_mask); + if (unlikely(offset + fragsz > size)) { page = virt_to_page(nc->va); if (!page_ref_sub_and_test(page, nc->pagecnt_bias)) @@ -99,17 +100,13 @@ void *__page_frag_alloc_align(struct page_frag_cache *nc, goto refill; } -#if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) - /* if size can vary use size else just use PAGE_SIZE */ - size = nc->size; -#endif /* OK, page count is 0, we can safely set it */ set_page_count(page, PAGE_FRAG_CACHE_MAX_SIZE + 1); /* reset page count bias and offset to start of new frag */ nc->pagecnt_bias = PAGE_FRAG_CACHE_MAX_SIZE + 1; - offset = size - fragsz; - if (unlikely(offset < 0)) { + offset = 0; + if (unlikely(fragsz > PAGE_SIZE)) { /* * The caller is trying to allocate a fragment * with fragsz > PAGE_SIZE but the cache isn't big @@ -124,8 +121,7 @@ void *__page_frag_alloc_align(struct page_frag_cache *nc, } nc->pagecnt_bias--; - offset &= align_mask; - nc->offset = offset; + nc->offset = offset + fragsz; return nc->va + offset; }