From patchwork Tue Jun 18 18:18:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13702815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8393C2BB85 for ; Tue, 18 Jun 2024 18:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D1DF8D0049; Tue, 18 Jun 2024 14:18:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 030DF8D0041; Tue, 18 Jun 2024 14:18:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB5D78D0049; Tue, 18 Jun 2024 14:18:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E375E8D0047 for ; Tue, 18 Jun 2024 14:18:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 91B941A0260 for ; Tue, 18 Jun 2024 18:18:24 +0000 (UTC) X-FDA: 82244819328.23.95C5301 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 8177F180010 for ; Tue, 18 Jun 2024 18:18:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aYOkhPAI; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718734699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+bS6r7fj10qDfK0KHXb3u39/YlU/kxNt/qAwrg8pPk=; b=G5zYY99+9p1TxQ/u1zcaIGM4I0TFyjAwdpcxNI4CO7vU9cx4lnire5BScvhykkpASl6xTX lQbKq85piPBblhdK8GfhxVKIzO9arQVd281h64qP9HPLzCbKN7TggnoHfW7HWtw1vQ+zaG MiDd0z7Tcx4nNXx95WKDc5DQjp8YIus= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aYOkhPAI; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718734699; a=rsa-sha256; cv=none; b=4qOmW1AfkDX+n5EXtBWTnXz/gJKOS5bYov2Xo3dpy0gAmhD0SU0EpCmann+RSs4NrJgvEO DPOIXlCJiSc/e0LE5lzkaSys2Xl/sxAvkXAzzeT9k4wq57xDoW/s7A6DE6E4wSB9JCVO7K buY/hqfAC54I/RD/UWKz4U99zPsZ2wU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 744F2CE1C0A; Tue, 18 Jun 2024 18:18:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31A89C4AF49; Tue, 18 Jun 2024 18:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718734698; bh=iHi9F2LJwfRH7bQXO7MbPtxBZ9hQhqVO/mLP8mATsq0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aYOkhPAIdBUFDJZuuOt/U3pLKRvSSX6WXYHpo+fIAycQr3OgTttGwtX284KPO+qPd hPVHPYRAtFozTVYqtkOhu2yi1QuxXf0q1fDgbkyNr9zb6YBKJdtc8u3LenvjZxZjhS ikrcX0GVUDeS6WeqszBOgeAe7eDR1c7gJhPc3iHVs8eDGvnMC0s8naVmIA6dH5+QGb ijPhu813BtP4jEPR18XhavPEc9pJ4IgbSuIqyrQRE/2Q5cv/Na8SAX8D4J9Hqo8ams YfHlm52WY2W/hyEXKQLccxzAtQlY4VNpvFvletIxoA/vcD4xKg3jgcWp8zqTeYdfTV BMtuWx94rR9Fg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] mm/damon/sysfs: use damon_commit_ctx() Date: Tue, 18 Jun 2024 11:18:00 -0700 Message-Id: <20240618181809.82078-4-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240618181809.82078-1-sj@kernel.org> References: <20240618181809.82078-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8177F180010 X-Stat-Signature: 3edmc4kur48zwizgabaw99hkkhzsoiep X-HE-Tag: 1718734702-160659 X-HE-Meta: U2FsdGVkX18+bc3RjTE/8RW7R+66NrCKjlnotrUN7GvsMj+ikBl3CBnGws+s5wsE+Ry0tB6wwedV24nWAE8EgygTze4A/1oDMPn5ObU5qIkgfq8bsAwJ3yjnfN4GeB77LOlVrVAHsAoHhfWwzK5YuUNeoL03QU/OeD0I7KlGpuj70L+vscj2HaZzPr3tPr/gfqt2LiSit1ZfMmgTJYCeciOcPQ8MnpcR/0C6kf/f5nZj7pdcehpmZTfr+fBR0LAIV9027nyDZCw232li8lQpXLpGifu8HjskR0Y7/BeFaChoPuee6xQ5Rc/5dtbT1xg09p/an3j12NDjMKpJhlBAt+Wt8dR0D6BlpWOpueFPnIcQteSM9kRQfprkpirZPWNwPcdQ294XNgsPANJG6gP3S/wrSPVLxoEzPxB9m9TkfoVEUjzJ/gPtlnd8DHw16cmuLFO8G9s5p1EP9wit6C9fgx5SxPQ2k8Agmmqj1Sztoqf7PgSegHrppjGWdAKycq5C705bu3Hi43Yohuz67mm/oL7eUBQiJfRqQNSnZKHfh8YTLWLzo8KWVzMgblNFzez8qBizE9v6OZ3wfhdvOv6BOm0CxVUqQ2IEkX0KOuoPaP02dgjwPaM1qeRMxsnhT/whK5B6pxLII3hLrO1kmJwgCNMc+H25ZDV2IlHgGMTL0H+hnpVWJp1RK5gA/xEu+3YmrgGWUJyTss2FALBXhqXALuMR0Dg1gLhnvVvRhfD4ojEEt3U6EitadiLV9oSyPzlOYNUB6LVUB4Z2NbXTHiU/+1VKYOB5mZIKyZoPfnWpvYjs109eo66NjrZQnWoUKB+QHydObrzqR2ebA8gUaR2v4C6s3qUwo9MVFbLSB0ouSL8gPYXDjkj5Csd3qJxwgG4PpWcy8Od28VFDsMRmSwMosIdEIuMCKIKwlgJ1bQjI8+4xSPjzThfq1WaaE7WbbaPHciw880PMd/FMN3iG+Wy BZuquJjy QrwxnUYt+kUCtRf/xtil0cbNkUidVXeRHviLwbQD7hMVs22YZVMSduoB3ILdpOm5ESb5LJD+bgq7eucx6ipwhRqpfH8O318CmVWCqhcP4spYmRUC+C1ZcK6no31xDfYFjcbpdacJ59kfHFdlTTIkoSmQWdBWLe5vfzjcsV3xlmUx/kSDcmqUVkW0EriBDOzTf4F2ZgWbugMqM7+gnITcV2TQ0sJ6SVY0b+IXQIvhkmkd899xgNTCmc08UGpRLuA+l+b310lK7G8as7noBwKYyb4k5dQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON_SYSFS manually manipulates DAMON context structs for online parameters update. Since the struct contains not only input parameters but also internal status and operation results, it is not that simple. Indeed, we found and fixed a few bugs in the code. Now DAMON core layer provides a function for the usage, namely damon_commit_ctx(). Replace the manual manipulation logic with the function. The core layer function could have its own bugs, but this change removes a source of bugs. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 6fee383bc0c5..0f9fe18beb40 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1345,6 +1345,9 @@ static int damon_sysfs_apply_inputs(struct damon_ctx *ctx, return damon_sysfs_set_schemes(ctx, sys_ctx->schemes); } +static struct damon_ctx *damon_sysfs_build_ctx( + struct damon_sysfs_context *sys_ctx); + /* * damon_sysfs_commit_input() - Commit user inputs to a running kdamond. * @kdamond: The kobject wrapper for the associated kdamond. @@ -1353,14 +1356,22 @@ static int damon_sysfs_apply_inputs(struct damon_ctx *ctx, */ static int damon_sysfs_commit_input(struct damon_sysfs_kdamond *kdamond) { + struct damon_ctx *param_ctx; + int err; + if (!damon_sysfs_kdamond_running(kdamond)) return -EINVAL; /* TODO: Support multiple contexts per kdamond */ if (kdamond->contexts->nr != 1) return -EINVAL; - return damon_sysfs_apply_inputs(kdamond->damon_ctx, - kdamond->contexts->contexts_arr[0]); + param_ctx = damon_sysfs_build_ctx(kdamond->contexts->contexts_arr[0]); + if (IS_ERR(param_ctx)) + return PTR_ERR(param_ctx); + err = damon_commit_ctx(kdamond->damon_ctx, param_ctx); + damon_sysfs_destroy_targets(param_ctx); + damon_destroy_ctx(param_ctx); + return err; } static int damon_sysfs_commit_schemes_quota_goals(