From patchwork Wed Jun 19 01:06:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13703302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEFEC27C4F for ; Wed, 19 Jun 2024 01:06:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49F1B6B0369; Tue, 18 Jun 2024 21:06:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428316B036B; Tue, 18 Jun 2024 21:06:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29FE66B036C; Tue, 18 Jun 2024 21:06:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0576E6B0369 for ; Tue, 18 Jun 2024 21:06:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B9D231403A4 for ; Wed, 19 Jun 2024 01:06:31 +0000 (UTC) X-FDA: 82245847782.01.1403894 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 0A8F2A0003 for ; Wed, 19 Jun 2024 01:06:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N+4GjmVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718759181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=4+esPStSBvaPch0YhqViQARgq29meV705wr3ONaOGAM=; b=mmll9HOEVUC7j75T7YxRfOFTGjzAfEWaydEn5ygvit0ADxIjw+U5qlQzLDOWzbffDIo3NS t+x0LpbtUkxbcFKOOMvIgGSL1r5FaVAUH55i/n++Z6KQzor338ijp1D9i8n6jkYngp3ktx +cw1DcAaCXNvcmARz/Ig5LguWrAqUPw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718759181; a=rsa-sha256; cv=none; b=zeKQIDeFfi6lK1RXrNWYcvlF9yuXy1mvLe5alvNXUtOnJskQPVG5Kd8aOfDgdUs8esOoKs JDIOev2zQx7LSvIE9Of3jAqW6Jho4ZxCgZ29D90H/cTUyy2PCmmT7anBn9OS3W40/qw/Kw xCpfTPVUYXTY8OFX6jsQe4oHN9m8cLc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N+4GjmVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57cb9efd8d1so619116a12.0 for ; Tue, 18 Jun 2024 18:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718759188; x=1719363988; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=4+esPStSBvaPch0YhqViQARgq29meV705wr3ONaOGAM=; b=N+4GjmVRgN38MKtegqzLHK2J+uEcOdg3Rw9GXA653zagRKC5UKl4S7wJflsTYjRd72 QtJaxmGv7yrL8f6xh6N2f78XvA3LzFbg8vnvrzg/sm8cdFTxU2yAtgFer06YBzGDcO/R pgUqRBTzjYhWk4zdAlUrOf7d5896BMmiE8JnZrKeAU24blZ7gPCTdH+oaPPRX7nT4xD3 wxfmGmE4nYOmJWNWIsuWu85uFS5JApOUpGslGVtec2yydnKSTD1y3VhYjfaR6Sb5kKr6 bmjpBgz1lrjbkuQdZ1tA/o3AHFWXTAIqOkAvOurEcLpvY3tAYLjPU5C8V1qqlmm5HwVI esmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718759188; x=1719363988; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4+esPStSBvaPch0YhqViQARgq29meV705wr3ONaOGAM=; b=KqikXM+SHfCLsGqsX+7xpvJj/DowcJ5vpMdZSc82FOcJwTub8NbFf6GoLA3jQEhRfh jBhDz2bIUYCpYQ60QBaT+ralL1/y7rU0dwyQuf01p+n4ZCNmSYbXZWo47t7rRa0QK1of Gfd8LlbPcsBWNFv+WbyrUEwR5gzntkeLyHchXLOg1/x4C/OYsLniVHKhkuV4qxflpFGh 0iyroHfv1L8tY/D+KPA9FyPTxeoHSX38lQND31U1m/ztsOVp3Z1oDuOkA24q0nhsXB6i fLzeeEgmGef1A2fC7jwqNsprZ77RyqzCCR/SyaTsjB0lWWVVGRAWn0thTlrDYoZtND37 Wu5A== X-Gm-Message-State: AOJu0YydhSkU1yT3a4XDELWT/q4YUaDbG/l1vmeY2ZQKSOqNEd8fx1Ud gPpQgcS54Q4ryisjKOsIWJIEqtMBZYQED5//k9pVPKIjBbumWrUs X-Google-Smtp-Source: AGHT+IGcruuDA/uPlPhmWGJIN7tHy/tJ+fG1TKVJSB0afFx+PhWFYYSI2DFTvc4bl/Jl7U/iT7uHZQ== X-Received: by 2002:a05:6402:1019:b0:57c:93b7:ab36 with SMTP id 4fb4d7f45d1cf-57cf7ae6832mr2261201a12.21.1718759188581; Tue, 18 Jun 2024 18:06:28 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72da785sm8047392a12.28.2024.06.18.18.06.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2024 18:06:27 -0700 (PDT) From: Wei Yang To: rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, Wei Yang Subject: [PATCH 4/4] mm/page_alloc: reword the comment of buddy_merge_likely() Date: Wed, 19 Jun 2024 01:06:12 +0000 Message-Id: <20240619010612.20740-4-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20240619010612.20740-1-richard.weiyang@gmail.com> References: <20240619010612.20740-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0A8F2A0003 X-Stat-Signature: sbpnxt9xon6y4q4mt9tdftt8t848tu6y X-Rspam-User: X-HE-Tag: 1718759189-463698 X-HE-Meta: U2FsdGVkX18E6jc4v7ptqusDNBXnKYtmPgbBT0ILr88skaUH6EiuUqm7u96FeDNsa3ZgSkBPvNKTZKkWIik6JzFAz0dB87PuEI25aiUV9rUrSQNjZXZWMZs+8TcJCtJMzCJMAXCL8rJRu8nzOLghTJJr3m8s0snLJxTGatkvFTkE/WShWxQdvu/w8POjb47T/7zvMla4McNRNNh+ka9esw3YfIZET0TMzile802UObe6gw5aWp3AONM+aqKyKSL5/HDEauGn1GA/7xwgsXcT29fUOUb2iUw/H4ZRrM14riaHDivDfSOMSDWMkiw5F00ZUenVjZqXP/Ca0ga21muNm54HCcnvynyLOHfpJ5fRVbaD5fRIMPD4as6OLgTOM+JGQQ1wqHOupLMbv+9DTo8/kuVjcKrjf0NmKZQxX8a2xbscFIsOUuooigfGaqrAdOTHqQDdNXcjz/EAUEgswFnmyv/ahsKBJXVJz4VGZr0qTDZFtH6hBqJWHJsFbTTrpXW4TeB8fkmew+0hMqzpKKs1/lv3sGBjAszMK79xQpCDrfkLRT/iFzVLu/K6sDoRFVuiHiPbD/7kutPGDfx/kg9HJ+M3juc8J7WPlWpnCG417BO+D7utMShRnUdkrLvFkmC/rlLtUrsyPWcHwsiuCI3SLjmyY2dYnXE1THAq34CP0Ud0Gmtl4YnZZfiB5EdtuQjs6ypxNbDbA1yM+jPsZnYeiO/Q08yyjuCclSnNiK0q+Ueuo3Rw/2jsE9F7wzOmlGI/pLs5qH9KXWWcgYIhNlOMcO374lBqCm2o5EIV/ZOmDiZ844pwAk/z5MBKvjspLfe7dH7dYzIVtVzrXxYMhVeUckMeb8WNY4Cqy5nG2XdEujnedBuQKUP8JAej2IajYGjXd3dstTNwO0TOalEDi6XtX3cPbAUvXxqk+DDACxnPT7wZZTmPitZX7bw5v8LdDz5+XBbhaNj40JLjHVOnJJV mfGHlOow QeWdrmZFwURsvqwqw/qRYMx7PuhZEFZ/FruaF2VJ2zkbah8CN+l2at1KkrVepL1DrNVOpl0hbfvb8PEw/9QRIWiYku/CstLtiTyD4QY/gyt51mYsyhGkbX+D+7DCXRs6MlPQARxOL84Vkmjpjcy3y8QRdNA7ik/d80OtxaW0y+SikkeDVrGG7AmkzTqzkyVxwH9vDB4JGxN1zmAyZwmslEkjK2u6Mqt/aLOSmM5tsapsM7AS5lBjNaJPT1DWW/+H7hNJWbe5YnBotN42yzLG5imuZLMNBQDM3P/kPYqXESbm3VwaUCRiMJ0HaX2cDoFkuhUJ7XYS08ffw+QbpNop6qf4xaHgJ3/Ve6IJzXAO11ruAHCLQMVoP0Fjn67/TWkaQPOf7ZhO5k/Rgr8HGRmia7ZBemBlUyQIBoX40KpfaBQ29q/SCEAfwerwkNMEYaLHr96QxR0I/No0H1js= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003725, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For page with order O, we are checking its order (O + 1)'s buddy. If it is free, we would like to put it to the tail and expect it would be merged to a page with order (O + 2). Reword the comment to reflect it. Signed-off-by: Wei Yang --- mm/page_alloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 594176449890..d1df7929f003 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -706,12 +706,12 @@ static inline struct page *get_page_from_free_area(struct free_area *area, } /* - * If this is not the largest possible page, check if the buddy - * of the next-highest order is free. If it is, it's possible + * If this is less than the 2nd largest possible page, check if the buddy + * of the next-higher order is free. If it is, it's possible * that pages are being freed that will coalesce soon. In case, * that is happening, add the free page to the tail of the list * so it's less likely to be used soon and more likely to be merged - * as a higher order page + * as a 2-level higher order page */ static inline bool buddy_merge_likely(unsigned long pfn, unsigned long buddy_pfn,