From patchwork Wed Jun 19 15:43:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13704128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F41C27C53 for ; Wed, 19 Jun 2024 15:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66D5B6B00A0; Wed, 19 Jun 2024 11:45:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D84B6B02CE; Wed, 19 Jun 2024 11:45:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ABDD6B02C7; Wed, 19 Jun 2024 11:45:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0D9126B02CA for ; Wed, 19 Jun 2024 11:45:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B3171207BA for ; Wed, 19 Jun 2024 15:45:54 +0000 (UTC) X-FDA: 82248063828.07.33F8F3F Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 500B118001A for ; Wed, 19 Jun 2024 15:45:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=flExNqPw; spf=pass (imf06.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718811946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3hDUyT9rvjh/uqttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=RfprX/KD//klNoXcqWlqBfk2UqE+zBO4qpB1NO5MSM2Du0IJzbOk3Je03aJZJJyWDgul9q SEfqcrQAR4UmU1onavv1FK+wDP0t7doasTKqgb6jThttlwA51A92w8AGjoQ/eIcU7lZeEe gJiQtsJUam9eWhdVYQWMKdqv9Mw6mHU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=flExNqPw; spf=pass (imf06.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718811946; a=rsa-sha256; cv=none; b=AA4GScatVE/YXPXV6AOBEEVKB+z93ZJBty+wM3/r4ZML4zrP2qlWB2Diw22H6RsXxZAI0y UNY+ZJ69cM7kZbaFE9fkqt2FMOC1+tTQGImExznsSJy0lqknABwDS9qc433foFwODFCMTL 6iiFAQRcszE6KmjE9IfGupBeWqZfEA8= Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JCx2dF011611; Wed, 19 Jun 2024 15:45:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=3hDUyT9rvjh/u qttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=flExNqPw+dIvwGWjJKEHRur/7P4Su z9MU05xbzurOxIUaHf+K4NRfzlo88K6oqRxBeuL56GF23rMh8xrIbrKkHptnNyrH nk3Tycf5seLnnmQI5SO0k4bnv31MQP/SEFT0tL5fTVjNxkgyTH2DZeyZNs13lZjw NxbNMvWNcdfogNUKQGf1ykhl8dXUMGkfp03A9gL0K1oRxC1vEkrTZvdfgfO6X102 ChB673HrtPnko86+w9tTMfEyuXwUEfaWJue45m0bBNKRx8sHXKhXIeE01kPCM3oF mppRajnfG7yi6q8sLuneetLrAU0v520x5+uzeQOkPJhWg7ss0eNHZsGEg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yuyt98h3h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:43 +0000 (GMT) Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45JFjhZs015348; Wed, 19 Jun 2024 15:45:43 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yuyt98h3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:43 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JE5h8L011031; Wed, 19 Jun 2024 15:45:42 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsndtmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 15:45:42 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JFja7s55116264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 15:45:38 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4946620067; Wed, 19 Jun 2024 15:45:36 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE9EE20065; Wed, 19 Jun 2024 15:45:35 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 15:45:35 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v5 07/37] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Date: Wed, 19 Jun 2024 17:43:42 +0200 Message-ID: <20240619154530.163232-8-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240619154530.163232-1-iii@linux.ibm.com> References: <20240619154530.163232-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JgxqkCBh6gonQsPsLTHK1eNwNcILiZpf X-Proofpoint-GUID: bJpX-eo45VEognRyQ2bVdqBxxfq5QhVK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190115 X-Stat-Signature: ysb6m9ggmfu81tzcrcuc8ssmcjxbibpj X-Rspam-User: X-Rspamd-Queue-Id: 500B118001A X-Rspamd-Server: rspam02 X-HE-Tag: 1718811952-943389 X-HE-Meta: U2FsdGVkX1/wBQOaPMA7DWERK0Taz3OT55cfaL1cl/lu2L8fmAUZCe+YrprI2+3xlOmAb6KjnYywUt0mI08s6Feq+5KVw6sKAWQEPDe9Y8z7pKvOluHEcwl30H2STH+LIBLfhHfFSoX3HbVU+xrabzMFd7/Z5YVpyiPArhKgbEvoTZqKX1TexZWQ7nWILKsiGxQF2W/po5+jSEIPMz7foC/BYNjLBC7VofYxWJVtbOgKIJRSPXmYVcrgf/Uk30EZ6LV4J9k7dgTpvdkt4H2DQXUUOUj9UbIMi7e+vvZBePCr8srfapdLnsPHfqLbOIQoEt6a8onXN6pSbwxV7JcPSq4WiP7WNnGQxW34xtFnxV4qAZFNNKXGj9kHxkKnFwMuM4Q4m5AepEGqeF3bVK2UetY1XOLL0KtA6ADQsqrs4vMuON7okyATayjD3LMzY72Gw5Ax0udwUbPcBH3t7ilbpU+xy0e82MnJZijvw/0I6muyXCmI0u6Vf6R3R4D3kIGcIz4IGeNpd2wiGT5sMExe202Cl9HMihrsc8Ycvw06IGqeGSGzvtQHDlhiw+3A2+0l6UkJ+N25lMPdPlKQ2Qn4UdgGSN6RRqh58COtnJOj2hDHOyQBSsj9dinptYzCSAOu/72XHLPxzwCuB4z8BZ+ZGafrbH0BMKwr6Sy0BhVWjVQoagfFc3JTPq0j4Oy+DTlJtvNAz+5dvB7K7xMH9HnwpMaEcrlCoITrl9R4ZZfUKunnvTI90giiWWFyTssowEZrv6V+ntsmICv6QQBmhaOlH/rgPEXn3YcQDIc8ngAch2h3XMT3HH9g+6OFuRqQ9ciLYJyMJ6J2baVlC+GtzB15BKDCnDYyPR5Bz92zABHGfqEQJoTozuo94Q3PXcl9XKntfYcJ6LTL5bx9CJQskj5EfJDn1gnGdvj03wC/v6HBhIhi+1c6cKYKqPYCUoF+B0LwOKctMk9v+ejWBPbptfB uKzghdjX Dzihest7ov0eW0Qc8vxVw8swTHFMl3/k0hJ9X5XFo+p9i/Tq90qFewaTPQQEjKFBAVljwyEmC4akGrzLThliNsyEzwVf1HCI1yI4XDy8jH/otJAfKkOdlvQYKv9xGBCWNSOUaBz5IyuA/OqzMpoYjwhRro9hkcVyI6naFdk2t8qyIfcDCgxkmGwUegOurJCk0XCsCShveo5X8vRvmJv38KPcuDWy2kYY0ay98YIOQTFaeWsychGrtXNAEnhuMZmj0VVsFs0bhDIgDy/l+b6yBphXJ8NmYepEUhWneZA8iDe4XaVCqu/cjhTrS6c/T6kvglRlt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The value assigned to prot is immediately overwritten on the next line with PAGE_KERNEL. The right hand side of the assignment has no side-effects. Fixes: b073d7f8aee4 ("mm: kmsan: maintain KMSAN metadata for page operations") Suggested-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/shadow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c index b9d05aff313e..2d57408c78ae 100644 --- a/mm/kmsan/shadow.c +++ b/mm/kmsan/shadow.c @@ -243,7 +243,6 @@ int kmsan_vmap_pages_range_noflush(unsigned long start, unsigned long end, s_pages[i] = shadow_page_for(pages[i]); o_pages[i] = origin_page_for(pages[i]); } - prot = __pgprot(pgprot_val(prot) | _PAGE_NX); prot = PAGE_KERNEL; origin_start = vmalloc_meta((void *)start, KMSAN_META_ORIGIN);