From patchwork Fri Jun 21 00:25:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13706585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541CFC2BBCA for ; Fri, 21 Jun 2024 00:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FAEB8D0104; Thu, 20 Jun 2024 20:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6594D8D0108; Thu, 20 Jun 2024 20:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 289E48D0104; Thu, 20 Jun 2024 20:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 031CE8D0106 for ; Thu, 20 Jun 2024 20:27:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B6D9A1C13E3 for ; Fri, 21 Jun 2024 00:27:09 +0000 (UTC) X-FDA: 82253006178.02.D501F75 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id 6E23E180005 for ; Fri, 21 Jun 2024 00:27:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WOG9KwPy; spf=pass (imf16.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718929623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPY2/xfj0WoITwfgq4isE+nahUee+x7RgpdrRutXdLc=; b=JW4OYlulNRlCFp8KghuZIX8r8TxazwG2lVgiUsdKx0M41eey/qXhwNH3gXnmYysqysMm9f MziBsnXok6NRpj1Oa55u3IwMPzCw9X1gu8Mg+JpH8O6bb2V9zGiGmVOcGFaXAxZnbCAAFW NumYXj7cAn0StOSWOKiB1xUyjvkj/nA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=WOG9KwPy; spf=pass (imf16.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718929623; a=rsa-sha256; cv=none; b=ULnKipHhXOu/gi2YzHtBByaggWoeFH7D2fataiYAVZp/5eO2dVFPSVoTtoBVh4hkKKLAM6 VVgMCwQsNVHgNNFxc7IL6l+/k/vgM2vvdzEdcK8dfkKQZCB7n6sGaVrbwJgbHp5hd/urzD eN/57TN1XiyphxhPt8eTIyiTazRvE7Q= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45L0QQck007775; Fri, 21 Jun 2024 00:27:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=tPY2/xfj0WoIT wfgq4isE+nahUee+x7RgpdrRutXdLc=; b=WOG9KwPy5lW6w/HKd3bM98s4XlbG/ HxT0Fdi4dg1Af4TILtilSApJ0ddc1DxxKQpmUovmxZbyfnpR4gJgxyqqZ2/DbVm7 6+AZ/8JNvxo4BmDNdEB1HnznDFfALsynkALE9mF3kQls/8WtGJZ+KLBM/Z/2cKcp fYI3n0+iQEpEYUEbIHAzCClNpgpCPPkvRLvPlpVA2Fqgk6dmMbuyuGuWg7n10vMM aI63AsdOkM2geaHldKvk1F12M4T9sLo/3T4s01K6qJwqaTElkuGmIA7hpmpUTkjg xhh8zW/qQEi9SDNWXqVJqDWKBnQjkVoV6prfVRLE1W5ZMS1xAU5+gr43A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvw8c8769-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:27:00 +0000 (GMT) Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45L0QxAf007945; Fri, 21 Jun 2024 00:26:59 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvw8c8766-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:26:59 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45KLeEAh032326; Fri, 21 Jun 2024 00:26:58 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3yvrspjn0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:26:58 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45L0QrZi54067482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jun 2024 00:26:55 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1160D20040; Fri, 21 Jun 2024 00:26:53 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DFBFF20043; Fri, 21 Jun 2024 00:26:51 +0000 (GMT) Received: from heavy.ibm.com (unknown [9.171.10.44]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 21 Jun 2024 00:26:51 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v6 27/39] s390/cpumf: Unpoison STCCTM output buffer Date: Fri, 21 Jun 2024 02:25:01 +0200 Message-ID: <20240621002616.40684-28-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240621002616.40684-1-iii@linux.ibm.com> References: <20240621002616.40684-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ZyRH2cM2a1ar3ozL6AHjMGtgyGHBGmOh X-Proofpoint-ORIG-GUID: ikkOvxFQ4wm1Gq2BQy-mlkcEGMDjF1s5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-20_11,2024-06-20_04,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 mlxlogscore=958 malwarescore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2406210001 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6E23E180005 X-Stat-Signature: hqnmnk3qfhosfpsgzd13esfgxhed7ea7 X-HE-Tag: 1718929627-775467 X-HE-Meta: U2FsdGVkX1+0KL/Iq9FM8Gw/IEt2za0/Lt2TG7SOdODIAAbWcGWTjT+EZk3J/GwBXgP9IHWqm58cOr7gwQ9PfK8QIf2ezOe67DdumftPgRt0V9Y4b6Ms3tEQdk14HkK2s5jt/HuhoeegivlDBF0O7M2IAWX8dQOOoQE/DERIzC8KdVIXSE/PHbd4G2yDuOUHnKY1lHbS/vT1eOjIsAQHwYuf7VnaoVR+US1lxb/PdVsth0D+t3oC40FO+4t4zdNz3Rp3lgQX97QGm9iZfCHAg4UgvUaY4QAROxyjLJlwn1v3Da60kxrdzPe1SZaGfJMTehn894NPL+Kuwwx0A6GjFI1UQ4YBU5ZIooUlq+FL7eDq5o9i3fcNuQjnkD2ElQwfcUnk9qPMCzumjllU/Hq47TnaOrCubLXAIQJy+LbsrmgnPo8vHrw7I/zys4kqycMWiggLn35IGssBeWw0kkBEgr4AU6hAIsiEcQAlkzhRjKT6TsfMC6nhoTcKSofQqXJLjLKdNcH4lWCGU/h7rABzYa1Uce5o3ShvkzUfFGfsPeJOty+JMZFwF8oiic/YDWd145Qu2phyj51P05UUnkKAvtNiB6Gin7l62l5mNofnXXfBRbAuzBtPlgdDVXUgfUww58KaR9GXtMiWFrOGofTZdmMfvyH+Lq7GE41m3amYeN12qlYjfnHQPQNnXFc7E1Vms9GGE05ko3rOQiY04tbV44JLgJkFk3mIoJxnonPTZwSStlyMcuowPEyjXM79ogH0e7jUaJTdG1MmRmErni4XDKvwrUzJH/jV413gKdeVxgUTU7NsMF/2TVkFf6oaMhGWKgK24OjzkiDjuW3dq/7Dv899HE721O6ED9uMQp8ymah9yzZxsdhSuP8Vb5Udb9uKL149vDFnJQ2E91KAd9IVyIIEtIACoxvkE0uwxCK8FWEgUSlbBUsNjjAuOUyx1Xu/fmZ9jr+gRiE9UxukRfu VaIvRRgD cfTmjt5O5BvwYjzQR+BMXPD3Yug2g1uULdDJL947ITaeEuqHNBhMg3z+sVV9aT93xjQ11gKg3QQu+QyAbh/qKl367S24vDejoRowCdLnxFFoZqjf1K2imAyQCC6kV7LGt8sbfmIo1NHwZIDr17t+gyggVD+aEynazJEbFfqbgYRcpDHlzXesHDFyTr8R2jZJmnkoR0u70OVqSNaZ71i/JfDKJVfs4OFsEP0q64WEqIhh6KHjJxjDUbpo9n0XU3qQOwSeRmTUVCbtiZDhY4f+YNcM1Rh4o+P1GCVP0qDBr+5HjVr7D6P5FOwEAG63cHdCIHQTvYbjv18M/DpUrCgmT+7UgzaKWmsFnDSiKFiNWiEUr9bcpNz4Eo/vCGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: stcctm() uses the "Q" constraint for dest, therefore KMSAN does not understand that it fills multiple doublewords pointed to by dest, not just one. This results in false positives. Unpoison the whole dest manually with kmsan_unpoison_memory(). Reported-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Acked-by: Heiko Carstens Signed-off-by: Ilya Leoshkevich --- arch/s390/include/asm/cpu_mf.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/s390/include/asm/cpu_mf.h b/arch/s390/include/asm/cpu_mf.h index a0de5b9b02ea..9e4bbc3e53f8 100644 --- a/arch/s390/include/asm/cpu_mf.h +++ b/arch/s390/include/asm/cpu_mf.h @@ -10,6 +10,7 @@ #define _ASM_S390_CPU_MF_H #include +#include #include #include @@ -239,6 +240,11 @@ static __always_inline int stcctm(enum stcctm_ctr_set set, u64 range, u64 *dest) : "=d" (cc) : "Q" (*dest), "d" (range), "i" (set) : "cc", "memory"); + /* + * If cc == 2, less than RANGE counters are stored, but it's not easy + * to tell how many. Always unpoison the whole range for simplicity. + */ + kmsan_unpoison_memory(dest, range * sizeof(u64)); return cc; }