From patchwork Fri Jun 21 11:34:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13707324 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F7BDC2BA1A for ; Fri, 21 Jun 2024 11:37:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FA8C6B0112; Fri, 21 Jun 2024 07:37:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 878998D00DB; Fri, 21 Jun 2024 07:37:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3066B0112; Fri, 21 Jun 2024 07:37:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 442C26B0110 for ; Fri, 21 Jun 2024 07:37:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E7CE8A315B for ; Fri, 21 Jun 2024 11:37:29 +0000 (UTC) X-FDA: 82254695418.10.B3FDC0D Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf22.hostedemail.com (Postfix) with ESMTP id A40CCC001E for ; Fri, 21 Jun 2024 11:37:27 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=kHBtbAMz; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718969836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3hDUyT9rvjh/uqttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=2HjDHmbignbodHqx/yasVO40roIwY45Ufrl3GXRggK+ALOtjgKIQ8qos6bnm1DS/xAYwgV p+9J0Vf98is0Vtn4ta8VmSYXEVjwChcrrzDdy7tekkGauePfb1JYTEzqp8l63G5IBY3Ceu nsuBLtaz5KKxVsN+NR6Pc6tseztlfSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718969836; a=rsa-sha256; cv=none; b=7C8sKAZ+FBOsG8QmEpDZokU5KfSPkdvpE5vkt1qHs9O01nWHaGHXsmxrdN52aw9cFqqhBV Mn9R75xRukbslUVs1RybtumL+h8PZ7hALQuAd9Tv4bIKs36mara8uYXl1Lm6YoYqEXcCk4 4HJI5VwPSkBTHybPrdgE6CSMX7+ijug= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=kHBtbAMz; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf22.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45LBSei0031789; Fri, 21 Jun 2024 11:37:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=3hDUyT9rvjh/u qttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=kHBtbAMzAkJCYKTs27vyxCRb9lPBr Vad5ZD61qzERd7uYenLzb1vDgaV28hZ+NGEWV7TkSykwXbm7AlCJJ+40CIFXA5I3 MHvX9PwhgoTnqwvc98rg95Uq7f2fvY4dm60lI0GCWAli23n3EoP0VaTP78SQ86Kx FRIFjTvIhsHopQ2S3xzLScX/z92CtlDQHf9aJfTv/gBrLWqRLBbsG3ekn26eWN22 kKNbT+cTZiI4xYuHJEIyk0PD7kQ4QjSMf0bwc4EDqUnm5a89b6YRC+gOcqNPVKo3 Oty/hjgffyzAnEoQAJOORY9TiLDBE1tSPnQHB1vuVI1SQJccwrIhgDN4w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yw8p2g0hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 11:37:20 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45LBbKjP014093; Fri, 21 Jun 2024 11:37:20 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yw8p2g0hr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 11:37:20 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45L95u7O030896; Fri, 21 Jun 2024 11:37:19 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yvrssxvb8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 11:37:19 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45LBbDV153019072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jun 2024 11:37:15 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E0C120043; Fri, 21 Jun 2024 11:37:13 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C85B82004F; Fri, 21 Jun 2024 11:37:12 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 21 Jun 2024 11:37:12 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v7 07/38] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Date: Fri, 21 Jun 2024 13:34:51 +0200 Message-ID: <20240621113706.315500-8-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240621113706.315500-1-iii@linux.ibm.com> References: <20240621113706.315500-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: M26Qsv0wYYoY7ZdLYkxPUzFolJ_IdfF5 X-Proofpoint-ORIG-GUID: 7hAxF8dJwBBtEW9YMS-8PINNDm1huIJ0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-21_04,2024-06-21_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2406210084 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A40CCC001E X-Stat-Signature: apxuzjg8izyppfa3wnieqnumfabgcrod X-Rspam-User: X-HE-Tag: 1718969847-810601 X-HE-Meta: U2FsdGVkX194XyYyFkWfjxllgEvezrtUgPhlO7WrVbE0s0OWRSKbJx8MnAzGus1Hv4J6JbpgggspTXKpvgsfu5Zcp137yPM7y2tNb0x3pQ24RhOqG7/LnbGaOPitMlFS2ESS4tDVICeWsOqS7JyulAH6Cs3ArZqAg6kYqHBUxUV+tgRaQhyCL9yeGYp+B3lyePl3koBGpJDM4Q1HiEZ7z0UbOZiZMakJu31oswHGzzI3TSb/Jhm8EOSy9ZlB4vhiwQTwOZArTk7GJlzbxACLZzqTob5gcczzVCrKQp5fB1qGPbgM3wJ7FkvWu3Gct4dQfjDk2YCtE6ztM1VtrIY8K5L80s5rNREKi+54f0HfV080JVwrZNKXnGZgT5WJIcU+H5Wnwc2YQ+6MC1bud+gi5GhUlWIVRCbJsKs5fdCUvFcnrZq6w+BilP6UcprWiw6WduF3M/kVdp9TcrZxpZIjHG/Xdov/RIMyu3ZHWTIoRDBJQw1OQ8dR2v4WUUlsBztKKxXa43LoL/kqsA2Ycotr2WlNjbSCa/kLdSCMXqXroOqwtfvyM6tM31eppnhUUNoyLMW4FuLl37gTJwFWb/oUOGAOFnuZhM/yeNPvKUQwQ3u9IvyamIF+sKi8XbbPz5xJ/4Mvh5Pgd1h9GyQXk60bvN4Rfyb2Oc04RRiPbvdEYiNRgp0UGCnRLa9U/dWtRWHi30LO2gPyoVDFZT8EKr1YsXPwYQje8BQcYOwREF/6EbxF+fGGsHnlcRkSm2Vm+8yiRCmTgaUXuaAhHVh+aPZZysI10LUCgiFRzrTMI6ObdN0iMMUNna6p1XSfyKgZmrf9tpPq5qy1lgpnh8AhOc1zpC8QLXUDXxXfg5yTmEwKBdhEcMckJj+BunNpirdFuRQJ70omTk0bGFCY2JQCif5EMJOesdzrxt2y+fzDd/wwNPY9Nzv1GkMct9wpj17GTyiSSFNO70i4RXJXSGMtL7g KOJ7fgXN bmcOqDQrk+3nPu8qHiCMe2FN6qev+8Uhh321jgsS+NhRiwwXHJRnSVTR0ebwJDtmUrBKGHe0IKZ7N28oXCe3aqFruJIL1lqjbFJvkSa+w5wSd52li34XhBw2jK6mK2nKfym/OJUHSBuyzTz8wOB3k0ugVl2PQr4ygMQCilmka/YeOsWGYEEf6fv6LToWH59C92Mw0A/v8vzdw2mMpzioIxIygFitbgjziqYyvW5AWfjqCex7JHQ1jSLoMpwaYI9qY6bomgeWBIVDX4wmNUzuPE8tBe0Dpp3iH6DY3CNYr3WxMmT5dYwOWjyKKZEoGLczUm/APq2JryDUeCPd81rsyPvBJEu/Bt1pu/MGIwascah0Egh0zVYu8yIjlQUkPY70qZxAHECeXBWOhWdo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The value assigned to prot is immediately overwritten on the next line with PAGE_KERNEL. The right hand side of the assignment has no side-effects. Fixes: b073d7f8aee4 ("mm: kmsan: maintain KMSAN metadata for page operations") Suggested-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/shadow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c index b9d05aff313e..2d57408c78ae 100644 --- a/mm/kmsan/shadow.c +++ b/mm/kmsan/shadow.c @@ -243,7 +243,6 @@ int kmsan_vmap_pages_range_noflush(unsigned long start, unsigned long end, s_pages[i] = shadow_page_for(pages[i]); o_pages[i] = origin_page_for(pages[i]); } - prot = __pgprot(pgprot_val(prot) | _PAGE_NX); prot = PAGE_KERNEL; origin_start = vmalloc_meta((void *)start, KMSAN_META_ORIGIN);