From patchwork Tue Jun 25 10:18:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 13710838 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633F3C2BBCA for ; Tue, 25 Jun 2024 10:19:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4E7E6B02EC; Tue, 25 Jun 2024 06:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB38D6B02FC; Tue, 25 Jun 2024 06:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F9076B02EC; Tue, 25 Jun 2024 06:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 949A26B02F0 for ; Tue, 25 Jun 2024 06:19:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 52EF21C318E for ; Tue, 25 Jun 2024 10:19:14 +0000 (UTC) X-FDA: 82269013428.10.8F55C13 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 094DE14001B for ; Tue, 25 Jun 2024 10:19:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kBPyOTV0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xWW1KRCc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kBPyOTV0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xWW1KRCc; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719310737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MSIf4jCjJDnMr8/f5CejiRw0oOxYjiOk2rPRf6qMsis=; b=qOn+a6hcs0Wgs2E0YaUEd2Yf19h3+17/nWe2YyUGLH/a6CyrlrFNhI03YVbOHr6X5nSIkz ROCfVxq0y9/lcaDmYxgBJYmZclQdB+Yyo29a2zIHjHnGenIHYINAV6SGyCQ4uczoxJtJM+ f2lP5sIheYZY8JtgpkEVZfBMRntadrQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719310737; a=rsa-sha256; cv=none; b=U74hG1+Y0TK6ERERYdRFJqwScttywgCHIp7ByjdEYV2xTrRna70sDGV6oSpV0ymUBWNJGC jL/eLA0or89pUeCjTe3vuOIYgVaSAPK5PSmI74DGo73iZUeE9ib+DV1ea5glxIhkqpfsIL skvW9XbQEO1vQj7ihOsFKA+PiFECrRw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kBPyOTV0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xWW1KRCc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kBPyOTV0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xWW1KRCc; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8E9991F84E; Tue, 25 Jun 2024 10:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719310750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSIf4jCjJDnMr8/f5CejiRw0oOxYjiOk2rPRf6qMsis=; b=kBPyOTV0CaOTXexoQ24sDAzDcrWGNQdGLdJUFDQX+LJyNiAjP52drz2g82eWlgUYeES32o yQM4/zfJ/ur3MNIK5pkc7HP7k775BA0oM1+DpbKqYL8hseJS8ArcT1O5j38k/zeuq4pfPT CFLzwK8gqJORSTSdbhODJ5HbTtnirT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719310750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSIf4jCjJDnMr8/f5CejiRw0oOxYjiOk2rPRf6qMsis=; b=xWW1KRCcPkzu29v7MB4OlDHn0/EQ27Zx2Yz1h01K2QfCfyRJSNbHCbJzeAJf6br/EKk1ik C2rEenkRSlbrJ+Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719310750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSIf4jCjJDnMr8/f5CejiRw0oOxYjiOk2rPRf6qMsis=; b=kBPyOTV0CaOTXexoQ24sDAzDcrWGNQdGLdJUFDQX+LJyNiAjP52drz2g82eWlgUYeES32o yQM4/zfJ/ur3MNIK5pkc7HP7k775BA0oM1+DpbKqYL8hseJS8ArcT1O5j38k/zeuq4pfPT CFLzwK8gqJORSTSdbhODJ5HbTtnirT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719310750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSIf4jCjJDnMr8/f5CejiRw0oOxYjiOk2rPRf6qMsis=; b=xWW1KRCcPkzu29v7MB4OlDHn0/EQ27Zx2Yz1h01K2QfCfyRJSNbHCbJzeAJf6br/EKk1ik C2rEenkRSlbrJ+Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 82EDC13AC1; Tue, 25 Jun 2024 10:19:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id k+H1H56ZemZ9WQAAD6G6ig (envelope-from ); Tue, 25 Jun 2024 10:19:10 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id EFF2DA0938; Tue, 25 Jun 2024 12:19:09 +0200 (CEST) From: Jan Kara To: Cc: Andrew Morton , Matthew Wilcox , , Jan Kara Subject: [PATCH 06/10] readahead: Drop dead code in page_cache_ra_order() Date: Tue, 25 Jun 2024 12:18:56 +0200 Message-Id: <20240625101909.12234-6-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240625100859.15507-1-jack@suse.cz> References: <20240625100859.15507-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=773; i=jack@suse.cz; h=from:subject; bh=W6XufS+irzkVLcuC4WuSgVtbQbyLhmOcwBflH4kmDVk=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBmepmQ2JTScI1xSohz7XtKQCtOoPQPG88nLecvwubO lW7qjfKJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZnqZkAAKCRCcnaoHP2RA2Xx+CA CmfVeVtxYG6T8ol6AezzBq8gB1CHQ/WaA6+W++fNTLMPGH957HjzY4L35mmXxN4u0pCa7sTWJKJKW5 OUxXv/EftfilCXwI62XRrrtaDx6XU+Bc5TqjxWiUz1/6A5ZF5Omm1zcb3d4vlU++Wdnis/KCGZ2fvl shg+9PzVGDqz4h5o1e+/ktFQkxvQjhHXt48C9Roj4eLTatk4dKVkTLvDEzygNPJwjbiWHsYykkaxnf OzGCYGO7qW7ESPBX1LpZEZgAKQ9eHMUfgxutNs4eU5ZLFMPXENWNN/6iFf8nbuQE5a755DD30M9Gcm CGVwrh2HvtZqZDCsNeTcG4juey+zPS X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C X-Stat-Signature: 9w1ty4w833cemauuzsnc91pwqxpg8pdy X-Rspamd-Queue-Id: 094DE14001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719310751-240294 X-HE-Meta: U2FsdGVkX19H7aXJf8GncW6H5VCTERs9IRjhkIJzf5noJXXo+Dcl7k6Dp4pij/6zYXG5cr2TigxXLuekCddUKYKuKY54hNTPVP+Y8N0oJCr3BzHRcRXzLGUj2lsadZF8Ne4YPG9MUbpDyhJDcPQTkrHZ/h5uSPHFQBp3PYy9AG/OAL1Q/fvU87/zJ3YnoN2mgnYy9cSCuLdkfMrKU1QEQ6bE69V4D5PYDvhQctD4h8irn5e2R+d6MlT+dicDeMMpLVEhHHA/jBdtD/NVAkeSHwk4Urhu+agAGy8TnV3u8iuXzNROSZcqGox090AFmLgz6pg2GGJhoKLnwt0GmEfoW6+o+z4a4VORHdaupDbQeYMdL/6MG4nKATVpLS3+Zx6c6vBTZCYedGlz8Y1HoA1Wd1WTkorqfyscwV7lLDzVO5LbQ+SVecnE5Vq7qiJfABDcWw4lINSQ+p1iFhvSgXZgsnT0xhwke8NyMMYA0Pd9wU53wPGCTY+qeLQWRDD0F76EqaMsazKoBYuyHnvOSssEBsEm/W+4aaRtQDw6VQ0MmVT0OF9n1UhmrGQHSG/E1yuFVQU36oRZmicbW2clPbJIV6YI9S6euptczu9S/57EEuCJ0pCYXQ5+D/IG5G/bt7MvXxQ48lgh1G/unmQKhnRtQ4O0866Xi5Tr/ThjdYejZukKAvf5/0ftd6/ZKB8k2BwnIE6wMccmozH/plLW2kOXyULjKqTo53XiKo+uKs+1GX9VbDoDcZL+XpFlbkKZEw3WzYP0Eb44/9cwy1fWxa67+df6UkM0x94t3foOu6Tw8HZ8bJNmi46+xodWQQDQuNg9F+CaYa2xCpuA9NTr/39uY/AOilC8L4x8aY0rmNQA1PW2Z/JYCu8lJkQZ5nzYHOEQ5fh/8tEoQaVg9nEQqmkBljQ6X2Kn8bzK+v82k7M0I7n6J1GB/AtAwDhuApNUaifOFvf8+oI1xOXqlHAYbqx qb5Oj0Vv mKST/hasFLBcsTzeW7FMT2aC6gGfofD4OkwNUzSjw8UYm8uwSdd5QGJrqlqZiINuw6igl9y/MrXLIvmP3mv/UvwGx+0aReNX/76BhVSwLogeGrH3OsRkkZ3AQVZsdCrQgMDbjLaJCnV2m8uawfYDN7tTemjcLC91rbuhGaHAOG/wd+iVOpaS39e0QrpW6Qj3CsH2/tOiuCh0C6PeJIGjgFjKOAHca8VOc8nYt1tcQk4ZZ7yw7FcXy5enFFoFatnzDdvlR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: page_cache_ra_order() scales folio order down so that is fully fits within readahead window. Thus the code handling the case where we walked past the readahead window is a dead code. Remove it. Signed-off-by: Jan Kara --- mm/readahead.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index 455edafebb07..9ea5125a0dce 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -525,11 +525,6 @@ void page_cache_ra_order(struct readahead_control *ractl, index += 1UL << order; } - if (index > limit) { - ra->size += index - limit - 1; - ra->async_size += index - limit - 1; - } - read_pages(ractl); filemap_invalidate_unlock_shared(mapping); memalloc_nofs_restore(nofs);