| Message ID | 20240625121547.23613-1-hushange@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: remove partial comments of kswapd_shrink_node head | expand |
On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" <hushange@163.com> wrote: > when function kswapd_shrink_node return, it will not check the condition > mentioned in the removed comments: "if the lack of progress was > due to pages under writeback", so remove it. Is this correct? shrink_folio_list() can skip under-writeback pages? > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order, > * zone that is currently unbalanced. > * > * Returns true if kswapd scanned at least the requested number of pages to > - * reclaim or if the lack of progress was due to pages under writeback. > - * This is used to determine if the scanning priority needs to be raised. > + * reclaim. This is used to determine if the scanning priority needs to be raised. > */ > static bool kswapd_shrink_node(pg_data_t *pgdat, > struct scan_control *sc) > -- > 2.17.1
diff --git a/mm/vmscan.c b/mm/vmscan.c index 900bad16e..a2369a3b1 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order, * zone that is currently unbalanced. * * Returns true if kswapd scanned at least the requested number of pages to - * reclaim or if the lack of progress was due to pages under writeback. - * This is used to determine if the scanning priority needs to be raised. + * reclaim. This is used to determine if the scanning priority needs to be raised. */ static bool kswapd_shrink_node(pg_data_t *pgdat, struct scan_control *sc)
when function kswapd_shrink_node return, it will not check the condition mentioned in the removed comments: "if the lack of progress was due to pages under writeback", so remove it. Signed-off-by: yongfa.hu <hushange@163.com> --- mm/vmscan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)