| Message ID | 20240701185932.704807-1-roman.gushchin@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] mm: memcg: drop obsolete cache line padding in struct mem_cgroup | expand |
On Mon, Jul 01, 2024 at 06:59:31PM GMT, Roman Gushchin wrote: > After the grouping of the cgroup v1-related fields and the > corresponding reorganization of the struct mem_cgroup, the existing > cache line padding doesn't make much sense anymore. Let's drop > it for now and put back to new places, if necessary. > > Suggested-by: Shakeel Butt <shakeel.butt@linux.dev> > Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index d0c9365ff039..8b5b3ddeba05 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -220,8 +220,6 @@ struct mem_cgroup { /* handle for "memory.swap.events" */ struct cgroup_file swap_events_file; - CACHELINE_PADDING(_pad1_); - /* memory.stat */ struct memcg_vmstats *vmstats; @@ -305,8 +303,6 @@ struct mem_cgroup { bool tcpmem_active; int tcpmem_pressure; - CACHELINE_PADDING(_pad2_); - /* * set > 0 if pages under this cgroup are moving to other cgroup. */
After the grouping of the cgroup v1-related fields and the corresponding reorganization of the struct mem_cgroup, the existing cache line padding doesn't make much sense anymore. Let's drop it for now and put back to new places, if necessary. Suggested-by: Shakeel Butt <shakeel.butt@linux.dev> Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev> --- include/linux/memcontrol.h | 4 ---- 1 file changed, 4 deletions(-)