From patchwork Thu Jul 4 04:31:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13723207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F592C30653 for ; Thu, 4 Jul 2024 04:33:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C05C66B00B8; Thu, 4 Jul 2024 00:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F456B00B9; Thu, 4 Jul 2024 00:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98F786B00BA; Thu, 4 Jul 2024 00:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 68ADF6B00B8 for ; Thu, 4 Jul 2024 00:32:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32EF2A0A7B for ; Thu, 4 Jul 2024 04:32:30 +0000 (UTC) X-FDA: 82300798860.30.D57A8F5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 1A05E4000C for ; Thu, 4 Jul 2024 04:32:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vi5KLgdE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PNL9w7HV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vi5KLgdE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PNL9w7HV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720067528; a=rsa-sha256; cv=none; b=VqWKP72FHp5U75vLJeTB8BZ2lSunngd+Oq6IeBby0/FRn1YZRVFigFNgl8XxXagemG2P6X HwF/n+TNlBa5h6bUZFOP4Mh86oD9thWNEitm0+6Rq/M+cboqH7kw6Q4W69+jLk3pApBBtM G0+EqCcuqKRGhcLjISDKDJ8NdzfZVZA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vi5KLgdE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PNL9w7HV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vi5KLgdE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PNL9w7HV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720067528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Eaq4YS+I2JMNj2PlLYmITmw1dUtdxAYyfPBt6d+VGg=; b=Zrws0IoF4wuPiyPj+cBctTgd9vExu0taV3niSpZ6ys96G+iNQBLjcjuk03uwN1EpgsurNS nDF7tlwtsRvRp/OzAEt9XBaMUFH5F5Bajo++PKtA1BRlGZEkHAT8OqBgXTOLQ88vNXKB+c V7eHpx1DdFUKN4e/6VcNUkoM3dt6HXs= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBF8521C0D; Thu, 4 Jul 2024 04:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720067546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Eaq4YS+I2JMNj2PlLYmITmw1dUtdxAYyfPBt6d+VGg=; b=vi5KLgdENdkrnyeebmRYr1GTUMnsDQhLSyx0si8djR9aeKoZAFXDbChioD9oLU5n2WEp19 sZ/1YXnUx4zsqmQaqBABY+2OXBM8pE0ZclE7Xl4ENMKN82fsQA0jjs9APgzard6WS/Yweg oOQsVALT38rdOWZXcSnlqZBgxaDhVAo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720067546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Eaq4YS+I2JMNj2PlLYmITmw1dUtdxAYyfPBt6d+VGg=; b=PNL9w7HV1zFYjASnMOA/fooIqae95dSIt4v71VfIDGS0e9g8E4lsal0N9CyLMaXb/wifCJ M4zsefGx9x+meuCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720067546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Eaq4YS+I2JMNj2PlLYmITmw1dUtdxAYyfPBt6d+VGg=; b=vi5KLgdENdkrnyeebmRYr1GTUMnsDQhLSyx0si8djR9aeKoZAFXDbChioD9oLU5n2WEp19 sZ/1YXnUx4zsqmQaqBABY+2OXBM8pE0ZclE7Xl4ENMKN82fsQA0jjs9APgzard6WS/Yweg oOQsVALT38rdOWZXcSnlqZBgxaDhVAo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720067546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Eaq4YS+I2JMNj2PlLYmITmw1dUtdxAYyfPBt6d+VGg=; b=PNL9w7HV1zFYjASnMOA/fooIqae95dSIt4v71VfIDGS0e9g8E4lsal0N9CyLMaXb/wifCJ M4zsefGx9x+meuCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ACDBD13889; Thu, 4 Jul 2024 04:32:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WC9sJdklhmbnDAAAD6G6ig (envelope-from ); Thu, 04 Jul 2024 04:32:25 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , Muchun Song , David Hildenbrand , SeongJae Park , Miaohe Lin , Michal Hocko , Matthew Wilcox , Christophe Leroy , Oscar Salvador Subject: [PATCH 29/45] mm/damon: Create damon_mkold_pud_entry to handle PUD-mapped hugetlb vmas Date: Thu, 4 Jul 2024 06:31:16 +0200 Message-ID: <20240704043132.28501-30-osalvador@suse.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240704043132.28501-1-osalvador@suse.de> References: <20240704043132.28501-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1A05E4000C X-Stat-Signature: wijm9dpp7zjwhfrw3hucgnsmwcri7qn5 X-Rspam-User: X-HE-Tag: 1720067547-703186 X-HE-Meta: U2FsdGVkX1+0zuMA39t4dj7dTKfd8BuTfmElllZay1uf8Wnu6LNz9O3lIrNjwfATlJdc9TYPXLbwTeqHjJ/qvEngVaWSy8BH2wuIKOt13bqIRcRKgyO0oiTR360BULhUtP17WLY3f2KjoAdJ5I5RYd0J0LMKacDsjn3qrrmywrhtlM6aFeX55ciHWwx3AG+rXglY3KwQQ996Upjkj6HPNEUgqhF4ugCoEhH/oHcQBTKGaom/8Cphkh+vL53WPIbF3Bp3VtrCrrisQ4aASVf9Gbd2nPKAbyAYyQqJBuAwhcbWvOJzmB5A3zJkrwf7rWndqg8mvVhDWob44Nhi32nA2kNJPmItiHr+gv6y2jMnl+LVmS9l1BLDrpDtDHPHCdp+8nEDQKGxCzEH5bGXUHkG4wWPc4D7Gwz3b1eg4hOexgqfgUl3fU97Bn9+/vOQCWvL5AGggGcdXH2QMypZeoYA7hexboOuYPDR+YL+0ZIka0cGFUnj3gUHAghvEF7q4WNC0WAK/D1qvnk3vMtdJpNrn6hgoVJWwElgUYkiSwKqZE60I3dcREMlNiRpUU38WJK/DcCpP6shG1DGP/h8mcmROWWz38puO9e71wwryrP3f9LHXW7kB5O3BHuxpHMPqSVfK79wdzCFb6Rybg2HlTokxRRIhQ7mUyJ/zynxfGnvQhuxHUJ3/BuI7lGXQL8QJtHhZunF2ECmzdV5mQAd00eGufH1TOAPfBoktwxmws46EjbVs0CJ3ORRVoDp78mtEubQ2QTHeaxj51ebNf0SpEXF0PwddN7L6Kelci1+EOS8LRQgGIu+pHcYeYBvcBurUqSU9Nr0YOYxBor/oLHFdo8OYzRxOtHZ8ThW+lGaUWsIrw3JGdVWn/yQc71ZgIPUv7sSLxYcHmYkC7GoOzpLE/I/TkSQ5bFUuzOMfrEN+7JMXCjN+TsRi8OIQtHeAOm7mvPWbNSy9SnZFSUaYiHxw5M qRwtmL/x RRj/YevbQCd706ioshidR4dtdFUGapz0qxv8j0hBlocSacY1y18nZs5RNQQzyTaS9Vms1uC6ehBDZX1VUpfp0FyugyWPmWymYcH8Y70X+GjLPCiQtF+6OUurKbEDSAW/b+y7a3D/p0vH1Z0dxjl+19nREP5hHUk1xSbz1CutEYHsQXiHytd2SKBOU/uy82P6jwuJG5MQi8y9WipUHfpK/jN/aL1rcH4sLk1LVK09+5B1DBHXq/n75USOlYanntU7RueN17v4u7fEjyliLkGHvSUUAA5ABjH285KmG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Normal THP cannot be PUD-mapped (besides devmap), but hugetlb can, so create damon_mkold_pud_entry in order to handle PUD-mapped hugetlb vmas. Signed-off-by: Oscar Salvador --- mm/damon/vaddr.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 47c84cdda32c..6a383ce5a775 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -329,6 +329,37 @@ static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, return 0; } +static int damon_mkold_pud_entry(pmd_t *pud, unsigned long addr, + unsigned long next, struct mm_walk *walk) +{ +#ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES + spinlock_t *ptl; + struct folio *folio; + struct vm_area_struct *vma = walk->vma; + unsigned long size = huge_page_size(hstate_vma(vma)); + + ptl = pud_huge_lock(vma, pud); + if (!ptl) + return 0; + + if (!pud_present(*pud)) + goto out; + + folio = pfn_folio(pud_pfn(*pud)); + folio_get(folio); + + if (pudp_test_and_clear_young(vma, addr, pud) || + mmu_notifier_clear_young(mm, addr, addr + size)) + folio_set_young(folio); + + folio_set_idle(folio); + folio_put(folio); +out: + spin_unlock(ptl); +#endif + return 0; +} + #ifdef CONFIG_HUGETLB_PAGE static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr) @@ -383,6 +414,7 @@ static int damon_mkold_hugetlb_entry(pte_t *pte, unsigned long hmask, #endif /* CONFIG_HUGETLB_PAGE */ static const struct mm_walk_ops damon_mkold_ops = { + .pud_entry = damon_mkold_pud_entry, .pmd_entry = damon_mkold_pmd_entry, .hugetlb_entry = damon_mkold_hugetlb_entry, .walk_lock = PGWALK_RDLOCK,