From patchwork Thu Jul 4 04:30:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13723182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176A1C30653 for ; Thu, 4 Jul 2024 04:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 685D46B0095; Thu, 4 Jul 2024 00:31:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60D446B0096; Thu, 4 Jul 2024 00:31:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 415C46B0098; Thu, 4 Jul 2024 00:31:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 142EA6B0095 for ; Thu, 4 Jul 2024 00:31:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BEE53A0FC9 for ; Thu, 4 Jul 2024 04:31:57 +0000 (UTC) X-FDA: 82300797474.24.0C67F49 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id B76864001D for ; Thu, 4 Jul 2024 04:31:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720067495; a=rsa-sha256; cv=none; b=EMy7/B0bLVPEusljspsE0FuXUaBnp2GN/S7y8NC37/eH+gRuqUY2572ReknCZ+4sXFxpiM R1FobHTW8gGgaCDgV6BCwvc+CDAWaPWHi3rmpXrx2vOOrg3FyVxLs/2Db3OKzCZJEogN/B h5j1PHQ+FVAXrcc31L/dfWx0WPXB3gk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720067495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPg1N4K/oKRWLAqwnTzV+x9t1Eetk6pBQBgkyAoigug=; b=3zQq1Xr4IlT60KlOzUgPsl60Zb4jEecgiLzPv9t8gZKT0H7E9kVP4P3qywgIE/XH6yx+Qj 7wdxmfZQrt6NYZXSbpBIiT4owtR2zyiyFL8iDF3Gw7seT/DieFe/Y+NLU/+xms+iX4euDA l5SOSu7DrVaWQelwRuc9+gIn/CYn5CA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8546721C10; Thu, 4 Jul 2024 04:31:54 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5593A13889; Thu, 4 Jul 2024 04:31:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SMuLELklhmbnDAAAD6G6ig (envelope-from ); Thu, 04 Jul 2024 04:31:53 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , Muchun Song , David Hildenbrand , SeongJae Park , Miaohe Lin , Michal Hocko , Matthew Wilcox , Christophe Leroy , Oscar Salvador Subject: [PATCH 04/45] mm/pagewalk: Only call pud_entry when we have a pud leaf Date: Thu, 4 Jul 2024 06:30:51 +0200 Message-ID: <20240704043132.28501-5-osalvador@suse.de> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240704043132.28501-1-osalvador@suse.de> References: <20240704043132.28501-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B76864001D X-Stat-Signature: kmo9ysqa5rz4xts469pksfqeujzjgphu X-Rspam-User: X-HE-Tag: 1720067515-754563 X-HE-Meta: U2FsdGVkX19BJnsbZ+YJuR+sEKXiWiNMROcbSYHw7qppraSG+e0mjzhRK18KmFl/NC21xN7+B2VzFSmM/vQi1P+C+tjOeQ3v1xTT/C8nR7+eroeI/qmyQTU/MLSPOAHp216zhz7oKO8nYjYc3woDL2uMZtKYIZaHG9OBzruvQ316jPJlOrmy3aTWh+Bm2BCufWhubS2QI8w/KPqKiuwNlGMFzZ/uitHcRZZrtizdHAlDodb17CLC29dN/TXczCG8FPwyDF55R7Xir1H3g6vUuay/fcKxxrb8tocKeAoThWI+pqYY/J51wZfOBD69x38ax7v0CvOPg2VqQAH+C7CI3YAISi1weouuloVeg+kEHJ1kkqrSV66QVvNNaDXkHGmHEsin6yVACGTo9mBmmFcTrALrjsz3PY2rG8Xue90KRACUUpliqLx+MULn0vS5zrtDWYg5v7BRlVwo1QP8ncml6M4QqTyfGlBZ2OQ7+T/3uZsm1Y7XDHyew/LXuIwRY6bvDQhvMujdm9FcMMlTeAkph3eVpTZJgr+4lHBpAGqUY7Strt8D8InXwZuNOcgXVd/CJ1u/MtkFu2o3k2QokzmwlvITNcS8O54yeZHi45RqE++mWiBgW1Jc0hD88lKlpizTcN2F6MIxxHCkrgUqMAvampq7+8DSTgZNXAy/4qa5H6wEAkq2r1HwpgXGOokROe/dEK1npQImH6UBM/xgjSdkL0aJ8IanJXdPHU20+33/UorV6ORd0RRaIbk73De5EB+K6cfih5XlEcjs6O2R7yDLDE1GGcQTUWuo3+e7uMinUGyQIUjpbjFPD3/91+FPLVuc1bNbcB59DkB6tDB2nUWZdan1PS7SLS6IiHVJygl8peS+tAGCW3JfdQsa2Yd0k4epW6FWkk4w2Vf/80RrsARL7BOLFWql2WqTyIpYDF6mr+O6D5uAPa9yFeF0LvKsbJKUIWeI7rSpYD7mERHw0hP B5J0cfuX YdNdmWjL9WRo+6+1RWYKou615bVZVwCUj0Ypf1Bm3sROzgDkc0l2iRoYLxeB2O/aUGpys1W73bp23n9dYJUSueXugByRVAg4aPL+cZe4/DhA9qQ/lLIvt26myHBLGuL5eFAW8eJnYOLo+sW4hwaBgfPfEFZjKGjMtP93jwdNuUu7GL0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Check first whether the pud is leaf one before trying to call pud_entry. Signed-off-by: Oscar Salvador --- mm/pagewalk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index eba705def9a0..d93e77411482 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -155,7 +155,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, walk->action = ACTION_SUBTREE; - if (ops->pud_entry) + if (ops->pud_entry && pud_leaf(*pud)) err = ops->pud_entry(pud, addr, next, walk); if (err) break;