From patchwork Mon Jul 15 19:21:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 13733831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B418FC3DA61 for ; Mon, 15 Jul 2024 19:21:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 000CD6B0095; Mon, 15 Jul 2024 15:21:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF3BD6B0096; Mon, 15 Jul 2024 15:21:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD0856B0098; Mon, 15 Jul 2024 15:21:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B06466B0095 for ; Mon, 15 Jul 2024 15:21:54 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50385A5306 for ; Mon, 15 Jul 2024 19:21:54 +0000 (UTC) X-FDA: 82342956948.18.28DCA59 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id C1E8B180015 for ; Mon, 15 Jul 2024 19:21:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IXILu6E5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721071269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xrFUBbcc9D0ORnx0qoNz81Y3Ewmb+xGo+hBykZs/BiM=; b=NV/v7336NL1QyCmZu205ELof6o/ap61NbM2G3FIN/vmFU+r2rtfUdk3U8AGgSBNKktn6Kh 35Dc1F1EwFIqTS336cyYPhGy/hxGQi1rnrG1IElcalycbyCF51VMYzpeCtII+slbtMHnez ECHTZHboarok/tPnozqOsabThQbGaaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721071269; a=rsa-sha256; cv=none; b=Ypn6K6L07g6E9HeGWWwkvPcEyrKk4cyifm6F5RNJ2DdyW5RvhPBA5prMmYjNECCSjcG8g5 qZgCg4UNLZ7BPG9wiINc6BYm1KS1K3uTlAZqjC3IlHq3bxssqYIgUYnKg469M/oPxEKum3 zZeF7uaPk+1grx/rKrcXJbzlb3eSy7s= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IXILu6E5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721071311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xrFUBbcc9D0ORnx0qoNz81Y3Ewmb+xGo+hBykZs/BiM=; b=IXILu6E5x3wA5zsonL8tx+nw5zAbj/4h66MD4lGDFIENTvebrBRz4jjQzyKFKuaNNLLP4t z0F5r9JRnur8+KOJJGg1UX6SZ89Ye4sazvhEy6fj7WEhtvR/qzErXuvK1hyaL/lMyRV4Df svhn6r90gjDiG8R9lfd07sa4gH0grXc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-V5CbpbQNM220fEYiYNIGcg-1; Mon, 15 Jul 2024 15:21:49 -0400 X-MC-Unique: V5CbpbQNM220fEYiYNIGcg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b5e99c06efso9781296d6.2 for ; Mon, 15 Jul 2024 12:21:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721071308; x=1721676108; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xrFUBbcc9D0ORnx0qoNz81Y3Ewmb+xGo+hBykZs/BiM=; b=lB7/NjSs0VoFyiPbPtZWqV8urjReNwTISpQWnIqN7j8sa1TugNXX/qfaP96Ecbhr4b 2XlSriDU49YYZqRTigjGwF1iZK04hftZbPBH3VXh/qZifQsVjeYjdaoB1Vz+FxvG0fxS SBv31Ew0epRTIaqnOQ87JsEPpVlLGhI0Hvh+BirUR4d1gl3riw0O+ZPEaaFqBrH2rZqf 5gJOAqFKxmz25YMbBkDYA3rjT6vpaih+Go7UZIEoDrQhKAkXzVi4G93Hj8BJZwNjfQhb CxnzbwZmbOHoK4fRps69RLWL+BeuIg5dHvTbEKLpn25ap9eLQDv3gNpkBLXCNPNr3EZL b/CQ== X-Gm-Message-State: AOJu0Yz5nwaw07a1ukpR/xLRHe7vrwRgFPOBaY1pgc3gqz6QPjvFQ3OR LEeaxq9DdPKuk3dxYfCliWEyBpRrpoIcATmyvSXT4MEPvzlp/qRdDeW0K0j4orOuIN4HhxTEyTb vGgjGXGN4EpbRgtH150MbEfsa+pPljwPgQ1eglhaxkpHMZN5nkFpbvZIebYup5NBL3nh4oWrWeC wg/kE/Bv6ZexiRbcdOHtehUEyNcegxUQ== X-Received: by 2002:a05:6214:3209:b0:6b7:64a2:3189 with SMTP id 6a1803df08f44-6b77e17f47fmr4877996d6.8.1721071308507; Mon, 15 Jul 2024 12:21:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFchV1JB+E55nHTPY9KJJNPGb9+S7LV2RfQetOl80mLgqA/kra292Zxs5L4jIR6tRho3Ee1yQ== X-Received: by 2002:a05:6214:3209:b0:6b7:64a2:3189 with SMTP id 6a1803df08f44-6b77e17f47fmr4877546d6.8.1721071308060; Mon, 15 Jul 2024 12:21:48 -0700 (PDT) Received: from x1n.redhat.com (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b761978d30sm24039356d6.31.2024.07.15.12.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 12:21:47 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Dave Jiang , Rik van Riel , Dave Hansen , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Matthew Wilcox , Rick P Edgecombe , peterx@redhat.com, Oscar Salvador , Mel Gorman , Andrew Morton , Borislav Petkov , Christophe Leroy , Huang Ying , "Kirill A . Shutemov" , "Aneesh Kumar K . V" , Dan Williams , Thomas Gleixner , Hugh Dickins , x86@kernel.org, Nicholas Piggin , Vlastimil Babka , Ingo Molnar Subject: [PATCH v3 1/8] mm/dax: Dump start address in fault handler Date: Mon, 15 Jul 2024 15:21:35 -0400 Message-ID: <20240715192142.3241557-2-peterx@redhat.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240715192142.3241557-1-peterx@redhat.com> References: <20240715192142.3241557-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C1E8B180015 X-Stat-Signature: zyrrp46e9whghyu1pk8fi31e6p1apmw9 X-Rspam-User: X-HE-Tag: 1721071311-336124 X-HE-Meta: U2FsdGVkX18ym9eX29/iJj6dYpZjMVBaj3KoMcAu8BwtDA6IkxffjTmy7BxTCtkyXkTfQFmpB7gyo7iPy34UUvAYRdIoIgr/FfqUCbMmBiZ10cEAVO0EpJqq2DwA5vHY0gWBVbuoRpOqPFEYEFU/yoobWWSW+fB3lIjEX7+EaNcGjF+7M/uqveO/YlyKbbucqeI7Q59ul2Gie2D+Rm1c4HN1Kq0xe7TvlCxxVUR9OBKTdHHXcy8FzwQKqxWYkmJ7zC8tHeftTO4X8ssz4SZCPHCNOrGmgzgeuIEhOKkPhpD4nsDcRj4TOuVZqZC4HHXjGuomRsXe0/mDvurAh9AP9tMXC8DGEtOeY6rHKCmY08jiHCPrVL4Q1ir6pqDrYzG1TvMX+XH0Ej8yI46igSYPmfNbBpdXJ2oeOvNaROS86BNnM2o1lFQYALkkdyPLWuLKB2rLUtGS0hImr12MIuPNagCTkYEryCvUJ0Ixe6APv1W6c1EgolwKg5Y+Upz9DkabNT8lgZUpyfTxyi466m/Jj8vXB1QuOPeMRkDStf7RRPoocPylkiwOh5ot8wDUozlZNp8lR/6sp8pU9qrq+phU4FVpEYsjHsyf2X/OLieA9aHtIZ2d0k3SVapzVNsyD4q+PifmOGVGxg5MlB/25uGzXNDiPfWNfqdUJ/mw+YB5z2+A2YbDa2/dR8pbSKc8vIfAoiiodBcACfL5a1bRol30B4x+Ocuti7Xu/2t+hUvMqk14bNG9+wVOdXXp5KLOz8ukWycKrP5ntFFxyX5BHbBiEBuVGHLwA6K6UpRSwab2orUuGApNVyM0i7JYkNv00yzms4U/VpVmqq2QJUTss0PU1UVsK+Yt+Y2dBsPm6sBURfSVSaYC+MzKl3kXCHCtOOE84aB4IBRZBSt8uphyMz/ZRGAvX3ICQhpzag9wfk4wMBQqK82ygqUf8hwifsRtp8Q1BQT0YA9xUd9UorCw1d+ jAGSX4t3 qL7zEOEWXH0zfxS2dbzUCswa++5U6F8FcEsIeN/g9lkoL3ajgdtiBCYsJMQ67waXtvjCLHazDB1jCbQ3Zbc1MgneEHvHTxEzzfr0RmsFhWjfEMSh12ySQcmFU+m84JTNG602rN3cy8yfnegF03mi8LwXQICofbUw/u0VoC1t/qY+8Xhke1JOpffk+Mmh0o5I6QqHUZUR3JB30Wdf94zaydhsIy4/Eb+8upKFFrx/uI5GLvo96mQNXiCUpW056qmgOROErU5oMF9GXqPJb9IODZLlKHCvAWk4CIb+V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently the dax fault handler dumps the vma range when dynamic debugging enabled. That's mostly not useful. Dump the (aligned) address instead with the order info. Signed-off-by: Peter Xu Acked-by: David Hildenbrand --- drivers/dax/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index eb61598247a9..714174844ca5 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -235,9 +235,9 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, unsigned int order) int id; struct dev_dax *dev_dax = filp->private_data; - dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) order:%d\n", current->comm, - (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", - vmf->vma->vm_start, vmf->vma->vm_end, order); + dev_dbg(&dev_dax->dev, "%s: op=%s addr=%#lx order=%d\n", current->comm, + (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", + vmf->address & ~((1UL << (order + PAGE_SHIFT)) - 1), order); id = dax_read_lock(); if (order == 0)